From 666af8a37b44b07a57dfdf17b7edc6e0d0a4550e Mon Sep 17 00:00:00 2001 From: Tichau Date: Wed, 24 Feb 2016 08:21:30 +0100 Subject: [PATCH] Refactor conversion preset settings definition to avoid duplicate. --- .../ConversionPreset/ConversionPreset.cs | 138 +----------------- 1 file changed, 3 insertions(+), 135 deletions(-) diff --git a/Application/FileConverter/ConversionPreset/ConversionPreset.cs b/Application/FileConverter/ConversionPreset/ConversionPreset.cs index 5246c1a..0e45380 100644 --- a/Application/FileConverter/ConversionPreset/ConversionPreset.cs +++ b/Application/FileConverter/ConversionPreset/ConversionPreset.cs @@ -397,145 +397,13 @@ namespace FileConverter private bool IsRelevantSetting(string settingsKey) { - switch (this.OutputType) - { - case OutputType.Aac: - switch (settingsKey) - { - case ConversionPreset.ConversionSettingKeys.AudioBitrate: - return true; - } - - break; - - case OutputType.Avi: - switch (settingsKey) - { - case ConversionPreset.ConversionSettingKeys.EnableAudio: - case ConversionPreset.ConversionSettingKeys.AudioBitrate: - case ConversionPreset.ConversionSettingKeys.VideoQuality: - case ConversionPreset.ConversionSettingKeys.VideoScale: - case ConversionPreset.ConversionSettingKeys.VideoRotation: - return true; - } - - break; - - case OutputType.Flac: - case OutputType.Ico: - break; - - case OutputType.Gif: - switch (settingsKey) - { - case ConversionPreset.ConversionSettingKeys.VideoScale: - case ConversionPreset.ConversionSettingKeys.VideoRotation: - case ConversionPreset.ConversionSettingKeys.VideoFramesPerSecond: - return true; - } - - break; - - case OutputType.Jpg: - switch (settingsKey) - { - case ConversionPreset.ConversionSettingKeys.ImageQuality: - case ConversionPreset.ConversionSettingKeys.ImageScale: - case ConversionPreset.ConversionSettingKeys.ImageRotation: - case ConversionPreset.ConversionSettingKeys.ImageClampSizePowerOf2: - return true; - } - - break; - - case OutputType.Mkv: - switch (settingsKey) - { - case ConversionPreset.ConversionSettingKeys.AudioBitrate: - case ConversionPreset.ConversionSettingKeys.VideoQuality: - case ConversionPreset.ConversionSettingKeys.VideoScale: - case ConversionPreset.ConversionSettingKeys.VideoRotation: - case ConversionPreset.ConversionSettingKeys.VideoEncodingSpeed: - return true; - } - - break; - - case OutputType.Mp3: - switch (settingsKey) - { - case ConversionPreset.ConversionSettingKeys.AudioEncodingMode: - case ConversionPreset.ConversionSettingKeys.AudioBitrate: - return true; - } - - break; - - case OutputType.Mp4: - switch (settingsKey) - { - case ConversionPreset.ConversionSettingKeys.AudioBitrate: - case ConversionPreset.ConversionSettingKeys.VideoQuality: - case ConversionPreset.ConversionSettingKeys.VideoScale: - case ConversionPreset.ConversionSettingKeys.VideoRotation: - case ConversionPreset.ConversionSettingKeys.VideoEncodingSpeed: - return true; - } - - break; - - case OutputType.Ogg: - switch (settingsKey) - { - case ConversionPreset.ConversionSettingKeys.AudioBitrate: - return true; - } - - break; - - case OutputType.Png: - switch (settingsKey) - { - case ConversionPreset.ConversionSettingKeys.ImageScale: - case ConversionPreset.ConversionSettingKeys.ImageRotation: - case ConversionPreset.ConversionSettingKeys.ImageClampSizePowerOf2: - case ConversionPreset.ConversionSettingKeys.ImageMaximumSize: - return true; - } - - break; - - case OutputType.Wav: - switch (settingsKey) - { - case ConversionPreset.ConversionSettingKeys.AudioEncodingMode: - return true; - } - - break; - - case OutputType.Webm: - switch (settingsKey) - { - case ConversionPreset.ConversionSettingKeys.AudioBitrate: - case ConversionPreset.ConversionSettingKeys.VideoQuality: - case ConversionPreset.ConversionSettingKeys.VideoScale: - case ConversionPreset.ConversionSettingKeys.VideoRotation: - return true; - } - - break; - - default: - Debug.LogError("Relevant settings '{1}' are not define for output type {0}.", this.OutputType, settingsKey); - break; - } - - return false; + return this.Settings.ContainsKey(settingsKey); } private void InitializeDefaultSettings(OutputType outputType) { + this.settings.Clear(); + switch (outputType) { case OutputType.Aac: