From 02e5b5bad70bb10031df5822cd9bf46915c87fb5 Mon Sep 17 00:00:00 2001 From: cypress-exe Date: Sat, 27 Sep 2025 15:32:29 -0600 Subject: [PATCH] Fix: Nested presets failing with 17+ files due to menu collision On the current upstream branch, converting 17+ files at once revealed an underlying issue where the program wouldn't necessarily choose the correct conversion profile. After 16 files are selected, Windows Explorer seems to optimize the context menu such that multiple `ToolStripMenuItems` with identical `text` properties share the same callback, which causes ambiguity issues. As a workaround, each menu's `text` property has a unique number of zero-width characters appended to it. This makes the text technically unique, ensuring that Windows maintains the distinction. Furthermore, it preserves the UI, has a minimal code refactor, and resolves an issue that has been reported at least twice and likely impacts all instances of FileConverter. Fixes #614, #567 --- .../FileConverterExtension/FileConverterExtension.cs | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/Application/FileConverterExtension/FileConverterExtension.cs b/Application/FileConverterExtension/FileConverterExtension.cs index d04576e..8ce6f85 100644 --- a/Application/FileConverterExtension/FileConverterExtension.cs +++ b/Application/FileConverterExtension/FileConverterExtension.cs @@ -104,8 +104,11 @@ namespace FileConverterExtension Image = new Icon(Properties.Resources.ApplicationIcon, SystemInformation.SmallIconSize).ToBitmap(), }; + int menuItemIndex = 0; foreach (MenuEntry menuEntry in this.menuEntries) { + menuItemIndex++; + ToolStripMenuItem root = fileConverterItem; if (menuEntry.PresetReference.Folders != null) { @@ -142,9 +145,14 @@ namespace FileConverterExtension root = fileConverterItem; } + // Make each menu item text unique using invisible zero-width spaces + // This prevents Windows Forms menu collision while being completely invisible to users + string uniqueSuffix = new string('\u200B', menuItemIndex); // Zero-Width Space characters + string displayText = menuEntry.PresetReference.Name + uniqueSuffix; + ToolStripMenuItem subItem = new ToolStripMenuItem { - Text = menuEntry.PresetReference.Name, + Text = displayText, Enabled = menuEntry.Enabled };