mirror of
https://github.com/storytold/artcraft-services.git
synced 2026-11-19 08:53:03 +01:00
## What was wrong Every `MediaUploadApi` upload method (`UploadImage`, `UploadAudio`, `UploadNewEngineAsset`, `UploadSpzFile`, `UploadNewScene`, `UploadNewVideo`, `UploadPmx`) defaulted `maybe_visibility` to `Visibility.Public` and sent it in the form. The upload handlers only fall back to the account's preferred visibility when the field is absent, so this client default overrode a private/hidden preference whenever a caller didn't pass a choice. Affected paths include frame-extractor saves, 3D model / splat uploads from the upload modal, and their thumbnails, which then showed up in public listings. Separately, the video editor's automatic project cover (`thumbnail-capture.ts`) uploaded a render of the timeline through `UploadImage` with no visibility, so a private project got a public cover image. ## What changed - `MediaUploadApi`: removed the `= Visibility.Public` defaults. The field is sent only when the caller chooses a value; otherwise the server applies the account preference (unchanged server logic). - `thumbnail-capture.ts`: reads the project's `creator_set_visibility` and uploads the cover with the same visibility; if it can't be read, the cover is private. - `Visibility` is now exported from `@storyteller/api` so the webapp can pass it. ## Blast radius Uploads from callers that don't choose a visibility now follow the account's preferred visibility instead of always being public. Accounts with no preference get the server default, as before. Explicit choices are unchanged. Existing covers are not updated, and changing a project's visibility later does not update its cover. ## Checks run - `npx vitest run src/lib/MediaUploadApi.spec.ts` in `libs/api`: 8/8 pass (7 fail on `main`). - `npx vitest run src/pages/video-editor/adapters/thumbnail-capture.spec.ts` in `apps/artcraft-webapp`: 2/2. - `tsc -p tsconfig.lib.json` / `tsconfig.spec.json` for `libs/api` and `tsc -p tsconfig.app.json` for the webapp: no errors in touched files (existing errors elsewhere are unchanged). ## Checks not run - Uploads against a running API with a private preferred visibility. - Propagating visibility changes to existing covers (needs a server-side change). Addresses CodeRabbit security findings (CWE-200). <!-- This is an auto-generated comment: release notes by coderabbit.ai --> <!-- coderabbit-ai-generated:v1 --> ## Summary by CodeRabbit * **New Features** * Media uploads without an explicitly selected visibility now use the account’s preferred visibility. * **Bug Fixes** * Video cover uploads now retain a project’s public or hidden visibility. If visibility is missing or unrecognized, the cover is uploaded as private. <!-- end of auto-generated comment: release notes by coderabbit.ai -->