mirror of
https://github.com/storytold/craft-ai-integrations.git
synced 2026-11-19 10:40:41 +01:00
* docs: record architecture decisions, one file each Add docs/adr/ with an index and 26 ADRs for decisions that already shape the layer, backfilled from the docs and merged pull requests and numbered by the date each was made. Each has its context, decision, consequences and a link to the doc or PR that holds the detail. Follows the docs/adr/NNNN-slug.md layout FilmCraft uses. LAYOUT.md points to the folder. * docs(adr): state the limits CodeRabbit found in eleven ADRs Narrow each claim to what the code does: the TLS test checks one builder call, consent is scoped by capability not tool, cancelling does not stop a runner at once, Remove background needs the burn feature and a model file, an existing agreement can skip re-approval, unknown fields in list items need a unique identity, two zero token prices give a zero estimate, the generated Burn module is exempt from Clippy, no shared passphrase prompt exists yet, Last-Modified is used only with no ETag, and a proxy resolves the destination on the proxied path.
Architecture decisions
One file per decision that shapes this layer, numbered in the order the decisions were made.
Adding one
- Copy the newest file, take the next number and give it a short slug.
- Fill in Status, Source, Context, Decision and Consequences. Keep it short and link to the doc or pull request that holds the detail.
- Add it to the table below, in the same pull request as the change it explains.
Record only decisions that were made. A proposal or an open question belongs in its issue. A
decision that replaces an earlier one gets a new file, and the old one's Status says
superseded by NNNN.
| ADR | Decision | Accepted |
|---|---|---|
| 0001 | The shared crates own the connection, each app owns its interface | 12/10/2026 |
| 0002 | A chosen model is never replaced silently | 13/10/2026 |
| 0003 | Declarative adapters run no code | 13/10/2026 |
| 0004 | One TLS setting for every network call | 14/10/2026 |
| 0005 | Consent is scoped to one use and can lapse | 14/10/2026 |
| 0006 | Local engines share one runner contract | 17/10/2026 |
| 0007 | A person's model folders are kept as a map, never reorganised | 17/10/2026 |
| 0008 | Accepted model licences are kept apart from installed files | 17/10/2026 |
| 0009 | Keys travel in headers, never in a URL | 19/10/2026 |
| 0010 | Keep a local craft-ai-core until craft-libs has what it lacks |
20/10/2026 |
| 0011 | SAM 2.1 is offered first for Select subject | 21/10/2026 |
| 0012 | Time goes through chrono |
21/10/2026 |
| 0013 | Burn is an optional engine after rten | 22/10/2026 |
| 0014 | An offer never chooses a model | 23/10/2026 |
| 0015 | Developer suggestions go through the intake path | 23/10/2026 |
| 0016 | Shared widgets use the suite's egui 0.37 fork | 25/10/2026 |
| 0017 | Remove background runs built in, with InSPyReNet on Burn | 30/10/2026 |
| 0018 | Approvals and plans are bound to what the person saw and to one app | 01/11/2026 |
| 0019 | The shared store stays additive, and a schema bump is the last resort | 05/11/2026 |
| 0020 | Report what this build can run apart from what is saved | 05/11/2026 |
| 0021 | A cost estimate is shown before consent, and never guessed | 09/11/2026 |
| 0022 | Clippy enforces the coding standards | 09/11/2026 |
| 0023 | Retry only where a repeat cannot charge twice | 10/11/2026 |
| 0024 | Encrypted file as the last secret store | 10/11/2026 |
| 0025 | Resume a cut download only against a named file version | 11/11/2026 |
| 0026 | Downloads connect only to addresses a link may reach | 11/11/2026 |