Files
craft-ai-integrations/tools
JeremyandClaude Opus 5.5 db30646d9d fix(ai-client): ask before running a ComfyUI workflow with add-on steps not known to stay local (#191)
* test(ai-native): read access lists in-process in the Windows tests

The owner-only tests read each file's access list back with PowerShell's
Get-Acl. That call failed for every test on the windows-latest CI runner
after #184 merged, while the library code itself was not involved. The
tests now read the owner and list with GetNamedSecurityInfoW, through a
test-only helper in the named unsafe module, and the owner parser no
longer assumes a group section.

* test(ai-native): accept the LA alias for the built-in Administrator

CI runners use the machine's built-in Administrator account (RID 500),
which SDDL writes as LA instead of its full SID. The owner-only tests
compared against the full SID and failed on windows-latest; the files
themselves were correct.

* fix(ai-client): ask before running a ComfyUI workflow with add-on steps not known to stay local

A connection to ComfyUI on this computer is local, but an imported workflow
can pass the picture and prompt to an add-on step that sends them to another
host. Such workflows ran with no consent prompt.

ai-comfyui now keeps a short list of ComfyUI's own steps that keep data on
this computer (local_steps.rs). When the chosen library workflow uses any
other step, the plan marks the job as possibly leaving the computer and names
those steps in the new Disclosure::unknown_steps, so the existing consent
path asks. An agreement records the steps it named and covers only those, so
a workflow that adds a step asks again. start re-reads the workflow and
refuses if its steps changed since the plan. Nothing is refused outright: a
workflow with add-on steps still runs once the person agrees.

The shared disclosure_lines adds a plain line naming the steps, and the
adopting guide says what apps show.

* fix(ai-comfyui): agree to a workflow's exact step names, shorten only the label

Step names were cleaned and cut to 80 characters before consent and the
changed-workflow check compared them, so two steps sharing their first 80
characters looked like one. unknown_steps now returns the exact names; the
consent line in ai-egui cleans and shortens them for display only.

* fix(ai-client): check workflow consent for every provider spelling

* fix: freeze approved workflows and scope consent grants

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-15 00:14:36 +00:00
..