Commit Graph
259 Commits
Author SHA1 Message Date
Dylan M. Taylor 84edfd6010 Fix the private config folder helper path (#1875)
* settings: call the private-folder helper through its module

* journal: format the redaction helper

* Secure the config directory before replacing settings
2026-11-14 15:21:24 -05:00
Dylan M. Taylor bc47887f4a journal: redact header-style and env-style credential field names (#1874) 2026-11-14 14:33:19 -05:00
Dylan M. Taylor 88facbb716 settings: write config.toml owner-only in a private folder (#1873) 2026-11-14 14:33:14 -05:00
Alex Joaquim Pereira 58748a7463 Keep comparison analysis limitations (R3.12) (#1817)
app_graphs_compare and js_exports_compare dropped the analysis limitations of the graphs they compared (a malformed source map, a truncated inventory, dynamic IPC names), so a comparison read as complete when one side was partial. Each side's limitations, from a path or from saved js_app_map evidence, now go into the comparison's evidence labelled left: or right:.
2026-11-14 23:34:18 +07:00
Alex Joaquim Pereira f8f1207fae Report complete native string reference counts (R3.12) (#1797)
native_strings_find listed at most 32 references per matching string with no count or flag. Each match now carries its complete reference_count and a references_capped flag, and a search with a cut list adds a references_capped limitation.
2026-11-14 23:05:27 +07:00
muraa-p 8374ad7154 Record the site's start page the way the walkthrough takes it (#1857)
The Deep website study from #1838 sent `web_walkthrough_record` a step shape it doesn't accept, so no recording was ever written. The step is now the tool's own (a test reads it as the tool's params), request bodies are kept so two operations to one endpoint are told apart, a body cut at its cap is left out rather than replayed incomplete, headers are read from the shape the browser keeps them in, and the file is written with private permissions.
2026-11-14 17:42:46 +07:00
muraa-p d3bb9ad455 Say when a light pin had to copy what it meant to share (R2.10) (#220)
A light pin hard-links dependencies and media from the project and copies a file it can't link (a drive without hard links, a file at its link limit). That fallback was silent, so the pin just looked bigger. Pins now record `copied_shared_bytes`, and the app says how much was copied instead of shared. Older pins read it as zero.
2026-11-14 17:06:12 +07:00
muraa-p c204d3ea18 Let a project's builder be chosen from the CLI and MCP (#1833)
`project_builder_set` chooses the AI that builds a project's later changes by an enabled backend's name, `default` gives it back to the app's own choice, and with no name it says which is chosen and which builds now. A name that is off or unknown is refused before anything is saved. It runs in Clean room, since it never looks at the target. The project page's own control is still open (R2.9).
2026-11-14 16:32:33 +07:00
muraa-p 3394cad58f Record a website's traffic in Deep mode and tell the builder about the stand-in backend (#1838)
A Deep website study now records the start page's requests and answers to `capture/original.har` (bodies within their cap, credential headers and declared secrets left out as in every capture; a failure is noted in how-it-works.md, not fatal). When that recording is there, the brief tells the builder that `web_standin_build` and `web_standin_start` can serve those answers to its own front end. Clean room is unchanged. Starting a stand-in automatically stays open (R3.11).
2026-11-14 16:30:07 +07:00
muraa-p a3e5d04df6 Count JSON responses, not all requests, for body outlines (#1845)
`web_page_show` read bodies for the first 200 requests of any kind, so a page that loads its data after a few hundred scripts, styles and telemetry calls got no JSON outline at all, and nothing said why. The cap now counts JSON responses, the network result counts them, and when some got no outline the evidence says how many and why: past the cap, after the window's deadline, or a body that couldn't be read as JSON (part of #1811).
2026-11-14 15:43:29 +07:00
Rudy Mizrahi Celekli a3db764949 Show ACP token counts as unknown when the agent does not report them (R2.2) (#1843)
Agents over ACP report context use, not a turn's tokens, so their turns now say the token count is unknown instead of 0, in the CLI, the build's activity and the app. Project and session totals keep what was reported: "Unknown" when nothing was, and a lower bound such as "1.9M+" when some turns had no count. usage.json gains `tokens_incomplete`; older files read as before.
2026-11-14 14:36:22 +07:00
Rudy Mizrahi Celekli f5a3d2d5e4 Verify Mac call observation with a real debugger (R2.4) (#1844)
An opt-in macOS test compiles a small program, runs `apple_calls_observe` on it under LLDB, checks that both function hits are recorded in order, and that a file LLDB can't debug is an error with a fix. Run on arm64 macOS with Apple LLDB.
2026-11-14 14:15:21 +07:00
Rudy Mizrahi Celekli ddd82831ff Check the browser exit diagnostic without timing the whole tool call (R5.2) (#1840)
The test of a browser that exits before it's ready checked a 20 s stopwatch over the whole call, which also timed process startup and cleanup and failed under load. It now checks the error code and the exit diagnostic, which already tell the exit apart from the deadline.
2026-11-14 14:15:15 +07:00
Nathaniel Caldwell 75d0fa0b4d Say what to do when a builder overwrites the build's progress record (R5.3) (#1810) (#1810)
A builder that kept its own notes in inbox/build-progress.json stopped every later run with an unexplained parse error. The run still stops on a progress record it can't read, but now says the file is Craft Anything's record of the build, that something else changed it, and to rename or delete it to go on; a record from a newer version still says to update. Every brief now names craft.json, feed.json and inbox/ as Craft Anything's own records.
2026-11-14 02:48:40 +07:00
Nicolas Bohn 6a1588e706 Read config.toml again for up to 2 s at startup before using defaults (R2.9) (#1828) (#1828)
A config.toml that another program or a virus scan held for a moment at startup left the whole session on defaults that refuse every save (#1735). Startup now reads it again after short waits, 2 s in all, before falling back, but not for a missing file or a folder in its place; edits deferred at the last exit are merged only once the file could be read, so they aren't lost while it stays unreadable.
2026-11-14 00:53:34 +07:00
Alex Joaquim Pereira 52f1daa668 Say how many report limitations were omitted (R5.6) (#1796) (#1796)
core_report_write lists at most 30 distinct limitations; past that, its Markdown and HTML reports now end the list with how many more were omitted, instead of dropping the rest without a word. A report with 30 or fewer is unchanged.
2026-11-13 01:11:05 +07:00
Alex Joaquim Pereira 26ea91abd3 Resolve and disclose application graph import facts (R3.12) (#1795) (#1795)
An application graph resolved only the first 2,000 imports of a module and dropped which per-file fact lists were cut, so later dependencies lost their edge and role and nothing said a list was cut. Every retained import is now resolved, the cut lists are named in a facts_truncated limitation, and js_app_map reports partial coverage for such a graph.
2026-11-13 00:47:39 +07:00
Alex Joaquim Pereira c64b74ec83 Report complete comparison row totals (R3.12) (#1792) (#1792)
app_graphs_compare and js_exports_compare cut added, removed, bundle-module and vendor rows at 2,000 without saying so, and the app comparison's summary reported the cut lengths as totals. Each list now carries its complete total beside the capped rows, the summary uses those totals, and a cut comparison is marked rows_capped with a limitation and partial coverage.
2026-11-13 00:07:18 +07:00
Alex Joaquim Pereira c727d788a0 Cap and disclose .gitignore reads (R3.11) (#1786) (#1786)
Folder walks read each .gitignore whole, whatever its size. They now read it through the capped, regular-file-checked reader with a 1 MiB limit; one that is too large, not a regular file, not UTF-8 or unreadable is skipped, and app_source_import, js_source_bundle_compare and the managed source reader say so in a gitignore_skipped limitation, since its rules no longer hide files.
2026-11-12 23:11:56 +07:00
Alex Joaquim Pereira 1fb6cf697a Mark archive comparison rows capped (R3.11) (#1782) (#1782)
core_archives_compare counted every added, removed, changed and moved file but cut each list at max_rows without saying so. It now marks a cut comparison rows_capped, with a limitation that the counts are complete and partial coverage; a comparison that fits keeps its evidence as before.
2026-11-12 21:11:00 +07:00
Alex Joaquim Pereira 71dda0be00 Disclose application-graph edges dropped at the cap (R3.12) (#1780) (#1780)
An application graph dropped edges past 4 x max_nodes without saying so, and js_app_map reported complete coverage even for a graph cut by its node or edge cap. The builder now counts edges the cap turns away and records an edge_cap limitation beside node_cap, and js_app_map marks coverage partial when either cap cut the graph, on every module page.
2026-11-12 20:34:52 +07:00
Alex Joaquim Pereira 664ce030d1 Keep source-bundle comparison totals honest under the row cap (R3.12) (#1778) (#1778)
A source-to-bundle comparison with more scripts than max_rows reported the examined window's counts as if they covered the whole tree, and its count of bundle units without a source was the capped row count. It now says how many scripts were examined beside the total, counts every unclaimed unit while still listing at most max_rows, and marks a capped result with a rows_capped limitation and partial coverage.
2026-11-12 19:46:46 +07:00
FuryNocturnTV (Tare Fernandez) 290c2fde44 Probe a port no other test can take in the JEB refused-connection test (R5.2) (#1773) (#1773)
The JEB test's nothing-listens-here check bound a port and released it, so a stand-in server in a test running beside it could take that port and answer, failing the test now and then. It now uses 127.0.0.1:1, which binding port 0 never hands out.
2026-11-12 19:20:30 +07:00
Alex Joaquim Pereira d56fa23860 Mark sources of unread external source-map sections uncertain (R3.12) (#1767) (#1767)
An index-map section that points at an external map, which is never fetched, adds no sources, so an application graph treated the map's list as complete. Such sections are now counted (through nested index maps), the graph names them in a limitation, and comparing a reference source tree with the bundle reports an otherwise unmatched source as uncertain with partial coverage instead of absent.
2026-11-12 18:12:13 +07:00
d7do7e 28f0357bd7 Normalize leading dot-slash before app/ prefix check in build tools (R5.4) (#1763) (#1763)
A build tool path that already names app/, written as ./app/... or app/..., or one that resolves inside app/, is never moved into a nested app/app/ by the fallback #1752 added.
2026-11-12 17:23:03 +07:00
htjulia 4a4b06d281 Study a macOS app bundle through the program its Info.plist names (R2.4) (#1759) (#1759)
An app picked as Name.app was studied as a plain folder, so Deep mode skipped Ghidra, the console runs and the window picture, and the app-screenshot check had nothing to compare with. A folder ending in .app now resolves to the program its Info.plist names, or the one named like the bundle; a bundle with no program, and any other folder, stay as picked. Fixes #1757.
2026-11-12 16:29:14 +07:00
d7do7e 7049097d35 Fall back to app/ for relative build tool paths (R5.4) (#1752) (#1752)
Commands run by build_command_run work inside app/, so compiler errors name files relative to it. build_files_list, build_file_read and build_file_edit now find such a path inside app/ when nothing is at it in the project root, and build_file_write writes there when the folder already exists in app/ and not in the root; anything else resolves as before, still inside the project.
2026-11-12 15:26:06 +07:00
Fury a01669bc23 Bound folder walks by the entries examined, not only the files kept (R3.11) (#1737) (#1737)
A folder walk is now limited by the entries it examines and the path bytes it holds, not only the files it keeps, so a tree of empty folders or links or one folder with millions of names no longer walks or loads without end. A cut listing keeps the first names in name order, the same every time; the walk stops at the first file or entry over a limit and says so, cancel is checked inside a long folder listing, and an ASAR's unpacked folder and JavaScript source folders now report when they were cut short.
2026-11-12 13:03:51 +07:00
Fury 699464db8d Never save defaults over a config.toml that couldn't be read (R2.9) (#1735) (#1735)
Only a missing config.toml gives plain defaults now. A file another program holds, the account can't read, or that isn't UTF-8 no longer loads as defaults that the next save writes over it: one that can't be understood is set aside under the first free config.toml.broken name (an earlier copy is never replaced), and one that can't be read or set aside stays where it is while saves, deferred saves, settings_set and plugins_add refuse with BadSettings.
2026-11-12 12:57:24 +07:00
Justin John 573d84e751 Say in the feed while a decompile waits on Ghidra, and for how long (R1.5) (#1722)
While native_function_pseudocode waited on Ghidra the feed showed only "start native function pseudocode" for up to 15 minutes, because the tool runs in our MCP server inside the coding agent and its progress reaches only the agent (#1714). A decompile now says, once a minute, how long it has waited (or that it is queued behind another decompile), as the tool's progress and as a line in the project's inbox; the run shows each new line in the feed, the line goes when the wait ends, and a run starts by clearing lines a stopped tool left.
2026-11-12 11:50:40 +07:00
Nicolas Bohn 438c80082a Report sources of unreadable source maps as uncertain, not missing (R3.12) (#1708)
A source map that was malformed, had an undecodable data URL or was listed but not loaded left its sources looking absent, so a source comparison reported them as confirmed missing. Such a map is now marked unreadable with a limitation, and the comparison reports otherwise unmatched sources as uncertain with partial coverage. A stand-alone .map beside an analysed script is read like a referenced one; other .map files stay listed and unread, so they can't make a comparison uncertain or match code that doesn't ship.
2026-11-12 08:50:04 +07:00
Nicolas Bohn ab79ec87a4 Count source-map sections, check skipped values and keep refused maps' sources uncertain (R3.12) (#1705)
Follow-up to #1703. A sections array of non-objects could cost several times the old parser's memory, skipped values weren't checked as a full read checks them so some broken maps read as valid, entries a repeated key replaces still used the budget, and the analyzer read a map refused at a limit as one with no sources. Index-map sections now count against the entry budget and non-map sections stay small, skipped values get the same string, number and nesting checks, a replaced list is freed and gives its entries back, the default limit is 4,000,000 so a million sources with content fit, and a map refused at any of the parser's limits leaves its sources uncertain with a limitation, while a malformed map is read as before.
2026-11-12 02:43:59 +07:00
Alex Joaquim Pereira cbf7c17981 Resolve relative project paths before builds, option runs and Play (R2.7) (#1702)
A project placed by a relative path gave engines and programs relative paths, but the child already runs inside app/, so Unity's -projectPath, Godot's --path, Unreal's -project and -archivedirectory, option runs (--screenshot, --self-test), console run checks and Play pointed inside app/ a second time. They now resolve the project path first; a program named by a bare PATH command is left as it is.
2026-11-12 00:49:27 +07:00
Alex Joaquim Pereira 3ce1ce9f52 Bound source-map recovery manifest paths and report partial recovery (R3.12) (#1700)
The source-map parser bounds the inventory it builds, but source recovery's manifest repeated every expanded source path in its outputs, so a long shared sourceRoot could still retain tens of megabytes of paths. Recovery now charges each original's source path and output path to the inventory's entry and byte budget, shared across inputs; once it's reached, further originals are left out, and the manifest, result, summary, a limitation and partial coverage say so. A pitfalls entry records the rule.
2026-11-11 23:34:20 +07:00
Afloat 3a9ad9c6c5 Report uncertain source comparisons after source-map truncation (R3.12) (#1694)
When a source map's inventory was cut by its limits, the source-to-bundle comparison searched only the retained names and reported an omitted source as confirmed unmatched. Sources with no observed match now go in a separate uncertain_sources list with the reason source_map_inventory_truncated, the result says the inventory was truncated, and the evidence carries a limitation and partial coverage; positive matches are unchanged.
2026-11-11 22:17:23 +07:00
Afloat 35f1136502 Keep colliding source-map originals during recovery (R3.12) (#1690)
Distinct source identities such as src//main.js and src/main.js normalize to the same recovery path, so recovery kept the first and dropped the rest; a file and a folder of the same name, and separate inputs with the same name, lost sources the same way. Ordinary paths are unchanged; a source whose path would collide now goes to its own sources-collisions/<input>/<source>/ folder, and the manifest records each one's input and source-map index. A pitfalls entry records the rule.
2026-11-11 21:53:57 +07:00
muraa-p cd9cceabe8 Test that a gzip stream named .txt and an empty .txt aren't read as text (R3.11) (#1677)
Target sniffing decides which tools are suggested. Two cases it already gets right had no test: a gzip stream named .txt stays Unknown, because the bytes decide the kind and not the name, and an empty .txt stays Unknown, because there is nothing to read.
2026-11-11 18:37:41 +07:00
Afloat 34774fd3b3 Report packet evidence only for valid capture and protocol fields (R3.12) (#1247)
DNS labels showed dots, backslashes and unprintable bytes as they came, so different wire names could look the same; they're now escaped (\. \\ \DDD). HTTP is reported only for a complete start line: a request with a known method, a target without control characters and an HTTP/1.x version, or a response with an HTTP/1.x version, a three-digit status and an optional reason phrase. The packet tools' warning about unreadable parts now says what may be missing.
2026-11-11 18:34:37 +07:00
Afloat a1581c0400 Keep warnings from every view in the .NET application graph (R3.12) (#1663)
The application graph is built from the assembly's inventory, members and native boundaries but only passed on the members' warnings, so a warning only the inventory or the native mappings raised (such as trailing bytes in an attribute's signature) disappeared from it. The graph now combines all three, keeps each view's first warning in view, and removes repeats before its 20-warning limit.
2026-11-11 18:20:41 +07:00
Afloat fdf958e443 Note non-minimal DER lengths in signatures and certificates (R3.12) (#1646)
The DER reader accepted redundant length encodings (a long form under 128, or a leading zero length byte) without saying so. Each element now records whether its length is minimal; certificate, CMS, Authenticode and certificate-chain views keep everything they read and add one note that an element is not strict DER, and signatures over those bytes are checked as before.
2026-11-11 17:26:06 +07:00
Afloat e9e78485cb Report trailing bytes after .NET signatures instead of ignoring them (R3.12) (#1632)
Signature readers returned the decoded signature and silently accepted bytes after it. Complete method, field, local, TypeSpec and instantiation signatures now note when their blob carries extra bytes: the decoded types are kept, as the runtime uses them, and the inventory, member and native-boundary views say once that some signatures have trailing data that wasn't interpreted.
2026-11-11 17:23:14 +07:00
Afloat e755c874e6 Don't open a different Godot project when its path isn't valid UTF-8 (R2.7) (#1649)
Godot reads --path as UTF-8, and the path was passed through a lossy conversion, so a project folder whose name isn't valid UTF-8 could open a different project with a similar name. Such a project now isn't launched instead.
2026-11-11 17:10:48 +07:00
NetterSilver 15e8282c74 Reject sign characters in hex addresses (#1625)
parse_address handed the digits after 0x (or before a trailing h) to from_str_radix, which accepts a leading sign, so 0x+10 and +10h read as 0x10. Hex addresses must now be non-empty hex digits, and anything else gets the usual "not an address" error. The address test covers 0x+10, +10h and 0x-10.
2026-11-11 15:39:06 +07:00
Afloat 4d87c5edc7 Preserve repeated observations when comparing evidence bundles (R3.11) (#1613)
`core_evidence_exports_compare` indexes each operation/subject by a single record. Normal exports can contain several observations of that subject, including different text pages or successive versions of the same address annotation. Later index insertions silently overwrite earlier observations, so additions and removals disappear, changing record order changes the comparison, and one intact page can hide a tampered page from the changed count.
2026-11-11 13:59:58 +07:00
Afloat 9480cc0108 Report partial text coverage when the final line is cut (R3.11) (#1610)
A text-read page that reached the last line of a file but cut a line at the 256 KiB limit reported cut_lines correctly, yet its coverage said complete because it was worked out from the line count alone. Coverage is now partial whenever a line on the page was cut.
2026-11-11 13:36:32 +07:00
Afloat b11ba97427 Keep evidence-based call paths within one input binary (R3.11) (#1612)
Function studies identify their source bytes, but `app_call_path_find` currently joins their addresses without checking that source identity. Two different binaries can therefore contribute different edges at the same addresses and produce a call path that exists in neither binary. The regression uses two real ELF targets: one has main → helper, the other has helper → dispatch, and neither contains the complete main → dispatch path. Both inline records and saved evidence references reproduce the false path.
2026-11-11 13:17:54 +07:00
Afloat 28d1063a52 Bound input reads and refuse non-regular files before reading (R3.11) (#1611)
The input loaders trust an earlier file-size report before reading to EOF. A regular virtual file can report zero bytes and still return data beyond the configured limit, and files can grow between the size check and read. Some loaders accept devices or pipes, allowing a text or evidence-bundle request to wait indefinitely for a writer. Prefix reads also use metadata size to decide whether to assign a whole-file hash, so a truncated prefix of a zero-size-reporting file is misidentified as the whole input.
2026-11-11 13:14:35 +07:00
Afloat 6a4dee893e Keep native function evidence from blocks before its entry (R3.11) (#1600)
A native function can branch to a body block placed before its entry address. The control-flow graph already included that block, but reference and string scans only looked from the entry onward, and parameter inference took the lowest-address block as the entry, so a register set by the real entry could become a false parameter while the real input disappeared. Reference scans now cover the address range of all of the function's body blocks, and parameters are read from the block at the function's actual entry.
2026-11-11 13:11:26 +07:00
Afloat 25f6c0720d Warn about undefined Python bytecode header flags (R3.12) (#1595)
A modern .pyc header's flag word defines only its two low bits, and other bits were read without comment. Undefined bits are now reported as a header warning, while the invalidation mode, source fields and code are read from the defined bits as before, so a file from a future Python release that adds a flag stays readable. Legacy headers, which have a timestamp in that position, are unaffected.
2026-11-11 13:08:26 +07:00
Afloat 2897b15894 Keep capped byte-search results in global file-offset order (R3.11) (#1609)
core byte search ran its hex, UTF-8 and UTF-16LE queries in turn against one shared 100,000-match allowance, so a stream of later hex matches could use it up before an earlier text match was considered, and sorting afterwards couldn't bring that match back. Each query now keeps up to the cap, the results are merged in file-offset order and cut to the cap, and the result says when the cap was reached.
2026-11-11 12:39:51 +07:00