Commit Graph
756 Commits
Author SHA1 Message Date
Efe Şahinbaş 479c287661 Localize saved-builder replacement notices after Just ask (R5.5) 2026-11-18 23:37:39 +03:00
macallantheroot 60e1b0928f Keep the independent status updates conflict-free (R3.11) 2026-11-18 22:31:41 +03:00
macallantheroot 6a28746956 Bound managed reconstruction source reads to the remaining budget (R3.11) 2026-11-18 22:30:11 +03:00
macallantheroot b277e09438 Localize saved-builder replacement notices in the desktop UI (R5.5) 2026-11-18 21:21:12 +03:00
AlexJoaquimPereira 64a388d06c Reject non-text game folders and settle only the failed job (R3.9)
Review follow-up: folder_picked now refuses a folder whose name isn't text before dispatching either tool, with a message, and sends the exact UTF-8 path. Game files keeps one map of in-flight jobs with their kind and whether the screen still waits for them, instead of a looks list and a listing id. A worker failure is always logged; a current folder scan or listing clears only its own spinner and says so, a failed triage holds neither, and a superseded job says nothing. Export save errors say so without stopping the archive listing, even when the archive path matches a reopened listing.

The same-folder regression now starts both looks through folder_picked and feeds results through CraftApp dispatch; new regressions cover the non-text refusal, a failed triage keeping the scan running, a superseded failure staying quiet, and an export error not clearing loading.
2026-11-18 21:26:03 +05:30
AlexJoaquimPereira 54f42f8230 Keep a Game files look with the job that asked for it (R3.9)
Picking game A, B and A again while the first A look ran could still apply the older A result, because the screen compared the shown folder's path. Worse, a folder whose name has bytes that aren't text was sent as a lossy display string, so every completion failed the same path check and the screen loaded forever. act now returns its job id; GameFiles records the folder looks and the archive listing still expected, and tool_done applies only those. A repeated pick ignores the older answer, and a non-text folder's current answer finishes with its error.

Regressions: a stale same-folder look is ignored and the newer one fills the list; a non-text folder's current error clears looking and is shown. The three existing wrong-folder/archive guards still pass.
2026-11-18 21:26:03 +05:30
Justin John 5e09595d55 Let Settings → AI choose Codex's model (#2129)
Codex now shows the model it uses ("Codex default" until one is chosen) with Change…, like Claude Code (#2109). The choices are its default (no model is passed, so its own settings decide) and the models `codex debug models` lists, in its order, leaving out the ones it hides; over SSH the remote Codex is asked. `ai model Codex` lists and sets them the same way. Until now the model could only be set by adding `cli_model` to config.toml by hand.
2026-11-18 21:35:57 +07:00
BFlat 9c9f5a10d2 Merge pull request #2128 from Plastic-time/bugfix/r3.11-pseudo-write-footprints
Follow-up to #2124. The pseudo-C could still show an argument's load in the call line after an instruction that overwrote the bytes it read, for writes the decompiler measured wrongly: 64-bit ARM pair and exclusive stores (both registers count, and non-temporal pairs are stores too), x86 bit writes through a register index, `movdir64b`, and a store that overwrites part of a Windows stack argument. Those are measured now. A register is treated as the stack frame only while the function really keeps its stack there, so a stack pointer loaded from elsewhere is no longer assumed clear of global data. 64-bit ARM loads also show the size they read (`*(uint8_t*)…`), and a pair store shows as two typed writes.

Measured on two real programs before and after (every function, default limits): an x86-64 `grep` folds 3,021 register arguments where it folded 3,023, the two lost being loads from a global with a store through a data pointer in between; an AArch64 `ls` folds 1,813 either way.
2026-11-18 21:27:16 +07:00
RRFZ e2df6bc410 Preserve pair writeback and split outgoing arguments (R3.11) 2026-11-18 08:49:22 -05:00
BFlat b935cb33bf Merge pull request #2123 from Plastic-time/bugfix/r3.12-js-app-file-localhost-dot-folders
Follow-up to #2113. A window loading `file://localhost/ui/index.html` was looked up as `localhost/ui/index.html`, which could match the wrong page; `localhost` and an empty host both mean this computer now. And a page reference ending in a `.` or `..` part (`./boot.js/.`) names a folder, so it is no longer matched to the file before it.
2026-11-18 20:26:30 +07:00
RRFZ bdd284d030 Preserve A64 memory effects and truncated direct stores (R3.11) 2026-11-18 08:23:09 -05:00
RRFZ d1421498e6 Preserve argument loads across overlapping memory writes (R3.11) 2026-11-18 07:57:51 -05:00
BFlat de20759323 Merge pull request #2125 from Plastic-time/bugfix/r5.7-result-lists-cap-before-index
Follow-up to #2116. A result with thousands of lists at its top level was still gone through in full, though its first 64 already decide what is listed. The top level is read first and the work stops at the 64th list; nested lists are only looked for when there is room left. What is listed doesn't change.
2026-11-18 19:47:46 +07:00
BFlat 194442dae5 Merge pull request #2124 from Plastic-time/bugfix/r3.11-pseudo-memory-write-overlap
Follow-up to #2119, which stopped a load being shown after a store that may have changed the memory it read, but still let it through in several cases: on 64-bit ARM, where the size of an access wasn't known and a 16-byte pair store looked clear of a load 8 bytes on; when a stack address had an index, or the two addresses used different segments; after an instruction the decompiler doesn't model, such as a byte store on 32-bit ARM or an x86 string operation; and for a value loaded from a fixed address. A Win64 argument passed on the stack is also no longer shown with the value stored before a later write to its slot. Where it can't tell, the decompiler now keeps the load as its own statement.
2026-11-18 19:38:01 +07:00
RRFZ a640dc31b8 Resolve local file URL authorities from the application root (R3.12) 2026-11-18 07:15:44 -05:00
RRFZ 55a9d46b24 Stop listing root arrays at the summary cap (R5.7) 2026-11-18 07:13:19 -05:00
BFlat 5633b513ff Merge pull request #2117 from Plastic-time/bugfix/r3.12-sqlite-default-followups
Follow-up to #2108. A column added later to a SQLite table fills older rows with its default. Two kinds of default were read as empty: a blob written with a plus sign in front (`DEFAULT+X'41'`), which #2108's splitting broke, and a bare word containing accented or other non-ASCII letters or a `$` (`DEFAULT été`, `DEFAULT a$b`). Both are read as SQLite reads them. A test table that SQLite itself would refuse to create is replaced by one it accepts.
2026-11-18 19:04:07 +07:00
BFlat cf6f1d1a7f Merge pull request #2116 from Plastic-time/bugfix/r5.7-result-lists-first-match-map
Follow-up to #2107. Listing a result's pageable lists looked each list name up from the top of the result again, so a large result with many names took one full walk per name (about 150 ms for 5,000 names in the author's measurement, under 1 ms now). The result is walked once, recording what each name reaches first, in the same order as before. What is listed doesn't change.
2026-11-18 18:54:47 +07:00
RRFZ cc9d50fcfd fix(disasm): keep pseudo-C argument loads and Win64 stack arguments before writes that may change them (R3.11) 2026-11-18 06:53:25 -05:00
BFlat 7871fc266a Merge pull request #2119 from Plastic-time/bugfix/r3.11-pseudo-call-arg-followups
Follow-up to #2114. An argument loaded from memory was written into the call that follows it, also when a store in between could have changed that memory: `ldr r0, [r4]; str r1, [r4]; puts(...)` printed `puts(*r4)`, which reads the value after the store. Such a load now stays where it is and the call is shown taking the register, unless the two places can be told apart (the same base with offsets far enough apart, or a stack slot and a fixed address). A store instruction was also recorded as setting the register it reads, which could make the store's own line disappear. And the object of a method-table call is still passed when it was saved to the stack before the call.
2026-11-18 18:48:59 +07:00
RRFZ 8616a48dc8 fix(analysis): read file://localhost as this computer and keep refs ending in a dot segment off files (R3.12) 2026-11-18 06:48:15 -05:00
BFlat e364d88b1a Merge pull request #2113 from Plastic-time/bugfix/r3.12-js-app-tail-resolution
Follow-up to #2100. A page script written as a `data:` or `blob:` URL was read as a local path, so `data:text/javascript,0//../../boot.js` became a dependency on the app's own `boot.js`. Anything with a URL scheme is now left alone, while a local path whose query holds a URL stays local. A path written with a `./` in the middle reaches the same file as one without. A dependency's file under `node_modules/` no longer wins over the app's own file of the same name. These lookups now use one index built once per app, where each used to scan every file.
2026-11-18 18:43:32 +07:00
RRFZ 49bd60ae81 fix(formats): skip a byte order mark where a SQLite token starts (R3.12) 2026-11-18 06:24:15 -05:00
RRFZ 19dc47baa4 perf(evidence): walk only names that hold lists when finding what they reach (R5.7) 2026-11-18 06:21:06 -05:00
RRFZ ad81606a81 fix(disasm): read the source registers of A32 STRB, STRH and STRD (R3.11)
Only STR lifted as a store, so the other plain stores recorded the stored register as written, which dropped it from entry-block parameters and other dataflow. Their kind is unchanged.
2026-11-18 06:09:34 -05:00
BFlat 5a17df35de Merge pull request #2112 from Plastic-time/bugfix/r3.12-js-ledger-verifier-ties
Follow-up to #2105. While the rebuild ledger was being built, the same piece of evidence was looked up several times. A check result saved in between could fail the first lookup and pass a later one, which left an entry marked proven with no result behind it. Each piece of evidence is now looked up once per build, and an entry is proven only when a passing check's result was actually selected. Two checks that tie no longer give a different explanation depending on the order they were recorded in.
2026-11-18 18:07:21 +07:00
RRFZ c93e201391 fix(disasm): keep spilled base arguments, loads before overlapping stores and store statements in pseudo-C (R3.11)
A memory-indirect call's base assigned in the block stays an argument after an earlier read of it. A folded load stays in place when a store before the call may overwrite what it read. A store's source register is no longer recorded as an assignment, which folded the store's statement away.
2026-11-18 06:05:26 -05:00
RRFZ 99516f7e99 fix(analysis): drop tabs inside HTML URLs, read FILE: in any case and keep trailing-slash paths off files
HTML refs lose interior tabs and newlines before the scheme check, file: is stripped case-insensitively, and a path ending in / resolves to no file in resolve_path or a modulepreload.
2026-11-18 06:02:13 -05:00
RRFZ 2f340063f6 fix(formats): read plus-prefixed blob and non-ASCII bare SQLite defaults (R3.12)
A unary plus before X'..' keeps the blob, as SQLite drops the plus. Bare default words take non-ASCII characters and a later dollar sign, as SQLite identifiers do. The comment-after-e fixture uses 0x1e--, which SQLite creates.
2026-11-18 05:48:46 -05:00
BFlat b60cca57d4 Merge pull request #2114 from Plastic-time/bugfix/r3.11-pseudo-call-args
Follow-up to #2096 and #2084. A call through a table reached from a register (`mov rdi, obj; call [rdi + 16]`) is usually a method call on that object, with the object as its first argument; since #2096 the pseudo-C showed it with no arguments. The register is passed by name again and its assignment stays visible. A jump to an imported function through its slot (`jmp [slot]`, `ldr pc, …`) is a tail call: it now shows the arguments set up before it and is listed among the function's calls, where it read `return puts();`. And a 32-bit ARM store relative to the program counter keeps its fixed address.
2026-11-18 17:43:27 +07:00
RRFZ efacf113fd perf(evidence): find what every result name reaches in one walk (R5.7)
result_lists looked each array name up from the root. It now builds the first match for every name once, in find_result_key's order, and keeps the level-order cap.
2026-11-18 05:42:13 -05:00
BFlat 63801a686e Merge pull request #2111 from Plastic-time/bugfix/r2.2-uninstall-blocker-advice
Follow-up to #2104. `craft-anything-cli uninstall` named the app whose config blocked it and nothing more; it now prints the reason and what to do. The advice also fits the problem: a folder where the config file should be is called that (Windows reports it as "access denied", which sent people to check permissions), only a real permission error points at permissions, and a config that is badly encoded or malformed is to be backed up and fixed where it is, since moving it aside would also take the other servers it lists out of use. Setup, doctor and uninstall share the wording.
2026-11-18 17:25:35 +07:00
RRFZ 1d7011b602 fix(analysis): trim HTML URL attributes, match node_modules segments and keep remote loads as URLs
Spaced HTML refs are classified as a browser reads them, only a whole node_modules directory segment marks dependency code, and remote loadURL targets stay URL nodes.
2026-11-18 05:24:18 -05:00
RRFZ 80740250b2 fix(disasm): keep base-register call arguments, A32 PC store addresses and import tail-call arguments
A memory-indirect call's base argument register is passed by name, valid A32 PC-relative stores keep their static address without becoming literal references, and import tail calls through ldr pc or jmp [slot] pass their register arguments and are recorded in Pseudo.calls.
2026-11-18 05:17:41 -05:00
RRFZ 56e3517f61 fix(analysis): treat any URL scheme as external and index js_app exact tails
data: HTML refs no longer resolve to local files, equivalent tail spellings reach the same file, node_modules listing entries never win a tail, and tails come from one index per analysis.
2026-11-18 05:07:15 -05:00
BFlat 26e977bb85 Merge pull request #2108 from Plastic-time/bugfix/r3.12-sqlite-tight-type-and-clause-tokens
SQLite accepts a `CREATE TABLE` with no spaces between its parts, and reading one went wrong in three ways. A constraint written straight after a type (`REAL(8)CHECK(...)`) became part of the type, which changed how the column's values were read (REAL as INTEGER, BLOB as TEXT). A quoted type straight after a column name (`id"INTEGER" PRIMARY KEY`) became part of the name, so the column wasn't seen as the row's key. And `DEFAULT-5`, `STRICT;` or `WITHOUT ROWID;` weren't recognised. Names, types and clauses are now split wherever SQLite splits them, and only its five whitespace characters count as space.
2026-11-18 17:06:48 +07:00
RRFZ 422e43b5df fix(analysis): check each ledger evidence id once and break verifier ties fully
A result that starts to verify mid-build can no longer prove a row with no selected result, proven needs a selected verifier result, and tied verifiers report the same gap in either order.
2026-11-18 05:00:34 -05:00
BFlat ab28f10099 Merge pull request #2107 from Plastic-time/bugfix/r5.7-evidence-result-lists
A tool's result says which of its lists can be paged through, up to 64 of them. Names were gathered depth first and counted before checking that each really led to a list, so 64 names that turned out to be counts, or the sub-lists of one nested object, could use up the limit and leave a real top-level list unlisted. A name now counts only when it leads to a list, and each level of the result is gone through before the one below it.
2026-11-18 16:59:31 +07:00
BFlat 8f97eebfc1 Merge pull request #2105 from Plastic-time/bugfix/r3.12-js-ledger-storage-and-bindings
The ledger of what a rebuilt JavaScript app must do names, for each entry, the place in the app's map it came from. For storage uses, requests with no method and native modules listed as files, that name didn't match any node in the map, so those entries led nowhere; they now use the map's own ids. The same entry could also be listed twice, and no longer is. And when one owner in the rebuild had several records for an entry, only the first was read: test cases in the later ones were lost, and a failed check after a passing one went unnoticed. All of an owner's records are now read together, and one failed check is enough to mark the entry disproved.
2026-11-18 16:54:39 +07:00
BFlat a33263a523 Merge pull request #2103 from Plastic-time/bugfix/r3.12-gitignore-globstar-escaped-slash
Follow-up to #2087. In a `.gitignore` pattern such as `a/**\/b.js`, the slash after `**` is written with a backslash, and `**` was then read as a single `*`, so `a/x/y/b.js` wasn't ignored. `**` followed by an escaped slash now crosses folders as git reads it, and still needs at least one folder in between.
2026-11-18 16:50:08 +07:00
RRFZ 2a5032c877 fix(setup): keep read errors' own advice and show uninstall blockers' fixes
A folder at the config path gets folder advice instead of permissions, other I/O errors keep their text, and malformed or non-UTF-8 configs are fixed where they are. The CLI prints each uninstall blocker's reason and remediation.
2026-11-18 04:48:02 -05:00
BFlat 2cba74c195 Merge pull request #2102 from Plastic-time/bugfix/r3.12-csharp-alias-expanded-nint-fallback
Follow-up to #2093. A conversion to `List<IntPtr>` or `List<UIntPtr>` is to the built-in `nint` or `nuint`, but when the program also imported a type of its own named `nint`, the conversion could be matched to that one. A name that was read as a built-in now matches only the built-in.
2026-11-18 16:46:26 +07:00
BFlat f06476a6dc Merge pull request #2104 from Plastic-time/bugfix/r2.2-uninstall-blocking-diagnostics
When uninstall couldn't safely take our entry out of another app's config file, it reported the wording of setup: "Can't add our entry…" and "run setup again". It now says what it found (the file can't be read, isn't valid, or our entry can't be removed in place) and what to do, ending in "run uninstall again". A config file that isn't UTF-8 text is also reported as that, with "save it as UTF-8", in setup, doctor and uninstall, where it used to say to check the file's permissions.
2026-11-18 16:39:42 +07:00
BFlat f6bc86889c Merge pull request #2100 from Plastic-time/bugfix/r3.12-js-app-tail-order-and-html-refs
Follow-up to #2097. A path written in code, such as a preload of `bridge.js`, was matched to a `bridge.ts` beside the code before a file really named `bridge.js` elsewhere in the app was looked for, and two files of that name no longer counted as ambiguous; the exact name is looked for first again. A path with `?v=2` or `#part` after it is found without them. A page's `<script src="//cdn.example/boot.js">` is an address on another site and is no longer joined into a local path, and a page script that can't be found is listed as unresolved, not as a package.
2026-11-18 16:30:33 +07:00
RRFZ 09a065d01d Count only lists that result names reach toward the result_lists cap, shallow levels first (R5.7) 2026-11-18 04:26:24 -05:00
RRFZ 90b447797a Treat only SQLite's ASCII whitespace as token breaks in CREATE TABLE parsing (R3.12) 2026-11-18 04:18:10 -05:00
RRFZ 58d5d35781 Recognize an escaped slash after a gitignore globstar (R3.12) 2026-11-18 04:09:29 -05:00
JG Tromp 788642e487 Offer Simple / Advanced on the Make screen, and always show Clean room / Deep there (R2.9) (#1286)
* Claim Simple / Advanced and Clean room / Deep on the Make screen (R2.9)

* Offer Simple / Advanced on the Make screen, and always show Clean room / Deep there (R2.9)

Simple mode's title bar leaves the mode switch out, so someone starting on
New project never saw that Advanced exists. The ways in now end with a
Simple / Advanced switch (on a line of its own when the window is too
narrow), using set_mode like Settings and the title bar; switching from
there stays on New project instead of opening the workbench, so the draft
stays in view.

The Clean room / Deep tiles appeared only once an original was picked. They
are now always in view: with nothing to recreate they are dimmed, can't be
picked, and say the choice applies once there is something to recreate.
Choice tiles report whether they are enabled to accessibility.

* Put back this PR's roadmap line, dropped by a merge of main, worded as review asked (R2.9)

A merge of main made in GitHub's conflict editor dropped the R2.9 line this
PR ticks. It's back, now saying Simple's title bar had no mode switch (only
Settings had one) rather than that Simple hid it everywhere but Settings.

* Describe #1286's two new tests in doc comments (R2.9)

* Measure the room Make's Simple / Advanced switch needs instead of assuming 240 points (R2.9)

Review of #1286: the row beside the ways in fitted the switch by a fixed 240-point width, set
for English. It's now measured from the switch and its name in the language shown
(widgets::segmented_width, from main's design system), so a longer translation moves the switch
under the ways in sooner. The narrow-window test also sweeps five window widths and checks the
switch and its name never overlap the ways in and stay inside the window.
2026-11-18 16:08:41 +07:00
RRFZ 66804ba597 Cover alias-expanded IntPtr, UIntPtr and dynamic controls in C# terminal fallback tests 2026-11-18 04:05:35 -05:00
RRFZ d04467530b Check exact tails before TypeScript fallbacks and skip external HTML references in js_app (R3.12) 2026-11-18 04:00:28 -05:00