Commit Graph
1148 Commits
Author SHA1 Message Date
BFlat b60cca57d4 Merge pull request #2114 from Plastic-time/bugfix/r3.11-pseudo-call-args
Follow-up to #2096 and #2084. A call through a table reached from a register (`mov rdi, obj; call [rdi + 16]`) is usually a method call on that object, with the object as its first argument; since #2096 the pseudo-C showed it with no arguments. The register is passed by name again and its assignment stays visible. A jump to an imported function through its slot (`jmp [slot]`, `ldr pc, …`) is a tail call: it now shows the arguments set up before it and is listed among the function's calls, where it read `return puts();`. And a 32-bit ARM store relative to the program counter keeps its fixed address.
2026-11-18 17:43:27 +07:00
RRFZ efacf113fd perf(evidence): find what every result name reaches in one walk (R5.7)
result_lists looked each array name up from the root. It now builds the first match for every name once, in find_result_key's order, and keeps the level-order cap.
2026-11-18 05:42:13 -05:00
BFlat 63801a686e Merge pull request #2111 from Plastic-time/bugfix/r2.2-uninstall-blocker-advice
Follow-up to #2104. `craft-anything-cli uninstall` named the app whose config blocked it and nothing more; it now prints the reason and what to do. The advice also fits the problem: a folder where the config file should be is called that (Windows reports it as "access denied", which sent people to check permissions), only a real permission error points at permissions, and a config that is badly encoded or malformed is to be backed up and fixed where it is, since moving it aside would also take the other servers it lists out of use. Setup, doctor and uninstall share the wording.
2026-11-18 17:25:35 +07:00
RRFZ 1d7011b602 fix(analysis): trim HTML URL attributes, match node_modules segments and keep remote loads as URLs
Spaced HTML refs are classified as a browser reads them, only a whole node_modules directory segment marks dependency code, and remote loadURL targets stay URL nodes.
2026-11-18 05:24:18 -05:00
RRFZ 80740250b2 fix(disasm): keep base-register call arguments, A32 PC store addresses and import tail-call arguments
A memory-indirect call's base argument register is passed by name, valid A32 PC-relative stores keep their static address without becoming literal references, and import tail calls through ldr pc or jmp [slot] pass their register arguments and are recorded in Pseudo.calls.
2026-11-18 05:17:41 -05:00
RRFZ 56e3517f61 fix(analysis): treat any URL scheme as external and index js_app exact tails
data: HTML refs no longer resolve to local files, equivalent tail spellings reach the same file, node_modules listing entries never win a tail, and tails come from one index per analysis.
2026-11-18 05:07:15 -05:00
BFlat 26e977bb85 Merge pull request #2108 from Plastic-time/bugfix/r3.12-sqlite-tight-type-and-clause-tokens
SQLite accepts a `CREATE TABLE` with no spaces between its parts, and reading one went wrong in three ways. A constraint written straight after a type (`REAL(8)CHECK(...)`) became part of the type, which changed how the column's values were read (REAL as INTEGER, BLOB as TEXT). A quoted type straight after a column name (`id"INTEGER" PRIMARY KEY`) became part of the name, so the column wasn't seen as the row's key. And `DEFAULT-5`, `STRICT;` or `WITHOUT ROWID;` weren't recognised. Names, types and clauses are now split wherever SQLite splits them, and only its five whitespace characters count as space.
2026-11-18 17:06:48 +07:00
RRFZ 422e43b5df fix(analysis): check each ledger evidence id once and break verifier ties fully
A result that starts to verify mid-build can no longer prove a row with no selected result, proven needs a selected verifier result, and tied verifiers report the same gap in either order.
2026-11-18 05:00:34 -05:00
BFlat ab28f10099 Merge pull request #2107 from Plastic-time/bugfix/r5.7-evidence-result-lists
A tool's result says which of its lists can be paged through, up to 64 of them. Names were gathered depth first and counted before checking that each really led to a list, so 64 names that turned out to be counts, or the sub-lists of one nested object, could use up the limit and leave a real top-level list unlisted. A name now counts only when it leads to a list, and each level of the result is gone through before the one below it.
2026-11-18 16:59:31 +07:00
BFlat 8f97eebfc1 Merge pull request #2105 from Plastic-time/bugfix/r3.12-js-ledger-storage-and-bindings
The ledger of what a rebuilt JavaScript app must do names, for each entry, the place in the app's map it came from. For storage uses, requests with no method and native modules listed as files, that name didn't match any node in the map, so those entries led nowhere; they now use the map's own ids. The same entry could also be listed twice, and no longer is. And when one owner in the rebuild had several records for an entry, only the first was read: test cases in the later ones were lost, and a failed check after a passing one went unnoticed. All of an owner's records are now read together, and one failed check is enough to mark the entry disproved.
2026-11-18 16:54:39 +07:00
BFlat a33263a523 Merge pull request #2103 from Plastic-time/bugfix/r3.12-gitignore-globstar-escaped-slash
Follow-up to #2087. In a `.gitignore` pattern such as `a/**\/b.js`, the slash after `**` is written with a backslash, and `**` was then read as a single `*`, so `a/x/y/b.js` wasn't ignored. `**` followed by an escaped slash now crosses folders as git reads it, and still needs at least one folder in between.
2026-11-18 16:50:08 +07:00
RRFZ 2a5032c877 fix(setup): keep read errors' own advice and show uninstall blockers' fixes
A folder at the config path gets folder advice instead of permissions, other I/O errors keep their text, and malformed or non-UTF-8 configs are fixed where they are. The CLI prints each uninstall blocker's reason and remediation.
2026-11-18 04:48:02 -05:00
BFlat 2cba74c195 Merge pull request #2102 from Plastic-time/bugfix/r3.12-csharp-alias-expanded-nint-fallback
Follow-up to #2093. A conversion to `List<IntPtr>` or `List<UIntPtr>` is to the built-in `nint` or `nuint`, but when the program also imported a type of its own named `nint`, the conversion could be matched to that one. A name that was read as a built-in now matches only the built-in.
2026-11-18 16:46:26 +07:00
BFlat f06476a6dc Merge pull request #2104 from Plastic-time/bugfix/r2.2-uninstall-blocking-diagnostics
When uninstall couldn't safely take our entry out of another app's config file, it reported the wording of setup: "Can't add our entry…" and "run setup again". It now says what it found (the file can't be read, isn't valid, or our entry can't be removed in place) and what to do, ending in "run uninstall again". A config file that isn't UTF-8 text is also reported as that, with "save it as UTF-8", in setup, doctor and uninstall, where it used to say to check the file's permissions.
2026-11-18 16:39:42 +07:00
BFlat f6bc86889c Merge pull request #2100 from Plastic-time/bugfix/r3.12-js-app-tail-order-and-html-refs
Follow-up to #2097. A path written in code, such as a preload of `bridge.js`, was matched to a `bridge.ts` beside the code before a file really named `bridge.js` elsewhere in the app was looked for, and two files of that name no longer counted as ambiguous; the exact name is looked for first again. A path with `?v=2` or `#part` after it is found without them. A page's `<script src="//cdn.example/boot.js">` is an address on another site and is no longer joined into a local path, and a page script that can't be found is listed as unresolved, not as a package.
2026-11-18 16:30:33 +07:00
RRFZ 09a065d01d Count only lists that result names reach toward the result_lists cap, shallow levels first (R5.7) 2026-11-18 04:26:24 -05:00
RRFZ 90b447797a Treat only SQLite's ASCII whitespace as token breaks in CREATE TABLE parsing (R3.12) 2026-11-18 04:18:10 -05:00
RRFZ 58d5d35781 Recognize an escaped slash after a gitignore globstar (R3.12) 2026-11-18 04:09:29 -05:00
JG Tromp 788642e487 Offer Simple / Advanced on the Make screen, and always show Clean room / Deep there (R2.9) (#1286)
* Claim Simple / Advanced and Clean room / Deep on the Make screen (R2.9)

* Offer Simple / Advanced on the Make screen, and always show Clean room / Deep there (R2.9)

Simple mode's title bar leaves the mode switch out, so someone starting on
New project never saw that Advanced exists. The ways in now end with a
Simple / Advanced switch (on a line of its own when the window is too
narrow), using set_mode like Settings and the title bar; switching from
there stays on New project instead of opening the workbench, so the draft
stays in view.

The Clean room / Deep tiles appeared only once an original was picked. They
are now always in view: with nothing to recreate they are dimmed, can't be
picked, and say the choice applies once there is something to recreate.
Choice tiles report whether they are enabled to accessibility.

* Put back this PR's roadmap line, dropped by a merge of main, worded as review asked (R2.9)

A merge of main made in GitHub's conflict editor dropped the R2.9 line this
PR ticks. It's back, now saying Simple's title bar had no mode switch (only
Settings had one) rather than that Simple hid it everywhere but Settings.

* Describe #1286's two new tests in doc comments (R2.9)

* Measure the room Make's Simple / Advanced switch needs instead of assuming 240 points (R2.9)

Review of #1286: the row beside the ways in fitted the switch by a fixed 240-point width, set
for English. It's now measured from the switch and its name in the language shown
(widgets::segmented_width, from main's design system), so a longer translation moves the switch
under the ways in sooner. The narrow-window test also sweeps five window widths and checks the
switch and its name never overlap the ways in and stay inside the window.
2026-11-18 16:08:41 +07:00
RRFZ 66804ba597 Cover alias-expanded IntPtr, UIntPtr and dynamic controls in C# terminal fallback tests 2026-11-18 04:05:35 -05:00
RRFZ d04467530b Check exact tails before TypeScript fallbacks and skip external HTML references in js_app (R3.12) 2026-11-18 04:00:28 -05:00
Fury d319fa1794 Read a folder only as far as the walk's limits, and report entries that couldn't be read (R3.11) (#2069)
The walk kept only as many names of a folder as its entry limit allowed, but read the folder to its end to pick the first names in order: 100,000 entries read for a limit of 2. Entries that failed to read were skipped in silence, and 64 failures in a row came back as an empty folder listed in full.

- A folder is read at most as far as the remaining entry limit, and one entry more that says the folder holds more; a name over the path-byte limit ends it the same way. Cancel is checked before every read.
- A cut listing holds the entries the system returned first, sorted by name; the comments and the roadmap no longer promise the same cut every time.
- Entries that couldn't be read mark the walk as cut short and put their folder in `unlisted` with a count and the first reason ("." for the root).
2026-11-18 15:58:28 +07:00
BFlat f21b14d001 Merge pull request #2097 from Plastic-time/bugfix/r3.12-js-app-typescript-resolution
In a TypeScript project that hasn't been built, `import "./util.js"` means the file `util.ts`: the import names what the file will be called after building. Mapping such a folder left those imports unresolved, so the app's modules looked unconnected. An import or preload path ending in `.js`, `.mjs`, `.cjs` or `.jsx` now falls back to the TypeScript file beside it when no file of that exact name exists, and `.mts`/`.cts` files and more kinds of `index` file are found. The declaration files `.d.mts` and `.d.cts` are no longer taken for code, as `.d.ts` already wasn't.
2026-11-18 15:47:04 +07:00
BFlat e047eda07d Merge pull request #2095 from Plastic-time/bugfix/r3.12-js-await-sequence-import
Follow-up to #2083, which stopped an unawaited `import("x")` being taken for the module itself. Bundled code often writes the awaited form as `await (0, import("x"))`, and that shape was no longer recognised, so calls on the module it loads weren't recorded. An awaited comma sequence that ends in a dynamic import is the module again; the same sequence without `await` still isn't.
2026-11-18 15:27:48 +07:00
RRFZ bdf0854760 Fix js_ledger expectation source_node IDs, candidate deduplication, and same-owner binding aggregation (R3.12) 2026-11-18 03:24:45 -05:00
RRFZ 4fb989e967 Claim R5.7: evidence-result-lists 2026-11-18 03:23:35 -05:00
BFlat d60732c4c0 Merge pull request #2096 from Plastic-time/bugfix/r3.11-pseudo-indirect-call-target
A call through a register (`blx r3`, `call rcx`, `call [rdi + 16]`) reads that register to find its target. The pseudo-C treated the register's assignment as an argument being set up: it removed the statement and passed the function's address as a parameter, so `r3 = table[2]; (*r3)(1, 2)` came out as `(*r3)(1, 2, r2, table[2])`. An assignment the call itself reads is now kept as a statement and isn't folded into the arguments.
2026-11-18 15:19:46 +07:00
RRFZ 8213aecf60 Exclude .d.mts/.d.cts declarations and resolve TypeScript source specifiers in js_app (R3.12) 2026-11-18 03:08:03 -05:00
RRFZ 18b931b6b9 Report dedicated uninstall blocking diagnostics and UTF-8 remediations in setup (R2.2)
- Build dedicated `ActionKind::Invalid` blocking records in `plan::uninstall` when a client config cannot be read, fails syntax parsing, or refuses in-place entry removal instead of calling `inspect_client(c, &[])` and reporting `"Can't add our entry..."` / `"run setup again."`.
- Share `plan::read_text` (`ReadFail::InvalidUtf8` vs `ReadFail::Io`) across `plan`, `doctor`, and `uninstall` so non-UTF-8 configs advise saving as UTF-8 rather than checking file permissions.
- Add `uninstall_blocking_diagnostics` integration regressions and update `docs/ROADMAP.md` and `docs/STATUS.md`.
2026-11-18 03:04:07 -05:00
BFlat a955c188fb Merge pull request #2094 from Plastic-time/bugfix/r3.12-js-recover-trailing-dots-and-ext-case
Windows drops a dot at the end of a file or folder name, so `pkg./a.js` and `pkg/a.js`, or a host written `ex.test.` and `ex.test`, were planned as two files and written as one, and the second was refused. Dots at the end of each part of a path are now removed before names are compared, as dots at the start already were. A module id ending in an upper-case extension (`src/App.TSX`) also keeps it, where `.js` used to be added after it.
2026-11-18 14:58:22 +07:00
RRFZ 3238242472 Add await-sequence 23/24 depth-cap boundary regression tests 2026-11-18 02:52:30 -05:00
RRFZ 50212b66f0 Keep alias-expanded native integer args exact-match-only 2026-11-18 02:50:58 -05:00
RRFZ 631191861b Tokenize tight SQLite CREATE TABLE types, defaults, and table options (R3.12) 2026-11-18 02:48:41 -05:00
RRFZ 8d350bed69 Claim R3.12 task: gitignore globstar escaped slash 2026-11-18 02:46:18 -05:00
RRFZ cdfeff5aca Preserve indirect-call target and base registers during pseudo-C argument folding (R3.11)
- Remove the `Flow::Call | Flow::IndirectCall` exemption around `defs.remove(r)` and `consts.remove(r)` in `Lifter::block` so registers read by indirect calls (callee pointers, memory-indirect bases/indices, and AArch64 PAC modifiers) retain their assignments instead of folding into callee argument lists.
- Add four integration regressions in `crates/disasm/tests/pseudo_indirect_call_target.rs` and update `docs/ROADMAP.md` and `docs/STATUS.md`.
2026-11-18 02:43:56 -05:00
RRFZ d2078af0e2 Align sequence-await depth cap and expand regression cases 2026-11-18 02:40:25 -05:00
RRFZ 0a71d49988 Claim R3.12 task: alias-expanded nint fallback 2026-11-18 02:29:36 -05:00
RRFZ 2d856f34a8 Preserve module identity for awaited sequence dynamic imports 2026-11-18 02:23:20 -05:00
RRFZ c731e50078 Claim R3.12 task: await sequence import 2026-11-18 02:23:20 -05:00
BFlat 642179c6ab Merge pull request #2093 from Plastic-time/bugfix/r3.12-csharp-contextual-keywords-and-fallback
Follow-up to #2080. `nint`, `nuint` and `dynamic` are only keywords when nothing in scope has that name, but a conversion operator to a program's own type called `nint` or `dynamic` was read as the built-in and reported as missing; such a name is now looked up among the program's types first. An explicit `System.IntPtr` keeps meaning the built-in. And a conversion to `List<String>` where `String` is another namespace's type, imported without `using System;`, is matched to that type before `String` is tried as `string`.
2026-11-18 14:11:50 +07:00
BFlat bd0f0235c7 Merge pull request #2090 from Plastic-time/bugfix/r3.11-dataflow-mode-registers
Tracing where a value goes in a function leaves out the stack pointer and program counter, which every instruction touches. On 32-bit ARM those are `r13` and `r15`, which weren't on the list, so each `push`, `pop` and stack store added them to the graph as if they carried data. They are now left out for ARM and Thumb only; on x86-64, where `r13` and `r15` are ordinary registers, nothing changes. A 32-bit x86 call also no longer lists three register names that are never used there.
2026-11-18 13:58:47 +07:00
BFlat 51f1f2b34f Merge pull request #2092 from Plastic-time/bugfix/r3.12-dotnet-member-body-generic-context
Fields, properties and local variables of a generic .NET type already showed its type parameters by name, but an event's type and everything a method body refers to (calls, field accesses, the listed instructions) showed them as numbered placeholders: `System.Action<!0, !1>`, `Dictionary<!1, !!0>::Add(!0, !1)`, `box !1`. They are now read with the enclosing type's and method's parameters, and a call on a generic type shows the argument types of the type it is called on.
2026-11-18 13:58:46 +07:00
BFlat f1e70b10a2 Merge pull request #2088 from Plastic-time/bugfix/r1.5-gdb-mi-framing
A console command sent to GDB with a line break in it was written as two lines, so its second line ran as a command of its own; line breaks, tabs and other control characters are now escaped. A result that arrived late from an earlier command that had timed out could be taken as the current command's result or leave its error behind; only the result carrying the current command's number counts now. A stray `}` or `]` in a stop record no longer hides the fields after it, and `\a`, `\b`, `\f`, `\v` and `\xHH` in GDB's output are decoded.
2026-11-18 13:54:02 +07:00
BFlat f6c6543713 Merge pull request #2089 from Plastic-time/bugfix/r3.12-js-fallback-caps-and-truncation
When a script can't be parsed, a simpler reader lists what it can from the script's words. It listed the address of a `fetch("https://…")` call twice and repeated an address for every time it was written; it stopped noticing addresses at all after 4,000 other strings; and when its lists of strings, IPC uses or exposed names were full it dropped the rest without saying so. Each address is now listed once, addresses are found however many strings came first, and a list that was cut is named as cut.
2026-11-18 13:53:12 +07:00
RRFZ 5dc919fd74 Strip trailing dots from recovered module and web-script segments and match known module extensions case-insensitively (R3.12) 2026-11-18 01:46:44 -05:00
BFlat 3f8e1eb3de Merge pull request #2086 from Plastic-time/bugfix/r2.2-qoder-skills-and-windows-tilde
Someone who moves Qoder's configuration folder with `QODER_CONFIG_DIR` got its settings written there but the skill written under `~/.qoder`, where their Qoder no longer looks; both now go to the folder the variable names. On Windows, a path given in such a variable as `~\folder` was taken as a folder literally named `~` inside the home folder; it is now the home folder, as `~/folder` already was.
2026-11-18 13:43:33 +07:00
RRFZ c888defe2c Preserve explicit System.IntPtr/UIntPtr identity across contextual keyword reconciliation 2026-11-18 01:27:16 -05:00
RRFZ 9e7ffa3f47 Propagate generic context to CLI events and method-body tokens (R3.12) 2026-11-18 01:25:15 -05:00
RRFZ 8e84985f6f Resolve C# contextual type keywords and scope-first generic fallback (R3.12) 2026-11-18 01:19:13 -05:00
RRFZ 5743ae32aa Claim R3.12 C# contextual keywords and generic fallback follow-up 2026-11-18 01:19:13 -05:00