Commit Graph
1584 Commits
Author SHA1 Message Date
BFlat 743d896094 Merge pull request #2049 from Plastic-time/bugfix/r3.12-csharp-verbatim-identifiers
A C# member or parameter named with a verbatim identifier (`@class`, `@namespace`, `@event`, `@operator`) had its `@` dropped and was then read as the keyword, which opened fake scopes and changed member kinds. Verbatim identifiers are now kept as names and never matched as keywords or modifiers.
2026-11-18 05:55:50 +07:00
BFlat 5d14417833 Merge pull request #2048 from Plastic-time/bugfix/r3.12-axml-typed-booleans
An Android manifest flag stored as an integer (`exported` = 0, `debuggable` = 1) was read as not set, so a component marked not exported could be reported as exported. Integer-typed values are now read as booleans as Android does, and only the un-namespaced `package` attribute names the package.
2026-11-18 05:55:43 +07:00
BFlat bc6198ee75 Merge pull request #2047 from Plastic-time/bugfix/r3.12-graphql-type-system-definitions
A GraphQL document that also declared a type-system definition without braces (`scalar`, `union`, `directive`, `extend`) or began with a description lost the operations after it, because the reader looked for a brace that never came. Those definitions and descriptions are now stepped over by their own grammar.
2026-11-18 05:55:36 +07:00
BFlat fa4788e0d2 Merge pull request #2046 from Plastic-time/bugfix/r3.11-pseudo-string-slice-offsets
A reference into the middle of a string skipped that many characters, not bytes, so pseudo-C showed the wrong tail for wide strings and for text with multi-byte characters. The tail is now taken by byte offset (two bytes a unit for UTF-16LE), and a reference that lands inside a character is left as an address.
2026-11-18 05:55:29 +07:00
BFlat 72aef6762c Merge pull request #2045 from Plastic-time/bugfix/r3.11-disasm-versioned-import-arity
An imported function named with a symbol version (`memcpy@GLIBC_2.14`), a stub suffix (`@plt`) or a Darwin variant (`$UNIX2003`) was not found in the argument-count table, so pseudo-C dropped arguments set in earlier blocks. Those suffixes are now stripped before the lookup; stdcall `@bytes` names work as before.
2026-11-18 05:55:23 +07:00
BFlat b9b1e73359 Merge pull request #2044 from Plastic-time/bugfix/r2.2-yaml-mapping-key-boundaries
When setup edits another app's YAML config, a key written with a space before its colon (`mcp_servers :`) was not found, so a second block was appended, and a plain key that merely starts with the same text (`craft-anything:dev:`) was taken for ours. Keys are now matched across optional whitespace before the colon and need a real key boundary after it.
2026-11-18 05:55:16 +07:00
BFlat 6efe485813 Merge pull request #2052 from Plastic-time/bugfix/r3.13-indexed-sourcemap-trace-context
Tracing a generated location through a source map made of sections found the original position but read the source snippet, the ignore flag and the source count from the outer index, which has none. So the snippet was missing, "ignored" was always false and the count was zero. They are now read from the section that covers the location, and sources are counted across sections.
2026-11-18 05:49:43 +07:00
Dylan M. Taylor 70e4d98c68 Use shared Java class reader and JVM opcode decoder (#2033)
* Use shared Java class reader and JVM decoder with legacy parity coverage

* deps: drop duplicate workspace pins left by the main merge
2026-11-17 17:13:10 -05:00
RRFZ 637ebd5875 Respect YAML mapping key boundaries in setup edits (R2.2) 2026-11-17 16:42:13 -05:00
RRFZ d1cee511e3 Keep GraphQL operations after braceless SDL definitions and descriptions (R3.12) 2026-11-17 16:40:34 -05:00
RRFZ 15f2ed0825 Redact form-encoded and mixed-case percent-escaped secrets in HAR views (R3.13) 2026-11-17 16:36:47 -05:00
RRFZ 3ef52a2f07 Read section source content and ignore lists when tracing indexed source maps (R3.13) 2026-11-17 16:36:47 -05:00
RRFZ 0dbb54fb49 Resolve indirect NS.bytes and integer NS.time in keyed archives (R3.12) 2026-11-17 16:36:46 -05:00
RRFZ 2815c3d8fa Bound SquashFS inode and directory tables across all superblock layouts (R3.12) 2026-11-17 16:36:46 -05:00
RRFZ ea626f3fd7 Treat C# verbatim @identifiers as names instead of keywords (R3.12) 2026-11-17 16:36:46 -05:00
RRFZ 51e94ed831 Decode integer-typed booleans and unnamespaced manifest package in AXML (R3.12) 2026-11-17 16:36:45 -05:00
RRFZ b080cfd7b6 Slice UTF-8 and UTF-16LE string literals by byte offset in lifter (R3.11) 2026-11-17 16:36:45 -05:00
RRFZ ac26c8621c Resolve versioned and stubbed import arity in disassembler (R3.11) 2026-11-17 16:36:45 -05:00
Dylan M. Taylor dcd5187cd5 Use shared PCAP and per-frame protocol inspection (#2031)
* Use shared packet capture and per-frame protocol inspection

* Pin PCAP inspection to merged shared library

* Test shared PCAP truncation and public adapter parity
2026-11-17 16:21:57 -05:00
Dylan M. Taylor 13845b54c1 Use shared lenient ZIP inspection and bounded seekable reads (#2020)
* Route ZIP inspection and seekable reads through shared lenient parser

* deps: pin craft-libs to the merged shared revision
2026-11-17 16:18:53 -05:00
Dylan M. Taylor 4e99363dc5 Use shared WebAssembly inspection and validation reports (#2029)
* Use shared WebAssembly inspection with app error compatibility

* Cover WASM resource indexes and component partial reports against oracle

* deps: pin craft-libs to the merged shared revision
2026-11-17 15:45:37 -05:00
RRFZ 72a05d6ad3 Claim R3.13: har-secret-encodings 2026-11-17 15:31:41 -05:00
RRFZ 13850b50d4 Claim R3.13: indexed-sourcemap-trace-context 2026-11-17 15:31:40 -05:00
RRFZ 5869d8a524 Claim R3.12: keyed-archive-nsbytes-nsdate 2026-11-17 15:31:40 -05:00
RRFZ 0b03c1f7cc Claim R3.12: squashfs-table-bounds 2026-11-17 15:31:40 -05:00
RRFZ 7beee9fc3e Claim R3.12: graphql-type-system-definitions 2026-11-17 15:31:39 -05:00
RRFZ 16246e590c Claim R3.12: csharp-verbatim-identifiers 2026-11-17 15:31:39 -05:00
RRFZ e3906bba87 Claim R3.12: axml-typed-booleans 2026-11-17 15:31:39 -05:00
RRFZ 763ff19d0c Claim R2.2: yaml-mapping-key-boundaries 2026-11-17 15:31:38 -05:00
RRFZ 8ba001646b Claim R3.11: pseudo-string-slice-offsets 2026-11-17 15:31:38 -05:00
RRFZ 13eb7a7da1 Claim R3.11: disasm-versioned-import-arity 2026-11-17 15:31:38 -05:00
Dylan M. Taylor c2c462446e Merge current main and normalize dex consumer lockfile 2026-11-17 13:57:47 -05:00
Dylan M. Taylor 4874699fec Merge pull request #2028 from storytold/refactor/shared-har
Use shared HAR capture reader preserving app policy
2026-11-17 13:52:48 -05:00
BFlat e3af36f2f3 Merge pull request #2040 from AlexJoaquimPereira/bugfix/r3.13-remaining-page-dialogs
Finishes #2037 for the last four page tools: bundle analysis, page watch, WebMCP tool discovery and the screenshot. They now answer a page's own dialogs the same way and list them in their results and summaries. The answering connect enables the Page domain itself, so each caller no longer has to.
2026-11-18 01:14:24 +07:00
Dylan M. Taylor f0ee15205f Merge current main and extend HAR consumer parity coverage 2026-11-17 12:59:15 -05:00
BFlat 5420a81632 Merge pull request #2039 from AlexJoaquimPereira/bugfix/r3.9-game-files-stale-results
A look at one game's folder or archive could finish after the person had picked another, and its list, profile or error then showed under the new pick. A finished look now carries the path it was asked for, and the Game files screen ignores a result for a folder or archive it no longer shows, leaving the new look running.
2026-11-18 00:46:16 +07:00
AlexJoaquimPereira 2928307c8a Answer a page's dialogs in the remaining inspection tools (R3.13)
The four page tools that still attached without answering a page dialog (web_page_js_analyze, web_page_watch, web_mcp_tools_list and web_page_screenshot_take) could wait to their deadline when a page opened an alert or confirm. The shared answering connect now enables Page, which is what delivers Page.javascriptDialogOpening, and all four use it; their results and summaries list the dialogs. The bundle-analysis and screenshot results now carry the dialogs capture_page already collects, and WebMCP discovery drains its events after the probe.

Regressions: a fake CDP server opens a confirm on Page.enable and records Page.handleJavaScriptDialog; all four tools answer and report it. The existing seven dialog tests and the full browser module pass.
2026-11-17 23:03:54 +05:30
AlexJoaquimPereira 4093fc457a Claim R3.13: answer the remaining page tools' dialogs
web_page_js_analyze, web_page_watch, web_mcp_tools_list and web_page_screenshot_take still attach without answering a page-opened dialog. Record the pending change before fixing it.
2026-11-17 22:56:45 +05:30
AlexJoaquimPereira 746ee700bf Keep a game-files look with the folder or archive it was for (R3.9)
A look at one game's folder or archive could land after the person picked another one, so the old profile, archive list or file rows were shown under the new pick, and a save could name an item from the old game. The button job now carries its request, and game_files::tool_done ignores an Ok or Err result whose path no longer matches the shown folder (game_archives_list/core_target_triage) or archive (game_pak_list/game_unity_list/game_iostore_list/game_unity_bundle_list). Export toasts still say a file was saved.

Regressions: an old game folder's archive list/profile and an old archive's rows are ignored and leave the new look running; an old folder's error isn't shown, while the shown folder's error is. All three failed before the guard.
2026-11-17 22:35:51 +05:30
AlexJoaquimPereira 850a5bf459 Claim R3.9: keep a game-files look with the pick it was for
A look at one game's folder or archive can land after another is picked. Record the pending change before fixing it.
2026-11-17 22:35:51 +05:30
BFlat a31e995858 Merge pull request #2037 from AlexJoaquimPereira/bugfix/r3.13-page-tools-dialogs
Follow-up to #2011, which answered a page's own dialogs only for the website session. The tools that connect to a page on their own (page show, walkthrough, coverage, listeners, module trace and the Electron page tools) now answer them the same way, so a page's alert no longer holds a call until its deadline: an alert or leave-page question is accepted and a confirm or prompt dismissed. Each result lists the dialogs and how they were answered, with declared secrets redacted, and the reporting code is shared in one place.
2026-11-17 23:51:58 +07:00
Dylan M. Taylor be8efd27fd Use shared span-preserving JSONC editor (#2026)
* Use shared span-preserving JSONC editor

* Pin JSONC editor to merged shared revision
2026-11-17 17:41:11 +01:00
Dylan M. Taylor 700dd24dc0 Pin HAR reader to merged shared prerequisite 2026-11-17 11:30:33 -05:00
Dylan M. Taylor 07559c5741 Merge remote-tracking branch 'origin/main' into refactor/shared-har 2026-11-17 11:30:17 -05:00
Dylan M. Taylor e0229453ca Use shared TAR and CPIO walkers while retaining app extraction policy (#2017) 2026-11-17 11:25:33 -05:00
AlexJoaquimPereira 68a990fee6 Answer a page's dialogs in the inspection and walkthrough tools (R3.13)
The tools that attach to a page themselves (web_page_show, web_walkthrough_record, the web-runtime coverage/listener/module tools, and the Electron page and walkthrough tools) connected without answering a page-opened alert or confirm, so the page's scripts stopped and the call waited to its deadline. They now answer dialogs as web_site_open does (alerts and leave-page questions accepted, confirm and prompt dismissed), enable the Page domain that delivers the event, and report each dialog's kind, first line and answer in the result and summary. Declared secrets in a dialog message are redacted. The shared dialog extraction moved to web_common so the website open and these tools use one reporter.

Regressions: a fake CDP server opens a confirm only after Page.enable and records Page.handleJavaScriptDialog; web_page_show, web_walkthrough_record, web_coverage_measure, web_listeners_list and web_modules_trace answer and report it. A unit test covers extraction, summary, empty/null and redaction.
2026-11-17 21:51:45 +05:30
AlexJoaquimPereira 2022ba91be Claim R3.13: answer a page's dialogs in the inspection and walkthrough tools
The tools that attach to a page on their own still let a page-opened dialog stall them. Record the pending change before fixing it.
2026-11-17 21:51:45 +05:30
BFlat 5af9ec5aec Merge pull request #2036 from AlexJoaquimPereira/bugfix/r2.9-build-file-edit-cap
Follow-up to #1965. build_file_edit read the whole file into memory before editing, so an oversized generated file could freeze or kill the app. It now uses the same 16 MiB capped read as build_file_read: a larger file is refused with a plain error and left unchanged, and text that is not valid UTF-8 is still refused.
2026-11-17 23:03:51 +07:00
BFlat 5e818e169e Merge pull request #2034 from GeraldBro/chore/i18n-fr-catalog
The French catalog was missing 27 strings from recent work (the update checker, updates managed by a launcher or package manager, agent management and website sign-in), so the French UI fell back to English on them. Placeholders are unchanged.
2026-11-17 22:46:24 +07:00
AlexJoaquimPereira 55ff4a1ee6 Refuse a project file over 16 MB in the builder's edit tool (R2.9)
A builder's edit read the whole project file into memory before replacing text, so a large generated file under app/ could freeze or kill the app. It now uses the same 16 MiB cap as a read, refusing a larger file before it is loaded and leaving it unchanged. A file at the cap still edits when the result fits the 8 MB write cap.

Regressions: an edit over the cap returns OverLimit and leaves the file unchanged; it failed before the fix with the write cap's BadInput after the whole file was read. A file exactly at the cap still edits down to the write cap.
2026-11-17 21:12:23 +05:30