Commit Graph
57 Commits
Author SHA1 Message Date
htjulia 34a0b11df1 Answer a page's JavaScript dialogs so web_site_open doesn't time out (R3.13)
A page that opened an alert while loading waited for someone to close
it, and nothing did, so the open always ran into its deadline. Alerts
and beforeunload are accepted so the page can go on; confirm and
prompt are dismissed so nothing is agreed to for the person. The
result says which dialogs the page opened and how each was answered.

Fixes #2010

Co-Authored-By: htjulia <htjulia1@gmail.com>
2026-11-17 13:44:48 +09:00
BFlat 88b2490892 Merge pull request #1961 from Fadlalla-ai/bugfix/r5.7-engine-path-folder
A path set in Settings → Engines counted as found whenever it existed, so a JDK's folder set for the Java runtime was listed as installed and then run as a program ("permission denied"). A folder is now looked in the way an install folder is, newest version first with digit runs compared as numbers; a folder without the program isn't found, and the message names the folder.
2026-11-16 23:55:43 +07:00
Fadlalla-ai a1c1c8abb9 Look for an engine's program in a folder set as its path, instead of running the folder 2026-11-16 20:18:11 +04:00
Fadlalla-ai 1520028963 Run JADX on the Java runtime engine, so it works with the Java Ghidra's setup brings 2026-11-16 19:54:38 +04:00
BFlat edbeee75d9 Merge pull request #1957 from Fadlalla-ai/bugfix/r5.7-ghidra-wrapper-and-linked-script
Follow-up to #1949. A script that runs the headless launcher is kept as the launcher even when it sits in Ghidra's own folder, so what it sets up (its Java, say) isn't dropped. A path a start script names is also followed through its links, so a script that runs a linked ghidraRun leads to the Ghidra folder.
2026-11-16 21:32:18 +07:00
Fadlalla-ai 5aec366273 Keep a wrapper in Ghidra's folder, and follow a link a start script names 2026-11-16 17:56:39 +04:00
Fadlalla-ai b4b51bc300 Find the Java that Ghidra's setup brings as the Java runtime, where Vineflower and the listing look 2026-11-16 17:48:58 +04:00
Fadlalla-ai 610fff4896 Follow a Ghidra setting that names a file to its Ghidra folder, and never run anything else as Ghidra 2026-11-16 16:56:00 +04:00
Justin John d2d52137ea Use the Windows manual proxy for engine downloads when no proxy variable is set (R2.9) (#1930)
Engine downloads (Ghidra and its JDK, Godot, pinned installs) used only the proxy environment variables, so behind a VPN that sets only the Windows system proxy they went direct and timed out. When no proxy variable is set, they now use the person's manual proxy from Windows' settings, read from the registry once per download; this computer and Windows' own exceptions go direct, and a NO_PROXY the person set replaces those exceptions. Settings with credentials, SOCKS only or no port are ignored. AI clients are unchanged. Not run behind a real system proxy. Fixes #1827, #1787.
2026-11-16 12:37:41 +07:00
FuryNocturn ab74a2730e Hide keys in a plugin's arguments in its log, and keep what a server that stopped answering printed (R5.5) 2026-11-16 01:30:50 +01:00
FuryNocturnTV (Tare Fernandez) febf096ea4 Keep a failure log when an MCP plugin doesn't start, and say what it printed (R5.5) (#1921)
A local MCP plugin that exited before answering only said "The X plugin exited." It now gives its exit code and the last lines it printed, and a write to a server that has already gone gives the same error. When a local plugin can't be started, exits, or doesn't answer in time, a failure log is written to logs/ in the config folder and named in the error. The plugin's environment is left out of the log, and a remote plugin or a stop writes none. The failure-log writer moves to the engine crate so plugins and agent runs share it.
2026-11-16 01:15:53 +07:00
Justin John 7be84b7c8d Take the Ghidra sweep's next function without a loop that always breaks (R1.5) (#1851)
The jump-table sweep found the next function with a `for` loop that always stopped on its first pass, which failed SonarCloud's reliability gate on main (java:S1751). It now takes the first function from the iterator, and the sweep still ends at the memory block's end when there's none. Behaviour is unchanged; the live Ghidra tests pass.
2026-11-14 14:39:38 +07:00
GAlun b512474615 Keep engine downloads on HTTPS across redirects (R2.9) (#1771) (#1771)
The shared engine downloader already required an HTTPS starting address but followed a redirect from HTTPS to plain HTTP. Every redirect hop is now held to HTTPS before connecting, and a refused redirect says so without printing the address, which can carry a signed query or credentials. Tested against local TLS servers with certificates made for each run.
2026-11-12 18:58:47 +07:00
Justin John 954b1607d5 Match a jump table's registers and guard to its own index (R1.5) (#1748) (#1748)
Bounding Ghidra's unguarded jump tables now takes the table from the lea that sets the movsxd's base register, and the index from the movzx into its index register, instead of the nearest lea; only an and of that index, or a cmp of it or its source byte followed by a conditional jump, counts as a guard. A pass that fails part way is undone instead of leaving half-made references. Checked live with Ghidra 12.1.4.
2026-11-12 15:19:30 +07:00
Justin John b9de86c149 Bound Ghidra's jump tables that have no bounds check before decompiling (R1.5) (#1743) (#1743)
A jump through a byte-indexed table of offsets with no bounds check, as Rust's async state machines use, made Ghidra read 256 entries, follow the ones inside other code and decompile without end (#1715). Before decompiling, the bridge now finds such tables, works out where each ends from a linear pass over the function (its .pdata extent on Windows) and gives Ghidra their real targets as a switch override, in memory for this run; guarded tables only get their targets added. A 60-stage Rust async program decompiled in 16 s instead of falling back after 938 s. Fixes #1715.
2026-11-12 14:12:52 +07:00
Justin John 573d84e751 Say in the feed while a decompile waits on Ghidra, and for how long (R1.5) (#1722)
While native_function_pseudocode waited on Ghidra the feed showed only "start native function pseudocode" for up to 15 minutes, because the tool runs in our MCP server inside the coding agent and its progress reaches only the agent (#1714). A decompile now says, once a minute, how long it has waited (or that it is queued behind another decompile), as the tool's progress and as a line in the project's inbox; the run shows each new line in the feed, the line goes when the wait ends, and a run starts by clearing lines a stopped tool left.
2026-11-12 11:50:40 +07:00
Alex Joaquim Pereira 87408500d0 Keep a failed program's last output in its error (R2.9) (#1685)
When a program printed more than its output cap, its error said "what it printed last" from the first bytes kept and never said the rest was dropped. The process runner now also keeps the last 16 KiB of a stream once it passes its cap; failure messages, ssh diagnosis and build checks quote that end and say the output was cut, while tools that parse output still get its start.
2026-11-11 20:32:53 +07:00
Afloat ffaef8564d Apply global PAX attributes to TAR members (R3.12) (#1570)
The tar reader handled per-member PAX extensions but ignored global ones, so later members could get the wrong path, link target or stored size, and a global size override left the next header at the wrong offset. Global path, link and size attributes are now kept until a later global record replaces or deletes them, applied after per-member PAX values and before GNU long names or the plain header. Each metadata header is read at its own stored length, inherited sizes must be unsigned decimals, and inherited sparse attributes are reported as unsupported. Copies of inherited names share a 64 MiB budget; engine installs refuse an archive that exceeds it before writing anything.
2026-11-11 02:29:14 +07:00
FredApps b97b44fa35 Remove the dead currentProgram check from the Ghidra bridge ping (#1482)
The bridge's ping began with an unused variable whose conditional gave an empty string either way. It's removed; the reply is unchanged.
2026-11-11 00:15:44 +07:00
Justin John 300dba586b Find a Unity Editor added to Unity Hub with Locate (R1.6) (#1467)
Unity Editors were looked for only in Unity Hub's default folders and its install-location setting, so an editor added to the Hub with Locate, which can be anywhere, wasn't found and Make kept saying Unity isn't installed. Unity Hub's own list of editors (editors-v2.json, then editors.json) is now read too, in either of its layouts, and every editor on it whose program is still there is offered; the list is read up to 1 MiB, and one that can't be read finds nothing.

Refs #1077
2026-11-10 13:33:57 +07:00
Afloat 2174cac80b Reject GNU tar long-name records that end before their padding (#1402)
A GNU long-name or long-link record whose text was complete but whose 512-byte padding was cut off, or whose padded size overflowed, stopped the listing without saying why, so the engine installer could still write the files listed before it and report success. Both cases now count as a cut-short GNU record, and the installer refuses the archive before writing anything.
2026-11-10 00:27:22 +07:00
Afloat 69e7f5773d Refuse incomplete tar engine installs after GNU metadata stops (#1394)
When a tar listing stopped at a GNU long name or link it refused (too long, or cut short), the engine installer still wrote the files listed before it and reported success, which could replace a working engine with part of one. The listing now says why it stopped, and the installer refuses such an archive before writing anything, with a plain-English error. An archive missing only its end marker still installs.
2026-11-09 23:34:38 +07:00
Afloat 5d853773d5 Bound the header used to read Android process lists (R3.3) (#1316)
The header line of a device's `ps` output is now cut at the same length limit as its rows, on a character boundary, so a very long header can't stretch the columns read for every process.
2026-11-09 20:11:07 +08:00
kuseidos 9470cdc024 Read the Windows system code, so a busy folder really waits (#1158)
Moving a Ghidra project folder that Windows reports as shared or locked (codes 32 and 33) now waits and tries again, as a permission error already did.
2026-11-09 01:39:40 +08:00
Justin John 9edd4838a7 Say to try again later when an engine download's server is busy (#1203)
A download that gets 429 or a 5xx says the server is busy and to try again in a few minutes; a 404 or 410 asks for a report.

Fixes #1193
2026-11-09 01:28:07 +08:00
Alex Joaquim Pereira 76f62972bc Cut adb and Frida parser lines at a UTF-8 boundary (R3.3) (#1215)
A long adb or Frida output line is cut at the last character boundary within the cap, so a multi-byte character at the cut no longer keeps the whole line.
2026-11-09 01:28:00 +08:00
NetterSilver 139103da1f Decode GDB/MI octal escapes as UTF-8 bytes in unquote (#1200)
Octal escapes in GDB/MI strings are read as bytes and then decoded as UTF-8, so \303\251 reads as é instead of two wrong characters.
2026-11-09 01:18:20 +08:00
BFlat caf8253ebd Find Ghidra's own launcher on PATH on Linux and macOS (#1085)
The PATH search uses the engine table's list for the host, so Linux and macOS no longer pick analyzeHeadless.bat and fail with permission denied.
2026-11-07 15:59:11 +08:00
BFlat 81de2e2d36 Download Unity Hub from its current address (#1078)
The download button no longer gets a 404: the installer is now UnityHubSetup-x64.exe.
2026-11-07 14:11:07 +08:00
kuseidos dbd5d0d963 Test both endings of a refused move, and say the lock reason once (#1057)
A move that can't pass gives the lock back and says why, tested with a release that works and one that doesn't, and a second reason no longer repeats "could not start Ghidra".
2026-11-07 10:16:23 +08:00
kuseidos 7b9c0407a1 Say why a move was refused, and never leave the analysis lock behind silently (#1047)
A refused move is only waited on when it may pass, and a timeout says what kept it waiting; a lock that can't be released ends the attempt with the reason.
2026-11-07 08:53:34 +08:00
kuseidos f7bf0b29c8 Move a half-written Ghidra project aside instead of deleting it under a running analysis (#1045)
A new build taking over a stale lock moves the project folder aside rather than deleting it, and waits if the move is refused because another Ghidra still has it open.

Closes #951.
2026-11-07 08:18:33 +08:00
adamsardo 2271338ae8 Refuse a Ghidra with no decompiler for this computer before its long analysis (#1023)
Ghidra's public downloads leave out macOS's native programs, so a Deep build analysed for many minutes and then decompiled nothing. It now stops at once and says which command builds one; an install laid out in a way we don't recognise is left to Ghidra.
2026-11-07 04:22:19 +08:00
BFlat 4390e97e60 Stop Ghidra when the app closes, and skip the analysis of an Electron program's runtime (#1007)
Closing the app stops analyses and waits for them to end. A Deep build no longer waits on Ghidra for an Electron program, whose logic is in `app.asar`.

Closes #946.
Closes #947.
2026-11-07 01:46:35 +08:00
Justin John c858a61c8d Find browsers under their other Linux names, and say why one isn't found (#927)
Finds browsers under more Linux names and says why one is missing: a bad set path, or the Flatpak sandbox.
2026-11-07 00:29:35 +08:00
Afloat ccfb5d48fc Stabilize loopback request and cancellation fixtures (#767)
Loopback test fixtures read complete request headers, negative probes use port zero, and the stand-in's shutdown test checks its answerer's lifetime rather than a port another test may reuse.
2026-11-06 23:16:46 +08:00
Alex Joaquim Pereira 8a6af4155c Point Unreal's C++ guidance at the right toolchain per platform (#777)
Unreal's C++ guidance names the right toolchain on each system: the bundled Clang on Linux, Xcode on macOS and Visual Studio on Windows.
2026-11-04 12:04:10 +07:00
BFlat 0356c4bc88 Find Flatpak browsers on Linux and give sandboxed browsers a profile they can reach (#759)
Chrome, Brave, Chromium and Edge installed as Flatpaks on Linux are found, and a Flatpak or Snap browser keeps its private profile in the home folder its sandbox shares, so it can start and its port can be read (fixes #747).
2026-11-04 10:31:11 +07:00
Fábio Soares 7b5ce085a3 Find Ghidra in the folders people unzip it to, and don't download it again (#745)
Ghidra is found where people unzip it (Program Files, the home folder, Downloads, Desktop, /Applications, Homebrew's cask and the usual Linux folders), by folder name a set number of levels down, and the guided install uses a copy already on the computer instead of downloading it again (fixes #740).
2026-11-04 08:08:26 +07:00
R ! Y 4 Z 1126c4a8e4 Find Visual Studio C++ tools installed outside Program Files (#726)
Unreal's readiness check finds Visual Studio's C++ tools installed outside Program Files, from the Visual Studio Installer's instance records and a developer shell's VSINSTALLDIR, VCINSTALLDIR or VCToolsInstallDir (fixes #669).
2026-11-04 07:58:04 +07:00
Ole Bohmbach 2769e787b0 Cap the size of a Ghidra bridge reply (#588)
The Ghidra client refuses a reply line over 128 MiB and closes the connection, so a hostile binary can't make one reply exhaust memory; a long reply split across read ticks is still read whole.
2026-11-03 20:19:09 +07:00
Bently 0ec096c569 Deep mode uses Ghidra when the engine store is under a dot folder such as ~/.config (#484)
On Linux, where the default engine store is under ~/.config, Ghidra is given a dot-free link to the store in a private runtime folder, since it refuses project paths with a dot folder; Deep mode now uses Ghidra there.
2026-11-03 14:51:00 +07:00
Bently 473f187c5d doctor says which Java Ghidra runs on as well as the Java on PATH (#489)
doctor reports which Java Ghidra runs on (JAVA_HOME_OVERRIDE in its launch.properties, the Java set for it in Settings, JAVA_HOME, then PATH), and warns when the set folder has no Java or an override wins over it.
2026-11-03 14:50:48 +07:00
Bently 7bf8220006 Test sessions find only the engines their settings name (#466)
Test sessions set engines.only_configured (never saved), so Settings::ghidra_launcher and engine_path look only where the settings and the managed store say, not on PATH or in the usual install folders. Tests now pass the same on a machine with Ghidra installed. New locate_configured and ghidra::get::headless_configured are the first half of locate and headless, which return the same as before.
2026-11-03 01:53:53 +07:00
muraa-p c6c8f35612 List a remote Frida device without frida-ls-devices -H (#227)
Listing Frida devices with a remote address returns that remote as one device, marked not contacted, instead of running frida-ls-devices with a -H flag it doesn't have.
2026-11-03 00:12:33 +07:00
bently-bot 11166b3589 Deep mode decompiles position-independent programs by name: addresses move between our image base and Ghidra's (#426)
In Deep mode, a position-independent program is decompiled by name: addresses move between our image base and the one Ghidra loaded it at (the bridge now reports it), with engine_entry and an engine_rebased limitation when they differ.
2026-11-02 23:50:33 +07:00
one-bit 1dcb46b2f8 Unreal Engine installations and their bundled Clang are found on Linux (#191)
Reads Linux registrations from ~/.config/Epic/UnrealEngine/Install.ini, honours a valid UE_ROOT, takes the version from Build.version, and counts the selected engine's own bundled Clang as its C++ tools.
2026-11-02 07:11:30 +07:00
Ole Bohmbach 3f8690a923 Find the Godot editor that the store installs on macOS (#141)
The macOS zip unpacks as Godot.app; it's renamed to Godot_v<version>.app so the engine store finds it, moving a previous install aside and restoring it if the rename fails.
2026-11-02 03:19:18 +07:00
BFlat 187fe5e000 Godot installs on macOS: its program may be bigger than other engines' files (#118)
The per-file unpack limit is passed per download: 256 MB for pinned tools as before, 1 GiB for Godot, whose download is checked against its official SHA-512 list first. Fixes #100.
2026-11-02 00:35:08 +07:00
valère didon 26bf3635f1 Frida lists devices and processes on Windows instead of hanging or finding none (#59)
frida_devices_find runs frida-ls-devices in a pseudo console on Windows, where it crashed on pipes and hung; frida_targets_list falls back to plain processes; device columns split on two spaces. Fixes #58.
2026-11-01 23:05:18 +07:00