Finishes #2037 for the last four page tools: bundle analysis, page watch, WebMCP tool discovery and the screenshot. They now answer a page's own dialogs the same way and list them in their results and summaries. The answering connect enables the Page domain itself, so each caller no longer has to.
The four page tools that still attached without answering a page dialog (web_page_js_analyze, web_page_watch, web_mcp_tools_list and web_page_screenshot_take) could wait to their deadline when a page opened an alert or confirm. The shared answering connect now enables Page, which is what delivers Page.javascriptDialogOpening, and all four use it; their results and summaries list the dialogs. The bundle-analysis and screenshot results now carry the dialogs capture_page already collects, and WebMCP discovery drains its events after the probe.
Regressions: a fake CDP server opens a confirm on Page.enable and records Page.handleJavaScriptDialog; all four tools answer and report it. The existing seven dialog tests and the full browser module pass.
web_page_js_analyze, web_page_watch, web_mcp_tools_list and web_page_screenshot_take still attach without answering a page-opened dialog. Record the pending change before fixing it.
A look at one game's folder or archive could land after the person picked another one, so the old profile, archive list or file rows were shown under the new pick, and a save could name an item from the old game. The button job now carries its request, and game_files::tool_done ignores an Ok or Err result whose path no longer matches the shown folder (game_archives_list/core_target_triage) or archive (game_pak_list/game_unity_list/game_iostore_list/game_unity_bundle_list). Export toasts still say a file was saved.
Regressions: an old game folder's archive list/profile and an old archive's rows are ignored and leave the new look running; an old folder's error isn't shown, while the shown folder's error is. All three failed before the guard.
The tools that attach to a page themselves (web_page_show, web_walkthrough_record, the web-runtime coverage/listener/module tools, and the Electron page and walkthrough tools) connected without answering a page-opened alert or confirm, so the page's scripts stopped and the call waited to its deadline. They now answer dialogs as web_site_open does (alerts and leave-page questions accepted, confirm and prompt dismissed), enable the Page domain that delivers the event, and report each dialog's kind, first line and answer in the result and summary. Declared secrets in a dialog message are redacted. The shared dialog extraction moved to web_common so the website open and these tools use one reporter.
Regressions: a fake CDP server opens a confirm only after Page.enable and records Page.handleJavaScriptDialog; web_page_show, web_walkthrough_record, web_coverage_measure, web_listeners_list and web_modules_trace answer and report it. A unit test covers extraction, summary, empty/null and redaction.
A builder's edit read the whole project file into memory before replacing text, so a large generated file under app/ could freeze or kill the app. It now uses the same 16 MiB cap as a read, refusing a larger file before it is loaded and leaving it unchanged. A file at the cap still edits when the result fits the 8 MB write cap.
Regressions: an edit over the cap returns OverLimit and leaves the file unchanged; it failed before the fix with the write cap's BadInput after the whole file was read. A file exactly at the cap still edits down to the write cap.
A Java folder set for Ghidra in Settings → Engines was used only to run Ghidra, so with no system Java, Vineflower said Java wasn't installed and JADX could not start. The Java runtime lookup now returns that folder's bin/java when no path is set for Java itself, so Vineflower, JADX, the engine list and doctor all find it. A path set for Java itself still wins, and a folder with no bin/java is ignored.
When a folder set in Settings → Engines didn't hold the program, these tools said the program wasn't installed. They now use the shared lookup and wording that the Java and disassembler tools already use: the folder set for it has no such program, or the path set for it isn't there, with how to correct it. Optional engines keep their "not installed, that's fine" note when no path is set.
Process capture was refused on FreeBSD, where a terminal loses a short program's output when it exits, so two console tests have failed in the nightly FreeBSD job. FreeBSD now uses the pipe capture Windows already uses, with the program's process group ended with it; scripted input, resizes, signals and watched files are still refused there. Linux, macOS and Windows are unchanged.
A script tag with language="VBScript" and no type was listed as JavaScript. When type is absent a browser uses the legacy language value to pick the script's type, so a language that is not a JavaScript one is no longer listed. An explicit type still decides, even an empty one.
A page that opens an alert while loading waits for someone to close it, and nothing did, so opening the site always ran into its deadline and a rebuild could not study it (#2010). The session's page client now answers dialogs as they open: an alert or a leave-page question is accepted so the page can go on, and a confirm or prompt is dismissed so nothing is agreed to for the person. The result lists the dialogs the page opened and how each was answered.
SQLite accepts a primary key written as PRIMARY KEY((a), b) in a WITHOUT ROWID table. The reader stopped at the first closing parenthesis and could not work out the stored row layout. It now reads to the matching end of the key list, finds the column inside redundant parentheses and uses its outermost collation.
The DOS header report took any "PE" prefix at the extended-header offset for a Windows extension, including a cut-off signature or "PENA" in unrelated bytes. The full four-byte signature is now required. A complete signature that overlaps the DOS header, as hand-packed small executables have, is still reported.
A Java class file that ended partway through a class-level attribute was read with no warning, so source or signature details after the cut were silently missing. The reader now keeps the attributes it could read and warns when the table ends early.
Follow-up to #1964, which made a pin without a recorded program look only inside its own folder. A saved Live pin has no copy: its folder is the project's own app, so with the project built into a shared or parent target directory it found nothing to start. Such a pin now uses the same lookup as Play; pins that keep a copy still look only inside it.
A TAR member with a valid PAX size still stopped the archive walk when its superseded size field held invalid octal, so later members vanished from the listing. The PAX size is now read first for ordinary members, and the old field is read and checked only when no override applies.
An IPv6 packet whose Next Header is 59 (no next header) got an invented "other" transport record that included any bytes after the header. Transport decoding now stops at 59, also when an extension header supplies it; other protocol values are decoded as before.
A page that opened an alert while loading waited for someone to close
it, and nothing did, so the open always ran into its deadline. Alerts
and beforeunload are accepted so the page can go on; confirm and
prompt are dismissed so nothing is agreed to for the person. The
result says which dialogs the page opened and how each was answered.
Fixes#2010
Co-Authored-By: htjulia <htjulia1@gmail.com>
An indexed source map that also carried a top-level `sources` list reported those names as part of the bundle although no section maps to them, and they could push a real source out of a full inventory. An indexed map now keeps only its file name and takes its sources from its sections.
On FreeBSD process capture was a stub that returned "only available on
Linux and macOS", so a console study kept no runs and a console run check
never ran the build. The nightly FreeBSD job has failed on the two tests
that cover them since they landed (#1679, #1702).
FreeBSD now captures the way Windows does: the program runs through
platform::process (its process group is ended with it) and its output is
read through pipes, which keep what a short program wrote after it exits;
a terminal on FreeBSD loses it. Scripted input, resizes, signals and
watched files still need the terminal capture and are refused there.
The pipe capture now has a Unix test, and capture_and_compare_echo runs on
every Unix rather than only Linux and macOS.
The Mach-O readers took the whole remainder of a load command as a library name or runpath when its path had no terminating NUL, so a command that never finished its string still supplied dependency evidence. The NUL must now be inside the command, in both summary views.
A script whose type was the module keyword with spaces around it was listed as a classic script, and a whitespace-only type was listed too, although browsers run neither. The keyword and the empty attribute are now matched exactly, before the whitespace trimming that classic script types get. Checked in a Chromium 156 page: padded and tab-prefixed module types and a whitespace-only type did not run.
A page with two meta Content-Security-Policy declarations reported only the last one, and an empty later declaration could hide an earlier policy. Every non-empty policy is now kept, in document order, joined with a comma as a policy list is written.