Commit Graph
847 Commits
Author SHA1 Message Date
BFlat e3af36f2f3 Merge pull request #2040 from AlexJoaquimPereira/bugfix/r3.13-remaining-page-dialogs
Finishes #2037 for the last four page tools: bundle analysis, page watch, WebMCP tool discovery and the screenshot. They now answer a page's own dialogs the same way and list them in their results and summaries. The answering connect enables the Page domain itself, so each caller no longer has to.
2026-11-18 01:14:24 +07:00
AlexJoaquimPereira 2928307c8a Answer a page's dialogs in the remaining inspection tools (R3.13)
The four page tools that still attached without answering a page dialog (web_page_js_analyze, web_page_watch, web_mcp_tools_list and web_page_screenshot_take) could wait to their deadline when a page opened an alert or confirm. The shared answering connect now enables Page, which is what delivers Page.javascriptDialogOpening, and all four use it; their results and summaries list the dialogs. The bundle-analysis and screenshot results now carry the dialogs capture_page already collects, and WebMCP discovery drains its events after the probe.

Regressions: a fake CDP server opens a confirm on Page.enable and records Page.handleJavaScriptDialog; all four tools answer and report it. The existing seven dialog tests and the full browser module pass.
2026-11-17 23:03:54 +05:30
AlexJoaquimPereira 4093fc457a Claim R3.13: answer the remaining page tools' dialogs
web_page_js_analyze, web_page_watch, web_mcp_tools_list and web_page_screenshot_take still attach without answering a page-opened dialog. Record the pending change before fixing it.
2026-11-17 22:56:45 +05:30
AlexJoaquimPereira 746ee700bf Keep a game-files look with the folder or archive it was for (R3.9)
A look at one game's folder or archive could land after the person picked another one, so the old profile, archive list or file rows were shown under the new pick, and a save could name an item from the old game. The button job now carries its request, and game_files::tool_done ignores an Ok or Err result whose path no longer matches the shown folder (game_archives_list/core_target_triage) or archive (game_pak_list/game_unity_list/game_iostore_list/game_unity_bundle_list). Export toasts still say a file was saved.

Regressions: an old game folder's archive list/profile and an old archive's rows are ignored and leave the new look running; an old folder's error isn't shown, while the shown folder's error is. All three failed before the guard.
2026-11-17 22:35:51 +05:30
AlexJoaquimPereira 850a5bf459 Claim R3.9: keep a game-files look with the pick it was for
A look at one game's folder or archive can land after another is picked. Record the pending change before fixing it.
2026-11-17 22:35:51 +05:30
AlexJoaquimPereira 68a990fee6 Answer a page's dialogs in the inspection and walkthrough tools (R3.13)
The tools that attach to a page themselves (web_page_show, web_walkthrough_record, the web-runtime coverage/listener/module tools, and the Electron page and walkthrough tools) connected without answering a page-opened alert or confirm, so the page's scripts stopped and the call waited to its deadline. They now answer dialogs as web_site_open does (alerts and leave-page questions accepted, confirm and prompt dismissed), enable the Page domain that delivers the event, and report each dialog's kind, first line and answer in the result and summary. Declared secrets in a dialog message are redacted. The shared dialog extraction moved to web_common so the website open and these tools use one reporter.

Regressions: a fake CDP server opens a confirm only after Page.enable and records Page.handleJavaScriptDialog; web_page_show, web_walkthrough_record, web_coverage_measure, web_listeners_list and web_modules_trace answer and report it. A unit test covers extraction, summary, empty/null and redaction.
2026-11-17 21:51:45 +05:30
AlexJoaquimPereira 2022ba91be Claim R3.13: answer a page's dialogs in the inspection and walkthrough tools
The tools that attach to a page on their own still let a page-opened dialog stall them. Record the pending change before fixing it.
2026-11-17 21:51:45 +05:30
AlexJoaquimPereira 55ff4a1ee6 Refuse a project file over 16 MB in the builder's edit tool (R2.9)
A builder's edit read the whole project file into memory before replacing text, so a large generated file under app/ could freeze or kill the app. It now uses the same 16 MiB cap as a read, refusing a larger file before it is loaded and leaving it unchanged. A file at the cap still edits when the result fits the 8 MB write cap.

Regressions: an edit over the cap returns OverLimit and leaves the file unchanged; it failed before the fix with the write cap's BadInput after the whole file was read. A file exactly at the cap still edits down to the write cap.
2026-11-17 21:12:23 +05:30
AlexJoaquimPereira 71b60cf036 Claim R2.9: cap a builder's project file edit
build_file_edit reads the whole project file into memory before replacing text. Record the pending change before fixing it.
2026-11-17 20:56:00 +05:30
Justin John db8b9777e2 Run Vineflower and JADX on the Java folder set for Ghidra (R5.7) (#2023)
A Java folder set for Ghidra in Settings → Engines was used only to run Ghidra, so with no system Java, Vineflower said Java wasn't installed and JADX could not start. The Java runtime lookup now returns that folder's bin/java when no path is set for Java itself, so Vineflower, JADX, the engine list and doctor all find it. A path set for Java itself still wins, and a folder with no bin/java is ignored.
2026-11-17 17:05:37 +07:00
Justin John acacd13b4a Say what's wrong with an engine path set for adb, Frida, GDB, Rizin, lldb, JADX, Apktool or tshark (#2021)
When a folder set in Settings → Engines didn't hold the program, these tools said the program wasn't installed. They now use the shared lookup and wording that the Java and disassembler tools already use: the folder set for it has no such program, or the path set for it isn't there, with how to correct it. Optional engines keep their "not installed, that's fine" note when no path is set.
2026-11-17 13:49:15 +07:00
BFlat 4402d170f9 Merge pull request #2015 from Plastic-time/bugfix/r3.12-html-legacy-script-language
A script tag with language="VBScript" and no type was listed as JavaScript. When type is absent a browser uses the legacy language value to pick the script's type, so a language that is not a JavaScript one is no longer listed. An explicit type still decides, even an empty one.
2026-11-17 12:05:54 +07:00
BFlat 1b0f5025fb Merge pull request #2011 from htcom-code/bugfix/r3.13-js-dialog-blocks-open
A page that opens an alert while loading waits for someone to close it, and nothing did, so opening the site always ran into its deadline and a rebuild could not study it (#2010). The session's page client now answers dialogs as they open: an alert or a leave-page question is accepted so the page can go on, and a confirm or prompt is dismissed so nothing is agreed to for the person. The result lists the dialogs the page opened and how each was answered.
2026-11-17 12:05:33 +07:00
BFlat 854f50e129 Merge pull request #2014 from Plastic-time/bugfix/r3.12-sqlite-parenthesized-primary-key
SQLite accepts a primary key written as PRIMARY KEY((a), b) in a WITHOUT ROWID table. The reader stopped at the first closing parenthesis and could not work out the stored row layout. It now reads to the matching end of the key list, finds the column inside redundant parentheses and uses its outermost collation.
2026-11-17 12:02:46 +07:00
BFlat ecaa1027e6 Merge pull request #2005 from Plastic-time/bugfix/r3.12-dos-extended-pe-signature
The DOS header report took any "PE" prefix at the extended-header offset for a Windows extension, including a cut-off signature or "PENA" in unrelated bytes. The full four-byte signature is now required. A complete signature that overlaps the DOS header, as hand-packed small executables have, is still reported.
2026-11-17 12:02:08 +07:00
BFlat cf749a926d Merge pull request #2009 from Plastic-time/bugfix/r3.12-java-truncated-attributes
A Java class file that ended partway through a class-level attribute was read with no warning, so source or signature details after the cut were silently missing. The reader now keeps the attributes it could read and warns when the table ends early.
2026-11-17 11:48:08 +07:00
BFlat f87737c213 Merge pull request #2008 from Fadlalla-ai/bugfix/r5.7-live-pin-external-build
Follow-up to #1964, which made a pin without a recorded program look only inside its own folder. A saved Live pin has no copy: its folder is the project's own app, so with the project built into a shared or parent target directory it found nothing to start. Such a pin now uses the same lookup as Play; pins that keep a copy still look only inside it.
2026-11-17 11:46:41 +07:00
BFlat e32b09b910 Merge pull request #2007 from Plastic-time/bugfix/r3.12-tar-pax-size-precedence
A TAR member with a valid PAX size still stopped the archive walk when its superseded size field held invalid octal, so later members vanished from the listing. The PAX size is now read first for ordinary members, and the old field is read and checked only when no override applies.
2026-11-17 11:46:35 +07:00
BFlat 11fad9bb2e Merge pull request #2004 from Plastic-time/bugfix/r3.12-ipv6-no-next-header
An IPv6 packet whose Next Header is 59 (no next header) got an invented "other" transport record that included any bytes after the header. Transport decoding now stops at 59, also when an extension header supplies it; other protocol values are decoded as before.
2026-11-17 11:45:41 +07:00
htjulia bd7ed31182 Note the page tools that don't answer dialogs yet (R3.13)
Co-Authored-By: htjulia <htjulia1@gmail.com>
2026-11-17 13:45:38 +09:00
htjulia 34a0b11df1 Answer a page's JavaScript dialogs so web_site_open doesn't time out (R3.13)
A page that opened an alert while loading waited for someone to close
it, and nothing did, so the open always ran into its deadline. Alerts
and beforeunload are accepted so the page can go on; confirm and
prompt are dismissed so nothing is agreed to for the person. The
result says which dialogs the page opened and how each was answered.

Fixes #2010

Co-Authored-By: htjulia <htjulia1@gmail.com>
2026-11-17 13:44:48 +09:00
BFlat 75b078888b Merge pull request #2006 from Plastic-time/bugfix/r3.12-indexed-map-source-inventory
An indexed source map that also carried a top-level `sources` list reported those names as part of the bundle although no section maps to them, and they could push a real source out of a full inventory. An indexed map now keeps only its file name and takes its sources from its sections.
2026-11-17 11:42:21 +07:00
htjulia 1b2f7e5eec Claim the JavaScript dialog fix for web_site_open (R3.13)
Co-Authored-By: htjulia <htjulia1@gmail.com>
2026-11-17 13:38:30 +09:00
RRFZ b259436c53 Honor legacy HTML script language when type is absent (R3.12) 2026-11-16 23:35:26 -05:00
RRFZ d2953f60dd Read parenthesized SQLite primary-key columns (R3.12) 2026-11-16 23:34:23 -05:00
RRFZ 2a944ea978 Claim R3.12: html-legacy-script-language 2026-11-16 23:29:29 -05:00
RRFZ 31de5dfdcc Claim R3.12: sqlite-parenthesized-primary-key 2026-11-16 23:29:27 -05:00
BFlat b87fce648a Merge pull request #2001 from Plastic-time/bugfix/r3.12-macho-complete-command-paths
The Mach-O readers took the whole remainder of a load command as a library name or runpath when its path had no terminating NUL, so a command that never finished its string still supplied dependency evidence. The NUL must now be inside the command, in both summary views.
2026-11-17 11:28:14 +07:00
Fadlalla-ai b92c9a3afd Let a saved Live pin find the project's build outside the app, as Play does 2026-11-17 08:23:02 +04:00
RRFZ d29465c20b Use PAX sizes before reading TAR member size fields (R3.12) 2026-11-16 23:21:43 -05:00
Fadlalla-ai 45c1200d54 Claim: a saved Live pin doesn't find a build outside the project 2026-11-17 08:21:18 +04:00
RRFZ 420552ff74 Report truncated Java class attribute tables (R3.12) 2026-11-16 23:19:02 -05:00
RRFZ baadb49201 Merge commit '6f07bad8c4794d75f34ff1646199e510b968b094' into bugfix/r3.12-java-truncated-attributes 2026-11-16 23:19:01 -05:00
RRFZ 481b3991fc Merge commit '6f07bad8c4794d75f34ff1646199e510b968b094' into bugfix/r3.12-tar-pax-size-precedence 2026-11-16 23:19:00 -05:00
RRFZ 0b1a643944 List sources from the section maps of an indexed source map (R3.12) 2026-11-16 23:18:59 -05:00
RRFZ 1c81805d44 Merge commit '6f07bad8c4794d75f34ff1646199e510b968b094' into bugfix/r3.12-indexed-map-source-inventory 2026-11-16 23:18:59 -05:00
RRFZ 7343ab0f40 Require the complete PE signature in DOS header reports (R3.12) 2026-11-16 23:18:58 -05:00
RRFZ 2bf656fbc0 Merge commit '6f07bad8c4794d75f34ff1646199e510b968b094' into bugfix/r3.12-dos-extended-pe-signature 2026-11-16 23:18:58 -05:00
RRFZ 3836b5bd52 Stop IPv6 packet decoding at No Next Header (R3.12) 2026-11-16 23:18:57 -05:00
RRFZ 0ceee9dc14 Merge commit '6f07bad8c4794d75f34ff1646199e510b968b094' into bugfix/r3.12-ipv6-no-next-header 2026-11-16 23:18:56 -05:00
BFlat 6f07bad8c4 Merge pull request #2003 from Plastic-time/bugfix/r3.12-html-exact-module-keyword
A script whose type was the module keyword with spaces around it was listed as a classic script, and a whitespace-only type was listed too, although browsers run neither. The keyword and the empty attribute are now matched exactly, before the whitespace trimming that classic script types get. Checked in a Chromium 156 page: padded and tab-prefixed module types and a whitespace-only type did not run.
2026-11-17 11:16:02 +07:00
BFlat 2708ee35c8 Merge pull request #2002 from Plastic-time/bugfix/r3.13-html-meta-csp-list
A page with two meta Content-Security-Policy declarations reported only the last one, and an empty later declaration could hide an earlier policy. Every non-empty policy is now kept, in document order, joined with a comma as a policy list is written.
2026-11-17 11:15:32 +07:00
RRFZ 54c8e6780c Claim R3.12: java-truncated-attributes 2026-11-16 23:14:25 -05:00
RRFZ feff90c291 Claim R3.12: tar-pax-size-precedence 2026-11-16 23:14:22 -05:00
RRFZ 011eeb8f33 Claim R3.12: indexed-map-source-inventory 2026-11-16 23:14:20 -05:00
RRFZ 629ddcae5a Claim R3.12: dos-extended-pe-signature 2026-11-16 23:14:17 -05:00
RRFZ 2ac41bf0af Claim R3.12: ipv6-no-next-header 2026-11-16 23:14:13 -05:00
BFlat 961078950d Merge pull request #2000 from Plastic-time/bugfix/r3.12-zip-legacy-zstd
A ZIP member using the original Zstandard method number, 20, was listed with an unknown method and could not be extracted or found in firmware scans. It now goes through the same name, bounded decoder and archive discovery as the current number, 93.
2026-11-17 11:10:12 +07:00
BFlat 67c70dfb14 Merge pull request #1998 from Plastic-time/bugfix/r3.12-sqlite-key-collations
In a WITHOUT ROWID table whose primary key names one column twice with different collations, SQLite stores a key slot for each. The reader collapsed them into one and so read the next column from the wrong slot. A repeated key term is now dropped only when its column and effective collation are already present.
2026-11-17 11:06:27 +07:00
RRFZ ecb83e9350 Honor the exact HTML module script keyword (R3.12) 2026-11-16 22:49:33 -05:00