Commit Graph
583 Commits
Author SHA1 Message Date
BFlat e3af36f2f3 Merge pull request #2040 from AlexJoaquimPereira/bugfix/r3.13-remaining-page-dialogs
Finishes #2037 for the last four page tools: bundle analysis, page watch, WebMCP tool discovery and the screenshot. They now answer a page's own dialogs the same way and list them in their results and summaries. The answering connect enables the Page domain itself, so each caller no longer has to.
2026-11-18 01:14:24 +07:00
AlexJoaquimPereira 2928307c8a Answer a page's dialogs in the remaining inspection tools (R3.13)
The four page tools that still attached without answering a page dialog (web_page_js_analyze, web_page_watch, web_mcp_tools_list and web_page_screenshot_take) could wait to their deadline when a page opened an alert or confirm. The shared answering connect now enables Page, which is what delivers Page.javascriptDialogOpening, and all four use it; their results and summaries list the dialogs. The bundle-analysis and screenshot results now carry the dialogs capture_page already collects, and WebMCP discovery drains its events after the probe.

Regressions: a fake CDP server opens a confirm on Page.enable and records Page.handleJavaScriptDialog; all four tools answer and report it. The existing seven dialog tests and the full browser module pass.
2026-11-17 23:03:54 +05:30
AlexJoaquimPereira 746ee700bf Keep a game-files look with the folder or archive it was for (R3.9)
A look at one game's folder or archive could land after the person picked another one, so the old profile, archive list or file rows were shown under the new pick, and a save could name an item from the old game. The button job now carries its request, and game_files::tool_done ignores an Ok or Err result whose path no longer matches the shown folder (game_archives_list/core_target_triage) or archive (game_pak_list/game_unity_list/game_iostore_list/game_unity_bundle_list). Export toasts still say a file was saved.

Regressions: an old game folder's archive list/profile and an old archive's rows are ignored and leave the new look running; an old folder's error isn't shown, while the shown folder's error is. All three failed before the guard.
2026-11-17 22:35:51 +05:30
AlexJoaquimPereira 68a990fee6 Answer a page's dialogs in the inspection and walkthrough tools (R3.13)
The tools that attach to a page themselves (web_page_show, web_walkthrough_record, the web-runtime coverage/listener/module tools, and the Electron page and walkthrough tools) connected without answering a page-opened alert or confirm, so the page's scripts stopped and the call waited to its deadline. They now answer dialogs as web_site_open does (alerts and leave-page questions accepted, confirm and prompt dismissed), enable the Page domain that delivers the event, and report each dialog's kind, first line and answer in the result and summary. Declared secrets in a dialog message are redacted. The shared dialog extraction moved to web_common so the website open and these tools use one reporter.

Regressions: a fake CDP server opens a confirm only after Page.enable and records Page.handleJavaScriptDialog; web_page_show, web_walkthrough_record, web_coverage_measure, web_listeners_list and web_modules_trace answer and report it. A unit test covers extraction, summary, empty/null and redaction.
2026-11-17 21:51:45 +05:30
AlexJoaquimPereira 55ff4a1ee6 Refuse a project file over 16 MB in the builder's edit tool (R2.9)
A builder's edit read the whole project file into memory before replacing text, so a large generated file under app/ could freeze or kill the app. It now uses the same 16 MiB cap as a read, refusing a larger file before it is loaded and leaving it unchanged. A file at the cap still edits when the result fits the 8 MB write cap.

Regressions: an edit over the cap returns OverLimit and leaves the file unchanged; it failed before the fix with the write cap's BadInput after the whole file was read. A file exactly at the cap still edits down to the write cap.
2026-11-17 21:12:23 +05:30
Justin John db8b9777e2 Run Vineflower and JADX on the Java folder set for Ghidra (R5.7) (#2023)
A Java folder set for Ghidra in Settings → Engines was used only to run Ghidra, so with no system Java, Vineflower said Java wasn't installed and JADX could not start. The Java runtime lookup now returns that folder's bin/java when no path is set for Java itself, so Vineflower, JADX, the engine list and doctor all find it. A path set for Java itself still wins, and a folder with no bin/java is ignored.
2026-11-17 17:05:37 +07:00
BFlat 4402d170f9 Merge pull request #2015 from Plastic-time/bugfix/r3.12-html-legacy-script-language
A script tag with language="VBScript" and no type was listed as JavaScript. When type is absent a browser uses the legacy language value to pick the script's type, so a language that is not a JavaScript one is no longer listed. An explicit type still decides, even an empty one.
2026-11-17 12:05:54 +07:00
BFlat 1b0f5025fb Merge pull request #2011 from htcom-code/bugfix/r3.13-js-dialog-blocks-open
A page that opens an alert while loading waits for someone to close it, and nothing did, so opening the site always ran into its deadline and a rebuild could not study it (#2010). The session's page client now answers dialogs as they open: an alert or a leave-page question is accepted so the page can go on, and a confirm or prompt is dismissed so nothing is agreed to for the person. The result lists the dialogs the page opened and how each was answered.
2026-11-17 12:05:33 +07:00
BFlat 854f50e129 Merge pull request #2014 from Plastic-time/bugfix/r3.12-sqlite-parenthesized-primary-key
SQLite accepts a primary key written as PRIMARY KEY((a), b) in a WITHOUT ROWID table. The reader stopped at the first closing parenthesis and could not work out the stored row layout. It now reads to the matching end of the key list, finds the column inside redundant parentheses and uses its outermost collation.
2026-11-17 12:02:46 +07:00
BFlat ecaa1027e6 Merge pull request #2005 from Plastic-time/bugfix/r3.12-dos-extended-pe-signature
The DOS header report took any "PE" prefix at the extended-header offset for a Windows extension, including a cut-off signature or "PENA" in unrelated bytes. The full four-byte signature is now required. A complete signature that overlaps the DOS header, as hand-packed small executables have, is still reported.
2026-11-17 12:02:08 +07:00
BFlat cf749a926d Merge pull request #2009 from Plastic-time/bugfix/r3.12-java-truncated-attributes
A Java class file that ended partway through a class-level attribute was read with no warning, so source or signature details after the cut were silently missing. The reader now keeps the attributes it could read and warns when the table ends early.
2026-11-17 11:48:08 +07:00
BFlat e32b09b910 Merge pull request #2007 from Plastic-time/bugfix/r3.12-tar-pax-size-precedence
A TAR member with a valid PAX size still stopped the archive walk when its superseded size field held invalid octal, so later members vanished from the listing. The PAX size is now read first for ordinary members, and the old field is read and checked only when no override applies.
2026-11-17 11:46:35 +07:00
RRFZ 6163368bea Keep PE signatures that overlap the DOS header 2026-11-16 23:46:20 -05:00
BFlat 11fad9bb2e Merge pull request #2004 from Plastic-time/bugfix/r3.12-ipv6-no-next-header
An IPv6 packet whose Next Header is 59 (no next header) got an invented "other" transport record that included any bytes after the header. Transport decoding now stops at 59, also when an extension header supplies it; other protocol values are decoded as before.
2026-11-17 11:45:41 +07:00
htjulia 34a0b11df1 Answer a page's JavaScript dialogs so web_site_open doesn't time out (R3.13)
A page that opened an alert while loading waited for someone to close
it, and nothing did, so the open always ran into its deadline. Alerts
and beforeunload are accepted so the page can go on; confirm and
prompt are dismissed so nothing is agreed to for the person. The
result says which dialogs the page opened and how each was answered.

Fixes #2010

Co-Authored-By: htjulia <htjulia1@gmail.com>
2026-11-17 13:44:48 +09:00
BFlat 75b078888b Merge pull request #2006 from Plastic-time/bugfix/r3.12-indexed-map-source-inventory
An indexed source map that also carried a top-level `sources` list reported those names as part of the bundle although no section maps to them, and they could push a real source out of a full inventory. An indexed map now keeps only its file name and takes its sources from its sections.
2026-11-17 11:42:21 +07:00
RRFZ b259436c53 Honor legacy HTML script language when type is absent (R3.12) 2026-11-16 23:35:26 -05:00
RRFZ d2953f60dd Read parenthesized SQLite primary-key columns (R3.12) 2026-11-16 23:34:23 -05:00
BFlat b87fce648a Merge pull request #2001 from Plastic-time/bugfix/r3.12-macho-complete-command-paths
The Mach-O readers took the whole remainder of a load command as a library name or runpath when its path had no terminating NUL, so a command that never finished its string still supplied dependency evidence. The NUL must now be inside the command, in both summary views.
2026-11-17 11:28:14 +07:00
RRFZ d29465c20b Use PAX sizes before reading TAR member size fields (R3.12) 2026-11-16 23:21:43 -05:00
RRFZ 420552ff74 Report truncated Java class attribute tables (R3.12) 2026-11-16 23:19:02 -05:00
RRFZ 0b1a643944 List sources from the section maps of an indexed source map (R3.12) 2026-11-16 23:18:59 -05:00
RRFZ 7343ab0f40 Require the complete PE signature in DOS header reports (R3.12) 2026-11-16 23:18:58 -05:00
RRFZ 3836b5bd52 Stop IPv6 packet decoding at No Next Header (R3.12) 2026-11-16 23:18:57 -05:00
BFlat 6f07bad8c4 Merge pull request #2003 from Plastic-time/bugfix/r3.12-html-exact-module-keyword
A script whose type was the module keyword with spaces around it was listed as a classic script, and a whitespace-only type was listed too, although browsers run neither. The keyword and the empty attribute are now matched exactly, before the whitespace trimming that classic script types get. Checked in a Chromium 156 page: padded and tab-prefixed module types and a whitespace-only type did not run.
2026-11-17 11:16:02 +07:00
BFlat 2708ee35c8 Merge pull request #2002 from Plastic-time/bugfix/r3.13-html-meta-csp-list
A page with two meta Content-Security-Policy declarations reported only the last one, and an empty later declaration could hide an earlier policy. Every non-empty policy is now kept, in document order, joined with a comma as a policy list is written.
2026-11-17 11:15:32 +07:00
BFlat 961078950d Merge pull request #2000 from Plastic-time/bugfix/r3.12-zip-legacy-zstd
A ZIP member using the original Zstandard method number, 20, was listed with an unknown method and could not be extracted or found in firmware scans. It now goes through the same name, bounded decoder and archive discovery as the current number, 93.
2026-11-17 11:10:12 +07:00
BFlat 67c70dfb14 Merge pull request #1998 from Plastic-time/bugfix/r3.12-sqlite-key-collations
In a WITHOUT ROWID table whose primary key names one column twice with different collations, SQLite stores a key slot for each. The reader collapsed them into one and so read the next column from the wrong slot. A repeated key term is now dropped only when its column and effective collation are already present.
2026-11-17 11:06:27 +07:00
RRFZ ecb83e9350 Honor the exact HTML module script keyword (R3.12) 2026-11-16 22:49:33 -05:00
RRFZ 8b6a701b16 Keep all declared HTML meta security policies (R3.13) 2026-11-16 22:49:32 -05:00
RRFZ 0586649778 Require terminated paths in Mach-O load commands (R3.12) 2026-11-16 22:49:31 -05:00
RRFZ 29badae7c9 Read the legacy Zstandard method in ZIP archives (R3.12) 2026-11-16 22:49:29 -05:00
RRFZ da974744c0 Keep distinct primary-key collations in SQLite row layouts (R3.12) 2026-11-16 22:49:27 -05:00
BFlat 5acce07c67 Merge pull request #1994 from Plastic-time/bugfix/r3.12-android-provider-sdk-default
An Android manifest with a minimum SDK of 23 and no target SDK reported a provider as exported by default. Android takes the minimum SDK as the target when none is given, and from 17 a provider is private by default. Export inference now uses the minimum SDK when the target is omitted; explicit targets and explicit exported values are unchanged.
2026-11-17 10:44:47 +07:00
BFlat 891d07819a Merge pull request #1996 from Plastic-time/bugfix/r3.13-har-request-mime
Recording a form POST that returned JSON wrote the response's type, application/json, as the request body's type too. The request body now takes its type from the request's own Content-Type header, and is left empty when that value was not captured.
2026-11-17 10:33:39 +07:00
BFlat a3fc0056d3 Merge pull request #1992 from Plastic-time/bugfix/r3.12-dynamic-import-options
On the lexer fallback, `import("./data.json", { with: { type: "json" } })` lost its dependency, because only a closing parenthesis was accepted after the path. A comma after a dynamic import's literal path is now accepted, and a method called `import` on an object is no longer taken for one.
2026-11-17 10:32:27 +07:00
BFlat dd1efd2923 Merge pull request #1995 from Plastic-time/bugfix/r3.12-android-sdk-m-permissions
A permission declared with the older `uses-permission-sdk-m` tag was left out of the manifest's permission list. Android treats that tag like `uses-permission-sdk-23`, and so does the reader now.
2026-11-17 10:30:27 +07:00
RRFZ 5a574f623b Read typed SDK integers when inferring Android exports 2026-11-16 22:22:10 -05:00
RRFZ 7ad785b788 Keep the request content type in recorded HAR bodies (R3.13) 2026-11-16 22:07:09 -05:00
RRFZ a45c0a5677 Include legacy SDK-M permissions in Android manifest inventories (R3.12) 2026-11-16 22:07:08 -05:00
RRFZ 3cd2a2dd1c Use the minimum SDK for omitted Android target defaults (R3.12) 2026-11-16 22:07:06 -05:00
RRFZ 358b15abc6 Keep dynamic import specifiers with options in lexer fallback (R3.12) 2026-11-16 22:07:01 -05:00
RRFZ 4d132b7b0a Ignore incomplete start tags in HTML page inventories (R3.13) 2026-11-16 22:07:00 -05:00
BFlat 2b36d3a97e Merge pull request #1983 from Plastic-time/bugfix/r3.12-sourcemap-block-boundaries
An unfinished `/*# sourceMappingURL=` comment overrode an earlier complete one, and a line with two `*/` could return a URL containing text outside the comment. A closing delimiter is now required and the first one ends the comment; the legacy `@` marker is accepted in a complete block as in line comments.
2026-11-17 08:35:31 +07:00
BFlat aba7ad0a1e Merge pull request #1984 from Plastic-time/bugfix/r3.12-cpio-symlink-crc
GNU cpio's crc format stores a symbolic link's target as the member body and leaves its checksum field at zero. The reader summed the target and warned that the link was damaged. A zero checksum on a symlink is now taken as omitted; a non-zero one, and every regular file's, is still checked.
2026-11-17 08:24:48 +07:00
BFlat cd4ecad585 Merge pull request #1982 from Plastic-time/bugfix/r3.12-graphql-string-line-breaks
The operation reader accepted a raw CR inside a regular quoted GraphQL string, and a raw line break after a backslash, both invalid GraphQL. Both line terminators are now checked before an escape is processed; block strings keep their multi-line grammar.
2026-11-17 08:23:59 +07:00
BFlat 105c95dcd1 Merge pull request #1981 from Plastic-time/bugfix/r3.12-tcp-ecn-flags
A TCP SYN with flag byte 0xc2 was reported as SYN only. The ECE and CWR bits are now named with the other flags; existing flag strings keep their order.
2026-11-17 08:23:52 +07:00
BFlat 3f45a9b1c3 Merge pull request #1980 from Plastic-time/bugfix/r3.13-html-bogus-comments
The HTML scanner reported a script found inside `<!unknown ...>` or a malformed end tag, text that browsers treat as a comment up to the first `>`. That text is now skipped before the next tag is looked for.
2026-11-17 08:23:45 +07:00
BFlat 72dfda7653 Merge pull request #1979 from Plastic-time/bugfix/r3.12-wasm-component-layout
A valid WebAssembly component showed an empty layout, because the inspector stopped once it had identified the component header. The outer section framing is now read and listed, embedded modules and components are left to the existing validator, and a cut-short section keeps the layout read so far.
2026-11-17 08:23:38 +07:00
RRFZ 07dfa1a52b Keep source map annotations before trailing comments 2026-11-16 20:12:13 -05:00