A dimension that belongs to one component's own drawing is a documented
constant in that component's file; layout sizes stay semantic tokens, and
no size-preset token exists for one component (craft-framework.md 5.4).
- Spec: 5.4 rule 3 reworded; Appendix A, 4.6 (the component-token rung
goes, no such tokens exist), 8.3, porting.md and the theme README agree.
- design-lint: literal-size/* treats a module- or impl-level const with a
doc comment as a named value: a name that resolves to it is not flagged,
and its initializer is its definition. Fn-local and undocumented consts
and call-site literals stay flagged. Nine markers that only covered such
consts are removed.
- Ruler ticks: size.ruler.tick.* leaves the size presets; kit.rs draws
TICK_MID = 6 and TICK_MINOR = 3 points in every density, as the old
library and the apps' rulers do. Comfortable ticks go back to 6 / 3
(from 9 / 4.5); Compact is unchanged.
- size.scroll_fade becomes FADE_LENGTH in scroll_bar.rs, size.notice.width
CARD_WIDTH in notice.rs, and size.story.* multiples of size.control.md
in testing/stage.rs (15, 10 and 30 control heights: today's values in
both densities). pointer_tip, checker, thumb.sample.*, the card gaps and
icon.glyph_md stay tokens: each has more than one user.
next's WordCraft port and the framework work under it (243d68e12d) take the memoized-view APIs where they meet the
branch: story values bind through StoryData::bind, value_at and pair_at (next's copy-out stories included; one held
form story still binds a copy, as its held answer is a note beside the value); next's env values (GroupLevel,
ControlPlace, RibbonLook, ScreenModeSet), IconMark and PageBandRoom derive MemoProps, and the shell entry keys the page
band's room; request_own_repaint calls become request_repaint. The collection extent next reworked (motion-owned
style context, FillHeight, ideal width by item count) moves into items_extent. The header's hosted cells join the
parts' roving group from the pass's own membership (parts_group over Cx::join_roving), as the parts' stops do. A
content-sized shell slot measures its content with the app running in it every pass. The gallery card hands the
story's output from its view's real run (StoryRun).
Memoized views stay the one change mechanism: next's settling-path additions (modifier reads as bind keys, given-edit
and keymap unsettling, settle counters) give way to the tracked inputs that cover them, and request_own_repaint calls
become request_repaint. next's command board, node facts after the node check, the guide drag out of a ruler and the
CommandStates input are taken; the trials next wrote on Lazy::settles run on memoized views. The ruler guide env value
keys a view under the canvas in every pass of a drag. The replay audit's run in the gate takes next's target selection.
Lazy::settles, Lazy::content, Key::Version, the input and unsettle rules
(Changes::input_through, unsettled_through, scan) and lazy::unsettle with its
callers are removed. frame::request_repaint marks the record of the view it
is asked in and reruns only that view; asked outside every view, every view
replays. request_own_repaint goes; ui-canvas calls request_repaint. Pages
measures each hidden page once per pass. The tests that used the old API are
memoized views, with trials for repaints in and outside views and for
given-value edits. API map rows and the framework doc describe memoized
views.
MenuHelp had two constructors, one over a list the caller built every
frame and one over a function the bar calls only while the Help menu is
open. Only the second keeps closed menus from paying for the list, so it
is the one constructor: MenuHelp::new takes the function.
ToolHost::inject hands each ToolInput to the window host's injected lane of the
canvas's viewport, one step per pass: presses, moves and releases as egui
pointer events (InjectedPointer), carrying the pen's reading, which the step's
pass reads in place of the tablet's; Hold/LetGo as steps with no event that the
lane holds (WindowHost::inject_hold, inject_let_go, injected_holds). The tool
reads its input from the canvas's press and the pass pointer as for a hand's,
so the Color HUD, hover and egui's button state see injected moves.
Held keys end where the lane drops input (withdrawal, focus loss, cancel, end
of the session). A held key's momentary command applies to the whole pass, as
the real key's does.
Removed: HostState.queued and injected_held, WindowHost::inject_pass and its
trial, the injected gesture path in the host (Active.injected, Run::injected,
pick_momentary), Momentary::press, ToolInput.clicks.
Trials: the injection trials run until injected_idle; new trials for a held
Space ended by a cancel, an injected pen reading, and the Color HUD picking at
an injected move.
- tools-w11: written from its sheet
- tools-w11: repair 1
- Integration: gradient overlay builds its non_exhaustive StopColor with StopColor::new
- tools-w11: review fixes (review-1)
- dialogs-w8: written by an agent
- dialogs-w8: the gradient map builds craft-color's non-exhaustive stops and rules through their constructors (combine)
- dialogs-w8: review fixes (review-1)
- dialogs-w15: written from its sheet
- dialogs-w15: repair 1
- dialogs-w15: trials build the non-exhaustive SaveForWebOptions from its default (combine)
- Integration: craft-color's re-export and panels trials take SwatchTable from craft_ui::choice (panels-w7 and panels-w6 requests, done here so the area compiles)
- dialogs-w15: review fixes (review-1)
- dialogs-w15: review fixes (item 3)
- dialogs-w15: the palette trial selects the Optimized pane, whose palette the Color Table shows (dialogs run round)
- dialogs-w10: written by an agent
- dialogs-w10: fill issues resolve their label through the env's view (combine)
- dialogs-w10: review fixes (review-1)
- dialogs-w10: review fixes (review-1): Props import
- dialogs-w10: liquify's command loop borrows the view per call, so the Preview command can toggle through set_preview (combine)
- dialogs-w4: written by an agent
- dialogs-w4: finished by an agent
- dialogs-w4: drop the PLAN note on TextWords' export (combine)
- dialogs-w4: review fixes (review-1)
- dialogs-w4: the About tab strip takes its tabs' height in the stack header (dialogs run round)
- dialogs-w4: Integration: the dialog host ends the shown life of a dialog it removes (dialogs run round)
- dialogs-w4: ui.dialog.cancel on a prompt with Cancel answers that Cancel in the typed-dialogs trial, as dl.N2 rules (top run round)
- canvas-widgets-w3: partly written (run interrupted)
- canvas-widgets-w3: partly written (run interrupted)
- canvas-widgets-w3: partly written (run interrupted)
- canvas-widgets-w3: written by an agent
- canvas-widgets-w3: review fixes (review-1)
- Integration: canvas trials keep canvas-widgets-w10's split module
- canvas-widgets-w3: the drag's snap reads the press bounds alone, so the release can take the gesture (combine)
- canvas-widgets-w3: the ruled guides trial shows its canvas in a room that holds the bounds, so its releases land on the canvas (fwcw round 3)
- canvas-widgets-w3: review fixes (review-tl-1)
202 upstream commits since 6cb00467a. Resolutions:
- craft-window, craft-platform: ours. Upstream's frame policy v2, restore
store and GNOME light/wait_first are the versions carried on 28 Oct;
ours moved place() to craft-behavior and kept LayoutWatch and the
appearance/portal.rs split.
- craft-timeline: ours. craft-time (crates/time) lands as upstream wrote
it and is not yet used by craft-timeline.
- Old crates/ui modules stay removed. Upstream's frosted backdrops, shape
gallery, dialog tabs and the iconic flyout top-edge rendering are not
carried. The #1094 model half is in craft-behavior's dock:
Group::flyout_offset and Action::MoveFlyoutTop.
- craft-update: #586 Save and Update, the install probe on the check
thread and quiet per-user MSI self-updates, carried into updater.rs,
stack_dialogs.rs, install/windows.rs and self_update/helper.rs.
- craft-jpeg: progressive Huffman decoding, carried into huffman.rs,
parse.rs and scan.rs.
- craft-print: the driver settings dialog's new tests and the bounded
XML parse's tests, as trials.
- Test-only conflicts: upstream tests from before the base that our side
cut stay cut; tests new upstream are kept.
Frames::frame_in_viewport runs a full frame of a child window, events and recorded output included, through the
fixture's one frame runner, so a trial can see what a child window's pass sends out. A painted pointer in a child
window sends no image and is painted.
The registry keeps the dialog's part and the host's part apart: the
host's gestures join the reach only while a modal body keeps the same
canvas, whatever order the two are made in, so a modal that keeps
nothing (an alert) leaves the canvas blocked. Trials: the host's gesture
lapses when the dialog stops keeping the canvas; under a dialog that
keeps nothing it passes no press and no wheel.
Also: the BlockingOverlay story's drive opens it; rows.rs doc wrapped;
api-map TonePickerRow note names pass_canvas_gesture.