mirror of
https://github.com/storytold/egui.git
synced 2026-11-21 01:52:58 +01:00
* Related: #5233, upstream https://github.com/linebender/parley/issues/644 * [ ] I have followed the instructions in the PR template On Windows with a non-Chinese locale, fontique's Han fallback is a single Japanese font (Yu Gothic UI), which lacks many Simplified Chinese characters like 这 and 还. These rendered as tofu even with Microsoft YaHei installed. The example text from the added demo without the fix fails to show some glyphs: <img width="582" height="146" alt="image" src="https://github.com/user-attachments/assets/1f37a778-6d67-431f-9aad-c7bd23e0e360" /> `SystemFontProvider` now tries the other Han locales (Simplified/Traditional Chinese, Japanese, Korean) when the font for the preferred locale can't render a char. Simplified Chinese is looked up as `zh-SG` instead of `zh-CN`: fontique treats `zh-CN` as the default Han locale and caches the result of the locale-less Han lookup (which every `Query::set_fallbacks` makes) as that default. So `zh-CN` lookups often returned the Japanese font, depending on which scripts were looked up first. A TODO points at linebender/parley#689, which should make this workaround unnecessary. Also adds a collapsed "System font fallback" section to the Misc Demos window to check the fallback by eye. ## Testing Verified on Windows 11 (de-DE): all samples in Misc Demos → System font fallback render, and `cargo test -p egui_system_fonts -- --include-ignored` passes. **Still needs testing on macOS and Linux**: open Misc Demos → System font fallback in `egui_demo_app` and run the ignored tests above. Both platforms also pick a single fallback font per script in fontique, so they could have the same problem in milder form, e.g. a Japanese-locale Mac, or a Linux system with only a Japanese CJK font. The Misc Demos snapshot was updated on Windows; if CI disagrees, `./scripts/update_snapshots_from_ci.sh` should fix it. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>