From 98ba4e989abd02479f46d69cd6ec7b0601101b7c Mon Sep 17 00:00:00 2001 From: FredApps Date: Thu, 19 Nov 2026 00:55:56 +0100 Subject: [PATCH] xlsx: clear the two clippy errors the ODS cutover left on main SheetNames::insert lost its only caller when the ODS reader moved to craft-ods, and craft_ods::Value::Text already holds an Arc. --- crates/xlsx/src/ods.rs | 2 +- crates/xlsx/src/read.rs | 5 ----- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/crates/xlsx/src/ods.rs b/crates/xlsx/src/ods.rs index e208bc6ce..cd7254110 100644 --- a/crates/xlsx/src/ods.rs +++ b/crates/xlsx/src/ods.rs @@ -103,7 +103,7 @@ fn map_value(v: craft_ods::Value) -> Value { match v { craft_ods::Value::Empty => Value::Empty, craft_ods::Value::Number(n) => Value::Number(n), - craft_ods::Value::Text(s) => Value::Text(Arc::from(s)), + craft_ods::Value::Text(s) => Value::Text(s), craft_ods::Value::Bool(b) => Value::Bool(b), craft_ods::Value::Error(e) => Value::Error(map_cell_error(e)), } diff --git a/crates/xlsx/src/read.rs b/crates/xlsx/src/read.rs index 7c01cb421..6b7d1faf3 100644 --- a/crates/xlsx/src/read.rs +++ b/crates/xlsx/src/read.rs @@ -65,11 +65,6 @@ pub(crate) struct SheetNames { } impl SheetNames { - /// Records `name` as taken. - pub(crate) fn insert(&mut self, name: &str) { - self.taken.insert(name.to_ascii_lowercase()); - } - /// A valid name for the `i`-th sheet based on `name`, not yet taken; it is recorded as taken. pub(crate) fn unique(&mut self, name: &str, i: usize) -> String { let mut base: String = name.chars().filter(|c| !matches!(c, ':' | '\\' | '/' | '?' | '*' | '[' | ']')).take(31).collect();