mirror of
https://github.com/storytold/gridcraft.git
synced 2026-11-19 08:51:13 +01:00
* Find and Replace: Undo and Redo reach the sheet while the dialog is open Ctrl+Z after Replace All did nothing until the dialog was closed: the open dialog kept the keyboard from the grid. The dialog now undoes and redoes the workbook itself unless a text box has focus (there the shortcuts edit the typed text). * Find and Replace: Undo and Redo use the sheet's shortcut table The dialog passed hard-coded keys to edit.undo and edit.redo. It now hands Cmd/Ctrl+Z, Cmd/Ctrl+Shift+Z and Cmd/Ctrl+Y to ribbon::shortcut, the table the grid uses, so the dialog and the sheet keep the same bindings. The test also covers the Mac Redo shortcut (Cmd+Shift+Z). * fix(find): allow workbook undo when a dialog button has focus Reserve Undo/Redo for text editing only while a text edit has focus. The regression reproduces the failure with keyboard focus on Replace All, checks both Redo shortcuts, and verifies text-field Undo leaves the sheet unchanged. Regression failed before the fix and passes now. Validation: 1143 UI integration tests pass; only existing missing-glyph failures U+1E9E and U+1EBB remain. WASM, assets, layers and generators pass. Full CI reaches the unchanged Windows CLI clippy::only_used_in_recursion failure in apps/gridcraft-cli/src/check.rs. * fix(find): block workbook shortcuts behind a modal message Check app.message before dispatching workbook Undo/Redo. Regression uses an empty Replace All search to open the real error, covers all three shortcuts, and checks Redo after dismissal. Extend text-focus coverage to type and undo actual text. Modal regression fails before the guard and passes after it. Validation: 1144 integration tests pass; two existing missing-glyph failures remain. WASM, assets and layers pass. Full CI still stops at the unchanged Windows CLI clippy::only_used_in_recursion warning. --------- Co-authored-by: Maciej Malinowski <231036771+webglobecontact-ui@users.noreply.github.com>