From 03c262d1eb388e1062a6fe18d07e301ead5a0de2 Mon Sep 17 00:00:00 2001 From: Behdad Esfahbod Date: Mon, 6 Apr 2026 17:13:58 -0600 Subject: [PATCH] [raster] Clamp reflected gradient LUT coordinates Malformed reflected gradients can produce very large finite gradient parameters. The raster backend normalized reflect mode by casting floorf(t) to int, which can overflow and drive LUT lookups past the fixed-size stack buffer. Fold reflected coordinates with fmodf(), clamp LUT inputs defensively, and add the minimized oss-fuzz raster testcase to the corpus. Fixes: https://oss-fuzz.com/testcase-detail/6597066439852032 Tested: meson test -C build Co-Authored-By: OpenAI Codex --- src/hb-raster-paint.cc | 21 +++++++++++------- ...inimized-hb-raster-fuzzer-6597066439852032 | Bin 0 -> 4268 bytes 2 files changed, 13 insertions(+), 8 deletions(-) create mode 100644 test/fuzzing/fonts/clusterfuzz-testcase-minimized-hb-raster-fuzzer-6597066439852032 diff --git a/src/hb-raster-paint.cc b/src/hb-raster-paint.cc index 4fe27dff9..503774294 100644 --- a/src/hb-raster-paint.cc +++ b/src/hb-raster-paint.cc @@ -954,6 +954,13 @@ normalize_color_line (hb_color_stop_t *stops, *omax = mx; } +static HB_ALWAYS_INLINE float +reflect_gradient_t (float t) +{ + t = fmodf (fabsf (t), 2.f); + return t > 1.f ? 2.f - t : t; +} + /* Evaluate color at normalized position t, interpolating in premultiplied space. */ static uint32_t evaluate_color_line (const hb_color_stop_t *stops, unsigned len, float t, @@ -977,10 +984,7 @@ evaluate_color_line (const hb_color_stop_t *stops, unsigned len, float t, } else /* REFLECT */ { - if (t < 0) t = -t; - int period = (int) floorf (t); - float frac = t - (float) period; - t = (period & 1) ? 1.f - frac : frac; + t = reflect_gradient_t (t); } /* Find bounding stops */ @@ -1039,10 +1043,7 @@ normalize_gradient_t (float t, hb_paint_extend_t extend) } /* REFLECT */ - if (t < 0.f) t = -t; - int period = (int) floorf (t); - float frac = t - (float) period; - return (period & 1) ? 1.f - frac : frac; + return reflect_gradient_t (t); } static void @@ -1063,6 +1064,10 @@ lookup_gradient_lut (const uint32_t *lut, hb_paint_extend_t extend) { float u = normalize_gradient_t (t, extend); + if (unlikely (!std::isfinite (u))) + u = 0.f; + else + u = hb_clamp (u, 0.f, 1.f); unsigned idx = (unsigned) (u * (GRADIENT_LUT_SIZE - 1) + 0.5f); return lut[idx]; } diff --git a/test/fuzzing/fonts/clusterfuzz-testcase-minimized-hb-raster-fuzzer-6597066439852032 b/test/fuzzing/fonts/clusterfuzz-testcase-minimized-hb-raster-fuzzer-6597066439852032 new file mode 100644 index 0000000000000000000000000000000000000000..e27bc88a2ee7491fd2b9fc7ca0e5dc23c5344b36 GIT binary patch literal 4268 zcmeHJdr(y86+idxgXOh?vbxJfb})l_D>zyNIh&T*G7E z_ujqB!txT7hbTm225qb9BaWGInzT)(cG@QCG|@3ml1|%kv^H5}iQ97@FlcT5@Q?h} zd*__@M*h46Aa)!; zez$1jv!(I3%B=tiBLKjC>!t5Jm$@|MGC<-otRF0UX=&c|jXU!Jh#ai%tk_##w?Uuq zFSM7A_2!z&@?8dt|1Vg62WdqODpdXQ&DdX#_4Jy()`rAk*%`F=D%K14mN(SFf{j=t z79&%d%lB3;%6KLU>upHEI?H}*=|`o9seFiE9j_wRQ4yf+ev{dP_c^GF`fSf!^R$=`GQ4&>< zPau*9K7xei8O4UO4aIO743UU97h;&iMgbxTTz*3caup`3Zm5|NA5GG6F#m>1K=7VyY=O?>bapYppd` zXH`^HnJO%M>P@*>n<}dh>?yD3`>mSDg^4_JB41V*C%Y6UPaTBrN(;kG%ebgZVQwL= zXnb;=Vq)!_PAn^~%$+Do1RYL<;MAaj6nFxb;I&u{&%F+HgEt7LFk7OcolvD zZ^Q5477?AjzplKZvf7kem0$HkQB;UxmnfvRs%lf-${f`3e7g5c8Hdc2XZOLuGkVEF zc8;ja&Xr`IB=aS?Op?nbxk8dFMJdibZAGY6Was2&=X}Ku8>AiniZ1Bwgj)j(_)Sa( z3KoJM(r_EU0U3}9i{VM!(5IjmuE6_50+CLfAU-Dj&nY)P&MPN9bL2#mVaPO*(a`J69849*%8lJrd-4b+3nBVEw)}AE%o*J*n_hYrRm!`em@cgH=uZ0#XSk}j~sW?fzqK(7(s4>iFPh81o$lSi7XuX1U{Sk1Mkfk0|aZxvD12(gS;3t!hm^_IVGA)AWPxbH~{%Hqy!_R z{2b;OVdZ5|&oUxFihdAMgimND0*E_s7YxLmX-I_py0rxM~2)Q3aj1kt}k&FnCq8@}K>{1JJsYJ4U@G|K0n!`DU0_w(d}iH$HPi3gK_+b1a2LLz2Yj7yKe*oX-c zNaXysk@KrSX@r~+5G@I~WJdHrJSn7yP*l?wBQ>}KzsG+orjsu_;R3t=e zXb=8guhZuUxK*@|qdAK6vmB>y?+6Au1EHk%wVcn#vHpSETGmguc{mm4ar@j9tt_zb zao1a&W}TW3x8bBOG@bK=U=CjrUy@N|V$VBm!~P-vP~c4a`L>{nWiU#2^&Rax=2!8T zmXfVLr2e;cpVq!bt2pJ^(Vl@p z{aA3cbA(ml68+TaUpXDadfMMc`>7Ly11Izt6vWuW&MT$9p?a&^|2+v#F>};{y?K<@YGjU#X=8eXtVSTS7^r!He z4=Yv9-hR&@)!)bZdi88D$Ob4@*-Lk|97ztp7uDM8u%~*xEKPM-wgmQ4E;mEF^>uVz ztGUJL)w*eq*W*z&HXO9?r##A??AoD~p1_Z&ef93vdi}OWg{QTZZlU(=?;fz} zU+!15yITEr8rS0SFkZ^i($nSAJ9_D(fup_v6YvHCY=CR?2iiLV9e5%P%jogA+x`A_ zU%PJLHXHN?o$b1S%g)&;ntp}Rud*v>Wwpy(XRqBEPSK)a#*4wptM@t?htK7togTMa z)!cO0VT)~PZYi`Ct8B%wwoZGuv(wwnVVvgg?Cft5R?K*LuFX;^F+~IB6MVJe+l}|8 zWxQX*D&PaXQFw!t5WF4;zE8AJP87Zz62ud{9&%{1hW3{Szo7 zWSoR#%qZ!gn`KG}lk=y6;nWTchu7ufa2>Wz4GPQrAIWX5U