From 3fb62cdc141d2d30ba0fc4a173dd50e7c1d56466 Mon Sep 17 00:00:00 2001 From: Garret Rieger Date: Mon, 5 Apr 2021 15:48:34 -0700 Subject: [PATCH] [subset] fail on offset overflow in tables that we don't repack. Fixes: https://oss-fuzz.com/testcase-detail/5229304507138048 --- src/hb-subset.cc | 5 ++++- ...-minimized-hb-subset-fuzzer-5229304507138048 | Bin 0 -> 56552 bytes 2 files changed, 4 insertions(+), 1 deletion(-) create mode 100644 test/fuzzing/fonts/clusterfuzz-testcase-minimized-hb-subset-fuzzer-5229304507138048 diff --git a/src/hb-subset.cc b/src/hb-subset.cc index e96146728..d443d248b 100644 --- a/src/hb-subset.cc +++ b/src/hb-subset.cc @@ -73,7 +73,10 @@ _repack (hb_tag_t tag, const hb_serialize_context_t& c) { if (tag != HB_OT_TAG_GPOS && tag != HB_OT_TAG_GSUB) - return c.copy_blob (); + { + // Check for overflow in a non-handled table. + return c.successful () ? c.copy_blob () : nullptr; + } if (!c.offset_overflow ()) return c.copy_blob (); diff --git a/test/fuzzing/fonts/clusterfuzz-testcase-minimized-hb-subset-fuzzer-5229304507138048 b/test/fuzzing/fonts/clusterfuzz-testcase-minimized-hb-subset-fuzzer-5229304507138048 new file mode 100644 index 0000000000000000000000000000000000000000..d04f7d8955a6ce558f16ae95ace30c08e33dff7c GIT binary patch literal 56552 zcmeI!c{G*V-vIFaoa2}s(;>q(osKaw6Yh~ANt7`ai6ccBQjwuD6bDpZt!$jFb0?}bEh z7NHURquF~oyLWSP#3{tai{MR3uqpN~&hAR+(=48$WsV4Cd-pXqt!achCzjyULg1MQ zY2qJVNf%$Zoqt|A)o|{DZ2o(Q6LNE$&ObP~x!>>@3Dx{#24~i@q8tTah@1KqmuaI$qVUf z#zvMTLj!3k8XuJ`MN{N4G_d3`Hd;*L@Et#RUjAx!)}<7O0r0OYPpNN1@Iu%#>s~m2b zR1&TdSB$H(Bn%A{NedLo76iUh@<@V`;u^{ZnsiZ>r1GBFb?0|jOUcXekcEUrg_%3N zFZ+8GT~1V|Q3Xg80jiLo0-YhDAucIMS}H6pAw-d6D61{il~cCeVz2IOrNPU`BTLt! z8M-Y|6p>$~D5@wbCC$&zPa%ZFr7?%gd@g6Jn1hTtI3?K5Pa}d|i=Rz77SjJu32N$# z30wrX7|uh%o3+GGN&4UWCd$b|(vs@Gsfh{6@k=nYO;uGTrG?0xq^gdMt`dz4{y$&G zh_(?Fk6%ap;&sPQI^etFZA|)bUOe<3336jUB<$=yXs}*qx6T|QLhuC7O`$9{I>z$F zjpRz_D;(NX(XMHD4jzM|y}P$2sMsElYmlaVMPOo^s(TUUwYp;Fu9K z8WGJ`f*Nsr4afYPQ;tM%51|r*gm}59+=j=ClfXOVp7NOiA-q2l=hXksIpyp`#2M!l zK#&Q3d?Dc~%oX{O$*`bA@9$p8M$xj3CFw>g! z=|*jXH+jW2yw7xfZd$PamWNSO+2EOC9`oP*5&~Kc{**4g^zgLx(&cypy$rz%seM#as!UAOnyT1+V z-gzs3j|jMG@%3ndS;y0u0Ht_eCF$lfG^*&3rJ33L{>R5P)GwucGfYmgsLQ^8AZ_C# zi|_&W#pWmGQP>TRf?HEEzp*tKu)AKxSe9&FyGG9NKafKMVE~2e7njg z`dat7;$mH|1qEf&$E-reXBR5u2tG49>Z6fjG*+1Hd#W-2A|p_mkpS|Zx-(ke|98oo{TuQ};TlPz-4 z@67eRY1`TR*&}FLdCzRYx#ktBVTVi~6n7I>J}WTfGncJt4gP%h(q&#ATYdjC7b6cb zo4XWI!`QH=s^E{k{h3eJq*zgoP(<$0Wo>(aga&M7&IZ3Sz*hpq>!Zi#04H9qVJzVbOe)!;yDyY~=# z{}-m#u(z@{?duROk^?=Ulx0Oy~KaJ*;?f7C=*C{^> z?z-(*+DZInsdFpZZ^`#%c{UtrS0abksdGEN9Wf6 zcE(<0?)&bW$H%7!_UQ?fP*7RRE*TxtlkLH=xuc5fY#Uq5p0$g8UlNg}-F4(jrSYR4 zYiR|qMU{Uxdika(J9H-RJ3Pv_;x5sDV$^R=>CH^C(^)sUe3Q!Si;T@CkNbGuonb3d z{3=XZXEG@b%f~;sDnGIs{L16Gvz=_9VBcH+@=KjU7j=v5MB2^lFS~3;8ockTs)rwG zNu^)YT$t9pNL0gD&8||^-|FR{eVAL(!Lam0)3T2RY;IQyDvAG~>@Ux(s_>sxf0Uz< zJwwW=f3q_+LyzQme?eNM#fI86x1o+fBJ^a@Zx`ZT+h)trJCzi5D|FaZlA+>_1JAX# zj%A~hJ%@IwI>hH)AmvWvW!T5>qkT%ez17p|@t&xv2xk48<=^@acn{f@h%7$XP`l%n zN&L>`--}eKtsl1rr#frIKMZ-$HJv1QG$1|ccDnzLq~cz&WtS>fbylpmCp-f3--X7U zd?E8dfN%7&Gg7tMf9P%4-+Kz=g63xre%oFXI}n=@ANJT)d4c(xsXy$4H?Clry{D%0 z@JiOzo%72vKli}HGql-&FT`TwgmaC|*$V}x&*b!6x9xqqIzxMGdCQKAVFCIF43ovL z7bRc%Az%A_k9GNrhUTfY)UmJx^46qb4bz9RbCXL~Z(Y7mf6Q(|;AMox((~6P86B2C zw>W+DzVfD2ZMIfnWR{XyVslye)9{!5POmUNK0U}Xc290Vd7X_3 z4-5U#c;x2u0&hy>BkgZ$9x;2$iX$)E7U$e0A?a@*c4T(;#f_8sVrpRtcX#rW;s+A4 znSqCc^|!x%Ueg}FN>{0Vw$*7^G3uhfv~>fsgY@zIYxG+5uOX$TXKp6~Rj$QNHC);< zB)EN;uX}16tEN59GNLJITJqL4c@||?TiNQvDIw7pdvn+3_68M=kE%Jbiw70#%9d?O zZ=r;5rXBu^hLbB{O(D+=$|+HDp-(3q#T+Z1$=Ixb!#O94$?vj|TVl&sg{7W(&yk9-Z** zT7TI0SZV)+XzJ-KR{X>DW}byM*J95|`dRbZKCDesSy0MX#_%j3`fe~}7p2-(mK4Wl z>tsLvZKJ!9b7!9a`<$q=b@Ea!J$>KZH}TI*5St1m>aJeVXdqdwP5fhu*Go*(e}>1~51SRt$D>+U8 literal 0 HcmV?d00001