From 5565d78d4fb9591d0814dbc9ef7bb1c317faff3b Mon Sep 17 00:00:00 2001 From: Behdad Esfahbod Date: Sat, 26 Jul 2025 12:51:18 -0600 Subject: [PATCH 1/3] [ot-font] Fix v-advance if font has no vmtx table Fixes https://github.com/harfbuzz/harfbuzz/issues/5425 --- src/hb-ot-font.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/hb-ot-font.cc b/src/hb-ot-font.cc index e1a0c1d2f..0f19b5561 100644 --- a/src/hb-ot-font.cc +++ b/src/hb-ot-font.cc @@ -516,8 +516,7 @@ hb_ot_get_glyph_v_advances (hb_font_t* font, void* font_data, { hb_font_extents_t font_extents; font->get_h_extents_with_fallback (&font_extents); - hb_position_t advance = font_extents.ascender - font_extents.descender; - advance = font->em_scale_y (- (int) advance); + hb_position_t advance = font_extents.descender - font_extents.ascender; for (unsigned int i = 0; i < count; i++) { *first_advance = advance; From 3416fd28a2ea389f4fcd631fca225262882af43b Mon Sep 17 00:00:00 2001 From: Behdad Esfahbod Date: Sat, 26 Jul 2025 12:56:16 -0600 Subject: [PATCH 2/3] [tests/vertical] Add test for previous commit --- test/shape/data/in-house/tests/vertical.tests | 1 + 1 file changed, 1 insertion(+) diff --git a/test/shape/data/in-house/tests/vertical.tests b/test/shape/data/in-house/tests/vertical.tests index 8b0030d7a..7dd50d503 100644 --- a/test/shape/data/in-house/tests/vertical.tests +++ b/test/shape/data/in-house/tests/vertical.tests @@ -17,6 +17,7 @@ # glyf, no vmtx ../fonts/191826b9643e3f124d865d617ae609db6a2ce203.ttf;--direction=t;U+300C;[uni300C.vert=0@-512,-578+0,-1024] ../fonts/f9b1dd4dcb515e757789a22cb4241107746fd3d0.ttf;--direction=t;U+0041,U+0042;[gid1=0@-654,-2128+0,-2789|gid2=1@-665,-2125+0,-2789] +../fonts/NotoSans-VF.abc.ttf;--direction=t --font-size=2000;U+0062,U+0063;[gid2=0@-615,-2112+0,-2724|gid3=1@-480,-1898+0,-2724] # glyf+gvar, no vmtx ../fonts/NotoSans-VF.abc.ttf;--direction=t;U+0061,U+0062;[gid1=0@-280,-948+0,-1362|gid2=1@-307,-1056+0,-1362] ../fonts/NotoSans-VF.abc.ttf;--direction=t --variations wght=700;U+0061,U+0062;[gid1=0@-302,-954+0,-1362|gid2=1@-316,-1056+0,-1362] From c3fcbffa651cea70400552f2a8bd695ad11023c1 Mon Sep 17 00:00:00 2001 From: Behdad Esfahbod Date: Sat, 26 Jul 2025 14:00:32 -0600 Subject: [PATCH 3/3] 11.3.3 --- NEWS | 5 +++++ meson.build | 2 +- src/hb-version.h | 4 ++-- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/NEWS b/NEWS index a559673f9..60094b256 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,8 @@ +Overview of changes leading to 11.3.3 +Sunday, July 26, 2025 +==================================== +- Fix but in vertical shaping of fonts without the vmtx table. + Overview of changes leading to 11.3.2 Sunday, July 20, 2025 ==================================== diff --git a/meson.build b/meson.build index ba1536dde..18c8a5877 100644 --- a/meson.build +++ b/meson.build @@ -1,6 +1,6 @@ project('harfbuzz', ['c', 'cpp'], meson_version: '>= 0.60.0', - version: '11.3.2', + version: '11.3.3', default_options: [ 'cpp_eh=none', # Just to support msvc, we are passing -fno-exceptions also anyway # 'cpp_rtti=false', # Do NOT enable, wraps inherit it and ICU needs RTTI diff --git a/src/hb-version.h b/src/hb-version.h index ce9ce4a64..aaf0b01d4 100644 --- a/src/hb-version.h +++ b/src/hb-version.h @@ -53,14 +53,14 @@ HB_BEGIN_DECLS * * The micro component of the library version available at compile-time. */ -#define HB_VERSION_MICRO 2 +#define HB_VERSION_MICRO 3 /** * HB_VERSION_STRING: * * A string literal containing the library version available at compile-time. */ -#define HB_VERSION_STRING "11.3.2" +#define HB_VERSION_STRING "11.3.3" /** * HB_VERSION_ATLEAST: