From 82cba446444c982229ed41f0a6f4bf44d8e234e2 Mon Sep 17 00:00:00 2001 From: Behdad Esfahbod Date: Fri, 17 Apr 2026 16:15:46 -0600 Subject: [PATCH 1/4] [gpu] Fix out-of-bounds read in emit_all_clip_sub_blobs When clip nesting exceeds HB_GPU_PAINT_MAX_CLIP_DEPTH (3), push_clip_glyph sets unsupported=true but still increments clip_depth. emit_all_clip_sub_blobs then iterated clip_depth without capping, reading past the fixed-size clip_stack array. Cap the iteration at HB_GPU_PAINT_MAX_CLIP_DEPTH. Fixes: https://oss-fuzz.com/testcase-detail/6573156621156352 Assisted-by: Claude Opus 4.6 (1M context) --- src/hb-gpu-paint.cc | 2 +- ...case-minimized-hb-gpu-fuzzer-6573156621156352 | Bin 0 -> 3892 bytes 2 files changed, 1 insertion(+), 1 deletion(-) create mode 100644 test/fuzzing/fonts/clusterfuzz-testcase-minimized-hb-gpu-fuzzer-6573156621156352 diff --git a/src/hb-gpu-paint.cc b/src/hb-gpu-paint.cc index 76050cf74..f83bad85c 100644 --- a/src/hb-gpu-paint.cc +++ b/src/hb-gpu-paint.cc @@ -497,7 +497,7 @@ emit_all_clip_sub_blobs (hb_gpu_paint_t *c, int out[HB_GPU_PAINT_MAX_CLIP_DEPTH] { for (unsigned i = 0; i < HB_GPU_PAINT_MAX_CLIP_DEPTH; i++) out[i] = -1; - for (unsigned i = 0; i < c->clip_depth; i++) + for (unsigned i = 0; i < hb_min (c->clip_depth, (unsigned) HB_GPU_PAINT_MAX_CLIP_DEPTH); i++) { out[i] = emit_clip_sub_blob (c, c->clip_stack[i]); if (out[i] < 0) diff --git a/test/fuzzing/fonts/clusterfuzz-testcase-minimized-hb-gpu-fuzzer-6573156621156352 b/test/fuzzing/fonts/clusterfuzz-testcase-minimized-hb-gpu-fuzzer-6573156621156352 new file mode 100644 index 0000000000000000000000000000000000000000..980c5e217cceeff8931c59b9e0b00bf47da4cf76 GIT binary patch literal 3892 zcmd^BdvH|M89(>#gUj*?$ii+e<_3&nTTzG)C zyN~<6dpD2G`>{z(0I>lTXnhnqV{NTYX|c+TisK(vr(-E|e&_qn+5HMOY$!mJksp~*UjC|8xr?4Q4&?nDS%2=cb#ilWN3 zRK}Mep9a}qUQ+Z-HZXe2K42-BA$w4DBI$JS~0ehpG}F?8pa4mHD| zk1goVl+`?9ItHQ@;Rrppx*%WQV>*_y!WlKN_OSVgVM*U|xe*9~%h@2B%^IMyAT!>M zmx8<|Jz}NkP7IJ-)4swXu$SA~g0(BrNtB&RrF{X0QJB*)0}%Xeo!v*?Gq~_Hp!m-A zE&UVdQ!I%dL7RYn58ozKVr0WYRv>CD)8S#W!3|wc=pOQ*}-WXFK zpB*(;g97e_-tIE`w9Rbbbpm_yr=$r@K-gCrkZuDa3UOVldo)jkRZBol^EjFcQkplR zEojv^Z$=NHfpOk~GSTPbycHeCtjLAj$P2U;m7^k%o2xN9Imw^s~06o+&q7IoIGK4 zcyi8j)5n+3#v!ZD@BMta55SMYs-Na!LF^>H3$Hi*@-uYl~+CF+t z{mnP$CV)mw+K0VKmyqQZ*86sJ5X*9Gu8#a)0Kx-e13Wo^9V|KC^D)OJzsG zBcWH4ZKn>Z^KZ6&#yECp_gZ*$nYKf1D9rk}=7Uqem50PP!hgZts`m-;$=WAt9h>)WYIhx3pw4hy8Wt_QPjj!&k+Lq{qxRa>xoREv3|Bl@ zcC^8%CKlPXyR}IT!MY}?&3QsyBgkS*l$;k2j!tdqPR6?e&JQ% zG!kK)b8RHU@&ZHo#G7oba#P3gY}=)WM+v(i@B;baQx;z2*i3=rqfBJ%z&Dc|9LsSm ztIhh6<9YQ~iy(-CkOe-bSYi^mBZtlPb#y&Vfs3gO!$rA>bBngd5@6$@CQ_0FQKHnl z)k!f)hV{;i2Sz8gbVri4&CVbH+#*H7Vwk+tp`N#E#PLO;pKRJvrY+GX=C3F(J@oW} znqQZ`E~zumzV*V3JASc~;Loi4oj2>vJ?ak*zxv*<&gH5(n*S5x(lqsN_AR9io}E;H z-rrE;d#F$|FW#^|L~~&wD)-P=N!(1_4!h4#CN0Rw(@R^Ljimb5pK=II;Qf=n)^~}1Fite2+ zK0k8ithz*u17)R5RPcv@kmvZ=^Ot2!6j1Am`d3^bF~f zZn7mH@+Tnj7qlt%hlQJ8D(WHBRE%;w z&oK;`*j>}y7odV&T({CCDNH;f69U5u49P@UmZ9qEYUmm=%IJCCEA2}J+JkLuN32s+ zI#0B{E%(Vuxi5aW@pvpw@I2%*(bd)3rx1cw?fTjx$T40apFg>;AxX)sdQN-b{SqRa z=wQ3ajt)U=qlD&0Ax?_cUaqsYI#YXh0?mZN;jD0&W@wUO1aKO!DpYnvq8vkdxXPeA z7-k);evvq$rrHy5lVd5BvvUl5EE^U>N|fM4iIYf479@#^H#RBFiaPT>ha`%UAopBw z2r?IABtp`oKyub)^scDK8+JM2*<%=H5l3H`A>IIjRe%3qVqajRxCyu6(_7z)!CB=# z$jZmqSrdk*^!lZjSQPEap*S{nQMq$K(5vyp~D z>dneOZ-0X$B-vCn$buX^yScv!T0$)WoqZc0uALK{~F^x!Lx9qhs$a+70*l!vUJ6ofr9wN9~7R zt%c;Zh17Sngc?Vw=Ko zrxKwhnglC6wUoAS*0PAJlHR^eo8th(yndTliVgE2F%ss&Of*XP8}^5M0e@hHZzbVd z>1(DF;bt}=9nn5k^Z86itiPvwK+-FNYuY@JTu_LdyGm3KXK`114`9Pr~%72~i6KMgeQ2M0g84HNh> zEd^Q$1O=ywN!u_<N7U&(E~Y zr=vihram!gsZY?SV}D4aa2P0{2iKYb`w?XS4j6Z!Q?LPg9fk$q&&fkGKSyL9x@8b$ z=Ap$o$a$41D*|A%E&~JCA*g>pGLN8-(5A6o!~WFo1~kL40zE9MGyqxAEIkrfId(ss z2ztop|E%GVT#UWmTn0+%kKjtHbf>(j>)Yn*RaZ2gE3CmS_?DbX&9IjI^^EJ(Rqcw$ b{|7FB71CH?7%Plog)COcV}<|qsdN7cDWOp- literal 0 HcmV?d00001 From 0f9e0ba2a5f9c916c0242454cf9bbde41a4f8e92 Mon Sep 17 00:00:00 2001 From: Behdad Esfahbod Date: Fri, 17 Apr 2026 16:19:47 -0600 Subject: [PATCH 2/4] [gpu] Fix signed integer overflow in extents computation Glyph extents from malicious fonts can have extreme values that overflow when computing x_bearing + width or the width/height deltas in hb_gpu_paint_encode. Widen to int64_t before the arithmetic. Fixes: https://oss-fuzz.com/testcase-detail/crash-8a9ba2164fd1e6a6fd7a8ed566cf4d0350c1357e Assisted-by: Claude Opus 4.6 (1M context) --- src/hb-gpu-paint.cc | 12 ++++++------ ...case-minimized-hb-gpu-fuzzer-6490288851058688 | Bin 0 -> 3246 bytes 2 files changed, 6 insertions(+), 6 deletions(-) create mode 100644 test/fuzzing/fonts/clusterfuzz-testcase-minimized-hb-gpu-fuzzer-6490288851058688 diff --git a/src/hb-gpu-paint.cc b/src/hb-gpu-paint.cc index f83bad85c..8bbec06a4 100644 --- a/src/hb-gpu-paint.cc +++ b/src/hb-gpu-paint.cc @@ -166,9 +166,9 @@ hb_gpu_paint_push_clip_path_end (hb_paint_funcs_t *funcs HB_UNUSED, int idx = (int) (c->sub_blobs.length - 1); int x0 = ext.x_bearing; - int x1 = ext.x_bearing + ext.width; + int x1 = (int) ((int64_t) ext.x_bearing + ext.width); int y0 = ext.y_bearing; - int y1 = ext.y_bearing + ext.height; + int y1 = (int) ((int64_t) ext.y_bearing + ext.height); c->clip_stack[c->clip_depth] = { HB_CODEPOINT_INVALID, nullptr, @@ -477,9 +477,9 @@ emit_clip_sub_blob (hb_gpu_paint_t *c, /* Accumulate extents: x_bearing/y_bearing are top-left, width * positive, height negative (growing down). */ int x0 = ext.x_bearing; - int x1 = ext.x_bearing + ext.width; + int x1 = (int) ((int64_t) ext.x_bearing + ext.width); int y0 = ext.y_bearing; - int y1 = ext.y_bearing + ext.height; + int y1 = (int) ((int64_t) ext.y_bearing + ext.height); c->ext_min_x = hb_min (c->ext_min_x, hb_min (x0, x1)); c->ext_max_x = hb_max (c->ext_max_x, hb_max (x0, x1)); c->ext_min_y = hb_min (c->ext_min_y, hb_min (y0, y1)); @@ -1477,8 +1477,8 @@ hb_gpu_paint_encode (hb_gpu_paint_t *paint, { extents->x_bearing = paint->ext_min_x; extents->y_bearing = paint->ext_max_y; - extents->width = paint->ext_max_x - paint->ext_min_x; - extents->height = paint->ext_min_y - paint->ext_max_y; + extents->width = (int) ((int64_t) paint->ext_max_x - paint->ext_min_x); + extents->height = (int) ((int64_t) paint->ext_min_y - paint->ext_max_y); } hb_blob_t *recycled = paint->recycled_blob; diff --git a/test/fuzzing/fonts/clusterfuzz-testcase-minimized-hb-gpu-fuzzer-6490288851058688 b/test/fuzzing/fonts/clusterfuzz-testcase-minimized-hb-gpu-fuzzer-6490288851058688 new file mode 100644 index 0000000000000000000000000000000000000000..a9af5f13b99ccc9b8e5b59b75c96eff31486d182 GIT binary patch literal 3246 zcmeHJYit}>6~1R@*K3a*Ck~#S-Pvt+HlEqX?5^rJ?$E+IDQOrSS#3k3dj+JHF{vkR zW7#f60$g(_lXnKlV6F-p=wzskYwA(!_BZp-& zA)A1ZG1+-JC-a1KVWC`foK9>J-|9FQiw^cE-|INU=j$B7(g=`kezeOw5{o;F{R4ZP zYqIeI)=bJ5cTP^+by;>!VWn=jF$#|7H-U`P=(Po2kOWQ81w&whDOf^DC<_&#D%6C! z&=BkpACf{^NDmny7BWLts1z!PDxqqq7OICDAzS1{Nz_DLG(;wvq9vBZvRDzTVoj`z z4bcwsVJWPI^{^3UVKZ!nOW|_360U}8;d;0cwj+E*if9o%VnkTPj98IUq#UV4s*zfx z9%)2uiI*fvlXS_D?vYH%l1frpsz_C-Ce@{eWJmd^6xE`7)QGaE8MUINXgOMmR-?6O zJ=%!cF+L{6w3r?hCruqo@A$_4zwY0B>zjlN zzJN8zE2oR=p8ezc(JRHP$2w02-F%SvT$Yf)JQ)tWNIJ-uNT03nilk_Yt{4haOvO@4 zN?EBWRi&oXm4;%gyeg@hs;h>|R8zIol3G?PYE`YNb+w_|Nj@nhwWOXjk}PQ^tz;=# zPF9lDWGz`wHj;LVPe~~)rKgM(OPMJvRZ5jpl~grVOVv}2l%3|&Qd&#vX(P?jX4p!X z(&cm|T}{{0^>ia`XEG9>(K33*$gqql{ud=X zsaaY{D{B?4s@1f**3j%MpOvy&R?iw)mNm0hwv;VrE7@wcmaS(SSv$w)q@0%1b4HHk z%$$`g<;uBAu9~am>bXYF&hvRGujTc;k!N``Z{ZI?fqoC@ z_kpee{UOjF0sRTkGeDmKdKT!igODPyTr0;>}eW3?xMMw6I%ex`jE!2V2;Wc(H{8h#zWUcl1YE*xj~c3)AMoFFbbq z(S0+s2ku*%oL`!qo|=1d)|%;W$^e={OhcH)`uhj^$pShw(a~qf6q!f7kIax+a)8`N zmdGSBOPHI+vN>`$A`45KVRuct+wS7Q7XNNoo{X;-UwzRx;I6rM23&9h@pj*rOZH+ncLjK$@I8ckWMXsNB6q@i_G0TJRdVk&e$00N)*xb7Qv^3mYrN zLfbc&50fnqk8iAEZioMN=z*hOJWRSCF09{LEWlTag#tNJ*!V%Q(0&wa^GAyC)-MlZ zM;t&PxXI_^Fg*OI18vRT6TvN-ZZL29fuj5F;m=XWKVwJ*0cZ7Y3^h-p8v>(9yD=1m z<<#2jQ{GM%lRUDFgFI95xoT`(~hxDi1Jz7bNEz|xQW|6@w{8%(EOr> zWlizc8NiJN?+tg^Cg($H;5x1oxxwo=KXOCYac{{#GgHNf`+n*ufsYzEi? zV6(su0=pmBu^Y*W2eIU=SGxAn@wYqTm)5)2&Rh}_e0OK(rDJQO>u1(hS67oLXjbv( UzaO6(G^d}MxXY3MPUJD?AE|u9{Qv*} literal 0 HcmV?d00001 From e4d1127676fcc4938e13a4e67509d64e1aa2e808 Mon Sep 17 00:00:00 2001 From: Behdad Esfahbod Date: Fri, 17 Apr 2026 16:23:42 -0600 Subject: [PATCH 3/4] [test] Add one more fuzzer font --- ...tcase-minimized-hb-gpu-fuzzer-5419605043773440 | Bin 0 -> 157 bytes 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 test/fuzzing/fonts/clusterfuzz-testcase-minimized-hb-gpu-fuzzer-5419605043773440 diff --git a/test/fuzzing/fonts/clusterfuzz-testcase-minimized-hb-gpu-fuzzer-5419605043773440 b/test/fuzzing/fonts/clusterfuzz-testcase-minimized-hb-gpu-fuzzer-5419605043773440 new file mode 100644 index 0000000000000000000000000000000000000000..b21ff96dca4bfb8ae7e8824431e2ae400c9e5277 GIT binary patch literal 157 zcmeYd3Grv(Q~-mV{NzLi7+_&g05UnCToxd$1ZFER0M-6i;9_8q0I|>kT>L)}AW6c- Wk;I(+eS*N^3=Dio!eAy7NIL-dw-%uQ literal 0 HcmV?d00001 From bb2b4bfbc2c6203377a142c3ebb7cd84a4d78e2a Mon Sep 17 00:00:00 2001 From: Behdad Esfahbod Date: Fri, 17 Apr 2026 16:29:06 -0600 Subject: [PATCH 4/4] [fuzzing] Cap font scale in raster fuzzer to avoid OOM Malicious fonts with extreme scale values cause huge pixel buffer allocations across multiple push_group surfaces. The library correctly bounds individual surfaces at 1 GB, but stacked group surfaces can exceed the fuzzer RSS limit. Cap the font scale to 1000 in the harness so the exercised surface stays within fuzzer memory constraints. Assisted-by: Claude Opus 4.6 (1M context) --- test/fuzzing/hb-raster-fuzzer.cc | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/test/fuzzing/hb-raster-fuzzer.cc b/test/fuzzing/hb-raster-fuzzer.cc index bdc785e74..464cb8ce8 100644 --- a/test/fuzzing/hb-raster-fuzzer.cc +++ b/test/fuzzing/hb-raster-fuzzer.cc @@ -20,6 +20,13 @@ extern "C" int LLVMFuzzerTestOneInput (const uint8_t *data, size_t size) } hb_raster_paint_set_foreground (paint, HB_COLOR (0, 0, 0, 255)); + /* Cap font scale so malicious fonts don't produce huge surfaces. */ + int x_scale, y_scale; + hb_font_get_scale (input.font, &x_scale, &y_scale); + if (x_scale > 1000 || x_scale < -1000) x_scale = 1000; + if (y_scale > 1000 || y_scale < -1000) y_scale = 1000; + hb_font_set_scale (input.font, x_scale, y_scale); + unsigned glyph_count = hb_face_get_glyph_count (input.face); unsigned limit = glyph_count > 16 ? 16 : glyph_count;