From df4be0cec8e4a820fda8ae57e057e648c89822d1 Mon Sep 17 00:00:00 2001 From: Behdad Esfahbod Date: Tue, 14 Apr 2026 21:49:12 -0600 Subject: [PATCH] [gpu] Use vector.reset() not resize(0) in hb_gpu_paint_clear Three accumulator vectors -- ops, sub_blobs, transform_stack -- can enter error state via failed push_or_fail() under failing-malloc. Once in error state, resize(0) short-circuits at the in_error() guard in alloc() and leaves length unchanged. In hb_gpu_paint_clear that means the next iteration's clear walks the stale entries again. For sub_blobs this is a double-destroy: the blob pointers were already freed in the previous clear, and hb_blob_destroy reads the dead ref_count field -- heap-use-after-free. Fix by calling vector.reset(), which clears the error state before resizing to 0. Matches the pattern hb_gpu_draw_clear already uses for draw->curves. Found by oss-fuzz/CIFuzz on hb-gpu-fuzzer; minimized testcase added to the fuzz corpus. Assisted-by: Claude --- src/hb-gpu-paint.cc | 11 ++++++++--- ...zer-7148eb19cc1a927d3bb5773630d4d9829fae5fbc | Bin 0 -> 14347 bytes 2 files changed, 8 insertions(+), 3 deletions(-) create mode 100644 test/fuzzing/fonts/clusterfuzz-testcase-minimized-hb-gpu-fuzzer-7148eb19cc1a927d3bb5773630d4d9829fae5fbc diff --git a/src/hb-gpu-paint.cc b/src/hb-gpu-paint.cc index 8aa3f1529..ff8bc94aa 100644 --- a/src/hb-gpu-paint.cc +++ b/src/hb-gpu-paint.cc @@ -1441,15 +1441,20 @@ hb_gpu_paint_encode (hb_gpu_paint_t *paint, void hb_gpu_paint_clear (hb_gpu_paint_t *paint) { - paint->ops.resize (0); + /* Use reset() not resize(0): if an earlier push_or_fail() set + * the vector's error state (common under failing-malloc), + * resize(0) short-circuits without clearing length. A + * subsequent clear would double-destroy the blob pointers left + * in the array, or keep stale ops across encodes. */ + paint->ops.reset (); paint->num_ops = 0; for (hb_blob_t *b : paint->sub_blobs) hb_blob_destroy (b); - paint->sub_blobs.resize (0); + paint->sub_blobs.reset (); paint->clip_depth = 0; paint->unsupported = false; paint->cur_transform = {1, 0, 0, 1, 0, 0}; - paint->transform_stack.resize (0); + paint->transform_stack.reset (); paint->ext_min_x = 0x7fffffff; paint->ext_min_y = 0x7fffffff; paint->ext_max_x = -0x7fffffff; diff --git a/test/fuzzing/fonts/clusterfuzz-testcase-minimized-hb-gpu-fuzzer-7148eb19cc1a927d3bb5773630d4d9829fae5fbc b/test/fuzzing/fonts/clusterfuzz-testcase-minimized-hb-gpu-fuzzer-7148eb19cc1a927d3bb5773630d4d9829fae5fbc new file mode 100644 index 0000000000000000000000000000000000000000..e4c214bc65f9c34dbb934241cdd3a3a7c56cf258 GIT binary patch literal 14347 zcmeHO3viXi6+Zv-CimXlgyiN)NPaHik_7VLk_SkTBqR_q5K16WwLl1gh=ha?5p`;# zsH13Kz-WDpr8?75>vTGF(6j?>Mu!>gSVe|br0T#7YD8KTga9V_`^X8V$y$^{W1K&5RsCXtt zfs&*Nz!PT8D=UBct*5sjJq&ngr}?up@Q)&WKm6pf@(kZSn;!j=NInF7S^0v31yBFs z@!d#&5_nQoZDl<<=_#Zq1J7Eyp|aumx1M+h^}h^!-KsVBu6)TcHymLX#e{BNh4k!_ z#eXNV-9e=9s;RDA5%JX#B+I}lrv?$u54F`O|4+b^YHAxdE?ccMA$=S0*=y>mDko$l z-;MNkN+qhT+*nV~%OSu^k#4N5tgRmHyt#!)Lw@Pi`nvUvW-~z^(i%=DAuFO-AbyZ^ zi4>9`65nKB?&Rz#J~x>ZO8=uEP|K7+Iw)7bslXL0m${Q}w?bfoA=2_dAt9d(%x%S( z9lKvCE|pMkc}dYC2{qwIwwF705IOX-P3_wquW`)TPec7hz#G9aWG63va?#Av1r)xf zvT-eB$N*M}%;WqO@S=2=?2=c@ugWKtEM`sYCwWkPg&YN3Z|`0Wu6mwJ=MYA0$0ar+B7PKZ@Fgk9j%!(xK!akX`Z7T zIs=EHq#lxfMH;D^Tjf#ll;z92$R{^*`5J#L;8yuzBb5{`Fesl2Xa>t$>a@Kq&o#*6 zNqtP)2tq^jC`)uMoQuMQbTzbFhqP>@m~D_rFmO9?2dJH(W4XA1hXQB8a({&bj}WC1 zZQG{^naUUos>ri1kMj_yW>Tbrx0>^O)@gOmK`k&33cX?CcChw&X8RMlxwUdmBo` zP#eFlm3s!H_RLfaUMKivuIbC2Xbk-6JZc5}E@+|@gSZ5^Bo}H9qG|XVl!p@b%4!ji z`vh|?@`z@W8jPF}y#%f?4#B3qR4NRFMcf%H-hAUY7&(Oz{<Rt?Y4-Kw?wG^$1 zPcGcP^u}5mSWCU6W4lbm8k-35I7kM@LpboW_DrNuJeI0>EK%_k#Kfu~Qv8c9WQ$dd z<28R~&S(RbL`CsT#0#+EOfif!V^;aXLK-EuyEwW@q}XW;rI7T5dK;*C_clm!vYx@& z?9c;%V;2ta6$n`zhMdnK*s;SonXR@&)Sn2(5;MS&)mR67C-eLL?o7P*aSQw0nFh6q zr1&=xE;xs-X%&(vbvRT=2oOU6k{o~v3F!!}D80QeE$Q)L(vmc7@S0RObhCl$WkabE zGO^&A(%mjOL%KM&d|nd1FWs%jw8O+3KFw{2$E(52jjN?mT&F65ST}}ry1M2LQ4{)e zh`KH&;(yJ5n`imtA-KKX4pDr7;)B$%9HP2TKm#~Y2-2>67xQa39eF0}%uhd=mRjoE z(Q<3XhuaEY_}h{Vzj*1yl>3%$WwmQ0Rvn>oC3dS@c2>2ZaN$k|m2fx_i*+Kp33}NB zH1>18zX+&wtTn2no1Z~_gVJf53#+L>3Wu5`)VNIY3f)K?2%+>u*YzX zM6=4~xexSR&f9%M-^8YweL=z`UvAFiFMd1p;YC%hUm)}uw7P5Hi=Y^%eTS^LXlA3uNZde(*&+6yztfk!ZezyUJV0d>rk+AIg5(**dwp>_mh5qr%%CiT7gT{ACpL)qZE#eH>e zfG&6jyTXe~cO!=oxUq6yMtC-z^as4Qc*Bp z^3E*w>n#(2vPahPjQ* zCOcJ?FtPE}Cc)%KnGD=3OmrTV&jDWsd<~oEJodNbQ{JB`p2Q&4kBZp0N z#uYEE!1Dx`sk4br=m+Urkj~`^6CHh#G!54!Y>XjHboAx)3UIDJj7@Z?gO-CHmwIFu z?<>KC_SudA7bZH}mbd(aC>W{~t-PLuv4zW~nw=av}}^Wny=6muirv#O?%BVc&qfo;ZYT0#xzugLqZd@Fdu?kH!lgnJ&!VPsneV9C8Ss@3<^!1R8o_7a)QGue#im zhyQsnN}v_;i*c)>AMhSePs@jJ1#l_sity!J?AzhfB(m=CmeBcBb4YU7pxT=!LHE>2?q)2G z+5Yu0Hstxb?b}oGci*%JQs6^PcsGgRuJ6 z_`|_i5tsSH{1}kq4?8e>Ciufng!m%5j_$@9R7KSYS0i*Mt)%>K9vOKDU{Yk1z! zT|Gkm$yJAZE0D+XFQ0>JuSM<4yK`KKUyjrHC}9;^!~8b%qh+P2Z53qJNP*Dh`7EZ5 z$kBj00=fE%TLf;p%I~|>3c=@{_$~*})sS^S?iIirXgx}(LoXQU^K`h0a8qd>+GZfk zF;l^R9r&pdbQ?r`4pP`AMZkGOtliRYlMt_BAw~7@tY#b4%AS9m9`Ks1ye5~ z#Y=HM6{ea+$Xf_);o?1F^cZahp}e~7-6O6qY5L=O**f+*ttw{pEF_RuHsdF#Z`i@Wriz&o9W4Na!7!h-VR#zz_!V*8tnSn(%- zu-CtP6X64J%lJevYT~W}gztb8CxX#a^sf-!2A9Mdzw)j#58-AwL+qk570&Nms|&3q zHVDx~?~FP88vBQSzBR04)9Lk5?>jyK8Vnwo8?pO3norxM3GNXcn~r}O^}at|B=X1k zxmC9G8w!)Ai}%}}Ya2CQ!L{wu;_S&rV2SO$UG}{kLS_@iI{X7&i?7R(ZEXZJ2($NV zYT>t(vq5gPLdok=I$psr^@;623!yYP=#=@;5lG1i_OPyqzivEaos+d^wMm%JV=Z5K z5gE_%|70|rhu|p>Qfl2^S~eS)SR6{`lp83^Fx#yaz|kCh+K?pENVaOsMQsI866>G< zRU=$Z_d?}qM7S2dLAOBl;mO}X__v8rxj1bFQj&$*)`<9YY<|kWIbF1ZSa>i6Q!?3s)7HHRHAP1V#M@ReT-PBOV&{op7|bMbXYJb z(+9|^>(^fkm9F}T0m%GYw2Hs7Nu4WT*ks%Lf05GfX8-^I literal 0 HcmV?d00001