From e6d5454350bcb2bbd12b3d32e79a43fb686f7675 Mon Sep 17 00:00:00 2001 From: Behdad Esfahbod Date: Wed, 30 Sep 2026 18:22:41 -0600 Subject: [PATCH] [paint] Clamp hb_color_lerp() channels to [0,255] (#6305) Sweep-gradient color-stop angles come from the font, so the interpolation fraction t can fall outside [0,1] (or be NaN). The interpolated channel was then cast float -> unsigned directly; a negative value (e.g. -387.671) is UB (UBSan float-cast-overflow) and yields meaningless colors on release builds. Clamp the interpolated channel to [0,255], mapping NaN to 0, before the cast. In-range behavior is unchanged. Add the reported fuzzer input as a seed. Reported by iceray-Li. Co-authored-by: Claude Sonnet 5.5 --- src/hb-paint.hh | 7 ++++++- .../49d296d4b92d7dbe2f354ac70fca3e32cbd4a936 | Bin 0 -> 51063 bytes 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 test/fuzzing/fonts/49d296d4b92d7dbe2f354ac70fca3e32cbd4a936 diff --git a/src/hb-paint.hh b/src/hb-paint.hh index 24e0fc313..df10bdc3d 100644 --- a/src/hb-paint.hh +++ b/src/hb-paint.hh @@ -294,7 +294,12 @@ hb_color_lerp (hb_color_t c0, hb_color_t c1, float t) auto lerp = [&] (unsigned shift) -> unsigned { unsigned v0 = (c0 >> shift) & 0xFF; unsigned v1 = (c1 >> shift) & 0xFF; - return (unsigned) (v0 + t * ((float) v1 - (float) v0) + 0.5f); + float v = v0 + t * ((float) v1 - (float) v0) + 0.5f; + /* t may be outside [0,1] (or NaN) for malformed gradients; + * keep the float-to-unsigned conversion defined. */ + if (!(v > 0.f)) return 0; + if (v > 255.f) return 255; + return (unsigned) v; }; return HB_COLOR (lerp (0), lerp (8), lerp (16), lerp (24)); } diff --git a/test/fuzzing/fonts/49d296d4b92d7dbe2f354ac70fca3e32cbd4a936 b/test/fuzzing/fonts/49d296d4b92d7dbe2f354ac70fca3e32cbd4a936 new file mode 100644 index 0000000000000000000000000000000000000000..bbd39d53aeb4ccedee4ecd95bdc1eaec0b509903 GIT binary patch literal 51063 zcmeHQ3w&Hf)j#L%E4z7Y(ma~BNxSJI^pU2!o1_mOB_R!MZQ7J1g+w09Hrcj;G%1_3 zB%;!SC=WqU-iRRb5U^N45VSxks0f0Hh$8y^sG{PhV9_d4A^ZJj?%dtGkF<-ApW=6K zGH1@5IdkURGiT=BJ9Bp~F%cC4*om6kTH9~Eb>=HXt3FM%^^NAWO|36J|F;W?9{(t~ zURZHrQx_dgZA5$5BE6ukV?nUxORG;OV(`%E9i2^`TYC3Cg#7KG4fkvgZ_&1GDueI? zNY`)J7LFbl`~60uCy=&n-`GF8;q8YHe2>WW8d2GO8rplj@)vFb!F`qX1*DfDJ#*9M;gQePPAo?Hb;!%>AM6SD+}L+4k#ja^yElhNw$LwV zD)3F<_YH(MN7i{~{()%fwM50aTLy=Qe|N-=RYZYXi6;Guge?%BdtmkbA@9+DCbmH? z(Jw|1{MH=XcS*X9G(p9IGPVa}PMqg2h{p09Ka-O5JRROCDLn$N zR^^B_y@$qPLYt1XvYUXZ*t(T_XHi^%K90sdj~VtDX6 z1%D5DUBF#}XCrx$?adMN&E$0hcY~46A}`eOdZqv$AuonRZ!QYamE?sY-aMh}=gFH- zvHgD(UB4@~|E(Cp81R!~`}YIi{|@kVvHgDlju4BjiS2(A_?v=fb!`6|z~8|6(bvd} zA=Fzu5%>e-EdgHQ1^z5~Uj_cEsMk31sEUGg3Y|fh()Dx)%03Rhm+4pZ7QM%AF6Ano z&r7(4PvBFzkGJv;zLc-y+xT97gulx_;(h!EzoR*{BCS%Jqcvzv+G?#^i)d$QAJZ<< zuF}4!?bIIDzNP&@`?>a8?awy0<=ZCNX4wL^V{9vJ>uh1$X4|Ok0^1d~8*O*m9KKmQ? zcN`8!k)zTv$I;+ua;$cAJ0gy=93OLBtt{tvRUDvs8bKUED#Pzi6CD$)qZ@I>DJUJ6{X5=i$IU#2#=Z2goa(?HY>|W_! z=MK9!yGPv@xUX>E=)TkafctUxv+kGOzjD9je$V6flzOT>^F2#EEuIrRr+WH4TRl5G zmwK-A+~&F0^N8oWo*#MkdEW56lk3PW%B{?uliQHnl)E~&TX$RA>*!h9C;f#ZS{3CJyp~IxGp1KJG}JGw3zn50QC~e{y0f&jq^vHu zuz@3id2@roxpRZFDyB@SsGK~dg10SSvSj)E<%9zR|YP;WC_D|1256ajA7G3v5%MO+u%p;TK50*bz{*Zpfw)%zDFRXrH^$Tkp zu*Lyv9QXi?1AIWve&PAD2<;_Od|)gO&zCp^ZakA4bWrf5sMGNvYbqf)jAuxW=O}3h z)swt>jy=c+@Nd*(luCN`$CEE+vJ+3f_EzJ`_x+76cHXO11=sIdnuko*S%{i(!{x4*l z22C!;Y=#5#0Y!xQEa;&tqHCh7B6PWUcFUZrO#!l6W?yX%LS7ADuI;w@vXHlX;mM1h zG6k(`(a8&+G6ykZaga~b-n6x6A@9xRXv;xU(7IZp%?Hgv$isXHW=B4OIhlMa(Pv!> zv>8QJB~!J!qN@6(64ruZ^DSuKymaiv1mqflYh6n>w=dwD1RQ%&;A1aB`qh{jX@`Ft zUV8h&@VP6-Zb?8sP2gJBigUvY`LqNayG7t*x9HxV(JSAd@5x?d$+7Gyd_c}A;H9WyP&rmO zWLah^!^(w@Yc!31sc;)jV@=_9;8hBD0B=;dlPWl*a2Ie@7w3TI8bxIuh6fv%$TA8AIfzMHRA@HLWUIe^N;S8R_s3ZFp}v9hhV%Szz6a~J);Vr2z;l)%fYix;ghH~*Q@Z!S{g2NZ|2kYni8|DWWbp`@Q2AAN!c2WJJg$wHsRZ0myTwy~ep^~oA zd{wgJ>_}vbuVXkI9riU1Y=qiv8#W9@hIM+&KyL=>Fr*CmdItLkqrRcx!7aW)S;QC6 z3yqf@Jal&5p|k5ddcx373a|0?L z+VW_)w+}Vo90#MlLp8n;e;R2toiq|i=SnAy1k<_FNzrui(Ll?{a0D$fo`DaSA3RL? zI=G3ieQ-ED97$?*6S-NpdzbQ(^qg)}PRE&%vwdA@q9nOHGdY8N$*$;z^v-B_U?|>( z;izb$kqpGqOvI7VOq`jBy_t&lj*7FEBKn1;dPhvBY$A^;a&v#*mg5FTd?Ty-29!%0 zq|tQJ$m+1+)CsOMQs2M;ydSU7ZQ11O8$fqef}8rcYzq6rBYiN)+Hl{%aK~VOU$2?k zEP8E+=(PUKqGz@GxD5JE6HX+>(>PFfM zis1kIWccuUi65b!<|A$Z4ALUh7r@_CKXN7^Ovv4S~Oh1|fM6 zHTfiMP}V+Zs>KIun`?T%rGx)a>AHWYbUjMd1@5}Mb@GmpS#f+o&=1i^gP*_Ip4 zx}08vsB0_g?SqAd)i)zO6xVV5T17nxzU3$xMtk=`dvOkWI|_Nd;1Xvyf*x~tuFeXQ88sxhg}m&!v(rBzJ()jM z_fFY^2GCp5`=Jy7AZhvOWDhh@h(f@@@UoTFKD_GVpsFJu}mkcHo(KVH8G%GG4D=eiRPS)YMgiZrE zV=*3!YpZ_W;*+}SSJz~Xo4_OPY{K9d()*N$tVK%55?5n!CGCR+$K!359AcCfS9kqN z>wjO|flR*^5c6Y+M-1TN+hyro;l z6SUqre2L{4M@Ae+O@?ewUx-XZU;k zEI-HJ=jZtc`~v@wU&LF`FY%B0C;T%1v|#I&$mY=c!I6->mCx;o4h{|Jc+N0p5ybO& z!9ZkVc(`v{BqVc-`uheV;b59_0<{fkoDG6nHYBD1 zAgOMlKeQ#>8yW~lql0Hp)XAXL`OWlFgMCQ`Drjb^5?$XAN@7-I(2$d;u|k&|tY1{y z5DG2{0wyw*I`dH?sgRhe46;36skjm1nmR!oGPS#|(WCo?CvR=kK zWx?b;qe+w%GiDl=OwO!Kv1W2^+%&pHr7P=hr_M5NP*av_Ic3lE3}sGJhN{M}W_pfc zOjFLZOtv)TD+S}GOwWp2(v+ndKzN+6m+HOxDXYAM9Zls_1H_#&sbGn&YNF?!-PapY z{nONM1+~~<#Tg5iH_@co44M+DTP%gB8_OUnJEZnjlM1H3YN9IZ7-G~|U>GKaY}mvg z8>4`^j|$mw*D&``k)b>w?oN8&6*)>&Qtvd;rBw{4HC18wQbLfbTept6#MDfllqjcE zi#t+UPTY?YIfl{WZj_c~Sj?=5(fbXnne*aiF!e;!>BbEweNtq^FBdpr<&7q?GFzNG zF+3-;E4pE{IKLV;%wA=xM438nvUo9-5w}=8LmAm{FOw`|Y*5z$Q;yNY6XuGG)2D}V zeU(?vkUk3?YViAOam^4=G2pT)F0C0D%H^bUssvm%RYpolWK7LiBH+hWSpb!tQclnQ zzTZDh-3M$`Q`(`3oI?(69_)>Xkzo3v@^z!kI5dlN!8t;FxIff0I53QP$4GBzyb5cw z%sLfKa>R2UFIfstsF&qHRI7JcXC#dl@ ztWbHuOdeAiFPJH}WC)Y&Arv&%Rgp$Cxu{+O&J!00?er36qN&7GDNZOJjMrky*2^Ym z$4|{SY)sXMHivOfI}!>&Ra6uTKxu>w4CpwLMUMk%68yDG7B(zF9||@sUL2aQVuKp; z&r2&2K>rkd)L*+0{n8(rk9%63lrMS3M82rgYfj-D3e9Ppp_u`xkeNYbhx|o}5<#R9 ziW8Lif+T>qXK*uqfZm5%n_F9&+Vd0Xj`rq)L~2<}N9Tk@5}Bd46I_@&lqOC9YoKlIp=E8$mba9oQjc5LzQ#mc(bT>yBqf-L9c{;V zrV*E|JpTBW_LeoxEv6G}>1xIatZZ9jGW+Uvt(_~^wsxB=x}u{sv|?RLc|sXM>1gU) z*WT2L(k6)_L+YQx+`4Y{$~A2rD?7WVVJR!JF*>+)pcf-37HC3h$PJ72oKT?Z(E0w_ zx^xL@$QoBdQa&V1O{+t{eNh5@hs@4gUaUQZQp;~JPI1VTjq*i3SSORu!dRRN^+z@g zm&7US2Zx6TH%nq^Dlyu(antaGI8_vuByXIgU!{v>dT3J^*FB?#G84^I$Ha896saqe z5Fv@W-a1jQsY0&Eg@lkTxDYBst82rA_;qnhFeJv+NG}`>O%BeUzGzQ>WGJ-FpH2#R z^xROi!JliO7;zG~iH;E_P7j*s81>@xx(0u#-UPCG;c$9eP2M6F4nd5{Nr_O;D3l6q z=!*^wPsx}y6v0)$w|rnwv2NblKint$SQk*E`%%we-#`!U9|wj*a$aL71dlp99PJIQ z@8251tz@sb9r0()tn9hqeH0M4akYoz7ls%R_YI>$pWypoR~iN0R}rDpxE6{=wnd^t zk?bs##(X#nWhih+3mN=bS||hi;VhJ~h|paVXmu#x!@Y@obaEdl=hf;6IdY40hAmqHm37n+)8Cu}#Jj zLZO**z|v<_Lj!ni38Rc0gZhR?=AxDYW$HuV)zZW4#8-A-pj)>Sf!*LE3 z0$zb%&5+{`ngIBS_#KbqhgeY}$8V_=Forj#$%*%f0q2Qba-97%3Gh6;ZB5Q=#XH*0 zd$5xZIiI9Tz@Lhpx19U&ZZ)~YTiE2P!0s{R3gVq@a;?Do+T=QoW&++svj88UYQSgc z2*7=?0J+|#IXK;XnhQ9C<^e9jiw>02hS!29CqlJ==g~BUM2OR@A zg_Z&a=vctz)ChPg7VgM1goRG>T!fd7$a51d1AG9B{p5LujtAU_R~^XnwrIQD#k3M| z4Sfi(msSCO1g}+5?&Vn2q}yv9ZOF}#361xI4(k_uX}C`twEu`EsnBUl=xg3GY%nc*n-HI_T6U<|LYkhcs= zpyX}Bq9%F8LMeH#!M;W0-HXLe^1g({Qu6*U7Cp&3hSy)HZ~|T@qrz&uG(d$%VmXxx z#lkcdoBY7SNJcITEUPDg+ zK1ojkzD3_6Dw#^(23$qo0UW_zJ5+KTeHZWrdKxfB&k&W?(Dwkl@mmQh{UkjHcqM%w z@D_R=a2Ndm@KJgJ@O$(_z@O5KfUnb!0RKWSVP8LuehgSZKLMPKy`reBntlqnj9vj; zPd@|vxCcW8<=Cm{06Y>q@?ZzBUapZ;w;hdQrZQ=HP^XdV>d4+GMmMMEvuRAifg6S6 z8%((wB>7UAcHwscn)or|9u&smlJY^N-wW!G*3G>;iTaYx`)V@p9zlJT_9Rp964d7@ zh4)IG7xpyQ_HjWi7vrFrx=B!X3EP{g?Yi7u$<(6-)kmj9lX$BI^^~YDnYU0-x6`>X zkaJ>#n;zPO`i#m$Ne& z{Ov!>%XW;SIWEF2^6fSV5s*bZU6+QO z^T*A(b=;g1vAqHHYP$h(nYsO-Yq8kI3g|8czt+>v_cD*Lb$r3jJEtXyYnX5orN?-J${gFBbDL>t!QVWop zPG3@~Dx^y2R+Z9+#@jT?pLBgL-JVM!WIO2&oHib(Y!BwVYkLq|CLGiihr%d_JN-s^ zLxJBM3p;3ljk$DxF5M@(0v#ts>@rU1Rrx3bfudmPI`PPWr=uJx1cK6;;XBzg<2sZ* zvlz+ItE3uGMm(fRHK5FRYGlbQ)X2$3vi@La_epC2LOviA08F!nV3s{em@XS;r~$St znZX#BsTY9)prlzNp@y#QVVQL`vSilPh*xb^DY;P+YGlc*tC1zMu135e%w`-KjR^r;}1YNlHaAM>Y~KcV1HJvq`C&6RC2H*0#&^QovhH_-Q75 zz`!R%wNi0S9g}68&~SZ1iwwET5_P5KqQ2_!!chpvBbA&P)I5$!^Rn-CyN zdkq0)wRbU6Pw)}_nuz{}_Zp4>i;^#|II>-iU&J?0bl<@dSyMb3jM<;0$DYsE9KY+-qwHrK=s8L>{8r(JEK$7}Z z+^Hz^9_$;g(4DyTRp?hR>MHbZjT{QSOCzU3?M38i6l)_nV!~Gn-DMNSaU3Pcu`>)Z z3|xX+dhE1jdk}XF2gNq~aeoH;(I|wIZWn;htUssz9EI1;{>$vYC_Jz7 ztjeqRsoX0P{P^7;mm z_jxfZ-G@o(8_}4UmHvWwin&QlOkYkn;}7)P#nkj&n3=wVFx`Bwn3UZU-y9v*6?fP2 z8x4&b{oV75usrToBD{d`3xq!sbwOL(EoUJ*BiK2{3m&Z_+jq9^RT?au>OCNR~S0|yJE{L49i2 zt73~`5p)W6fEJWj#Xh>W?P5ROx!CF$n@#UNi|DZ!(t>X_tr^279aNb%S}Rg~U@T8j zPN4QZ5Fl(%3@O+_TI|xh9e*nAB4<+CjUAd3`2p-hjD2=Z{IkR-Fiq(r#Ah%~={e#P za561E-(tf?&-v7WPjfsaw2*p;k1E))=dl-i85bpTM5%LQ&`{(~z+S~ARI0x4CQH6s zjt!ml+%oJ`TuzfDMdlHiawlW&;tHx9CwD6LB=%9&IJwjDna_DtW6o9f65Cp;IB zUs6=Puj(x(as&8~XC2i`iprIoyj`@^B3c|916j7Uq%5H$Qz%E#(J7Q;XlV-NSZYM; zVuNeQ(j_<1adC=np9Xw7w3(Kf^)#JD3qJh0oK}pJyOKVHPk*+i<%;UiXg1-7a^vR$ zxpnlnkx~bCX1WalJ4B-;0VsAJt%|*Q-kY&s?>`u8Yg-`pjux9?$6o)=rWpS$7Tdmk zd+bAV=Ei!OX2ve;nG*Zb$4X;+uP=zb{wQWfUL=_>cru0Zv)+xB?)Y1*=&FOU{4XDj zxgUKeX8++|WAvN9X5=?yC}m|c02kd$e1(MMdC7#Nr#G!SZ zw6;TtLEOT~?>MPBfG?4N-W+6f0mO9-2SHqquaY=An%lbANlwJw>>^i3b4M4xUy_5k zo89DI-rnVB4?g1B-tFgH%0)WBd6b8Afb%II=^z(S0n$PCl6QG~yPpfG5OIKusHnNE zHGpr~Oh6puVk$;l$0bzK-qzW~rBsTzi_54CaW_w-i5;uDnz)?GJ63f!@g$nmv8uU? zC(~ra-8_Y+bhdYOaRpU$ws&`NB~>Eb%~NSA(%n3brggS2>tY}I5O;GGRdu!^J)Nc_ z?&cXZqq((fCC{Xp&8^)lc^1t=x{0f)8tEoJf{tizUD?L7X?D}v6#ehfacX2ceNEUqb~|X|_^<#hZJ$Du?I1gkU=i(&@BfH4NukO1NukNMN}uhRZlG2JcTBjKZPV+A%!O0B84Vh zB!wp3C50wkCxs^6D6X<@KIu{^H0fS3=~QAA5{Dd{h^2$2(4@1aG?a9_6q=c@G@)VkM_!OFS{uG+*2q`q#DN<;%gQU=8 zXGx*Sjw1(F-Ta~jWG6DwFU literal 0 HcmV?d00001