From f94bf9f06ff46d6fc33d04fbb4e92e5d25fcaa42 Mon Sep 17 00:00:00 2001 From: Garret Rieger Date: Mon, 25 Jan 2021 15:57:42 -0800 Subject: [PATCH] [set fuzzer] limit the total number of set members in a fuzzing input. Currently the fuzzer can create arbitarily long inputs which once big enough will trigger a timeout. --- test/fuzzing/hb-set-fuzzer.cc | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/test/fuzzing/hb-set-fuzzer.cc b/test/fuzzing/hb-set-fuzzer.cc index 79b9fc52f..0a547f3a0 100644 --- a/test/fuzzing/hb-set-fuzzer.cc +++ b/test/fuzzing/hb-set-fuzzer.cc @@ -7,6 +7,12 @@ #include "hb.h" +// Only allow ~5,000 set values between the two input sets. +// Arbitarily long input sets do not trigger any meaningful +// differences in behaviour so there's no benefit from allowing +// the fuzzer to create super large sets. +#define MAX_INPUT_SIZE 20000 + enum set_operation_t : uint8_t { INTERSECT = 0, @@ -37,6 +43,9 @@ extern "C" int LLVMFuzzerTestOneInput (const uint8_t *data, size_t size) if (size < sizeof (instructions_t)) return 0; + if (size > MAX_INPUT_SIZE) + return 0; + #pragma GCC diagnostic push #pragma GCC diagnostic ignored "-Wstrict-aliasing" const instructions_t &instructions = reinterpret_cast (data);