From fcfed99ce0cba7272e646e5504fc76b4ab9a167e Mon Sep 17 00:00:00 2001 From: Behdad Esfahbod Date: Thu, 2 Apr 2026 00:21:12 -0600 Subject: [PATCH] [gpu] Reduce MSAA from 3x3 grid to 4 corner samples MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Use 4 samples at ±1/3 pixel corners instead of the full 3x3 grid. Diagonal placement provides good moiré reduction at half the cost. Assisted-by: Claude --- src/hb-gpu-fragment-glsl.hh | 6 +----- src/hb-gpu-fragment.glsl | 6 +----- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/src/hb-gpu-fragment-glsl.hh b/src/hb-gpu-fragment-glsl.hh index 423948917..40d11e46e 100644 --- a/src/hb-gpu-fragment-glsl.hh +++ b/src/hb-gpu-fragment-glsl.hh @@ -293,14 +293,10 @@ static const char *hb_gpu_fragment_glsl = " float c = hb_gpu_render (renderCoord, glyphLoc_);\n" "\n" " vec2 d = fwidth (renderCoord) * (1.0 / 3.0);\n" -" float msaa = (1.0 / 8.0) *\n" +" float msaa = 0.25 *\n" " (hb_gpu_render (renderCoord + vec2 (-d.x, -d.y), glyphLoc_) +\n" -" hb_gpu_render (renderCoord + vec2 ( 0.0, -d.y), glyphLoc_) +\n" " hb_gpu_render (renderCoord + vec2 ( d.x, -d.y), glyphLoc_) +\n" -" hb_gpu_render (renderCoord + vec2 (-d.x, 0.0), glyphLoc_) +\n" -" hb_gpu_render (renderCoord + vec2 ( d.x, 0.0), glyphLoc_) +\n" " hb_gpu_render (renderCoord + vec2 (-d.x, d.y), glyphLoc_) +\n" -" hb_gpu_render (renderCoord + vec2 ( 0.0, d.y), glyphLoc_) +\n" " hb_gpu_render (renderCoord + vec2 ( d.x, d.y), glyphLoc_));\n" "\n" " return mix (c, msaa, blend);\n" diff --git a/src/hb-gpu-fragment.glsl b/src/hb-gpu-fragment.glsl index e9a7933c6..881507511 100644 --- a/src/hb-gpu-fragment.glsl +++ b/src/hb-gpu-fragment.glsl @@ -292,14 +292,10 @@ float hb_gpu_render_msaa (vec2 renderCoord, uint glyphLoc_, float c = hb_gpu_render (renderCoord, glyphLoc_); vec2 d = fwidth (renderCoord) * (1.0 / 3.0); - float msaa = (1.0 / 8.0) * + float msaa = 0.25 * (hb_gpu_render (renderCoord + vec2 (-d.x, -d.y), glyphLoc_) + - hb_gpu_render (renderCoord + vec2 ( 0.0, -d.y), glyphLoc_) + hb_gpu_render (renderCoord + vec2 ( d.x, -d.y), glyphLoc_) + - hb_gpu_render (renderCoord + vec2 (-d.x, 0.0), glyphLoc_) + - hb_gpu_render (renderCoord + vec2 ( d.x, 0.0), glyphLoc_) + hb_gpu_render (renderCoord + vec2 (-d.x, d.y), glyphLoc_) + - hb_gpu_render (renderCoord + vec2 ( 0.0, d.y), glyphLoc_) + hb_gpu_render (renderCoord + vec2 ( d.x, d.y), glyphLoc_)); return mix (c, msaa, blend);