Commit Graph
12 Commits
Author SHA1 Message Date
Behdad Esfahbod 2b1e11ee50 [subset] Use serialized contour coordinates for IUP optimization (#6547)
A shifted default can leave fractional contour coordinates that round to
identical positions in glyf. Selecting IUP references against those
fractions can omit deltas that no longer interpolate correctly after
serialization. The reported four-point case loses 499 units.

Round the real contour points after merging default deltas and before
selecting IUP references. The gvar caller already uses a private point
copy, so the plan's coordinates and metric calculations stay intact.
Leave the four phantom points unrounded.

Add a tuple-store regression covering both axes and signs, and regenerate
six affected subset expectations. The reported fixture now reconstructs
exactly. All nine checked optimized fixtures stay within the existing
0.5-unit tolerance against optimization-disabled output, with unchanged
non-gvar tables apart from the head checksum.

Testing: meson test -C build (276 passed).

Fixes: https://github.com/harfbuzz/harfbuzz/issues/6462
Reported-by: olsklcode
Assisted-by: OpenAI Codex
2026-11-01 19:29:45 -07:00
Qunxin Liu a5c9c82692 rename expected files from *.retain-all-codepoint.* to *.all.*
This is to fix file name too long error
tar: harfbuzz-8.4.0/test/subset/data/expected/sync_vmetrics/playwrite_mm.subset.default.retain-all-codepoint.SPED=25,YEXT=520,wght=100-400,slnt=18.iup_optimize.ttf: file name is too long (cannot be split); not dumped
tar: Exiting with failure status due to previous errors
2024-05-06 13:22:49 -07:00
Garret Rieger 990fb14d78 [subset] Disable fonttools comparison in a few tests where rounding diffs show up.
Context: https://github.com/harfbuzz/harfbuzz/issues/4642
2024-03-28 17:00:12 -06:00
Qunxin Liu 84771374e8 [instancer] add tests for iup delta optimization 2024-01-26 15:51:49 -08:00
Qunxin Liu df735213a8 [instancer-solver] port solver fix (#4519)
* [instancer-solver] port solver fix

from https://github.com/fonttools/fonttools/pull/3374
2023-12-06 10:50:29 -07:00
Qunxin Liu d550e16acc [instancer] Recalc avgcharwidth after instancing 2023-11-06 13:12:04 -07:00
Qunxin Liu ce46698929 [subset] update tests
to reflect changes in GDEF.MarkGlyphSetsDef and Lookup.MarkFilteringSet
2023-10-18 15:49:57 -07:00
Qunxin Liu 57dac23d79 [instancer] add tests
Also update tests to gei rid of no-tables-with-item-variations profile
2023-10-18 08:07:26 -06:00
Qunxin Liu 2415d5f239 [instancer] update tests to include GDEF/GPOS tables 2023-09-27 13:33:09 -07:00
Qunxin Liu ef4ff1d6a4 [instancer] make varstore items sorting method match fonttool's
Also update expected tests
2023-09-20 11:45:00 -07:00
Qunxin Liu 2d2818c096 [instancer] update expected tests to include HVAR/VVAR tables 2023-09-20 10:30:47 -07:00
Qunxin Liu 7b5daff5eb [instancer] add tests for mvar partial instancing 2023-09-18 12:20:36 -07:00