Files
Behdad Esfahbod fbdac41be3 [test] Raise timeout of chunked fuzzing tests to 120s
The raster-fuzzer chunks occasionally hit meson's default 30s test
timeout on CI (e.g. raster-fuzzer-chunk-5 at 30.8s on linux main).

The dominant cost is not the fuzzer inputs themselves: meson runs
tests with MALLOC_PERTURB_ set, which makes glibc scribble over
every allocation on free.  Fuzz inputs that acquire large raster
surfaces (up to 4096^2, 64MB) normally leave most pages untouched,
but the perturbation forces a full memset and page-in on free, so a
chunk that runs in ~1.1s bare takes ~7.7s under meson locally
(~6s of it system time), and brushes 30s on slower shared CI
runners.  Which chunk is affected varies by machine because the
fonts glob is not sorted, so chunk membership differs.

Keep the perturbation (it catches real bugs) and raise the timeout
of the chunked fuzzing tests to 120s instead, in line with other
suites (subset: 500, threads: 300, perf: 100).

Fuzzing suite passes.

Assisted-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-17 15:21:24 -06:00

275 lines
7.1 KiB
Meson

tests = [
'hb-shape-fuzzer.cc',
'hb-subset-fuzzer.cc',
'hb-raster-fuzzer.cc',
'hb-vector-fuzzer.cc',
'hb-gpu-fuzzer.cc',
'hb-repacker-fuzzer.cc',
]
depend_tests = [
'hb-depend-closure-parity.cc',
'hb-depend-fuzzer.cc',
]
# Build the binaries
foreach file_name : tests
test_name = file_name.split('.')[0]
sources = [file_name]
fuzzer_ldflags = []
extra_cpp_args = []
if get_option('fuzzer_ldflags') == ''
sources += 'main.cc'
else
fuzzer_ldflags += get_option('fuzzer_ldflags').split()
extra_cpp_args += '-DHB_IS_IN_FUZZER'
endif
if get_option('experimental_api')
extra_cpp_args += '-DHB_EXPERIMENTAL_API'
endif
if (test_name.contains('subset') or test_name.contains('repacker')) and get_option('subset').disabled()
continue
endif
if test_name.contains('raster') and get_option('raster').disabled()
continue
endif
if test_name.contains('vector') and get_option('vector').disabled()
continue
endif
if test_name.contains('gpu') and get_option('gpu').disabled()
continue
endif
link_with_libs = [libharfbuzz]
if test_name.contains('subset') or test_name.contains('repacker')
link_with_libs += [libharfbuzz_subset]
endif
if test_name.contains('raster')
link_with_libs += [libharfbuzz_raster]
endif
if test_name.contains('vector')
link_with_libs += [libharfbuzz_vector]
endif
if test_name.contains('gpu')
link_with_libs += [libharfbuzz_gpu]
endif
exe = executable(test_name, sources,
cpp_args: cpp_args + extra_cpp_args,
include_directories: [incconfig, incsrc],
dependencies: [],
link_args: fuzzer_ldflags,
link_with: link_with_libs,
install: false,
)
set_variable('@0@_exe'.format(test_name.underscorify()), exe)
endforeach
# Build depend-related fuzzers only if depend_api is enabled
if conf.get('HB_EXPERIMENTAL_API', 0) == 1
foreach file_name : depend_tests
test_name = file_name.split('.')[0]
sources = [file_name]
fuzzer_ldflags = []
extra_cpp_args = []
if get_option('fuzzer_ldflags') == ''
# hb-depend-closure-parity has custom main that sets font path global
if test_name == 'hb-depend-closure-parity'
sources += 'hb-depend-closure-parity-main.cc'
else
sources += 'main.cc'
endif
else
fuzzer_ldflags += get_option('fuzzer_ldflags').split()
extra_cpp_args += '-DHB_IS_IN_FUZZER'
endif
if get_option('experimental_api')
extra_cpp_args += '-DHB_EXPERIMENTAL_API'
endif
# hb-depend-closure-parity needs glib for option parsing
test_deps = []
if test_name == 'hb-depend-closure-parity'
if conf.get('HAVE_GLIB', 0) == 0
continue
endif
test_deps = [glib_dep]
endif
exe = executable(test_name, sources,
cpp_args: cpp_args + extra_cpp_args,
include_directories: [incconfig, incsrc],
dependencies: test_deps,
link_args: fuzzer_ldflags,
link_with: [libharfbuzz, libharfbuzz_subset],
install: false,
)
set_variable('@0@_exe'.format(test_name.underscorify()), exe)
endforeach
endif
glob_cmd = find_program('glob.py', required: true)
fonts_glob = run_command(glob_cmd, meson.current_source_dir() / 'fonts', check:true).stdout().strip().split('\n')
subset_fonts_glob = run_command(glob_cmd, meson.current_source_dir() / '..' / 'subset' / 'data' / 'fonts', check:true).stdout().strip().split('\n')
graphs_glob = run_command(glob_cmd, meson.current_source_dir() / 'graphs', check:true).stdout().strip().split('\n')
depend_closure_parity_fonts_glob = []
foreach font : subset_fonts_glob
# These fonts currently spend tens of seconds or more building the
# contextual GSUB dependency graph before the parity tests start.
if not font.contains('NotoNastaliqUrdu-Bold.ttf') and not font.contains('NotoNastaliqUrdu-Regular.ttf')
depend_closure_parity_fonts_glob += [font]
endif
endforeach
# Chunk the glob lists to avoid command line length limits, and for parallelization
chunk_size = 64
foreach glob_name : ['fonts_glob', 'subset_fonts_glob', 'depend_closure_parity_fonts_glob', 'graphs_glob']
glob = get_variable(glob_name)
chunks = []
chunk = []
foreach item : glob
if chunk.length() >= chunk_size
chunks += [chunk]
chunk = []
endif
chunk += [item]
endforeach
if chunk.length() > 0
chunks += [chunk]
endif
set_variable('@0@_chunks'.format(glob_name), chunks)
endforeach
# Run fuzzers
i = 0
foreach chunk : fonts_glob_chunks
test('shape-fuzzer-chunk-@0@'.format(i),
hb_shape_fuzzer_exe,
args: chunk,
workdir: meson.current_build_dir() / '..' / '..',
protocol: 'tap',
suite: ['fuzzing'],
timeout: 120,
)
i += 1
endforeach
if not get_option('raster').disabled()
i = 0
foreach chunk : fonts_glob_chunks
test('raster-fuzzer-chunk-@0@'.format(i),
hb_raster_fuzzer_exe,
args: chunk,
workdir: meson.current_build_dir() / '..' / '..',
protocol: 'tap',
suite: ['fuzzing'],
timeout: 120,
)
i += 1
endforeach
endif
if not get_option('vector').disabled()
i = 0
foreach chunk : fonts_glob_chunks
test('vector-fuzzer-chunk-@0@'.format(i),
hb_vector_fuzzer_exe,
args: chunk,
workdir: meson.current_build_dir() / '..' / '..',
protocol: 'tap',
suite: ['fuzzing'],
timeout: 120,
)
i += 1
endforeach
endif
if not get_option('gpu').disabled()
i = 0
foreach chunk : fonts_glob_chunks
test('gpu-fuzzer-chunk-@0@'.format(i),
hb_gpu_fuzzer_exe,
args: chunk,
workdir: meson.current_build_dir() / '..' / '..',
protocol: 'tap',
suite: ['fuzzing'],
timeout: 120,
)
i += 1
endforeach
endif
if not get_option('subset').disabled()
i = 0
foreach chunk : fonts_glob_chunks + subset_fonts_glob_chunks
test('subset-fuzzer-chunk-@0@'.format(i),
hb_subset_fuzzer_exe,
args: chunk,
workdir: meson.current_build_dir() / '..' / '..',
protocol: 'tap',
suite: ['fuzzing'],
timeout: 120,
)
i += 1
endforeach
endif
if not get_option('subset').disabled()
i = 0
foreach chunk : graphs_glob_chunks
test('repacker-fuzzer-chunk-@0@'.format(i),
hb_repacker_fuzzer_exe,
args: chunk,
workdir: meson.current_build_dir() / '..' / '..',
protocol: 'tap',
suite: ['fuzzing'],
timeout: 120,
)
i += 1
endforeach
endif
if conf.get('HB_EXPERIMENTAL_API', 0) == 1
if conf.get('HAVE_GLIB', 0) == 1
i = 0
foreach chunk : depend_closure_parity_fonts_glob_chunks
test('depend-closure-parity-chunk-@0@'.format(i),
hb_depend_closure_parity_exe,
args: ['-s', '42', '-n', '16'] + chunk,
workdir: meson.current_build_dir() / '..' / '..',
protocol: 'tap',
suite: ['fuzzing'],
timeout: 120,
)
i += 1
endforeach
endif
i = 0
foreach chunk : fonts_glob_chunks
test('depend-fuzzer-chunk-@0@'.format(i),
hb_depend_fuzzer_exe,
args: chunk,
workdir: meson.current_build_dir() / '..' / '..',
protocol: 'tap',
suite: ['fuzzing'],
timeout: 120,
)
i += 1
endforeach
endif