Chain::compile_flags() resolved every type-39 (language tag) feature record by interning the font's ltag string with hb_language_from_string(), whose process-wide language list is a linear, never-freed linked list meant for the handful of languages an application passes in. A font controls both the number of records and the number of distinct tags, so shape-plan creation became quadratic (about a minute for a 125 KB font) and the tags stayed in the list for the life of the process. Add ltag::matches_language(i, specific), which compares the tag bytes directly against the buffer language, applying the same canonicalization hb_language_from_string() does (at most 63 bytes, lowercase, '_' to '-', stop at the first other non-alphanumeric) and the same prefix rule as hb_language_matches(); each record now costs at most the length of the buffer's language and nothing is added to the global list. get_language() is kept for the name table, which genuinely needs an hb_language_t. Behaviour is unchanged for every real tag; only a degenerate tag with no valid leading byte, which used to become the empty/invalid language, now matches nothing. Adds a regression font to the in-house aat-morx tests whose type-39 features gate substitutions by tags 'sr' and 'Zh_Hant', exercising case folding, '_' canonicalization, subtag prefix matching and non-matches. Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-KYZIZMO6. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Adding tests
You can test shaping of a unicode sequence against a font like this:
$ ./hb-unicode-encode 41 42 43 627 | ../../util/hb-shape font.ttf
assuming an in-tree build. The 41 42 43 627 here is a sequence of
Unicode codepoints: U+0041,0042,0043,0627. When you are happy with
the shape results, you can use the record-test.sh script to add
this to the test suite. record-test.sh requires pyftsubset to
be installed. You can get pyftsubset by installing
FontTools from https://github.com/behdad/fonttools.
To use record-test.sh, just put it right before the hb-shape invocation:
$ ./hb-unicode-encode 41 42 43 627 | ./record-test.sh ../../util/hb-shape font.ttf
hb-subset and hb-view are resolved as sibling executables next to the
provided hb-shape binary.
what this does is:
- Subset the font for the sequence of Unicode characters requested,
- Compare the
hb-shapeoutput of the original font versus the subset font for the input sequence, - If the outputs differ, perhaps it is because the font does not have
glyph names; it then compares the output of
hb-viewfor both fonts. - If the outputs differ, recording fails. Otherwise, it will move the
subset font file into
data/in-house/fontsand name it after its hash, and print out the test case input, which you can then redirect to an existing or new test file indata/in-house/testsusing-o, e.g.:
$ ./hb-unicode-encode 41 42 43 627 | ./record-test.sh -o data/in-house/tests/test-name.tests ../../util/hb-shape font.ttf
If you created a new test file, add it to data/in-house/meson.build
so it is run. Check that make check does indeed run it, and that the
test passes. When everything looks good, git add the new font as well
as the new test file if you created any. You can see what new files are
there by running git status data/in-house. And commit!
Note! Please only add tests using Open Source fonts, preferably under OFL or similar license.