mirror of
https://github.com/storytold/harfbuzz.git
synced 2026-11-19 22:11:04 +01:00
* [instancer] Don't dedup VarStore rows when not optimizing as_item_varstore dropped duplicate delta rows even with optimize=false, where varidx_map is left empty and callers rely on original VariationIndex values staying valid. HVAR/VVAR subsetting uses that mode when the source table has an implicit (map-less) advance mapping: any two glyphs sharing identical deltas shifted every following row, so the synthesized identity map pointed at wrong rows and past the end of the VarData — advances silently froze or took neighbors' deltas when partially instancing such fonts (e.g. Source Han fonts). Fixes https://github.com/harfbuzz/harfbuzz/issues/6068 * [subset] Drop identity advance maps for map-less HVAR/VVAR sources When the source table uses implicit glyph-id indexing, the subsetter synthesized an advance DeltaSetIndexMap whose content was the identity over every output glyph — equivalent to the implicit indexing it replaced, just bigger. Recognize that case in is_identity () and keep the output map-less, like fontTools does. Sources that carry a real map keep one, preserving their form; truncated maps don't qualify since glyphs past their end share the last value. retain-num-glyphs expected files regenerated: NotoSansJP-VF.subset.otf is map-less, and its redundant identity map is now dropped (verified against fontTools output). * [test/subset] Test partial instancing of map-less HVAR ImplicitHVAR.ttf carries an HVAR with implicit (map-less) advance indexing and deliberately duplicated delta rows, the combination that broke before the row-dedup fix: rows shifted or fell off the end of the rebuilt VarData and advances silently froze. Expected outputs are cross-checked against fontTools varLib.instancer + subset.
14 lines
105 B
Plaintext
14 lines
105 B
Plaintext
FONTS:
|
|
ImplicitHVAR.ttf
|
|
|
|
PROFILES:
|
|
default.txt
|
|
|
|
SUBSETS:
|
|
*
|
|
ABC
|
|
|
|
INSTANCES:
|
|
wght=300:600
|
|
wght=200:400:800
|