hb_ot_metrics_get_position_with_fallback() and
hb_ot_layout_get_font_extents() / ...2() document their result pointer
as optional ((out) (optional) / (out) (nullable)), and one path in each
honours that, but the others dereference it: the metrics fallback reads
*position for the strikeout/underline zero check and writes it in every
synthesized arm, and the layout miss path hands the pointer unchecked to
hb_font_get_extents_for_direction(), which memsets it.
Substitute a stack local at function entry with the existing
`if (!p) p = &local;` idiom (cf. hb-paint.cc), so every path below is
unchanged, and drop the now-redundant `if (extents)` guard. ...2() is
covered through its callee. The prototype comment becomes
`/* OUT. May be NULL. */` to match hb_ot_metrics_get_position(). No
API/ABI change.
Regression cases are added to test/api/test-ot-metrics.c and
test/api/test-base-minmax.c.
Reported by Anthropic's OSS Scanner as ordinary bug ANT-2026-Y1S3T3RY.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>