Files
harfbuzz/test/api
Behdad EsfahbodandClaude Opus 4.8 507575fd82 [metrics][layout] Accept NULL out-pointer where the docs allow it
hb_ot_metrics_get_position_with_fallback() and
hb_ot_layout_get_font_extents() / ...2() document their result pointer
as optional ((out) (optional) / (out) (nullable)), and one path in each
honours that, but the others dereference it: the metrics fallback reads
*position for the strikeout/underline zero check and writes it in every
synthesized arm, and the layout miss path hands the pointer unchecked to
hb_font_get_extents_for_direction(), which memsets it.

Substitute a stack local at function entry with the existing
`if (!p) p = &local;` idiom (cf. hb-paint.cc), so every path below is
unchanged, and drop the now-redundant `if (extents)` guard.  ...2() is
covered through its callee.  The prototype comment becomes
`/* OUT.  May be NULL. */` to match hb_ot_metrics_get_position().  No
API/ABI change.

Regression cases are added to test/api/test-ot-metrics.c and
test/api/test-base-minmax.c.

Reported by Anthropic's OSS Scanner as ordinary bug ANT-2026-Y1S3T3RY.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-10-30 16:35:27 -06:00
..
2025-04-06 18:08:50 -06:00
2026-07-30 19:02:25 -06:00
2026-09-04 14:14:49 -06:00
2026-07-31 04:31:26 +03:00
2025-04-05 22:37:10 -06:00
2020-01-31 16:37:30 -05:00
2020-01-15 13:36:01 -08:00
2025-06-08 13:43:27 +03:00