mirror of
https://github.com/storytold/harfbuzz.git
synced 2026-11-19 14:01:10 +01:00
* [util] Fix Unicode command line arguments on Windows GLib g_option_context_parse() converts argv strings from the system ACP via g_locale_to_utf8(), but Windows cmd deliver arguments encoded in the system codepage (ex: CP1252), which cannot represent most Unicode codepoints. This caused non ascii character to be corrupted For example, for this command, it rendered garbage instead of the emoji: ``` hb-view.exe "C:\Windows\Fonts\seguiemj.ttf" "😋" --output-file=output.png ``` Fix this in all util binaries (hb-ft-raster, hb-info, hb-raster, hb-shape, hb-subset, hb-vector, hb-view) by: 1. Calling g_win32_get_command_line() to obtain correctly UTF-8-encoded arguments from GetCommandLineW(). 2. Parsing with g_option_context_parse_strv() which skips the g_locale_to_utf8() conversion for G_OPTION_ARG_STRING entries. 3. Adding G_OPTION_FLAG_FILENAME to the G_OPTION_REMAINING callback entry in main-font-text.hh, so the callback path also skips the locale conversion in strv_mode (see https://gitlab.gnome.org/GNOME/glib/-/blob/8ef2f3ad402daf9fb94615ddef63ceef978fd76f/glib/goption.c#L1305). * [util] Fix Windows UTF-8 argv parsing On Windows, GLib's option parser treats argv as encoded in the system codepage and converts strings with g_locale_to_utf8(). The utilities need to parse the UTF-8 command line obtained from GetCommandLineW() instead, otherwise non-ASCII arguments can be corrupted before reaching the tool logic. Add a small argv_t wrapper for utility entry points to replace argv with g_win32_get_command_line() on Windows, and use the strv parser there so GLib skips the top-level argv conversion. Mark remaining callback arguments as filenames so GLib also skips callback argument conversion for positional text and font arguments. Testing: meson test -C build Assisted-by: OpenAI Codex * [mingw] Update instructions --------- Co-authored-by: moi15moi <moi15moismokerlolilol@gmail.com>