hb_accelerate_subtables_context_t::dispatch() filled accelerator entries with a counter that advanced only for the subtable types ChainSubtable::dispatch() knows, while Chain::apply() reads entries by subtable position. A subtable of a reserved type (3, or 6 and up), which the sanitizer accepts and apply() steps over, shifts every later entry down by one, so each later subtable is gated by the wrong glyph set and the last one gets a zeroed entry and is never applied. Output then depends on where the unknown subtable sits in the chain. Add Chain::accelerate(), the same walk Chain::dispatch() does but setting the context's index to the subtable position before each dispatch, and stop the context's dispatch() from advancing the index itself; create() calls accelerate() instead of dispatch(). Unknown- type subtables keep a zeroed entry, which is what the calloc in create() already relies on, and apply() does nothing for them anyway. mort shares Chain/ChainSubtable so it is fixed too; the kerx accelerator already fills one entry per subtable and is untouched. Adds a regression font with subtables [reserved, 1->2, 3->1] to the in-house aat-morx shape tests. Reported by Anthropic's OSS Scanner as ordinary bug ANT-2026-OIN1GIHX. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Adding tests
You can test shaping of a unicode sequence against a font like this:
$ ./hb-unicode-encode 41 42 43 627 | ../../util/hb-shape font.ttf
assuming an in-tree build. The 41 42 43 627 here is a sequence of
Unicode codepoints: U+0041,0042,0043,0627. When you are happy with
the shape results, you can use the record-test.sh script to add
this to the test suite. record-test.sh requires pyftsubset to
be installed. You can get pyftsubset by installing
FontTools from https://github.com/behdad/fonttools.
To use record-test.sh, just put it right before the hb-shape invocation:
$ ./hb-unicode-encode 41 42 43 627 | ./record-test.sh ../../util/hb-shape font.ttf
hb-subset and hb-view are resolved as sibling executables next to the
provided hb-shape binary.
what this does is:
- Subset the font for the sequence of Unicode characters requested,
- Compare the
hb-shapeoutput of the original font versus the subset font for the input sequence, - If the outputs differ, perhaps it is because the font does not have
glyph names; it then compares the output of
hb-viewfor both fonts. - If the outputs differ, recording fails. Otherwise, it will move the
subset font file into
data/in-house/fontsand name it after its hash, and print out the test case input, which you can then redirect to an existing or new test file indata/in-house/testsusing-o, e.g.:
$ ./hb-unicode-encode 41 42 43 627 | ./record-test.sh -o data/in-house/tests/test-name.tests ../../util/hb-shape font.ttf
If you created a new test file, add it to data/in-house/meson.build
so it is run. Check that make check does indeed run it, and that the
test passes. When everything looks good, git add the new font as well
as the new test file if you created any. You can see what new files are
there by running git status data/in-house. And commit!
Note! Please only add tests using Open Source fonts, preferably under OFL or similar license.