* Don't divide by zero interpolating duplicate trak tracks TrackData::get_tracking() brackets the requested track value (always 0 when shaping) between entries i and j and interpolates with (track - t0) / (t1 - t0). The bracketing scan doesn't assume the entries are sorted or distinct, so two entries that both have track value 0.0 end with i = 1, j = 0. That skips the exact-match return and computes 0/0. The NaN reaches hb_font_t::em_multf(), where the cast to hb_position_t is undefined (UBSan float-cast-overflow at hb-font.hh:1167); in practice the advance becomes INT_MIN on x86 and the tracking is dropped on arm64. Sanitize accepts such a table, so any font with STAT plus this trak reaches it from hb_shape(); the CoreText font funcs call the same getter. Handle t0 == t1 the way TrackTableEntry::interpolate_at() already handles equal sizes, by averaging the two values. Added a 108-byte font to the aat-trak shape tests. It fails without the fix and passes with it. meson test passes on an ASan+UBSan debug build. Assisted-by: Claude * [aat] Pin duplicate-trak test to ot font funcs The 108-byte test font only carries STAT and trak, with no head, hhea or hmtx. The ot font funcs give each glyph a 500 advance, but FreeType reports 1000 and DirectWrite refuses to load the font, so the ft and directwrite runs of the test disagreed with the expected output. The test only needs to exercise the trak interpolation, so pin it to --font-funcs=ot like other minimal-font tests. Tested with meson test -C build; the shape suites pass with FreeType enabled. Assisted-by: Claude
Adding tests
You can test shaping of a unicode sequence against a font like this:
$ ./hb-unicode-encode 41 42 43 627 | ../../util/hb-shape font.ttf
assuming an in-tree build. The 41 42 43 627 here is a sequence of
Unicode codepoints: U+0041,0042,0043,0627. When you are happy with
the shape results, you can use the record-test.sh script to add
this to the test suite. record-test.sh requires pyftsubset to
be installed. You can get pyftsubset by installing
FontTools from https://github.com/behdad/fonttools.
To use record-test.sh, just put it right before the hb-shape invocation:
$ ./hb-unicode-encode 41 42 43 627 | ./record-test.sh ../../util/hb-shape font.ttf
hb-subset and hb-view are resolved as sibling executables next to the
provided hb-shape binary.
what this does is:
- Subset the font for the sequence of Unicode characters requested,
- Compare the
hb-shapeoutput of the original font versus the subset font for the input sequence, - If the outputs differ, perhaps it is because the font does not have
glyph names; it then compares the output of
hb-viewfor both fonts. - If the outputs differ, recording fails. Otherwise, it will move the
subset font file into
data/in-house/fontsand name it after its hash, and print out the test case input, which you can then redirect to an existing or new test file indata/in-house/testsusing-o, e.g.:
$ ./hb-unicode-encode 41 42 43 627 | ./record-test.sh -o data/in-house/tests/test-name.tests ../../util/hb-shape font.ttf
If you created a new test file, add it to data/in-house/meson.build
so it is run. Check that make check does indeed run it, and that the
test passes. When everything looks good, git add the new font as well
as the new test file if you created any. You can see what new files are
there by running git status data/in-house. And commit!
Note! Please only add tests using Open Source fonts, preferably under OFL or similar license.