mirror of
https://github.com/storytold/harfbuzz.git
synced 2026-11-20 14:31:10 +01:00
get_base_glyph_paintrecord() looked up the BaseGlyphList with the reference-returning bsearch(), which yields the all-zero Null object when the glyph is absent, and then rejected non-matches by comparing record->glyphId against the requested gid. For glyph 0 the Null object's glyphId (0) equals the requested gid, so the sentinel was taken for a real record. .notdef then resolved to a bogus empty paint, and COLR::get_extents() returned success with 0,0,0,0 instead of letting hb_ot_get_glyph_extents() fall back to the glyf outline. Use bfind(), which reports presence directly, so a missing glyph (including glyph 0) returns nullptr and extents fall back correctly. This surfaced as a mark-positioning difference: fallback mark positioning centers a mark using the base and mark glyph extents, so a .notdef mark over a space was positioned differently from shapers that report the real outline extents (e.g. fontations/HarfRust). Testing: - test/api/test-extents.c: glyph 0 (.notdef, has an outline) now reports its outline extents; updated the expectation accordingly. - b/util/hb-shape Noto-COLRv1.ttf -u 0020,0650 now matches --font-funcs=fontations. - meson test -C build (246 passed, 1 skipped) Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>