mirror of
https://github.com/storytold/harfbuzz.git
synced 2026-11-20 06:21:16 +01:00
CmapSubtableFormat4::accelerator_t::collect_unicodes() and collect_mapping() trusted the format's invariant that segments are sorted and disjoint, so a subtable whose 32766 segments all cover U+0000..U+FFFE was walked once per segment: ~2.1 billion insertions (about 30 s of CPU) for a single hb_subset() or hb_face_collect_nominal_glyph_mapping() call on a 262 KB font. Both walkers now keep a cursor `next` past the last collected code point and clamp each segment's start to it, skipping segments that end before the cursor. Total work per subtable is therefore at most 65536 code points plus one step per segment, mirroring the ordering guard CmapSubtableLongSegmented::collect_mapping() already has for formats 12/13. The glyphIdArray index is still computed from the raw startCount[i], so range-offset segments map exactly as before, and get_glyph() is untouched. Behaviour changes only for malformed subtables: where sorted segments overlap the earlier segment now wins the shared code points, and a segment lying wholly inside an earlier one is ignored. Adds test_collect_unicodes_format4_overlapping_segments to test/api/test-collect-unicodes.c. Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-GV7L48CF. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>