Files
harfbuzz/test/api/test-extents.c
T
Behdad EsfahbodandClaude Opus 4.8 d639197ed5 [COLR] Fix glyph extents for .notdef in COLRv1 fonts (#6012)
get_base_glyph_paintrecord() looked up the BaseGlyphList with the
reference-returning bsearch(), which yields the all-zero Null object
when the glyph is absent, and then rejected non-matches by comparing
record->glyphId against the requested gid. For glyph 0 the Null
object's glyphId (0) equals the requested gid, so the sentinel was
taken for a real record. .notdef then resolved to a bogus empty paint,
and COLR::get_extents() returned success with 0,0,0,0 instead of
letting hb_ot_get_glyph_extents() fall back to the glyf outline.

Use bfind(), which reports presence directly, so a missing glyph
(including glyph 0) returns nullptr and extents fall back correctly.

This surfaced as a mark-positioning difference: fallback mark
positioning centers a mark using the base and mark glyph extents, so a
.notdef mark over a space was positioned differently from shapers that
report the real outline extents (e.g. fontations/HarfRust).

Testing:
- test/api/test-extents.c: glyph 0 (.notdef, has an outline) now
  reports its outline extents; updated the expectation accordingly.
- b/util/hb-shape Noto-COLRv1.ttf -u 0020,0650 now matches
  --font-funcs=fontations.
- meson test -C build  (246 passed, 1 skipped)

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-01 03:23:05 -06:00

135 lines
4.2 KiB
C

/*
* Copyright © 2023 Red Hat, Inc.
*
* This is part of HarfBuzz, a text shaping library.
*
* Permission is hereby granted, without written agreement and without
* license or royalty fees, to use, copy, modify, and distribute this
* software and its documentation for any purpose, provided that the
* above copyright notice and the following two paragraphs appear in
* all copies of this software.
*
* IN NO EVENT SHALL THE COPYRIGHT HOLDER BE LIABLE TO ANY PARTY FOR
* DIRECT, INDIRECT, SPECIAL, INCIDENTAL, OR CONSEQUENTIAL DAMAGES
* ARISING OUT OF THE USE OF THIS SOFTWARE AND ITS DOCUMENTATION, EVEN
* IF THE COPYRIGHT HOLDER HAS BEEN ADVISED OF THE POSSIBILITY OF SUCH
* DAMAGE.
*
* THE COPYRIGHT HOLDER SPECIFICALLY DISCLAIMS ANY WARRANTIES, INCLUDING,
* BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND
* FITNESS FOR A PARTICULAR PURPOSE. THE SOFTWARE PROVIDED HEREUNDER IS
* ON AN "AS IS" BASIS, AND THE COPYRIGHT HOLDER HAS NO OBLIGATION TO
* PROVIDE MAINTENANCE, SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS.
*
* Author(s): Matthias Clasen
*/
#include "hb-test.h"
static void
test_glyph_extents_color_v1 (void)
{
hb_face_t *face;
hb_font_t *font;
hb_glyph_extents_t extents;
hb_bool_t ret;
/* This font contains COLRv1 glyphs with a ClipBox, as well as plain
* glyphs with no COLR paint. Extents resolve from COLR when the glyph
* has a paint, and otherwise fall back to the glyph outline. So glyph 0
* (.notdef), which has an outline, reports its outline extents, while
* the empty glyph 1 (.space) reports 0,0,0,0.
*/
face = hb_test_open_font_file ("fonts/adwaita.ttf");
font = hb_font_create (face);
ret = hb_font_get_glyph_extents (font, 0, &extents);
g_assert_true (ret);
g_assert_true (extents.x_bearing == 51 &&
extents.y_bearing == 950 &&
extents.width == 410 &&
extents.height == -1200);
ret = hb_font_get_glyph_extents (font, 1, &extents);
g_assert_true (ret);
g_assert_true (extents.x_bearing == 0 &&
extents.y_bearing == 0 &&
extents.width == 0 &&
extents.height == 0);
ret = hb_font_get_glyph_extents (font, 2, &extents);
g_assert_true (ret);
g_assert_true (extents.x_bearing == 180 &&
extents.y_bearing == 960 &&
extents.width == 1060 &&
extents.height == -1220);
ret = hb_font_get_glyph_extents (font, 3, &extents);
g_assert_true (ret);
g_assert_true (extents.x_bearing == 188 &&
extents.y_bearing == 950 &&
extents.width == 900 &&
extents.height == -1200);
ret = hb_font_get_glyph_extents (font, 4, &extents);
g_assert_true (ret);
g_assert_true (extents.x_bearing == 413 &&
extents.y_bearing == 50 &&
extents.width == 150 &&
extents.height == -75);
ret = hb_font_get_glyph_extents (font, 5, &extents);
g_assert_true (ret);
g_assert_true (extents.x_bearing == 638 &&
extents.y_bearing == 350 &&
extents.width == 600 &&
extents.height == -600);
ret = hb_font_get_glyph_extents (font, 1000, &extents);
g_assert_false (ret);
hb_font_destroy (font);
hb_face_destroy (face);
}
static void
test_glyph_extents_color_v0 (void)
{
hb_face_t *face;
hb_font_t *font;
hb_glyph_extents_t extents;
hb_bool_t ret;
/*
* This font contains a COLRv0 glyph with an empty default glyph
* to make sure we are getting extents from the COLRv0 layers.
*/
face = hb_test_open_font_file ("fonts/COLRv0.extents.ttf");
font = hb_font_create (face);
ret = hb_font_get_glyph_extents (font, 13, &extents);
g_assert_true (ret);
g_assert_true (extents.x_bearing == 192 &&
extents.y_bearing == 573 &&
extents.width == 731 &&
extents.height == -758);
hb_font_destroy (font);
hb_face_destroy (face);
}
int
main (int argc, char **argv)
{
hb_test_init (&argc, &argv);
hb_test_add (test_glyph_extents_color_v1);
hb_test_add (test_glyph_extents_color_v0);
return hb_test_run();
}