Files
harfbuzz/test/shape/data
Behdad EsfahbodandClaude Opus 4.8 c5d3fdda16 [glyf] In phantom-only get_points, descend only into the last USE_MY_METRICS component
Glyph::get_points(phantom_only=true) is the path hb-ot-font uses for
advances and vertical origins of a gvar font without HVAR/VVAR.  It recursed
into every USE_MY_METRICS component although each one overwrites the phantoms
copied from the previous one, so only the last surviving one can influence the
result; a composite that sets the flag on many components could thus cost
nearly a whole HB_BUDGET_GLYPH per advance lookup, and a small font could reach
the same per-character cost that previously needed a megabyte-sized one.

Add a cheap pre-pass over the component records (bounded by the same count the
offset-collecting loop already charges) that picks the last flagged component
the decycler would accept, and descend only into it.  Components that are not
descended into now continue before the post-child bookkeeping; this also
removes a latent wrong-advance bug where the unconditional
all_points.resize (length - PHANTOM_COUNT) for a skipped component ate entries
pushed by earlier siblings, making the parent's phantom copy read out of range
and return advance 0.

Non-phantom-only traversal (drawing, extents, subsetting) is unchanged:
copy_metrics reduces to the old condition and the new continue is never taken.
The one behavioural difference in phantom-only mode is that a traversal failure
(nesting, edge count, budget) inside a flagged subtree that is no longer visited
no longer fails the whole lookup.

Reported by Anthropic's OSS Scanner as ordinary bug ANT-2026-DQGMHCLX.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-10-31 21:59:50 -06:00
..