mirror of
https://github.com/storytold/harfbuzz.git
synced 2026-11-19 14:01:10 +01:00
* [fontations] Fix OOB write on glyph-name callback with size == 0 The Rust `_hb_fontations_glyph_name()` callback computed `glyph_name.len().min(size as usize - 1)`. When a caller passed `size == 0`, `size as usize - 1` underflowed a `usize` to `usize::MAX`, the `min()` clamp collapsed to `glyph_name.len()`, and the subsequent `copy_nonoverlapping` / trailing NUL wrote `glyph_name.len() + 1` bytes into a zero-capacity caller buffer. This is an out-of-bounds write reachable from the public API whenever the build was configured with `-Dfontations=enabled` and the application had called `hb_fontations_font_set_funcs()`. Short-circuit the `size == 0` case before the subtraction. Return `true` in that case to match the existing post and CFF1 backends (`hb-ot-post-table.hh`, `hb-ot-cff1-table.hh`), which both early-out with `return true` on `!buf_len` — the glyph does have a name; we simply had no buffer to write it into. Regression tests added in `test/api/test-glyph-names.c` cover the zero-size path on post and CFF1 backends, a sub-font, a NULL buffer, and `size == 1` / small-buffer / exact-fit cases so the truncation path does not silently regress. Fixes: https://github.com/harfbuzz/harfbuzz/issues/5946 Assisted-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * [font] Reject glyph-name lookups with size == 0 at the wrapper `hb_font_t::get_glyph_name()` previously pre-wrote the trailing NUL only when `size != 0` but still dispatched to the backend callback with `size == 0`. Every current glyph-name backend has to re-validate that argument: `post` and `cff1` short-circuit with `return true`, the new Rust `fontations` callback now short-circuits too (prior commit), and the CoreText callback in `hb-coretext-font.cc` has a structurally similar `(CFIndex)size - 1` pattern. Normalize this at the wrapper layer: return `false` immediately on `size == 0`, before any backend dispatch and before the `*name = '\0'` write. This makes the zero-size case a single, auditable no-op for every glyph-name provider (native or Rust, current or future) and removes the CoreText underflow from the reachable surface through the same chokepoint. Observable change: callers that invoked `hb_font_get_glyph_name(font, gid, buf, 0)` on post/cff1 backed fonts used to get `true` back; they now get `false`. `size == 0` queries carry no useful information for the caller, so this is considered a safe hardening rather than a contract break. Assisted-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * [font] Preserve glyph-name zero-size probe semantics Keep `hb_font_get_glyph_name(..., NULL, 0)` as a valid return-value-only probe instead of rejecting `size == 0` in the wrapper. Fix the remaining backend-specific zero-size paths in hb-ft and hb-coretext-font so they answer the probe without dereferencing the caller buffer, and update the API tests to assert the preserved behavior. Testing: CCACHE_DISABLE=1 meson test -C build test-glyph-names Testing: CCACHE_DISABLE=1 meson test -C build test-ft Assisted-by: OpenAI Codex <codex@openai.com> --------- Co-authored-by: jeffhuang <jeff@docker.xydrsucermoubd24xgo33yhsgd.bx.internal.cloudapp.net>