From f421d10b3fbfaf199f2c58c1fe3c19f503230111 Mon Sep 17 00:00:00 2001 From: Belligerently Date: Wed, 4 Nov 2026 20:18:15 -0500 Subject: [PATCH] Recognize Histogram Scan and Auto Levels SBS aliases --- crates/formats/src/sbs.rs | 19 +++- crates/formats/tests/sbs_library_aliases.rs | 117 ++++++++++++++++++++ 2 files changed, 133 insertions(+), 3 deletions(-) create mode 100644 crates/formats/tests/sbs_library_aliases.rs diff --git a/crates/formats/src/sbs.rs b/crates/formats/src/sbs.rs index 5beb820..ff6431b 100644 --- a/crates/formats/src/sbs.rs +++ b/crates/formats/src/sbs.rs @@ -1074,8 +1074,13 @@ impl<'text> Reader<'text, '_> { if let Some(node) = node { for param in instance_params() { let param_name = child_value(param, "name").unwrap_or(""); - match def.param(param_name) { - Some(param_def) => self.set_param(node, param_name, ¶m_def.default, param_def.options.len(), param, &graph_name), + let id = match (def.id, param_name) { + ("histogram_scan", "Position") => "position", + ("histogram_scan", "Contrast") => "contrast", + _ => param_name, + }; + match def.param(id) { + Some(param_def) => self.set_param(node, id, ¶m_def.default, param_def.options.len(), param, &graph_name), None => self.warnings.add(format!("`{}`: parameter `{param_name}` has no MaterialCraft equivalent and was ignored", def.id)), } } @@ -1086,7 +1091,15 @@ impl<'text> Reader<'text, '_> { let port_for = |identifier: &str| if def.output_index(identifier).is_some() { identifier.to_string() } else { first_output.clone() }; let unbridged = output_uids.iter().filter(|(uid, _)| !bridgings.iter().any(|(b, _)| b == uid)).map(|(uid, _)| (uid.clone(), first_output.clone())); let outputs = bridgings.iter().map(|(uid, identifier)| (uid.clone(), port_for(identifier))).chain(unbridged).collect(); - let inputs = def.inputs.iter().map(|p| (p.id.to_string(), p.id.to_string())).collect(); + let mut inputs: HashMap<_, _> = def.inputs.iter().map(|p| (p.id.to_string(), p.id.to_string())).collect(); + let input_alias = match def.id { + "histogram_scan" => Some("Input_1"), + "auto_levels" => Some("Input"), + _ => None, + }; + if let Some(alias) = input_alias { + inputs.insert(alias.to_string(), "input".to_string()); + } ReadNode { id, index, inputs, outputs, open_inputs: false } } diff --git a/crates/formats/tests/sbs_library_aliases.rs b/crates/formats/tests/sbs_library_aliases.rs new file mode 100644 index 0000000..a90a104 --- /dev/null +++ b/crates/formats/tests/sbs_library_aliases.rs @@ -0,0 +1,117 @@ +//! The reported library-node aliases must preserve imported settings and connections. +use materialcraft_core::{Graph, Package, Value}; +use materialcraft_formats::sbs::{read_sbs, write_sbs}; + +fn plain_xml(bytes: &[u8]) -> String { + let text = String::from_utf8(bytes.to_vec()).unwrap(); + // Exercise XML import rather than the writer's embedded exact native-package copy. + format!("{}", text.split("