Commit Graph
52 Commits
Author SHA1 Message Date
chasse20 85e0bf9247 Add parameter-owned function graphs 2026-11-10 04:07:54 -05:00
chasse20 bc2f20b365 Fix library review, graph annotations and processor sampling 2026-11-09 23:59:27 -05:00
PiJellyPin 7ec846cf27 Fixed Library UI 2026-11-10 02:51:07 +01:00
PiJellyPin 9290c2d906 Listing all nodes from custom functions.sbs
also fixed library ui with categories
2026-11-10 00:52:05 +01:00
chasse20 54ab0fc877 Remove package and import limits 2026-11-09 00:01:56 -05:00
chasse20 49e99948d9 Fix package round trips 2026-11-08 23:31:17 -05:00
chasse20 fc4cde095f Complete Explorer resources and SBS folder attributes 2026-11-08 22:45:22 -05:00
chasse20 cc052aeaa8 Support SBS resources and independent MCRAFT packages 2026-11-08 22:10:35 -05:00
chasse20 158e1c85e3 Fix graph editing and make undo configurable 2026-11-08 18:11:10 -05:00
chasse20 a0032d6ac2 Add SBS function library and Explorer graph editing 2026-11-08 17:25:08 -05:00
chasse20 570bc528a6 Add linked graph instances 2026-11-07 18:23:51 -05:00
chasse20 8101e8da68 Refine graph outputs and Explorer 2026-11-07 17:00:36 -05:00
chasse20 b99ca7f361 Improve function editing and link swaps 2026-11-07 15:49:40 -05:00
eliets2 af2893e4ed Address review findings 2026-11-07 11:36:01 +02:00
eliets2 2a7ce968a6 Address remaining review requests 2026-11-07 11:17:08 +02:00
eliets2 d7878b30de Repair review branch integration 2026-11-07 10:49:50 +02:00
eliets2 611e2c690b Address review for pull request 142 2026-11-07 08:39:10 +02:00
eliets2 98af9a3dfd Address review findings 2026-11-07 08:39:10 +02:00
eliets2 4b6c02a83f Address remaining review requests 2026-11-07 08:39:10 +02:00
eliets2 c2e4b20cb0 Bound mesh vertex memory before collecting positions
Loading a mesh should fail with a package error instead of allocating unbounded vertex buffers first, matching the existing triangle limit intent.

Add a vertex-count bound checked while parsing OBJ and glTF positions so excess vertices are rejected before the full mesh is collected, with a regression test using an OBJ whose vertex count exceeds the bound but whose triangle count does not.

Test: obj_with_excess_vertices_is_rejected failed before the change and passes after.
2026-11-07 08:39:10 +02:00
c479765c01 Reject non-finite glTF normals before normalizing them (#114)
A glTF file with NaN or infinite normals currently loads as a mesh with zero normals instead of being rejected like non-finite positions, UVs and OBJ normals.

Check raw glTF normals for finiteness before transforming them and return an error for non-finite values, matching the existing finish() checks.

Test: gltf_non_finite_normals_are_rejected failed before the change and passes after.

Co-authored-by: eliets2 <287273517+eliets2@users.noreply.github.com>
Co-authored-by: FredApps <153173854+FredApps@users.noreply.github.com>
2026-11-06 10:10:27 +01:00
chasse20 2adbdf4aab Merge main while preserving native graph architecture 2026-11-06 00:58:56 -05:00
chasse20 fe88ee5c4d Unify graph editors and optimize material workflows 2026-11-06 00:13:10 -05:00
chasse20 d318484b41 Checkpoint native SBS primitive workflow
Replace the legacy Rust procedural library with clean-room native primitives, typed function execution and FX-Map graphs. Save supported content as native SBS and organize the model, evaluators, codecs and editors into focused modules.

Add shared graph editing behavior, flat filtered node menus, frame and comment editing, named Explorer outputs and an original atomic sample. Document the tested scope and remaining interoperability work.
2026-11-05 18:23:06 -05:00
FredApps 56407b9470 Revert the batch rollback and restore prior main 2026-11-05 22:04:58 +01:00
Rafael Mendes a7b9194820 Revert reviewed PR batch and cancel 0.1.3 preparation
Restore tracked files to 91bb53f07a, immediately before the batch, at the maintainer request. Preserve the existing history and earlier work, including PR #38. Revert the 50 reviewed PR merges and the version bump in 441092c. The published 0.1.2 release is unchanged.
2026-11-05 17:48:14 -03:00
Rafael Mendes 9fa360bb69 Preserve decoder bounds and create atomic save files exclusively 2026-11-05 15:25:17 -03:00
Rafael Mendes f1cd7f4387 Stream mesh indices and stop before exceeding the triangle budget 2026-11-05 15:22:47 -03:00
Rafael Mendes 3fa7540b61 Merge remote-tracking branch 'review/latest87' into review/pr-87 2026-11-05 15:21:45 -03:00
Rafael Mendes cc9a5b3c82 Keep bitmap color-space requests unambiguous and inspectable 2026-11-05 15:19:39 -03:00
Rafael Mendes 30621629e8 Preserve shared package resources and enforce read and write size budgets 2026-11-05 15:17:30 -03:00
SteamSmithandClaude Sonnet 5.5 47b69c0f3a chore(merge): bring fix/bitmap-colour-space up to date with main
Upstream's ResourceBytes and decode limits kept; decode keeps the linear flag, and the
decoded-image memo is now keyed by (content hash, linear) so sRGB and data reads of the
same file don't collide.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-05 12:10:10 -05:00
Rafael Mendes 99f2932c09 Merge branch 'fix/18-sbs-parameter-functions' of https://github.com/storytold/materialcraft into review/pr-70 2026-11-05 14:09:26 -03:00
Rafael Mendes ccb68a13f4 Merge pull request #64 from Belligerently/fix/sbs-library-node-aliases
Recognize reported SBS aliases for four library nodes
2026-11-05 12:20:32 -03:00
Rafael Mendes be02ec236c Merge branch 'fix/sbs-library-node-aliases' of https://github.com/Belligerently/materialcraft into review/pr-64 2026-11-05 12:19:28 -03:00
Simon Hull e153b8b603 Merge remote-tracking branch 'origin/main' into advisor/004-correct-cache-keys 2026-11-05 07:52:44 -06:00
Rafael Mendes c2677734a9 Merge pull request #41 from simonhull/fix/package-load-budget
Formats: bound package load memory, check image size before decoding, guard parsers
2026-11-05 10:37:25 -03:00
SteamSmithandClaude Sonnet 5.5 d4ad0fc96c fix(formats): check image size from the header and sync atomic writes
decode() decoded the whole image before checking its size, so an oversized
image allocated first and was refused after. The dimensions are now read from
the header and refused before decoding, and the decoder gets width and height
limits. write_atomic syncs the temp file before the rename and uses a
per-process, per-call temp name so concurrent saves of one path do not collide.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-05 07:12:30 -05:00
SteamSmithandClaude Sonnet 5.5 14dd4448c8 fix(formats): drop whole bad triangles and reject non-finite mesh data first
Out-of-range indices were filtered one at a time, which shifted every later
triangle (and a glTF index count that was not a multiple of 3 shifted later
primitives). Importers now keep or drop whole triangles. Non-finite positions,
normals and UVs are rejected before normals, tangents and bounds are computed
from them; a NaN position used to hang the import.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-05 07:04:34 -05:00
SteamSmithandClaude Sonnet 5.5 ee903c96ad fix(formats): choose sRGB or linear when reading bitmaps
decode() sRGB-decoded every 8/16-bit color bitmap, so an RGB normal map
(0.5, 0.5, 1) became (0.214, 0.214, 1). decode now takes a linear flag. The
Bitmap node gets a Color space choice (sRGB by default, so existing files cook
the same) and graph input preview images can be bound as linear data maps
(graph.input.bind linear: true, stored in input_images_linear).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-05 06:58:19 -05:00
SteamSmithandClaude Sonnet 5.5 7beb8252ed fix(formats): cap and share package resource reads, error on missing entries, dedupe saved names
load_package read a resource entry once per resource that named it, so a tiny
deflated entry plus thousands of resources could allocate hundreds of GB. Each
distinct entry is now read once and shared, the resource count and total bytes
are capped, and a missing or over-cap entry is an error instead of silently
empty data. save_package gives colliding sanitized file names a numeric suffix.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-05 06:50:39 -05:00
Rafael Mendes 4461d0ce5b Avoid logging SBS XML in expression test failures 2026-11-05 00:21:35 -03:00
Rafael Mendes 91175aafc6 Import numeric SBS parameter expressions 2026-11-04 23:36:54 -03:00
Belligerently 96db0b01f9 Preserve Flood Fill and Height Blend SBS inputs 2026-11-04 20:30:54 -05:00
Belligerently f421d10b3f Recognize Histogram Scan and Auto Levels SBS aliases 2026-11-04 20:18:15 -05:00
PiJellyPin 66fdba878f Testing a bunch of stuff 2026-11-04 08:47:10 +01:00
PiJellyPin 6310230ecd Load sbs files
save, load etc.. for sbs files
2026-11-04 07:03:54 +01:00
Simon Hull c4d7443218 Eval: key resources on content and graph instances on their whole sub-graph tree
Resources carry a content hash (ResourceBytes); the decoder memo is keyed on it and pruned.
Graphs that use themselves, directly or through other instanced graphs, give an explicit error.
2026-11-03 14:19:15 -06:00
Simon Hull 4b97a81f7d Formats: bound package load memory, check image size before decoding, guard parsers 2026-11-03 13:08:13 -06:00
bflatasticandClaude Opus 5.5 53ab0f2d6a Cross-app materials: .mcmat portable materials for TextureCraft
- formats: .mcmat (zip: material.json manifest, maps/<usage>.png, source.mcraft) with
  read/write and caps; color usages 8-bit sRGB, data maps 16-bit linear
- engine: file.exportMaterial {path, size?, values?, inputs?}, file.sendToTextureCraft
  (TextureCraft's library folder), graph.input.bind/unbind; file.open reads .mcmat
- core/eval: Graph::input_images preview images for input nodes (mesh maps from
  TextureCraft); caller images win; grayscale inputs convert to gray
- ui: File > Export material..., File > Send to TextureCraft, Open accepts .mcmat,
  input previews in the graph properties
- docs: control protocol (portable materials), file formats, gaps, parity ≈ 67%,
  roadmap, architecture, AGENTS convention for shared formats

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 12:06:09 +07:00