Commit Graph
252 Commits
Author SHA1 Message Date
Rafael Mendes 4897dab15d Merge branch 'review/pr-43' into review/pr-44 2026-11-05 11:16:47 -03:00
Rafael Mendes 2e525e1738 Reconcile the author's SBS resource update 2026-11-05 11:14:31 -03:00
Simon Hull 2f0533cf28 Eval: give the clamping test a locked cache 2026-11-05 08:07:53 -06:00
Rafael Mendes a026ddaaf9 Integrate cache keys with SBS and bound graph traversal 2026-11-05 11:02:15 -03:00
Simon Hull e39a227ca1 Merge commit 'e153b8b' into advisor/005-cook-only-what-changed 2026-11-05 07:52:55 -06:00
Simon Hull e153b8b603 Merge remote-tracking branch 'origin/main' into advisor/004-correct-cache-keys 2026-11-05 07:52:44 -06:00
Rafael Mendes 56aaea24ae Use the bound control port and handle thread creation failures 2026-11-05 10:50:37 -03:00
Rafael Mendes f5b3fe73de Merge remote-tracking branch 'origin/main' into review/pr-42 2026-11-05 10:37:52 -03:00
Rafael Mendes c2677734a9 Merge pull request #41 from simonhull/fix/package-load-budget
Formats: bound package load memory, check image size before decoding, guard parsers
2026-11-05 10:37:25 -03:00
Rafael Mendes 82373ba8f7 Merge pull request #40 from simonhull/fix/enforce-param-ranges
Nodes: clamp parameters to hard limits before cooking
2026-11-05 10:35:51 -03:00
Rafael Mendes 6785310caf Merge pull request #39 from Belligerently/fix/numeric-parameter-input
Keep typed numeric parameter values across frames
2026-11-05 10:35:16 -03:00
Rafael Mendes 80338564d4 Merge remote-tracking branch 'origin/main' into review/pr-35
# Conflicts:
#	crates/ui-egui/src/graph_view.rs
2026-11-05 10:23:17 -03:00
Rafael Mendes 2d445acf5c Merge pull request #31 from Belligerently/fix/movable-dialogs
Allow centered dialogs to move by their title bars
2026-11-05 10:21:19 -03:00
Rafael Mendes a7def58061 Guard export dimensions and verify graph context export 2026-11-05 10:19:26 -03:00
Rafael Mendes 854764bddb Merge remote-tracking branch 'origin/main' into review/pr-25 2026-11-05 10:16:37 -03:00
Rafael Mendes b3232bfbe9 Respect device texture limits for editing previews 2026-11-05 09:42:37 -03:00
SteamSmithandClaude Sonnet 5.5 105bfd5a4a fix(engine): record multi-command gestures as one undo entry
Rewiring a dragged link (Disconnect + Connect), dragging a frame (Edit
frame + Move nodes) and Import bitmap (import + add node + set param)
each made 2-3 history entries. Add Session::begin_group/end_group and
Session::group: edits inside a group share one snapshot, an untouched
group records nothing, and a failing group() restores everything. The
UI uses begin/end_group around those gestures.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-05 07:20:50 -05:00
SteamSmithandClaude Sonnet 5.5 8c6fcf64f8 fix(nodes): scale the coarse levels of Normal to Height correctly
The multigrid solve divided the slope divergence by the level's scale where it
must multiply (one coarse pixel spans `scale` full-size pixels), so the coarse
levels contributed almost nothing and the broad shape was lost. A Gaussian bump
round-tripped through Height to Normal now correlates 0.99+ at 256 and 1024 px
(0.86 at 256 before).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-05 07:16:49 -05:00
SteamSmithandClaude Sonnet 5.5 84bd8f8b9d fix(nodes): clamp numeric parameters to their declared ranges
resolve_params only checked types, so a hand-edited file, a binding to an
exposed input or a dynamic function could pass any float or int to a cook
(including NaN and 1e30). Clamp Float, Int and Float2 parameters to the
declared min/max in resolve_params (new clamp_params; non-finite values fall
back to the default; angles are left alone) and again in eval after bindings
and functions have run.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-05 07:13:59 -05:00
SteamSmithandClaude Sonnet 5.5 d4ad0fc96c fix(formats): check image size from the header and sync atomic writes
decode() decoded the whole image before checking its size, so an oversized
image allocated first and was refused after. The dimensions are now read from
the header and refused before decoding, and the decoder gets width and height
limits. write_atomic syncs the temp file before the rename and uses a
per-process, per-call temp name so concurrent saves of one path do not collide.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-05 07:12:30 -05:00
SteamSmithandClaude Sonnet 5.5 178c406840 fix(ui): ask before unsaved work is thrown away
File > Open, Close all, Empty package, drag-drop and browser open, and
closing the window or Quit replaced or ended the package without
checking Session::modified. They now hold the action and show a Save /
Discard / Cancel dialog; a failed or cancelled save keeps the work. The
decision is a pure state machine (unsaved.rs) and the held action is
serde state in Windows::unsaved. Engine commands run by the control
channel, MCP and CLI still never open a dialog.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-05 07:10:57 -05:00
SteamSmithandClaude Sonnet 5.5 98279937bc fix(nodes): make Anisotropic Noise, Grunge Map 3 and Leaks tile
Each used one noise period for both axes while the cell counts differed per
axis, leaving a seam. Add noise::value_xy (separate period per axis) and use
whole-number cell counts. The noises_tile test now checks the top/bottom edge
too, compares against the mean neighbour difference, and covers the three nodes.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-05 07:05:29 -05:00
SteamSmithandClaude Sonnet 5.5 75fd718c6b fix(control): merge ui.set recursively and clamp camera zoom
ui.set replaced whole top-level keys, so a partial {"prefs":{"thumbnails":false}}
reset every other preference to its default. It now merges objects
recursively. GraphCamera and ImageCamera gain sanitized(), applied after
ui.set and when drawing, so a zoom of 0 or NaN can no longer reach the
division in view_center and the 2D view.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-05 07:04:40 -05:00
SteamSmithandClaude Sonnet 5.5 14dd4448c8 fix(formats): drop whole bad triangles and reject non-finite mesh data first
Out-of-range indices were filtered one at a time, which shifted every later
triangle (and a glTF index count that was not a multiple of 3 shifted later
primitives). Importers now keep or drop whole triangles. Non-finite positions,
normals and UVs are rejected before normals, tangents and bounds are computed
from them; a NaN position used to hang the import.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-05 07:04:34 -05:00
SteamSmithandClaude Sonnet 5.5 7b4124b6c0 fix(cook): catch panics in the cook worker and in app and control commands
A panic in the background cook left stale previews with no error, and a
dead worker (Disconnected) was cleared silently. The worker now runs under
catch_unwind and reports failure; the failure and a vanished worker mark
every node with the error and raise a toast. App::run and the control
channel's command.run also run commands under catch_unwind and reply with
an error instead of crashing.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-05 07:00:31 -05:00
SteamSmithandClaude Sonnet 5.5 ee903c96ad fix(formats): choose sRGB or linear when reading bitmaps
decode() sRGB-decoded every 8/16-bit color bitmap, so an RGB normal map
(0.5, 0.5, 1) became (0.214, 0.214, 1). decode now takes a linear flag. The
Bitmap node gets a Color space choice (sRGB by default, so existing files cook
the same) and graph input preview images can be bound as linear data maps
(graph.input.bind linear: true, stored in input_images_linear).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-05 06:58:19 -05:00
SteamSmithandClaude Sonnet 5.5 858dde47a1 fix(cook): drop a stale background cook that a newer sync cook superseded
A background cook of version A could land after session.inspect had
synchronously cooked version B and cleared dirty, overwriting B's results
with no recook. Sessions now count synchronous cooks (cook_epoch) and the
cooker discards a result whose start epoch is out of date.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-05 06:57:43 -05:00
SteamSmithandClaude Sonnet 5.5 4e21afda5f fix(nodes): cap the bin span in Splatter and Scratches
The grid-bin span was unbounded, so a large size or length visited billions of
bins per item, and Splatter also scanned each bin with contains. Cap the span
to one turn of bins per axis (as fx_map does), drop the contains scan, and
clamp Splatter's count to its declared maximum of 2000.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-05 06:57:14 -05:00
SteamSmithandClaude Sonnet 5.5 0546dd58c6 fix(engine): end undo merge runs at gesture and request boundaries
merge_key was cleared only by edit/undo/redo/reset_history, so two drags
of one slider, two "New random seed" clicks and two MCP/control
node_param calls collapsed into one undo entry. Add Session::end_merge,
call it on pointer release and around each control/MCP command, and
restore the session when a merged edit fails.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-05 06:57:14 -05:00
SteamSmithandClaude Sonnet 5.5 7cbdce8e63 fix(nodes): bound the anisotropic blur's horizontal pass
blur_xy made ceil(extra/2) full-image passes with an unclamped sigma, so a
large intensity at high resolution took ~1e11 ops and a hostile one never
ended. Clamp both sigmas to the image size and do the extra horizontal blur
as one Gaussian (new ops::gaussian_h, three box passes, O(1) per pixel).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-05 06:51:38 -05:00
SteamSmithandClaude Sonnet 5.5 7beb8252ed fix(formats): cap and share package resource reads, error on missing entries, dedupe saved names
load_package read a resource entry once per resource that named it, so a tiny
deflated entry plus thousands of resources could allocate hundreds of GB. Each
distinct entry is now read once and shared, the resource count and total bytes
are capped, and a missing or over-cap entry is an error instead of silently
empty data. save_package gives colliding sanitized file names a numeric suffix.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-05 06:50:39 -05:00
SteamSmithandClaude Sonnet 5.5 d428d41c87 fix(nodes): Normal Blend no longer returns NaN for a base normal with z = -1
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-05 06:39:23 -05:00
SteamSmithandClaude Sonnet 5.5 7b87236f26 fix(eval): hash nested instanced graphs and whole resource bytes into the cache key
Editing a graph two levels below an instance node left the instance's cached result stale, and
bitmaps of equal length with equal headers shared a cache key.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-05 06:39:23 -05:00
SteamSmithandClaude Sonnet 5.5 a6c7fd46f2 fix(review): keep the open graph open after deleting an earlier one; clamp huge sample coordinates
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-05 06:39:22 -05:00
FredApps 4ce6d19362 ui-egui: rustfmt the Arabic catalog; enable web-sys Navigator for the browser language 2026-11-05 04:25:17 +01:00
Rafael Mendes 4461d0ce5b Avoid logging SBS XML in expression test failures 2026-11-05 00:21:35 -03:00
FredApps 8b72a7c0b9 Merge remote-tracking branch 'origin/main' into fix38 2026-11-05 04:14:55 +01:00
Rafael Mendes 821c7172b5 Add DirectX normal-map interpretation to the 3D view 2026-11-05 00:04:50 -03:00
Rafael Mendes 91175aafc6 Import numeric SBS parameter expressions 2026-11-04 23:36:54 -03:00
Rafael Mendes dce9f30c5a Add base-two and Cartesian function primitives 2026-11-04 23:25:13 -03:00
Rafael Mendes 4c7aeabb74 Expose 4K editing previews in the material views 2026-11-04 23:05:25 -03:00
Belligerently ed9f2d0fac Make the full node-search result row clickable 2026-11-04 21:04:56 -05:00
Belligerently b0e8b14017 Reveal node search selection after query changes and reopening 2026-11-04 20:57:57 -05:00
PiJellyPin 8bdae1157d Fixed Heightmap 2026-11-05 02:38:04 +01:00
Belligerently 96db0b01f9 Preserve Flood Fill and Height Blend SBS inputs 2026-11-04 20:30:54 -05:00
Belligerently f421d10b3f Recognize Histogram Scan and Auto Levels SBS aliases 2026-11-04 20:18:15 -05:00
Belligerently ff310018ef Make round parameter values reachable by dragging 2026-11-04 19:56:16 -05:00
Belligerently 9b51c35dd7 Keep keyboard-selected node search results visible 2026-11-04 19:14:56 -05:00
Rafael Mendes 2900eb1058 Merge branch 'feat/alpha-3d-and-wire-editing' into feat/levels-histogram
# Conflicts:
#	crates/ui-egui/tests/snapshot.rs
2026-11-04 20:14:36 -03:00
Rafael Mendes 6a249c66ff Merge remote-tracking branch 'origin/main' into feat/alpha-3d-and-wire-editing
# Conflicts:
#	README.md
2026-11-04 20:11:35 -03:00