mirror of
https://github.com/storytold/photocraft.git
synced 2026-11-19 08:51:41 +01:00
lint/ast-grep holds four rules from RFC-0012 for the CLI code
(apps/photocraft-cli, the shared launch options in
crates/automation/src/args.rs, and the desktop app's main.rs and
launch_args.rs, which read its arguments):
- clap-error-message: no string literal, format!, .to_string() or
SCREAMING_CASE const passed to Command::error or Error::raw.
- clap-error-message-variable: the same, through a variable built with
format!, .to_string(), String::from or a literal's .to_owned() in the
block around the call.
- string-error: no Result<_, String>, Err(format!(..)), Err("..") or
Err(x.to_string()).
- args-os: no std::env::args() (also when imported or renamed), which
panics on a non-Unicode argument.
Each rule has valid and invalid cases in rule-tests/. The workflow calls
craft-common-actions' ast-grep.yml, which runs the rule tests and then
the scan. It takes seconds and builds nothing.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>