Commit Graph
776 Commits
Author SHA1 Message Date
vangel76andClaude Opus 5.5 07e94e1c86 Merge upstream/main into fix/217-generator-offset
Keep the curvature mode and detail sizes from upstream and route the
finished generator value through Generator::shape so the offset applies
to every generator kind. A non-finite offset now counts as 0.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 09:18:34 +01:00
Chris Hassebrook c6edc30a5b Merge pull request #315 from Rebornim/feat/curvature-bands
Curvature generators: mode and detail sizes
2026-11-08 03:12:20 -05:00
Chris Hassebrook e729def8da Merge main and resolve translation conflicts 2026-11-08 07:59:02 +00:00
Chris Hassebrook b177ecc912 Merge pull request #323 from Rebornim/feat/polygon-fill-parity
Polygon fill: box selection, polygon mode, hit-test, visible polygons only and the 2D view
2026-11-08 02:49:29 -05:00
Chris Hassebrook 52d0579bb4 Fix web preview repaint scheduling 2026-11-08 02:47:55 -05:00
Chris Hassebrook e8145421c3 Fix curvature detail handling and merge main 2026-11-08 07:31:13 +00:00
Chris Hassebrook c87247c6d3 Fix polygon fill drag state and visibility 2026-11-08 02:23:39 -05:00
vangel76andClaude Opus 5.5 6c3e2f9625 Merge upstream/main into fix/217-generator-offset
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 08:17:31 +01:00
Chris Hassebrook c46e9b3f3c Merge pull request #308 from Rebornim/feat/filter-picker
Filter picker: swap a filter's type from its Properties slot
2026-11-08 02:07:24 -05:00
Chris Hassebrook b966d13da2 Fix filter picker visibility and swap error context 2026-11-08 01:42:22 -05:00
Chris Hassebrook 57bdfa483a Merge pull request #350 from storytold/349-clean-up-pr-review-guidelines-helper
Updated the PR review helper to be even more helpful
2026-11-08 00:05:52 -05:00
Rebornim 4003e3172d Path tool: live preview while placing points, edit points in the views
- The brush stroke paints while points are placed and dragged (3D and 2D);
  applying is one undo step, Esc removes the unfinished path
- Click the curve to insert a point, select a point and remove it with
  Backspace or the Remove point button; undo steps through point changes
- The selected layer's other paths are drawn (lit under the pointer) and a
  click opens one for editing; 3D lines follow where their paint lands
- A path repaint recomposites only the tiles it changed, not the whole set
- Pen pointer for the tool; new paths start open; Apply/Cancel removed
- Switching texture sets applies a path being placed first

Closes #333
2026-11-08 04:51:39 +00:00
chasse20 97d4bbc38a Updated the PR review helper to be even more helpful 2026-11-07 23:46:15 -05:00
Rebornim d60c954cdd Symmetry: toolbar toggle and settings popup, plane, axis and manipulator in the 3D view
- The toolbar's X/Y buttons become a Symmetry toggle and a settings button
  with a popup: type, axis, axis position, radial count and angle span with
  a preview, and display options; the symmetry rows leave brush Properties
- The 3D view draws where the plane cuts the mesh, where the radial axis
  meets it, copies of the brush cursor where they land on the surface, and
  an axis position manipulator that moves the plane or axis
- Translations for the new strings
2026-11-08 01:39:59 +00:00
Rebornim 74c9afcad9 Renderer: see-through overlay quads drawn after the mesh
Frames carry quads the 3D view draws depth-tested after the mesh (no depth
writes), so the mesh hides them per pixel; used for the symmetry plane, axis
and the line where the plane cuts the mesh.
2026-11-08 01:39:59 +00:00
Rebornim b9b5eb4747 Symmetry: movable plane, angle span and on/off; copies paint where their source does
- Symmetry gets an on/off toggle that keeps its settings, an offset of the
  mirror planes and radial axis from the mesh center, and a radial angle
  span; defaults paint exactly as before
- tool.brush takes and reports symmetryOn, symmetryOffset and
  symmetryAngleSpan
- A symmetry copy runs the camera checks (hidden, facing away, angle fade)
  at its source's point, so it paints the mirror of the stroke
- The eye-depth test allows for neighbouring pixels of the same surface
  where it turns away from the camera: strokes reaching the silhouette broke
  into dots there
2026-11-08 01:39:59 +00:00
Rebornim cbe3c86acb Curvature detail: full-strength block borders, neutral raw curvature, stricter sizes
Divide each blurred detail size by the share of the blur window inside its
UV tile block, so texels near a block or map edge keep their strength
instead of fading toward zero. Raw mode reads mid gray when there is no
curvature to sample. The size cache keeps one layout per curvature map.
Mask previews of hidden layers build their sizes once before the tiles run
in parallel. effect.set rejects a sizes array with a non-numeric entry.
2026-11-08 01:38:20 +00:00
vangel76andClaude Opus 5.5 aecf9cd7ab Use as_chunks in the bake_tiles tests main added
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 02:29:28 +01:00
Rebornim 8cdd5dc296 Filter slot: use Id::unique for the open request (Id::new is deprecated) 2026-11-08 01:28:25 +00:00
Rebornim dd7bb51bd5 Bake visualization: pick up the reach even when nothing is drawn
The reach job was only polled while the high poly was drawn, so leaving
bake mode or hiding the high poly mid-reach kept busy() true and the view
repainting every frame. Poll it at the start of every sync.

The resend test now waits for the rebuilt cage's reach before checking
that a resend starts none, so it no longer depends on thread timing.
2026-11-08 01:27:58 +00:00
vangel76 d8ecfb7d42 Merge upstream/main into fix/clippy-chunks-exact-to-as-chunks 2026-11-08 02:27:35 +01:00
Rebornim 6d3f7c216d Levels: paint the active handle on top
Handles are painted with the dragged or hovered one last, so the handle
drawn on top is the one the pointer grabs. Value labels keep the active
handle first so its value wins over an overlapping neighbour's.
2026-11-08 01:26:54 +00:00
Rebornim 284cb7d125 Refuse host paths in files entries for automation
textureSet.meshMap.import takes its paths in files[].path, which
authorize_command did not look at, so a control client could import an
image from outside --read-root. Treat a path or dir in any files entry
like a top-level one, and document that automation imports baked maps
through resource_import plus textureSet.meshMap.set.
2026-11-08 01:25:35 +00:00
vangel76andClaude Opus 5.5 8334230ed1 test(formats): a late entry error with all earlier entries fine is returned
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 02:23:52 +01:00
Rebornim 45ab0f42d9 Image drop: clearer decal specs, layer/effect check, menu edge cases
layer.add.decal's spec says the other-set selection is for x/y only and
documents the maskEffect it returns; layer.decal.set's says image keeps
the decal's channel or mask and refuses an effect given with another
layer. The drop menu's channel list scrolls past 60% of the window. A
waiting drop lets go once its menu goes undrawn (the 3D view hidden),
and the click that closes the menu no longer moves a decal being placed.
2026-11-08 01:23:12 +00:00
Rebornim c39d95b4c8 Filter swap: test that invalid parameters for the new filter are refused 2026-11-08 01:21:42 +00:00
Rebornim e2a69c4d12 Filter picker: Add filter opens the picker, same-id set edits in place
Add filter still adds a neutral HSL filter, and its slot now opens the
picker straight away; Esc keeps the HSL and one undo removes it.
effect.set naming the filter the effect already is edits its parameters
instead of rebuilding it from defaults. The picker's filter list is
worked out once. The slot cuts long names short between the thumbnail
and the caret, stays highlighted while its picker is open and shows an
outline while it has keyboard focus. More engine tests: a swap on a
mask, an explicit name, refused swaps leave no change and no undo step.
2026-11-08 01:15:26 +00:00
vangel76andClaude Sonnet 5.5 c3a59ed421 Keep the anchored brush outline when a Ctrl+right drag leaves the 2D view
The outline is drawn at the press origin for the whole adjustment drag;
only the system-pointer hiding depends on the pointer being in the view.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-08 01:40:50 +01:00
Rebornim 346a0b24f5 Bake visualization: test every branch of VertexReach::missed
A table over distance starts (painted amount 1 and 2) and a cage-mesh
start covers both inclusive ends of the ray range, a name mismatch and
Ignore Backface both ways. Also test a request with no high poly.
2026-11-08 00:26:26 +00:00
Rebornim 1a58c57f64 Section reset: keyboard focus outline, tests over every section
The reset icon draws an outline while it has keyboard focus and is left
out of Tab order while its section is at its defaults. The tests now run
every brush section: enabled and disabled state, the reset folds nothing
in either state, and Enter on the focused icon resets.
2026-11-08 00:26:23 +00:00
Rebornim f5d07ced6b Pick the display tone mapping from a dropdown
The AO intensity is set in Shader Settings, so Display Settings no longer
repeats it.
2026-11-08 00:18:46 +00:00
Rebornim 63fc993644 Tidy the Shader Settings, History and Log panels
Shader Settings starts with the shader model; its description moves to the
model's tooltip. The height to normal strength stays in the texture set
settings only. Subsurface scattering and Transmission are collapsible
sections. The History and Log lists fill their panel's height.
2026-11-08 00:18:46 +00:00
Rebornim 508c4bb2aa Keep the click that dismisses the image drop menu from painting
The views don't paint while a dropped image waits for its menu pick, so a click
on the mesh outside the menu only closes it. Also document Texel::source and
DecalDrop::menu_id.
2026-11-08 00:11:02 +00:00
Rebornim 1a0fc5fec8 Curvature detail: build only the sizes in use, map coverage on all cores 2026-11-08 00:10:40 +00:00
Rebornim 906dcf324e Curvature detail: name the tuned weights, clean up the effect plans and blur 2026-11-08 00:10:40 +00:00
Rebornim a1d010ccb2 Curvature generators: mode and detail sizes
Curvature and edge wear generators read the baked curvature map one
texel at a time, so they only marked the sharpest edges. They now take a
mode (edges, cavities, both, raw) and seven detail size weights: the map
itself and the map blurred at 1 to 32 texels at 2K, padded past the UV
islands and built once per map and layout. Each size's edges and
cavities combine like a screen blend.

New curvature and edge wear generators use detail sizes. Generators saved
without them, and smart masks, read the map exactly as before.
2026-11-08 00:10:40 +00:00
Rebornim c827d1b910 Drop a shelf image on the texture set under the cursor, as a channel or a mask
An image dragged over the 3D view highlights the texture set under the
cursor, as materials do. A drop opens a menu at the drop point: Mask, then
that set's channels. A pick selects the set and places the decal there
with the image in the picked channel, or as the gray mask of a new fill
layer. A click elsewhere places nothing; the background opens no menu.

layer.add.decal takes channel (a channel id, default baseColor, or
"mask") and adds the decal to the set under the point, selecting it, as
one undo step. layer.decal.set takes effect to edit a mask decal, so the
view's frame and handles work on it too, and a new image stays in the
channel the decal was placed in. One-value channels and masks read an
image's gray instead of its red.
2026-11-08 00:10:09 +00:00
Rebornim ca19e714a0 Filter picker: swap a filter's type from its Properties slot
effect.set takes filter: <id> to swap a filter effect's type in place,
keeping its place, blending, opacity and visibility (one undo step).
A reusable resource_picker shows grouped, searchable shelf tiles at a
slot; the filter slot uses it, and Add filter adds a neutral filter.
2026-11-08 00:09:49 +00:00
vangel76andClaude Sonnet 5.5 d0967df09e Test that the system pointer returns when a drag leaves the 2D view
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-08 00:54:33 +01:00
vangel76andClaude Sonnet 5.5 3f13752155 Test that the generator offset survives save and reopen and undoes
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-08 00:54:31 +01:00
vangel76andClaude Sonnet 5.5 8d902bea6f Hide the system pointer only while it is over the 2D view
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-07 16:54:02 +01:00
vangel76andClaude Sonnet 5.5 8eeb8e5e7e Name the exact byte counts in the too-large-to-save error
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-07 16:54:00 +01:00
vangel76andClaude Sonnet 5.5 9c570137f7 Keep the pointer over the 2D view header and size the brush outline by pen pressure
The brush cursor in the 2D view hid the system pointer and drew the outline
over the view header pickers. Its radius also ignored pen pressure, while
painting shrinks the stamp towards min_size. Both now follow the painted
footprint (BrushSettings::uv_stamp_radius, shared with continue_stroke_uv),
with regression tests for header hover and partial pressure.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-07 15:37:56 +01:00
Rebornim bac53688c1 Bake mode: draw the high poly, the cage and where the bake's rays miss
The 3D view in bake mode gets a Baking Visualization panel (high poly, cage,
UV seams, low poly, selected texture set only). The cage is built from the
bake's own ray starts (a RayFrame now shared by the bake and the view), so it
grows and shrinks with the distance sliders exactly as the rays do, and
high-poly vertices the transfer rays cannot reach are drawn red.

Refs #330
2026-11-07 13:26:38 +00:00
Rebornim ed45aa0807 Levels: edit the input range, gamma and output range on the histogram
Drag the input low, gamma and input high handles above the histogram and
the output low/high handles under a black-to-white strip; double-click a
handle to type its value. Reset, Auto and Invert replace the five sliders.
Every drag is one undo step through effect.set.
2026-11-07 13:00:33 +00:00
Rebornim 3836730030 X inverts the mask paint value while painting a mask
New command tool.swapMaskValue (mask value becomes 1 - value), default
shortcut X, enabled only while the selected layer's mask or one of its
mask effects is the paint target. Ctrl+X stays cut. Closes #332.
2026-11-07 12:26:07 +00:00
vangel76andClaude Sonnet 5.5 d4ad712f08 Merge upstream/main into fix/179-2d-brush-cursor
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-07 12:06:33 +01:00
Rebornim 4543c85812 Reset icon on each brush section header
Each brush section header gets a reset icon at its right end that puts only that
section's settings back to their defaults; dimmed and inert while already at them.
Docked Properties uses the solid scroll bar so the icon sits flush right.
2026-11-07 10:49:42 +00:00
Rebornim 6eed52435d Match UV tiles per file, skip empty imports, review cleanups
- Each tiled file is keyed by its own tile number and its image passed to
  use_images, so tiles named differently or renamed on import still match
- Files of a tiled set without one of its tiles, and maps missing a tile, go
  to unmatched instead of failing the import
- Nothing to import leaves no undo step
- The map is read from the file name after the set name
- Toast counts maps; a failed import keeps the file list
- Cap the bytes one import reads; whole-method cleanup of set, use_images,
  tile_images and new_project
2026-11-07 09:14:41 +00:00
Rebornim ffe8587e54 Take &Path in the import test helper 2026-11-07 09:14:40 +00:00