From ddd1a961fb5bec712659c3b8c29fdfd39b724de5 Mon Sep 17 00:00:00 2001 From: dotCooCoo Date: Thu, 19 Nov 2026 02:10:41 -0800 Subject: [PATCH] Live Paint: Swap leaves faces with freeform gradients as they are Swap Fill and Stroke on a whole Live Paint group compared the faces' fills without gradient placement, so faces with freeform gradients counted as one shared fill and the edges took a freeform gradient without its points. A freeform gradient on any face or edge now counts as a paint the parts do not share, and the group keeps its paint. - docs/mcp.md says that a face or edge given with its whole group follows the group's rule, and that Default Fill and Stroke replaces the parts' appearance also when the Default Graphic Style is redefined. - The progress-doc line states the behavior as VectorCraft's own rule and lists all eight tests. - Tests cover freeform faces in Swap, an edge given with its group, and Default Fill and Stroke with a redefined Default Graphic Style. --- crates/engine/src/cmd/paint.rs | 31 ++++++++++++++++++------------- crates/engine/src/cmd/stroke.rs | 5 +++-- crates/engine/src/tests/build.rs | 30 +++++++++++++++++++++++++++++- docs/mcp.md | 14 ++++++++------ docs/target-app-parity.md | 2 +- 5 files changed, 59 insertions(+), 23 deletions(-) diff --git a/crates/engine/src/cmd/paint.rs b/crates/engine/src/cmd/paint.rs index eb4b1e7443..071c5f9862 100644 --- a/crates/engine/src/cmd/paint.rs +++ b/crates/engine/src/cmd/paint.rs @@ -6,6 +6,7 @@ use serde_json::{Value, json}; use vectorcraft_color::{BlendMode, Color, GradientPaint, Paint}; use vectorcraft_doc::appearance::{FillLayer, StrokeLayer}; use vectorcraft_doc::{Appearance, AppearanceItem, CharStyle, Document, GraySource, Node, NodeId, NodeKind}; +use vectorcraft_tools::builder::{edges, faces, is_live_paint}; use super::appearance::{ItemTarget, edit_items, edit_items_then, item_target, row_targets}; use super::gradient::{item_paint_bounds, place_paint, place_run_paint, run_paint_mut, run_stroke_weight, unplaced}; @@ -44,7 +45,7 @@ pub fn specs() -> Vec { "Swap Fill and Stroke", [], Some("Shift+X"), - "{ids?|id?} swap the fill and stroke of the selection (type too) and of the defaults. A Live Paint group's faces take the stroke its edges share and its edges take the fill its faces share, a gradient fitted to each face or edge; a group whose faces' fills or edges' strokes differ, or that has no face or no edge, keeps its paint. On a path directly in a graph series, the graph also stores the swapped paints and the stroke weight, and on a graph label the swapped paints of its characters for every label of its kind, and on a graph's axis line, tick mark or radar ring what the swap changes on its rows for every line of its kind (exceptions: docs/mcp.md). While the Live Paint Bucket is the active tool and no ids or id are given (a null one counts as none), only the defaults change", + "{ids?|id?} swap the fill and stroke of the selection (type too) and of the defaults. A Live Paint group's faces take the stroke its edges share and its edges take the fill its faces share, a gradient fitted to each face or edge; a group whose faces' fills or edges' strokes differ (a freeform gradient counts as differing), or that has no face or no edge, keeps its paint. On a path directly in a graph series, the graph also stores the swapped paints and the stroke weight, and on a graph label the swapped paints of its characters for every label of its kind, and on a graph's axis line, tick mark or radar ring what the swap changes on its rows for every line of its kind (exceptions: docs/mcp.md). While the Live Paint Bucket is the active tool and no ids or id are given (a null one counts as none), only the defaults change", has_doc, swap ), @@ -53,7 +54,7 @@ pub fn specs() -> Vec { "Default Fill and Stroke", [], Some("D"), - "{ids?|id?} white fill and 1 pt black stroke for the selection and the defaults (in a document whose Default Graphic Style differs from the shipped one, as a New Document profile can redefine it: that style's fills, strokes and effects, without its opacity or a link to it); type gets black fill and no stroke. A Live Paint group's faces get no fill and its edges get a 0.5 pt black stroke, and with only Live Paint groups selected (or in ids) the defaults become no fill and a 0.5 pt black stroke (with New Art Has Basic Appearance off, new art then takes the selection's appearance, as after any command). On a path directly in a graph series, the graph also stores the paint, weight, opacity and blend mode of the topmost visible fill and stroke, and on a graph label the black fill and no stroke of its characters for every label of its kind, and on a graph's axis line, tick mark or radar ring its rows for every line of its kind (exceptions: docs/mcp.md). While the Live Paint Bucket is the active tool and no ids or id are given (a null one counts as none), only the defaults change", + "{ids?|id?} white fill and 1 pt black stroke for the selection and the defaults (in a document whose Default Graphic Style differs from the shipped one, as a New Document profile can redefine it: that style's fills, strokes and effects, without its opacity or a link to it); type gets black fill and no stroke. A Live Paint group's faces get no fill and its edges get a 0.5 pt black stroke, in place of their whole appearance and also when the Default Graphic Style is redefined, and with only Live Paint groups selected (or in ids) the defaults become no fill and a 0.5 pt black stroke (with New Art Has Basic Appearance off, new art then takes the selection's appearance, as after any command). On a path directly in a graph series, the graph also stores the paint, weight, opacity and blend mode of the topmost visible fill and stroke, and on a graph label the black fill and no stroke of its characters for every label of its kind, and on a graph's axis line, tick mark or radar ring its rows for every line of its kind (exceptions: docs/mcp.md). While the Live Paint Bucket is the active tool and no ids or id are given (a null one counts as none), only the defaults change", has_doc, default_paint ), @@ -226,7 +227,7 @@ impl Session { if let Some(n) = nodes.first() { return Some((Cow::Borrowed(*n), None)); } - if !vectorcraft_tools::builder::is_live_paint(n) { + if !is_live_paint(n) { return None; } } @@ -273,7 +274,6 @@ fn same_in_proxy(a: &Paint, b: &Paint) -> bool { /// The ids of the faces and edges of `n` when it is a Live Paint group, else none. pub(crate) fn live_paint_parts(n: &Node) -> Vec { - use vectorcraft_tools::builder::{edges, faces, is_live_paint}; if !is_live_paint(n) { return vec![]; } @@ -290,8 +290,7 @@ pub(crate) fn painted<'a>(n: &'a Node, top: bool, stroke: bool, out: &mut Vec<&' if n.is_ruler_guide() { return; } - if vectorcraft_tools::builder::is_live_paint(n) { - use vectorcraft_tools::builder::{edges, faces}; + if is_live_paint(n) { out.extend(if stroke { edges(n) } else { faces(n) }.into_iter().map(|part| &**part)); return; } @@ -765,7 +764,6 @@ pub(crate) fn bucket_color_params(s: &Session, p: &Value, cmd: &str) -> Result