Commit Graph
9373 Commits
Author SHA1 Message Date
BFlat 27e413fda5 Merge pull request #8936 from dotCooCoo/fix/dimension-level-snap-checks
Dimension tool: a line at a slight angle or past the distance limit is not a level
2026-11-22 10:46:51 +07:00
BFlat b288f27bd8 Merge pull request #8930 from dotCooCoo/fix/flare-lone-x2-y2-error
Flare: a lone x2 or y2 in shape.flare is an error
2026-11-22 10:46:31 +07:00
BFlat b3c83f75ba Merge pull request #8923 from dotCooCoo/fix/library-pattern-color-copies
Swatch libraries: repeated adds reuse numbered colors, and tints link to a color of their kind
2026-11-22 10:45:30 +07:00
dotCooCoo ff26d5e4a3 Swatch libraries: colors a pattern brings skip the library's other names
A global or spot color that a library pattern's art brings under a
numbered name no longer takes a name the library gives another swatch.
Before, adding a pattern whose art uses "Ink" to a document with another
"Ink" brought the color as "Ink 2" even when the library has its own
"Ink 2"; adding that library swatch next then came in as "Ink 2 2". The
brought color now takes the next free name the library does not use
("Ink 3"), and every paint linked to it follows the new name, so adding
the library's "Ink 2" next adds it under its own name and adding both
again adds nothing.

A color the pattern's art brings or takes is the color a library tint
or gradient links to only when it has the library color's paint and its
process, global or spot kind, as for the other lookups in the same add.

The test a_numbered_copy_named_like_another_library_color_is_found now
makes the blue "Ink 2" itself, as an earlier version's pattern add left
it, since a pattern add no longer gives that name.
2026-11-21 15:38:19 -08:00
dotCooCoo 79dd33e228 Swatch libraries: a tint whose color was deleted brings it back
A library tint or gradient counts as already in the document only when
each color it links to is there. When the document's tint of that name
links to a color the document no longer has (deleted without unlinking),
the color comes back under its own name and is listed in `added`.

A picked pattern the document already holds keeps the copy of a color
its art takes (a numbered copy the library also names), and the picked
tints and gradients of that color link to it, so adding the pattern and
the tint again adds nothing. Without such a pattern, a numbered copy the
library also names stands for that library swatch alone.

docs/mcp.md also states that a pattern pasted with Merge for some colors
and Add for others is added again as a copy.
2026-11-21 09:30:26 -08:00
dotCooCoo 7f97df87d4 Swatch libraries: library tints link only to a color of their own kind
swatch.library.add linked a library tint to the wrong color in two cases.
When the document had a process color with the same name and paint as the
tint's global color, the global color counted as already present and the
tint linked to the process color. When a tint was added without its global
color and the document had another swatch of that color's name, the tint
linked to that swatch.

- A library color counts as already in the document only when the
  document's color of that name is the same kind: process, global or spot.
  A global color whose name the document gives a process color now comes
  in under a numbered name, and its tints link to that copy.
- A global or spot color that an added tint or gradient links to, and that
  the document does not have, now comes in with the tint or gradient. It
  keeps its own name when that name is free and gets a number otherwise.
  added lists it after the picked swatches.
- A library tint is not the document's tint of the same name and paint
  when the document's swatch of the base's name is another color or kind.
- A tint that a pattern brought is used for a picked library tint only
  when the color it links to is the library color's kind.
2026-11-21 07:54:43 -08:00
dotCooCoo 9772495468 Swatch libraries: check the color names a pattern copy gives
When a library tint waits for a color that a pattern's art brings,
swatch.library.add learns the color's name by importing the pattern into
a copy of the document. The import into the document now confirms those
names: when it gives a color another name, or none, the tints linked
from the copy are linked again.

- library.use and Add to Swatches report an error from the import that
  merges a pattern's colors instead of falling back to adding them.
- The params text, docs/mcp.md and docs/target-app-parity.md say that a
  tint or gradient links to the numbered copy its global or spot color
  comes in under or already has, and name a gradient test.
- The new code uses the HashMap import, and one helper relinks the
  added tints and gradients at both places that did it.
2026-11-21 05:42:17 -08:00
dotCooCoo 35e43f9cfe Swatch libraries: library tints and gradients link to their colors in any order
A library tint or gradient whose global or spot color comes in under a
numbered name now links to that copy whichever order the swatches are
picked in, when the color was added by an earlier call, and when a
pattern's art brought the color or took the document's copy of it.
Adding the same tints again finds the ones added before.

- Each tint's or gradient's color is looked up for itself before
  anything is added, past a process swatch of the same paint and past a
  color group of that name. A numbered copy that the library's own
  swatch of that name is stays that swatch's, and a new copy skips the
  library's other names.
- A tint links to a global or spot color of the same kind only, and to
  a color this call picks rather than to a copy a pattern took.
- Links are set as soon as the color's name is known. A tint waiting
  for a color that a pattern's art brings learns its name from an
  import into a copy, so the pattern does not add a second tint.
- A swatch a pattern brought takes a picked swatch's place only when
  its colors link where the picked one's do.
- A stop linked to the Registration swatch counts as linked.
- library.use, Add to Swatches and the reuse check share one import
  probe (patternlib::probe_import), and the probed copy is kept instead
  of importing a second time.

Docs: docs/mcp.md, docs/target-app-parity.md.
2026-11-21 04:57:24 -08:00
dotCooCoo 479dd27535 Dimension tool: a line at a slight angle or past the distance limit is not a level
A linear dimension line placed near another dimension's line lands on its
level only when that line is parallel. Before, the check compared the two
directions only, so a long line at a slight angle passed it: with its first
end within the snapping tolerance, the new line landed on a level the other
line had already left, and the guide ran at an angle between the lines. A
line is now parallel when it moves off its level by no more than 0.000001 pt
across the span of both lines.

A level that would put the line more than 1,000,000 pt from its points is
passed over. Before, the tool took it, the preview failed validation and
was not sent, and a click committed the earlier preview position. The next
level within reach is taken instead, or the line goes where the pointer is.

The level guide also needs Smart Guides on when it is drawn, so turning
Smart Guides off before the next pointer move hides it.

The nonparallel case in the placement test now puts the pointer within
reach of the first line's end, so it fails without the parallel check, and
the guide test expects exactly one guide.
2026-11-20 20:42:08 -08:00
dotCooCoo c9d6c8f126 Docs: an Alt-drag copy of a clipping path in Draw Behind goes above it
The progress line now says that in Draw Behind the copy of the clipping path of a clip group or a clipping layer goes directly above it, so the clipping path stays the bottom object, as docs/mcp.md and copy_beside already do.
2026-11-20 20:23:32 -08:00
dotCooCoo 9eb8cd6146 Merge main into feat/draw-behind-alt-drag-copy 2026-11-20 20:07:57 -08:00
BFlat f593dff00c Merge pull request #8903 from dotCooCoo/fix/plugins-folder-special-files
Plug-ins: the plug-ins folder can't block startup on a special file
2026-11-21 11:02:50 +07:00
BFlat 4ce43b1091 Merge pull request #8532 from dotCooCoo/feat/distorted-image-commands
Links: Relink, Embed and Unembed keep a distorted image's corners
2026-11-21 11:01:53 +07:00
BFlat ddcefb86c9 Merge pull request #8918 from storytold/train/carry8875
Path Precision Tools: the Tangent Circle Tool leaves out a circle that would reach past the canvas (#8875)
2026-11-21 11:00:19 +07:00
BFlat 1a1a939bdf Merge pull request #8858 from dotCooCoo/fix/style-redefine-series-own-links
Graphic Styles: Redefine Graphic Style keeps the own style of a path inside a series group linked to the target
2026-11-21 10:56:45 +07:00
BFlat 9078e13d78 Merge pull request #8867 from dotCooCoo/perf/selection-widgets-kind-first
Selection: on-canvas widgets check an object's kind before its editability
2026-11-21 10:56:16 +07:00
dotCooCoo 0575c1604a Swatch libraries: adding a pattern again reuses its numbered colors
Since the change that brings a library pattern's global and spot colors
under a numbered name ("Ink 2") when the document gives the name another
color, adding the same pattern or color again added more copies, and
Use Library Item still linked a pattern's art to the document's own
color of that name.

- A library color whose name the document gives another color is the
  document's numbered copy with the same color, so adding it again adds
  nothing. A numbered name that the same call also picks is not shared.
- A pattern the document holds with its art linked to the document's
  own color of a name, as pasting with Merge leaves it, is reused
  instead of coming in again as "Squares 2".
- `added` lists the colors a pattern brought, after the picked swatches.
- A library tint added with its base color links to the base's name in
  the document, and a later add finds it there.
- library.use brings a pattern's colors the same way.

Docs: docs/mcp.md.
2026-11-20 19:55:08 -08:00
dotCooCoo b763053289 Merge main into fix/flare-lone-x2-y2-error 2026-11-20 19:55:07 -08:00
bflatastic 3bda231dd6 Merge remote-tracking branch 'origin/main' into HEAD
# Conflicts:
#	docs/target-app-parity.md
2026-11-21 10:46:25 +07:00
BFlat 96726b1f41 Merge pull request #8837 from dotCooCoo/fix/live-paint-contents-group-targets
Live Paint: graphic styles on a group's contents give fills to its faces and strokes to its edges
2026-11-21 10:39:37 +07:00
BFlat f558297963 Merge pull request #8681 from dotCooCoo/feat/retype-near-matches
Retype: near matches within a tolerance, and words outlined as one compound path
2026-11-21 10:38:18 +07:00
BFlat 911177c775 Merge pull request #8874 from dotCooCoo/docs/3d-shadow-expands-blurred-as-image
Docs: a blurred 3D shadow expands to an image
2026-11-21 10:37:51 +07:00
BFlat 53fe391488 Merge pull request #8865 from dotCooCoo/fix/palette-typo-order-docs
Command Palette: docs order typo matches by the field the word is met in
2026-11-21 10:37:26 +07:00
BFlat 193f110ebe Merge pull request #8864 from dotCooCoo/fix/relink-edited-mask-docs
Docs: Relink and Update Links keep a clipping mask edited in the document
2026-11-21 10:37:02 +07:00
BFlat 6aaef5ad68 Merge pull request #8886 from dotCooCoo/fix/outline-compound-strokes-not-fill
Pathfinder: Outline of a compound shape with no fill adds no stroke of its own
2026-11-21 10:35:55 +07:00
BFlat 7945ef5c86 Merge pull request #8884 from dotCooCoo/fix/safe-mode-expand-symbol-art
Expand Appearance: Safe Mode checks symbol art that a group's raster effect draws
2026-11-21 10:35:31 +07:00
BFlat f39e3e06cf Merge pull request #8871 from dotCooCoo/feat/draw-behind-place-symbol
Symbols: in Draw Behind a placed instance goes directly below the selection
2026-11-21 10:35:08 +07:00
BFlat e8b23c5ba9 Merge pull request #8852 from dotCooCoo/fix/mesh-picks-survive-tool-switch
Mesh: picked points stay picked between the mesh-point tools
2026-11-21 10:33:52 +07:00
BFlat a5f9966ca5 Merge pull request #8861 from dotCooCoo/feat/freeform-lines-leave-ends-line
Gradient: moving out of a freeform object ends the Lines mode line
2026-11-21 10:33:27 +07:00
BFlat 4c0edd8844 Merge pull request #8904 from dotCooCoo/feat/script-check-host-classes
Script checker: setting a File's length, hidden or readonly counts as a file write
2026-11-21 10:32:19 +07:00
dotCooCoo b82d2a2ac2 Merge main into fix/flare-lone-x2-y2-error 2026-11-20 19:22:08 -08:00
dotCooCoo 318d1ed6e2 Selection: an Alt-drag copy in Draw Behind goes directly below its original
In Draw Behind, an Alt-drag of whole objects with the Selection or Direct
Selection tool now puts each copy directly below its own original, in the
original's group or layer, and selects the copies, as the drawing modes help
page lists duplicating by Alt-drag among the actions Draw Behind applies to
(https://helpx.adobe.com/illustrator/desktop/draw-shapes-and-paths/learn-drawing-basics/drawing-modes-overview.html).
The copy of a clip group's or clipping layer's clipping path goes directly
above it, so the clipping path stays the bottom object.

- object.transform takes drawBehind (with copy); the tools send it while Alt
  is held. A value that is not true or false is refused.
- Draw Normal, Draw Inside, object.move, the transform dialogs' Copy,
  Duplicate and Transform Again keep putting copies above.
- Document::insert_below puts nodes directly below their anchors in one pass.

Docs: docs/mcp.md, docs/target-app-parity.md.
2026-11-20 19:19:13 -08:00
BFlat 3f5531a7d3 Merge pull request #8881 from dotCooCoo/fix/dimension-first-pick-link
Dimension: a first Linear point keeps its link when the art moves before the second click
2026-11-21 10:18:42 +07:00
dotCooCoo ce2fd22267 Path Precision Tools: the Tangent Circle Tool works out its circle again after a canceled live edit
A live edit changes the document without an undo step, so the tool was
not told about it. Circles found while a preview moved the second
segment stayed cached under the same segment key, and a click after the
preview was canceled drew the cached circle instead of one touching the
segment where it is again. A first segment picked during a preview kept
its old shape the same way.

The cache key now holds the shapes of the first segment and of the
segments a circle may touch, so moving along an unchanged segment still
reuses the search. The first segment is forgotten when its shape no
longer matches the document, and a press on the second segment follows
the segments as they are at the release; a pressed segment that is gone
leaves nothing to touch.
2026-11-20 19:15:06 -08:00
dotCooCoo b2e7784160 Docs: progress line for the script checker's File setters and host test
docs/target-app-parity.md gets a line for the file.write report on a
File object's length, hidden and readonly and for the test that lists
every name the script host adds, with the tests that cover them. The
test's comment on vc no longer names another app.
2026-11-20 19:05:54 -08:00
dotCooCoo e2d62de4fe Merge main into feat/distorted-image-commands 2026-11-20 18:54:01 -08:00
dotCooCoo 417ed94431 Script checker: setting a File's length, hidden or readonly counts as a file write
Setting a File object's length truncates or pads the file, and setting
readonly or hidden changes it, but script.check reported no outside
category for those assignments. It now reports file.write and
filesWritten for them: plain and compound assignment, ++ and -- before
or after, and the property name as a string literal in brackets.

A new integration test lists every global and member the script host
adds to the JavaScript engine (the own properties of the global object,
of each object or function it holds and of each function's prototype,
compared with a plain engine) and fails when one has no row. Each name
that reaches outside the document has a probe script, and the test
checks that script.check gives it the expected outside id. vc is listed
as not checked: script.check reads scripts written for the reference
app's scripting, and what vc.run does depends on the command. The test
also checks that the checker lists every preprocessor directive the
host reads, through the new DirectiveName::ALL.

File object properties:
https://extendscript.docsforadobe.dev/file-system-access/file-object/
2026-11-20 18:36:13 -08:00
dotCooCoo 71d747946b Merge main into fix/flare-lone-x2-y2-error 2026-11-20 18:23:24 -08:00
BFlat 80c9dadf59 Merge pull request #8893 from dotCooCoo/fix/blends-live-in-file-formats-gap 2026-11-21 09:08:15 +07:00
BFlat e33f3d3f7c Merge pull request #8901 from dotCooCoo/feat/plugin-wasm-features 2026-11-21 09:07:52 +07:00
BFlat 4596183e67 Merge pull request #8898 from dotCooCoo/feat/scripts-api-c1-corpus 2026-11-21 09:01:03 +07:00
BFlat f35cf264c1 Merge pull request #8899 from dotCooCoo/docs/ai-deep-distorted-images 2026-11-21 08:51:00 +07:00
dotCooCoo 2adc433f5e Plug-ins: the plug-ins folder can't block startup on a special file
A folder load checked each .wasm path and then opened it with a blocking
open. When a named pipe replaced the file between the two, the open held
the load until something wrote to the pipe, and with it startup or a
prefs.set of the folder. On Unix the file is now opened
without waiting and without making a terminal the controlling terminal,
and the opened file is checked again: anything that is not a regular file,
or is over the module limit, is refused and listed in the folder report.

A folder load still reads at most 1,000 .wasm files, the first by file
name, and now holds only those paths while it lists the folder. The
files past the first 1,000 were dropped and not reported; plugin.reload
and plugin.list now return their count as leftOut. An error while the
folder is listed fails the load, as an error opening the folder does,
instead of dropping the entries after it.
2026-11-20 17:28:22 -08:00
Dylan M. TayloranddotCooCoo 82d5aabeec refactor(cdr): use shared craft-cdr from craft-libs (#8857)
* refactor(cdr): depend on shared craft-cdr from craft-libs (#1665)

Replaces the local crates/cdr (vectorcraft-cdr) crate with craft-cdr
from storytold/craft-libs#2697 (storytold/craft-libs#778), keeping
VectorCraft's document/artboard/layer/shape mapping in crates/engine.

Co-authored-by: dotCooCoo <RobertLeeLW@gmail.com>

* build(cdr): pin craft-cdr to craft-libs main (75d179f8df)

* build(cdr): pin craft-cdr to craft-libs main (9b28b56bc7)

* docs(cdr): point CDR/CMX provenance and test paths to craft-cdr

---------

Co-authored-by: dotCooCoo <RobertLeeLW@gmail.com>
2026-11-20 20:27:55 -05:00
dotCooCoo 0d1009fab0 Dimension: a first Linear point goes back to its pick when its art is deleted
The first point followed its moved art by overwriting the stored point, so
when that art was then deleted the point stayed at the moved position
instead of where it was picked. The tool now keeps the pick separately and
falls back to it for the marker, the rubber band, Shift and the dimension.
A first anchor whose path is deleted is dropped from the point, so the
second click still places the dimension.
2026-11-20 17:25:58 -08:00
dotCooCoo b0fba57f4a Plug-ins: the host checks the WebAssembly features a plug-in uses
Plugin::load now validates each module with wasmparser and a fixed list
of WebAssembly features before wasmi reads it: mutable globals, sign
extension, saturating conversions, multi-value, bulk memory, reference
types, tail calls, extended constant expressions and floats. A module
that uses any other feature is refused, so a wasmi upgrade, a change to
its defaults or one of its crate features turned on elsewhere in the
build does not change what a plug-in may use. wasmi's Config is set to
the same list for every setter it has in this build.

The list is the set wasmi accepted before, without multi-memory. A
second memory was already refused by the one-memory limit; its error
now says "multiple memories". No module that loaded before is refused.

wasmparser 0.228.0 is the version wasmi 2.0.0 already uses.

A new test loads a plug-in that uses each listed feature and checks
that modules using SIMD, relaxed SIMD, memory64, a second memory,
custom page sizes, wide arithmetic, threads, exceptions, legacy
exceptions, function references or garbage collection are refused with
an error that names the feature.

docs/plugins.md lists the whole set; it named only four of the allowed
features before.
2026-11-20 17:25:01 -08:00
dotCooCoo bb8d24017a Docs: .ai writers write a distorted image 8 deep as its nearest placement and leave out deeper ones
The mesh sentence in docs/mcp.md no longer lists the .ai writers among
the exports that draw a mesh. Both docs now say the fallback applies to
an image nested 8 deep, name the containers each writer counts (ordinary
groups and layers do not count), and say an image nested deeper is not
written. The Perspective Distort line cites the two nesting tests.
2026-11-20 17:24:20 -08:00
dotCooCoo 5511fb21c0 Docs: distorted images nested past the .ai writers' depth limit are written at their nearest placement
The mesh paragraph in docs/mcp.md named DXF, WMF and HP-GL as the only
exports that do not draw a distorted image as a mesh. The editing data
of a .ai file writes an image inside 8 or more nested opacity masks,
symbols, live objects and pattern tiles as the parallelogram nearest its
corners, and a legacy .ai (version 7) does so inside 8 or more nested
symbols and live objects, each with a warning. The paragraph and the
Perspective Distort line in docs/target-app-parity.md now say so.
2026-11-20 17:11:16 -08:00
dotCooCoo 4df95ec51f Flare: a lone x2 or y2 in shape.flare is an error
shape.flare took the rings' end point only when both x2 and y2 were
numbers. Given one of them alone, it dropped it and placed the end point
from pathLength and direction instead. It now refuses the call with
"missing number `y2`" (or `x2`), as shape.editFlare already does, draws
nothing and adds no undo step. With neither, or both null, pathLength
and direction still place the end point.

Saved flare settings that hold only one of x2 and y2 are no longer read
as an editable flare; the group stays as art.

Docs: params text, docs/mcp.md, docs/target-app-parity.md.
2026-11-20 17:06:34 -08:00
dotCooCoo bbc183f793 Tests: fetch a pinned public script corpus and report its headless pass rate
Part of #1210.

- `cargo xtask corpus --scripts` fetches 397 scripts and 1 included file
  from 19 MIT and Apache-2.0 repositories at pinned commits into
  corpus/scripts, each repository's license file beside its scripts.
  xtask/script-corpus.txt lists every file with its size and SHA-256; a
  download replaces the previous copy only when both match. One more
  candidate is listed as excluded because it is over the 1 MiB limit for
  one script. The fetch caps 64 MiB of scripts and 128 MiB of transfer,
  refuses `..`, absolute paths, reserved names, case-fold collisions and
  links, and holds a lock file while it runs.
- `cargo xtask corpus` takes at most one of --download, --affinity and
  --scripts, and refuses other arguments with the usage text.
- `cargo xtask scripts --pass-rate [--report <path>]` runs each script in
  a process of its own (the ignored `row` test in
  crates/engine/tests/script_corpus.rs): a new document, 5,000,000
  instructions, no dialog answers, file reads only in the script's
  repository folder and a new folder of its own, file writes only in that
  folder, stopped after 10 seconds. It writes a JSON report with the pass
  rate overall, per repository and for scripts without dialogs or
  windows, how many parse, and each script's outcome, with local folders
  removed from messages. Script failures never fail the command, and
  without the corpus it prints a skip line and exits 0.
2026-11-20 16:47:30 -08:00