Commit Graph
133 Commits
Author SHA1 Message Date
dotCooCoo 93789dd3e3 Merge main into fix/graph-design-art-paint 2026-11-14 21:45:07 -08:00
dotCooCoo 2b164f6138 Merge main into fix/graph-design-art-paint 2026-11-14 20:04:05 -08:00
dotCooCoo 39a4de61cb Merge main into fix/aligned-paint-rows-of-design-art 2026-11-14 20:00:33 -08:00
dotCooCoo b1acfaf5d4 Merge main into fix/aligned-paint-rows-of-design-art 2026-11-14 19:10:09 -08:00
dotCooCoo 6aab3e3280 Merge main into fix/graph-design-art-paint 2026-11-14 19:05:44 -08:00
dotCooCoo 63aeb358c9 Graphs: proxy recolors keep a group's own paint and spread checks on design art alone
paint.invert and paint.complement without an item recolor a given group's own fills and strokes with the objects inside it again, except with target "contents", and leave the art of graph designs inside it as it is. A given member of a compound path stands for the compound path.

paint.editGradient with a spread or a negative aspect for design art alone no longer checks it against the kind of the default gradient, so it changes nothing instead of failing. A bad value is still an error.
2026-11-14 19:05:43 -08:00
dotCooCoo f6ecf49a19 Graphs: Invert, Complement and stroke weights of a design's art alone leave the new-art defaults
With only the art of a graph design in a series given or selected, paint.invert and paint.complement without an item recolored that art and remembered its new color, and stroke.set with a weight set the stroke weight for new art. Invert and Complement now leave the art out, as they do with an item, also when they are given the whole graph or a series group, and with only design art they change nothing. stroke.set with only design art leaves the weight for new art as it is.

An item the art has no row of that kind for is still an error in the commands that leave the art out, as on any other object, and so is a bad aligned or target param. Without stroke, paint.editGradient and paint.setGradientGeom read the kind of an item named on design art alone from that art's row.
2026-11-14 18:04:28 -08:00
dotCooCoo 2d790aab20 Merge main into fix/graph-design-art-aligned-rows 2026-11-14 16:21:34 -08:00
dotCooCoo 031fb6565e Appearance: aligned edits with a graph design's art follow the art's stack
- appearance.moveItem with from "contents" and aligned: true is refused when
  the objects' stacks differ, as it is for rows.
- paint.invert and paint.complement with an item remember the paint of an
  object they recolored, not that of design art they left out.
- effect.remove and effect.duplicate with indices and aligned: true are an
  error, and change nothing, when the design art given first has no effect
  at one of the indices.
2026-11-14 13:17:29 -08:00
dotCooCoo 6a895f1a3b Merge main into fix/graph-design-art-paint 2026-11-14 12:23:42 -08:00
dotCooCoo 771b4e54b5 Graphs: invert and complement remember the equal row they recolor; document aligned
With a mixed selection and the Appearance panel's active row, paint.invert
and paint.complement recolor each object's row equal to the active one,
but remembered the color at the active row's index in the first object in
paint order, which can be another row. They now remember the row they
recolor there, as the gradient and freeform edits do.

The params text of paint.setFill, paint.setStroke, paint.invert,
paint.complement, paint.lastColor, paint.lastGradient, stroke.setAdvanced,
paint.editGradient, paint.setGradientGeom and the paint.freeform edits now
lists `aligned`. docs/mcp.md names paint.lastColor and paint.lastGradient,
which take the same rows as paint.setFill, and docs/target-app-parity.md
gets a line for the rows of a design's art.
2026-11-14 11:14:22 -08:00
dotCooCoo 3b1c068f30 Merge main into fix/graph-design-art-aligned-rows 2026-11-14 09:57:39 -08:00
dotCooCoo c8f046c74d Merge main into fix/aligned-paint-rows-of-design-art 2026-11-14 09:00:08 -08:00
dotCooCoo 90a2bd0494 Graphs: aligned paint and stroke rows given with a design's art are rows of its stack
paint.setFill, paint.setStroke, paint.invert and paint.complement with an
item, stroke.set, stroke.setAdvanced, paint.editGradient,
paint.setGradientGeom and the paint.freeform edits read an item given with
aligned: true and the art of a graph design in a series first as a row of
the art's stack, as appearance.setItem and transparency.set do. Each other
object edits the row equal to it and an object without one is left as it
is. A row the art does not have, a row of the other kind, or a row no
other object has is an error, also when the art is the only object given,
and the document and its undo history stay as they are. Without stroke,
the gradient commands edit the kind of the art's row.

The objects and ids the commands report, a gradient spanning the
selection, and the last color and last gradient count only the objects
whose row was edited.
2026-11-14 08:54:28 -08:00
dotCooCoo d233cd8291 Merge main into fix/graph-series-group-opacity 2026-11-14 05:57:05 -08:00
dotCooCoo f4281d3cc0 Graphs: test the effect edits on rows of a design's art, document aligned on effect.apply
effect.apply and appearance.addEffect take `aligned`, and their params
text now says so, with the rule for a graph design's art given first.

The tests add appearance.addEffect, a 3D effect.apply with an object
that has no equal row, effect.setParams and effect.duplicate on a row
of the art, and the removal of an object-level effect equal to the
art's. They also check that appearance.setItem and appearance.removeItem
on a row no other object has leave the art as it is and record no undo
step.
2026-11-14 04:18:45 -08:00
dotCooCoo 9b65454983 Graphs: aligned rows given with a design's art stay rows of its stack
The Appearance and effect commands leave the art of a graph design in a
series out, and aligned rows were then matched against the first object
left over. With the art given first, appearance.removeItem with index 1
and aligned: true on art [red fill, blue fill] and a mark [blue fill,
stroke] removed the mark's stroke instead of its blue fill.

When the first object given is design art, rows and effects given with
aligned: true are now rows of the art's stack, and each other object
edits the row or effect equal to it. An object without one is left as
it is. This covers appearance.setItem, appearance.removeItem,
appearance.duplicateItem, transparency.set with an item, effect.apply,
appearance.addEffect and the effect commands that edit or remove an
effect. When no object has one, appearance.setItem and
appearance.removeItem change nothing, as they do for a row no object
has, and the other commands are an error. appearance.moveItem,
effect.move and appearance.duplicateItem with `to` compare the art's
stack too, and are an error when it differs from the other objects'.
The effect dialog reads the effects of such a row from the art's stack,
and passes the art on with the other objects.

docs/mcp.md states the rule.
2026-11-14 03:39:54 -08:00
dotCooCoo bf3a23d031 Merge main into fix/graph-label-paint-recolor 2026-11-14 02:19:54 -08:00
dotCooCoo ded56d3d70 Merge main into fix/graph-series-group-opacity 2026-11-14 02:15:46 -08:00
dotCooCoo 6344e07ad1 Merge main into fix/graph-design-art-paint 2026-11-14 01:56:07 -08:00
dotCooCoo eb9976a825 Merge main into fix/graph-label-paint-recolor 2026-11-13 19:22:11 -08:00
dotCooCoo 78ce56d021 MCP: an integer given as a string or a fraction is refused as the wrong type, not reported as missing
A command that needs a whole number of 0 or more, such as `index` of
`appearance.setItem`, `anchor` of `path.removeAnchor` and
`addon.pen.removePoint`, `sourceDocument` of `edit.dropSelection`, `index`
of `document.activate` and `to` of `document.move`, answered "missing
integer `index`" (or "missing index") both when the key was left out and
when it was given as a value that is not a whole number of 0 or more, such
as "3", 2.5, -1 or true. A value that is given but is not one is now
refused with "`index` must be a whole number", the message object ids
already use. A key left out or given as null is still missing, and an
optional index such as `subpath` keeps its default. Neither error changes
the document or records an undo step.

Docs: docs/mcp.md, docs/target-app-parity.md.
2026-11-13 18:02:42 -08:00
dotCooCoo 01043c05cd Graphs: paint, stroke and transparency commands leave a design's art in a series out
The graph draws the art of a column or marker design in a series again
from the design when its data, type or designs change, and an edit made
to that art is lost.

- stroke.set, stroke.weightUp, stroke.weightDown, stroke.setAdvanced,
  paint.editGradient, paint.setGradientGeom, object.setOverprint,
  paint.swap, paint.default, and paint.invert and paint.complement with
  an item leave the art out and edit the other objects given.
- transparency.set without an item, the paint.freeform.* commands that
  edit points and lines, graphicStyle.breakLink and
  effect.expandAppearance are an error when all their objects are
  design art. Expand Appearance is disabled for a selection of only
  design art, and it leaves the design art inside a selected graph or
  series group as it was.
- When the first selected object is design art, the commands do not
  use the Appearance panel's active row, which is a row of that art.
- The error names the command that ran.

docs/mcp.md lists the commands. The params texts of the appearance.*
commands and graphicStyle.apply name the rule, and the Graph column
designs entry in docs/target-app-parity.md states it.
2026-11-13 17:49:07 -08:00
dotCooCoo 87b4a8053b Merge main into fix/graph-series-group-opacity 2026-11-13 16:49:51 -08:00
BFlat c79a21c8b7 Merge pull request #7320 from dotCooCoo/fix/graph-design-art-appearance
Graphs: Appearance and effect commands leave a design's art in a series out
2026-11-14 07:33:59 +07:00
dotCooCoo 89ee320591 Graphs: a series group also keeps its isolation and knockout
transparency.set and object.setProps with isolate, knockout or
knockoutShape on a series group now store them for the series
(groupIsolate, groupKnockout, groupKnockoutShape), and the series group
has them again when the graph is drawn again. Randomize Opacity, Sort
Objects and Global Edit store the opacity they give a series group, so
a redraw no longer puts back an older stored value over it.

A move or copy of an appearance onto a series group whose stored values
differ from its own now counts as a change, so the edit is kept. Tests
cover graphicStyle.redefine of a style linked to a series group.
2026-11-13 16:02:54 -08:00
dotCooCoo f6d90063fc Merge main into fix/graph-label-paint-recolor 2026-11-13 15:33:30 -08:00
BFlat 6fa41d4f76 Merge pull request #7304 from dotCooCoo/fix/graph-series-object-opacity-other-commands
Graphs: Global Edit, Randomize Opacity and Sort Objects keep what they give a series
2026-11-14 06:26:22 +07:00
dotCooCoo 4129587abe Graphs: recolor, stroke and gradient edits on labels are kept for their kind
A recolor of a graph (Invert and Complement on the proxy, the Edit Colors
commands, Recolor Artwork, the color filters, Apply Nearest Swatch and the
ink limit of Print Ink Fixes) stored the new paint of the series marks but
not of the labels. stroke.set, the stroke weight steps, the gradient edits,
Swap Fill and Stroke and Default Fill and Stroke stored nothing when they
changed a label's characters. When the graph was drawn again, the labels
went back to their stored style.

- These commands now store, for every label of the kind they reach, the
  label's object rows when they change, and the fill, stroke, stroke weight,
  caps, joins, miter limit, dashes and stroke alignment of its characters
  when all of them show the change alike.
- A gradient is stored without its placement, and each label fits it to its
  own box. A stroke weight and dashes are stored as a scaled label shows
  them.
- When labels of one kind change differently, the frontmost one sets what
  the kind keeps.
- On a pie with Legends in Wedges, the legend labels' fill is stored only
  when every legend label reached ends up with the same fill, so a recolor
  of the whole pie leaves them black or white by their wedge.
- Axis lines, ticks and radar rings are not stored and are drawn again with
  their default paint.

Docs: docs/mcp.md, the commands' params text, docs/target-app-parity.md.
2026-11-13 15:22:55 -08:00
dotCooCoo d132c330d0 Merge #7304 (fix/graph-series-object-opacity-other-commands) into fix/graph-series-group-opacity 2026-11-13 15:18:09 -08:00
dotCooCoo 2ae9a8f0f0 Graphs: an opacity or blend mode set on a series group is kept
transparency.set and object.setProps with an object opacity or blend mode,
given a series group picked with Group Selection, set the group's own
opacity and blend mode, and the graph drew its series groups again
without them. The graph now stores them for the series (groupOpacity and
groupBlend) and puts them back on the series group when it is drawn
again. Commands that clear the group's own opacity and blend mode
(appearance.clear, graphicStyle.apply, appearance.transfer onto the
group, graphicStyle.redefine of a linked group) remove what the graph
stores.
2026-11-13 14:52:08 -08:00
dotCooCoo 0d26724a7c Graphs: Appearance and effect commands leave a design's art in a series out
A graph draws the art of a column or marker design inside a series again
from the stored design. Rows, effects and graphic styles that a command
gave that art were lost the next time the graph's data, type or size
changed. The paint commands already left the art out.

- The appearance.* row and whole-appearance commands, effect.apply,
  appearance.addEffect and the effect.* commands that edit, move or
  remove an effect, threeD.mapGraphic, graphicStyle.apply,
  graphicStyle.addFromLibrary with apply, transparency.set with a fill
  or stroke item, and appearance.copyFrom (as the target) leave out any
  object inside a series group other than a path directly in it, given
  by id, selected or reached through target: "contents". They edit the
  other objects given, and a command whose objects are all design art
  is an error.
- appearance.transfer with design art as its target, or as its source
  without copy, is an error.
- A Pathfinder effect no longer groups selected design art.
- The paint commands given a design's copy with a fill or stroke item
  leave it out as well.

docs/mcp.md states the rule, and the Graphs line in
docs/target-app-parity.md names it.
2026-11-13 14:51:31 -08:00
BFlat 2fe70b2483 Merge pull request #7258 from dotCooCoo/fix/graph-label-appearance-kept
Graphs: Appearance edits on a label are kept for every label of its kind
2026-11-14 05:42:08 +07:00
dotCooCoo 6e308c4e54 Graphs: Global Edit, Randomize Opacity and Sort Objects keep what they give a series
A path directly in a graph series lost what these commands gave it when
the graph was drawn again, for example after graph.setData:

- While Global Edit is on in an isolated graph, a match that is a series
  path, or a series group whose paths take the edit, now has what
  changed on its paths stored for their series: the paint, weight,
  opacity and blend mode of the topmost visible fill and stroke, and the
  object's opacity and blend mode. The edited match is stored by its own
  command as before.
- addon.arrange.randomizeOpacity and addon.arrange.sort with apply
  "opacity" now store the object opacity, with the blend mode, of the
  series paths whose opacity they change. When they change several
  paths of one series, the frontmost of them sets what the graph
  stores, as for the other commands.

The graph stores them in the same undo step as the edit. The params
text of addon.arrange.randomizeOpacity and addon.arrange.sort,
docs/mcp.md and docs/target-app-parity.md describe the new behavior.
2026-11-13 13:53:55 -08:00
BFlat 4558196e16 Merge pull request #7053 from dotCooCoo/feat/warichu
Type: Warichu stacks selected characters on lines inside their line
2026-11-14 04:32:40 +07:00
dotCooCoo fdedfb0e59 Merge main into feat/warichu 2026-11-13 11:59:22 -08:00
dotCooCoo 5c0f22b345 Graphs: Appearance edits on a label are kept for every label of its kind
A fill or stroke row that the Appearance commands gave a graph label, its
object opacity, and the characters the Eyedropper gave it lasted only
until the graph was drawn again: the graph stored nothing for a label's
rows, and the Eyedropper's character attributes were not stored.

- The graph keeps, for value axis numbers, category labels and legend
  labels, the paint, weight, opacity and blend mode of a label's topmost
  visible fill and stroke row, their order and place relative to the
  Characters row, and the label's object opacity and blend mode
  (labelStyles valuesRows, categoriesRows, legendRows). Every label of
  the kind gets those rows when the graph is drawn again, with a placed
  gradient fitted to each label.
- Every appearance.* command stores them, and so do graphicStyle.apply
  and redefine and the paint, stroke, gradient and transparency edits
  aimed at a row, even when the label already showed them.
  transparency.set without a row and object.setProps store only the
  object opacity and blend mode. With several labels of a kind, the last
  one edited wins.
- appearance.copyFrom onto all of a label's text stores the character
  attributes it applied and, from type, the paragraph attributes; a
  transparency pick stores the object opacity and blend mode, and
  append stores the rows.
- paint.setFill and paint.setStroke store a character fill or stroke
  only when the characters take the paint (the whole label, or all of
  its text highlighted with the Type tool); aimed at a row, they store
  the row.
- Document Color Mode and swatch edits reach the kept rows.

Docs: docs/mcp.md, the commands' params text, docs/target-app-parity.md.
2026-11-13 11:35:27 -08:00
dotCooCoo 3c434a7e90 Merge main into fix/graph-series-paint-visible-rows 2026-11-13 10:02:14 -08:00
dotCooCoo 5d31439e46 Merge main into fix/graph-series-paint-other-commands 2026-11-13 09:57:15 -08:00
dotCooCoo 87ad60ec42 Merge main into fix/graph-series-group-appearance 2026-11-13 08:15:48 -08:00
dotCooCoo 9a1d36c57e Merge main into fix/graph-series-paint-visible-rows 2026-11-13 08:14:30 -08:00
dotCooCoo b8ab31ff50 Merge main into fix/graph-series-paint-other-commands 2026-11-13 08:13:53 -08:00
dotCooCoo b6aaea6c97 Graphs: Appearance commands and graphic styles given a series group edit its marks
A graph draws its series groups again with no rows of their own, so a
fill, stroke, opacity or graphic style that a command put on a series
group was lost the next time the graph's data, type or size changed,
and the graph stored nothing. paint.setFill and paint.setStroke already
pass a series group's id on to the paths directly inside it.

- appearance.addFill, addStroke, setItem, removeItem, duplicateItem and
  moveItem, graphicStyle.apply and transparency.set with a fill or
  stroke item now edit the paths directly in a series group given by id
  or picked with Group Selection, and the graph stores what they change.
  A series group with no such path, or with a fill or stroke row of its
  own, is still edited itself, and appearance.moveItem from "contents"
  still moves the group's own Contents row.
- appearance.clear, appearance.reduceToBasic, appearance.showAllHidden
  and graphicStyle.breakLink edit the group as well as its paths.
- graphicStyle.apply without add and appearance.transfer onto a series
  group clear the group's own opacity, blend mode, isolation, knockout,
  effects and style link, and graphicStyle.apply with add unlinks the
  group. A transfer source that is one of the group's paths keeps its
  look, and a source that is the group's only path is an error.
- graphicStyle.redefine passes the style to the paths of a linked series
  group, other than the source and the linked paths whose look was
  edited, and clears and unlinks the group.
- graphicStyle.new, graphicStyle.redefine and appearance.transfer read a
  series group that holds no row, effect, opacity, blend mode,
  isolation, knockout or style link of its own through the topmost path
  directly in it, and a move clears each of those paths. A series group
  that holds one of them is read itself, as before.
- The Graphic Styles panel reads the style link of such a selected
  series group from that path.

Docs: docs/mcp.md, docs/target-app-parity.md. Not yet: the Appearance
panel and appearance.setActiveItem still read the selected group's own
rows, and the effect commands and the paint, stroke and gradient
commands with an item still edit the group itself.

Follows #5501.
2026-11-13 07:25:03 -08:00
dotCooCoo 2343e0e8b0 Graphs: paint commands store a series' paint only from the row a mark shows
paint.setFill, paint.setStroke, paint.none, Apply Fill to Stroke, Apply
Stroke to Fill and a library gradient or pattern applied with library.use
stored the topmost fill or stroke row of a graph series mark on the graph
even when that row was hidden, and stored a stroke set on a Filled Lines
band. When the graph was drawn again, every mark of the series took a
paint that the edited mark never showed, and a band took the stroke color
as its fill.

These commands now follow the rules of the Appearance commands:

- The graph stores the paint only when the row the command wrote is the
  topmost visible row of its kind, or when the command changed what the
  mark shows. With `item`, that is the named row.
- A series that draws Filled Lines bands stores no stroke paint or
  weight; the band keeps its own outline.
- A row without paint before and after the command keeps what the graph
  stores, so None on a marker without a stroke no longer removes the
  line's stored stroke.
- When one command writes several marks of a series, the frontmost mark
  sets what the graph stores, whatever the order of the ids.
- Apply Fill to Stroke and Apply Stroke to Fill on a mark whose row
  already has the paint store it, as paint.setFill does.

A document without graph series marks among the edited objects skips the
comparison of paints.

Docs: docs/mcp.md and the params text of the paint commands.
2026-11-13 06:20:05 -08:00
dotCooCoo cf4d27c38e Graphs: stroke, gradient and recolor commands update a series' stored paint
A stroke weight set with stroke.set or stroke.weightUp/weightDown, a
gradient made, placed or edited with paint.editGradient,
paint.setGradientGeom or the freeform gradient edits, and colors changed
by paint.invert, paint.complement, the Edit Colors recolor and Blend
commands, recolor.apply, addon.color.filter,
addon.color.applyNearestSwatch or the ink limit of
addon.color.printFixes changed a series mark but not the paint the graph
stores, so the mark went back to the old paint when the graph was drawn
again.

appearance::edit_items now stores what its edit changes on the topmost
visible fill and stroke of series marks, as the Appearance commands do,
and the recolor pass does the same for the series marks it reaches,
including those inside a series group or a graph it is given. When one
command changes several marks of a series, the frontmost one sets the
stored paint. A gradient is stored with its placement.

These commands do not store the colors they give a graph's axes and
labels. docs/mcp.md, the params text and the Graphs line in
docs/target-app-parity.md say what is stored.
2026-11-13 05:08:19 -08:00
dotCooCoo 6b55d7ca3e Eyedropper: a whole pick that removes a series mark's painted row replaces the stored transparency
A whole pick from a source with no fill row, or no stroke row, removes
that row from the target. When the target is a graph series mark whose
row had paint, the pick now replaces the row opacity and blend mode the
graph keeps for that kind of row in the series. A row that had no paint
before the pick still leaves the kept values as they are, and a pick of
some attributes from such a source is unchanged.
2026-11-13 04:50:59 -08:00
dotCooCoo 2170ddcac4 Eyedropper: a pick that leaves a series mark's row without paint replaces the stored transparency
An Eyedropper pick that includes transparency now counts a fill or stroke
row that had paint before the pick and has none after it when it stores
the series' row opacity and blend mode on the graph, as graphic styles
already do. Before, such a pick left the opacity and blend mode another
mark of the series had stored, and the series was drawn with them again
after its data changed. A row that had no paint before the pick still
leaves the stored values as they are.
2026-11-13 04:05:56 -08:00
dotCooCoo 226ac437b9 Type: Warichu stacks selected characters on lines inside their line
The Character panel menu has Warichu and Warichu Settings… with Show East
Asian Options. Warichu characters are set at a percentage of their size
and stacked on 1 to 6 lines inside their line: one above the other in
horizontal type and side by side in vertical type. Warichu Settings sets
Lines, Line Gap, Scale and Alignment.

- text.setFormat and text.setRangeStyle take warichu, warichuLines,
  warichuGap, warichuScale and warichuAlign; ui.warichuSettings opens
  the dialog.
- A stretch of warichu characters is one block that stays whole on one
  line. The canvas and every export draw the stacked lines; SVG, PDF and
  the .ai writers write such type as outlines, as they do ruby. Type on a
  path sets the characters at their own size.
- The attributes are saved natively, carried by character styles and
  translated in every complete catalog.

Docs: docs/mcp.md, docs/type-parity.md.
2026-11-12 21:13:21 -08:00
BFlat 81247fdae9 Merge pull request #6666 from dotCooCoo/fix/malformed-id-not-missing
MCP: a malformed object id is refused as such, not reported as missing
2026-11-12 19:14:06 +07:00
Sven Lafebre ab17837cba Merge remote-tracking branch 'origin/main' into fix/5111-kern-paragraph-start
# Conflicts:
#	docs/target-app-parity.md
2026-11-12 09:24:22 +01:00