Commit Graph
842 Commits
Author SHA1 Message Date
BFlat f15f711280 Merge pull request #7870 from dotCooCoo/fix/pdf-preserve-numbers-tagged-images
PDF export: Preserve Numbers converts tagged images from their profile
2026-11-16 08:11:02 +07:00
BFlat d150b244d4 Merge pull request #7984 from dotCooCoo/fix/import-fuzz-sliced-psd-samples
Tests: fuzz PSD slices in versions 6, 7 and 8
2026-11-16 08:10:53 +07:00
BFlat b7a1428325 Merge pull request #7935 from dotCooCoo/fix/psd-relink-clip
Links: relinking a clipped PSD follows the new file's clipping path
2026-11-16 06:54:59 +07:00
BFlat ad94d5dd7a Merge pull request #7967 from dotCooCoo/fix/svg-artboard-export-keeps-brushed-path
SVG: an artboard's SVG keeps a brushed path whose brush art reaches it
2026-11-16 06:54:29 +07:00
dotCooCoo 846d000486 Merge main into fix/pdf-preserve-numbers-tagged-images 2026-11-15 13:58:49 -08:00
dotCooCoo 740b1e3f7e Tests: fuzz PSD slices in versions 6, 7 and 8
import_fuzz builds PSD files from scratch whose image resource 1050
holds slices in version 6 (a version 16 descriptor after the first
record) and in the version 16 descriptors of versions 7 and 8. Each
sample has one user slice, one slice that follows a layer and one
generated automatically; the first two come in as user slices.

- the_sliced_psd_samples_bring_in_their_user_slices: each sample opens
  with its two user slices and no warning, document.psdInfo counts 2,
  and an embedded place brings 2.
- sliced_psd_samples_with_huge_counts_or_cut_short_come_in_without_their_slices:
  slice counts of 10,001, 0x7fffffff and u32::MAX, data one byte
  short, and data cut inside the count bring the art in without its
  slices and with a warning.
- mutated_psd_slices_never_panic: mutated slice data, kept whole, cut
  short with the resource length rebuilt, or with the file cut in the
  resource block, never makes document.open, document.psdInfo or an
  embedded file.place report an internal error.

tests_psdslices::damaged_slices_never_panic now fails when a command
reports an internal error instead of discarding the results.
2026-11-15 13:57:26 -08:00
BFlat d87cc85a90 Merge pull request #7917 from dotCooCoo/fix/pdf-trim-artboards-keep-bleed
Import PDF: artboards on trim boxes keep the bleed between them
2026-11-16 04:29:59 +07:00
BFlat 087246a785 Merge pull request #7896 from dotCooCoo/fix/svg-image-check-follows-writer
MCP: confined SVG output checks the linked images the file draws
2026-11-16 04:29:28 +07:00
BFlat 58cb42509e Merge pull request #7805 from dotCooCoo/fix/an-image-whose-recode-fails-is-written-without
PDF export: an image whose colors can't be converted is left out with a warning
2026-11-16 04:28:53 +07:00
BFlat f8eeaaca41 Merge pull request #7893 from dotCooCoo/fix/psd-v6-record-id-16
PSD: a version 6 slice record whose ID is 16 is read as a slice
2026-11-16 04:28:11 +07:00
dotCooCoo e45b36f5aa Merge main into fix/svg-artboard-export-keeps-brushed-path 2026-11-15 12:20:35 -08:00
dotCooCoo 9c5eac0d17 SVG: an artboard's SVG keeps a brushed path whose brush art reaches it
An SVG or SVGZ of a chosen artboard left out a brushed path lying just
off the artboard even when its brush art painted onto it, as the
artboard filter measured the path without room for its brush art. The
filter now leaves the room PDF and EPS export leave
(vectorcraft_brush::reach_within): none for a brushed stroke without a
paint, only the clipping path's for a clip group, and only a compound
path's own strokes.
2026-11-15 12:19:17 -08:00
dotCooCoo 0b1b948f55 Merge main into fix/pdf-preserve-numbers-tagged-images 2026-11-15 12:15:12 -08:00
dotCooCoo 1c5d5ea4ba Merge main into fix/pdf-preserve-numbers-tagged-images 2026-11-15 12:15:12 -08:00
FredApps 33b5706c7a Merge pull request #7664 from storytold/fix/restore-codec-cutover-ci
Restore shared codec cutover with CI compatibility fixes
2026-11-15 21:05:52 +01:00
dotCooCoo cbe83c89a7 Links: relinking a clipped PSD follows the new file's clipping path
links.relink and links.update kept a PSD or PSB file's clip group as it
was, so an image relinked to a file with another clipping path, or with
none, stayed clipped to the old file's path, and a plain image relinked
to a clipped PSD came in unclipped.

- The PNG a PSD or PSB file's merged image is kept as now carries the
  clipping path the file names in a text chunk, and RasterImage.clip
  holds it with its fill rule (even-odd), as it holds a DCS file's
  (nonzero).
- links.relink and links.update read that path the way they read a DCS
  file's: the clip group's clipping path becomes the new file's, a file
  that names none leaves a plain group of the image, and a later file
  that names one clips it again. A clip group whose path or fill rule
  was changed in the document stays as a clipping mask around the
  file's clip group.
- docs/mcp.md and the evidence line in docs/target-app-parity.md
  describe the new behavior.
2026-11-15 11:04:20 -08:00
dotCooCoo f1507ccec3 Merge main into fix/an-image-whose-recode-fails-is-written-without 2026-11-15 10:54:25 -08:00
dotCooCoo a6d9dd2881 Import PDF: artboards on trim boxes keep the bleed between them
Opening a PDF with Crop To Trim Box put each artboard 36 pt after the
one before, while the bleed boxes round the trim boxes became the
document's bleed. With a bleed over 18 pt, one page's bleed reached
into the next artboard, and a page exported with its bleed showed part
of its neighbor. The document's bleed is now read from every picked
page first, and the artboards are 36 pt apart plus that bleed on both
sides, as linked pages on their trim boxes are laid out since #7723.
2026-11-15 10:34:12 -08:00
BFlat f4f0c49501 Merge pull request #7892 from dotCooCoo/fix/psd-cut-short-slices-warn
PSD: a slices resource cut short warns that the slices were left out
2026-11-16 01:33:18 +07:00
dotCooCoo 1e32738b8f MCP: confined SVG output checks the linked images the file draws
The read-root check for SVG output now looks at the same art the
writer draws:

- A placed document's art is checked, with the pixels its file holds.
  A placed native file that links an image outside the read roots was
  written with that path under Images: Link.
- Hidden objects inside symbols, patterns and graph designs are left
  out unless hidden layers are kept, as they are in the layers.
- With profile tiny12 the file leaves out opacity masks, and their
  images are not checked.
- An object whose effect SVG has no filter for is checked as the image
  the file draws of it, for file output and clipboard.exportSvg alike.

The last three refused files and clipboard SVG that name no file
outside the roots.
2026-11-15 09:13:08 -08:00
dotCooCoo 303d0c0a05 PSD: a version 6 slice record whose ID is 16 is read as a slice
A version 6 slices resource may follow a record with a descriptor of
version 16, and the reader took any record that starts with the value
16 for one. A record whose ID is 16 then had its first bytes read as a
descriptor, and the records after it were misread or left out. When the
records read one after another, followed by nothing or by one
descriptor (the layout ag-psd writes), only the last record is checked
for a descriptor. Files that follow each record with a descriptor are
read as before.
2026-11-15 08:45:10 -08:00
dotCooCoo dc8054fb39 PSD: a slices resource cut short warns that the slices were left out
When image resource 1050 declared more bytes than the image resources
hold, the lookup stopped as if the file stored no slices, and Open and
Place brought the artwork in without the warning that the slices were
left out. The new psdread::resource tells a cut-short resource 1050
apart from one that is absent or that follows another block cut short,
and the slices reader passes that error on, so the warning names it.
Other resource readers keep their behavior.
2026-11-15 08:45:10 -08:00
dotCooCoo 411310a757 PDF export: Preserve Numbers converts tagged images from their profile
With Output › Convert to Destination (Preserve Numbers), and in PDF/X-1a,
which converts the same way, a gray or RGB image that carries an ICC
profile had its numbers read as sRGB: converted as sRGB to a CMYK
destination, and kept as they were in an RGB one. Preserve Numbers keeps
the numbers of untagged content only, so such an image is now converted
from its profile to sRGB with the color settings' intent, and then to a
CMYK or other RGB destination, the document's own RGB profile included.

- An untagged RGB image keeps its numbers in an RGB destination and
  converts from sRGB to a CMYK one, as before.
- A gray image is converted to sRGB grays in an sRGB destination and
  keeps its profile in the others.
- With RGB colors ICC-tagged as sRGB, the image is written as sRGB.
- A profile the color engine can't read leaves the image as it is in an
  RGB destination, and its numbers read as sRGB in a CMYK one, with a
  warning each.
- The table for an RGB destination is built only when the first tagged
  image needs it.
2026-11-15 07:28:29 -08:00
dotCooCoo ec4a1ac25d PDF export: a set Don't Include Profiles removes image color profiles
When Profile inclusion is set to Don't Include Profiles (`profiles:
"none"`), gray, RGB and CMYK images are written in device color spaces
without their ICC profiles, and a JPEG that is kept as is loses its
APP2 ICC_PROFILE segments. PDF/A-2b, PDF/X-3 and PDF/X-4 keep tagging
their images.

Leaving the setting out keeps the earlier output. `profiles` now
serializes as null when not set, `"default"` clears a preset's value,
and Save PDF > Output lists Default first. Presets and stored settings
saved earlier hold `"profiles": "none"`, so exports from them now drop
image profiles.
2026-11-15 07:27:08 -08:00
FredApps c9cad8d017 Merge main into fix/restore-codec-cutover-ci
Port main's new variable-library parsing (variable kinds, image, visibility
and graph values) from roxmltree to craft-xml with the branch's strict
options and attribute validation. Keep both sides' variable tests.
Drop the stale docx::nesting doc link.
2026-11-15 15:43:44 +01:00
dotCooCoo 5ce407dfbf Merge main into fix/an-image-whose-recode-fails-is-written-without 2026-11-15 06:17:33 -08:00
BFlat 3239725c40 Merge pull request #7817 from dotCooCoo/feat/psd-import-options-import-slices-after-7649
PSD: Import Slices brings a file's slices in as user slices on Open and Place
2026-11-15 20:45:50 +07:00
BFlat 1d47588e77 Merge pull request #7798 from dotCooCoo/fix/save-and-save-for-older-apps-read-the-placed
Save: read the images and placed documents in stored brush art
2026-11-15 16:39:45 +07:00
dotCooCoo d842aa816c Merge main into feat/psd-import-options-import-slices-after-7649 2026-11-15 00:50:14 -08:00
BFlat 6dc068b162 Merge pull request #7703 from dotCooCoo/feat/color-management-policies
Color Settings: RGB and CMYK policies keep, take off or convert a document's profiles on open
2026-11-15 15:46:48 +07:00
BFlat f94b97c4d5 Merge pull request #7789 from dotCooCoo/fix/an-opaque-16-bit-cmyk-tiff-s-inks-are-rounded
TIFF: an opaque 16-bit CMYK TIFF's inks are rounded to 8 bits for display
2026-11-15 15:43:49 +07:00
dotCooCoo 8afaaec3f8 Merge main into feat/psd-import-options-import-slices-after-7649 2026-11-15 00:16:53 -08:00
dotCooCoo 34430eb82c Merge main into fix/an-image-whose-recode-fails-is-written-without 2026-11-15 00:16:02 -08:00
dotCooCoo 7a1b1c5f2e Merge main into fix/save-and-save-for-older-apps-read-the-placed 2026-11-15 00:02:09 -08:00
BFlat 97c3226d72 Merge pull request #7773 from dotCooCoo/feat/variables-panel-sort-columns
Variables: Variables, Objects and type columns sort the variable list
2026-11-15 14:43:04 +07:00
dotCooCoo 5f18834e55 Merge main into fix/save-and-save-for-older-apps-read-the-placed 2026-11-14 22:52:49 -08:00
dotCooCoo c0b1c2e144 Merge main into feat/color-management-policies 2026-11-14 22:51:34 -08:00
BFlat 0cef4fa727 Merge pull request #7743 from dotCooCoo/fix/legacy-ai-artboard
.ai import: legacy PostScript .ai files open on their own artboard
2026-11-15 13:50:00 +07:00
BFlat b43372361e Merge pull request #7746 from dotCooCoo/fix/replace-clipped-psd-keeps-transform
Place: a plain image replacing a clipped PSD keeps its scale and rotation
2026-11-15 13:49:22 +07:00
dotCooCoo d999d861de Color Settings: Convert to Working Space compensates CMYK black points
- CMYK colors converted between two loaded CMYK profiles now use the
  Color Settings black point compensation, as RGB colors already did:
  the conversion goes through linear ProPhoto RGB and maps the source
  profile's black onto the destination's.
- The edit.colorSettings, document.open and file.newFromTemplate params
  text and docs/mcp.md name file.newFromTemplate with the commands that
  apply the policies, and say that colorMode on open converts after the
  policies, through the profiles the document keeps.
- A test covers New from Template under the policies, and another the
  CMYK black point compensation.
2026-11-14 22:43:08 -08:00
dotCooCoo b867dee0b8 Merge main into fix/an-opaque-16-bit-cmyk-tiff-s-inks-are-rounded 2026-11-14 22:30:11 -08:00
dotCooCoo d5ccac5646 Variables: Variables, Objects and type columns sort the variable list
The Variables panel drew each variable as one "name · object" line in
the order the variables were defined, with no headers and no sorting.

The list now has three columns with headers: the type icon, Variables
and Objects. A click on a header sorts the list by that column, and a
second click reverses the order. The new command variable.sort {by:
name|object|type|none, descending?} sets the order, which is panel
state: not saved and not an undo step. variable.list lists the
variables in that order and reports it as sort. An unknown by, or a
descending that is not true or false, is an error.
2026-11-14 22:21:08 -08:00
dotCooCoo d0b69af348 Merge main into feat/psd-import-options-import-slices-after-7649 2026-11-14 22:06:58 -08:00
dotCooCoo 149280032e Merge main into fix/an-image-whose-recode-fails-is-written-without 2026-11-14 21:59:05 -08:00
dotCooCoo 3a060417aa Merge main into fix/save-and-save-for-older-apps-read-the-placed 2026-11-14 21:55:56 -08:00
dotCooCoo dd01ae03f7 PSD: the slices' version 6 descriptors share one limit of values
Each record's look-ahead descriptor read started with its own allowance
of 200,000 values, so a file with 10,000 records could make one Open read
about two billion. The descriptors of a slices resource now spend one
allowance between them, and a look-ahead that runs it out refuses the
slices with a warning instead of being read past.
2026-11-14 21:51:22 -08:00
BFlat 1a596c0362 Merge pull request #7653 from dotCooCoo/fix/svg-export-confined-image-links
MCP: SVG output under read roots refuses to name a linked image file outside them
2026-11-15 12:38:16 +07:00
dotCooCoo 456895bc53 Merge main into fix/save-and-save-for-older-apps-read-the-placed 2026-11-14 20:50:29 -08:00
dotCooCoo 0a95045f8f Merge main into fix/an-opaque-16-bit-cmyk-tiff-s-inks-are-rounded 2026-11-14 20:46:26 -08:00
dotCooCoo bee46530d8 Place: a plain image replacing a clipped PSD keeps its scale and rotation
Replace measured the image inside a PSD or PSB file's clip group only
when the new file brought its own clipping path. A plain image placed
with `replace` over such a clip group took only the group's center and
came in at 100%, losing the image's scale and rotation. The image in
the group is now measured whenever the new art is an image, clipped or
not.
2026-11-14 20:40:45 -08:00