import_fuzz builds PSD files from scratch whose image resource 1050
holds slices in version 6 (a version 16 descriptor after the first
record) and in the version 16 descriptors of versions 7 and 8. Each
sample has one user slice, one slice that follows a layer and one
generated automatically; the first two come in as user slices.
- the_sliced_psd_samples_bring_in_their_user_slices: each sample opens
with its two user slices and no warning, document.psdInfo counts 2,
and an embedded place brings 2.
- sliced_psd_samples_with_huge_counts_or_cut_short_come_in_without_their_slices:
slice counts of 10,001, 0x7fffffff and u32::MAX, data one byte
short, and data cut inside the count bring the art in without its
slices and with a warning.
- mutated_psd_slices_never_panic: mutated slice data, kept whole, cut
short with the resource length rebuilt, or with the file cut in the
resource block, never makes document.open, document.psdInfo or an
embedded file.place report an internal error.
tests_psdslices::damaged_slices_never_panic now fails when a command
reports an internal error instead of discarding the results.
An SVG or SVGZ of a chosen artboard left out a brushed path lying just
off the artboard even when its brush art painted onto it, as the
artboard filter measured the path without room for its brush art. The
filter now leaves the room PDF and EPS export leave
(vectorcraft_brush::reach_within): none for a brushed stroke without a
paint, only the clipping path's for a clip group, and only a compound
path's own strokes.
links.relink and links.update kept a PSD or PSB file's clip group as it
was, so an image relinked to a file with another clipping path, or with
none, stayed clipped to the old file's path, and a plain image relinked
to a clipped PSD came in unclipped.
- The PNG a PSD or PSB file's merged image is kept as now carries the
clipping path the file names in a text chunk, and RasterImage.clip
holds it with its fill rule (even-odd), as it holds a DCS file's
(nonzero).
- links.relink and links.update read that path the way they read a DCS
file's: the clip group's clipping path becomes the new file's, a file
that names none leaves a plain group of the image, and a later file
that names one clips it again. A clip group whose path or fill rule
was changed in the document stays as a clipping mask around the
file's clip group.
- docs/mcp.md and the evidence line in docs/target-app-parity.md
describe the new behavior.
Opening a PDF with Crop To Trim Box put each artboard 36 pt after the
one before, while the bleed boxes round the trim boxes became the
document's bleed. With a bleed over 18 pt, one page's bleed reached
into the next artboard, and a page exported with its bleed showed part
of its neighbor. The document's bleed is now read from every picked
page first, and the artboards are 36 pt apart plus that bleed on both
sides, as linked pages on their trim boxes are laid out since #7723.
The read-root check for SVG output now looks at the same art the
writer draws:
- A placed document's art is checked, with the pixels its file holds.
A placed native file that links an image outside the read roots was
written with that path under Images: Link.
- Hidden objects inside symbols, patterns and graph designs are left
out unless hidden layers are kept, as they are in the layers.
- With profile tiny12 the file leaves out opacity masks, and their
images are not checked.
- An object whose effect SVG has no filter for is checked as the image
the file draws of it, for file output and clipboard.exportSvg alike.
The last three refused files and clipboard SVG that name no file
outside the roots.
A version 6 slices resource may follow a record with a descriptor of
version 16, and the reader took any record that starts with the value
16 for one. A record whose ID is 16 then had its first bytes read as a
descriptor, and the records after it were misread or left out. When the
records read one after another, followed by nothing or by one
descriptor (the layout ag-psd writes), only the last record is checked
for a descriptor. Files that follow each record with a descriptor are
read as before.
When image resource 1050 declared more bytes than the image resources
hold, the lookup stopped as if the file stored no slices, and Open and
Place brought the artwork in without the warning that the slices were
left out. The new psdread::resource tells a cut-short resource 1050
apart from one that is absent or that follows another block cut short,
and the slices reader passes that error on, so the warning names it.
Other resource readers keep their behavior.
With Output › Convert to Destination (Preserve Numbers), and in PDF/X-1a,
which converts the same way, a gray or RGB image that carries an ICC
profile had its numbers read as sRGB: converted as sRGB to a CMYK
destination, and kept as they were in an RGB one. Preserve Numbers keeps
the numbers of untagged content only, so such an image is now converted
from its profile to sRGB with the color settings' intent, and then to a
CMYK or other RGB destination, the document's own RGB profile included.
- An untagged RGB image keeps its numbers in an RGB destination and
converts from sRGB to a CMYK one, as before.
- A gray image is converted to sRGB grays in an sRGB destination and
keeps its profile in the others.
- With RGB colors ICC-tagged as sRGB, the image is written as sRGB.
- A profile the color engine can't read leaves the image as it is in an
RGB destination, and its numbers read as sRGB in a CMYK one, with a
warning each.
- The table for an RGB destination is built only when the first tagged
image needs it.
When Profile inclusion is set to Don't Include Profiles (`profiles:
"none"`), gray, RGB and CMYK images are written in device color spaces
without their ICC profiles, and a JPEG that is kept as is loses its
APP2 ICC_PROFILE segments. PDF/A-2b, PDF/X-3 and PDF/X-4 keep tagging
their images.
Leaving the setting out keeps the earlier output. `profiles` now
serializes as null when not set, `"default"` clears a preset's value,
and Save PDF > Output lists Default first. Presets and stored settings
saved earlier hold `"profiles": "none"`, so exports from them now drop
image profiles.
Port main's new variable-library parsing (variable kinds, image, visibility
and graph values) from roxmltree to craft-xml with the branch's strict
options and attribute validation. Keep both sides' variable tests.
Drop the stale docx::nesting doc link.
- CMYK colors converted between two loaded CMYK profiles now use the
Color Settings black point compensation, as RGB colors already did:
the conversion goes through linear ProPhoto RGB and maps the source
profile's black onto the destination's.
- The edit.colorSettings, document.open and file.newFromTemplate params
text and docs/mcp.md name file.newFromTemplate with the commands that
apply the policies, and say that colorMode on open converts after the
policies, through the profiles the document keeps.
- A test covers New from Template under the policies, and another the
CMYK black point compensation.
The Variables panel drew each variable as one "name · object" line in
the order the variables were defined, with no headers and no sorting.
The list now has three columns with headers: the type icon, Variables
and Objects. A click on a header sorts the list by that column, and a
second click reverses the order. The new command variable.sort {by:
name|object|type|none, descending?} sets the order, which is panel
state: not saved and not an undo step. variable.list lists the
variables in that order and reports it as sort. An unknown by, or a
descending that is not true or false, is an error.
Each record's look-ahead descriptor read started with its own allowance
of 200,000 values, so a file with 10,000 records could make one Open read
about two billion. The descriptors of a slices resource now spend one
allowance between them, and a look-ahead that runs it out refuses the
slices with a warning instead of being read past.
Replace measured the image inside a PSD or PSB file's clip group only
when the new file brought its own clipping path. A plain image placed
with `replace` over such a clip group took only the group's center and
came in at 100%, losing the image's scale and rotation. The image in
the group is now measured whenever the new art is an image, clipped or
not.