Commit Graph
18 Commits
Author SHA1 Message Date
BFlat f0af46d070 Merge pull request #8508 from dotCooCoo/perf/layer-highlight-set
Layers: a Shift-click range looks rows up in a set instead of searching them for each row
2026-11-19 00:43:12 +07:00
dotCooCoo bf2ca2cf80 Merge main into perf/layer-highlight-set 2026-11-18 07:39:22 -08:00
dotCooCoo 2499661541 Merge main into feat/layers-locate-frontmost 2026-11-18 07:33:00 -08:00
BFlat 9d59b6b885 Merge pull request #8510 from dotCooCoo/feat/layers-draw-behind-new-layer
Layers: in Draw Behind a new layer goes directly below the current layer
2026-11-18 13:04:43 +07:00
BFlat 3bc6bf441b Merge pull request #8075 from dotCooCoo/perf/layer-select-all-one-pass
Layers: a Shift-click in the selection column adds or removes a layer's art in one pass
2026-11-18 13:04:07 +07:00
BFlat cad5d37e55 Merge pull request #8372 from dotCooCoo/feat/layers-locate-layer
Layers: with Show Layers Only on, Locate Object becomes Locate Layer
2026-11-18 12:58:00 +07:00
dotCooCoo c66272a9e3 Layers: in Draw Behind a new layer goes directly below the current layer
layer.new without `top` or `below` now reads the drawing mode: in Draw
Behind the new layer goes directly below the current layer, at its level
(a sibling below a current sublayer), as the help page describes
(https://help.adobe.com/archive/en_US/illustrator/cs5/illustrator_cs5_help.pdf#page=234).
The Layers panel button, the panel menu, Ctrl/Cmd+L and the Layer
Options dialog all go through layer.new. `top` and `below` keep their
meaning in every mode, Draw Normal and Draw Inside keep a new layer
above the current one, and New Sublayer is not affected.
2026-11-17 18:19:14 -08:00
dotCooCoo 688baab2db Layers: a Shift-click range looks rows up in a set instead of searching them for each row
layer.highlight searched the highlighted rows once for every id it was
given, so a range of n rows took about n^2/2 comparisons, and the panel's
preview of the rows (apply_row_click) did the same before sending the
command. Both now keep a set of the highlighted rows beside the ordered
list. layer.highlight builds the set only for more than 8 ids, so a
one-row Ctrl/Cmd-click toggle does not pay for it.

The rows, their order, the returned rows, the current layer and the
revision are unchanged; tests compare the command with the per-id search
on 3,000 rows and the widget with it on 5,000 rows.
2026-11-17 17:52:43 -08:00
dotCooCoo d04b8b3f21 Layers: a repeated Locate reveals the row it already highlighted
Running Locate Object or Locate Layer again on the row it already
highlighted wrote the same highlight, so the Layers panel did not open
the layers around the row or scroll to it: a sublayer whose layer was
closed since stayed hidden. layer.locate now leaves a one-time request
on the document (DocState::locate_reveal) that the panel takes on its
next frame, opening the layers around the located row and scrolling to
it whether or not the highlight changed. The request is not saved and
adds no undo step, and the panel drops it when the row is no longer
highlighted.
2026-11-17 13:47:51 -08:00
dotCooCoo 0e2ac0b4f9 Layers: Locate Object locates the frontmost of several selected objects
With several objects selected, Locate Object (and Locate Layer) now
finds the one frontmost in the stacking order instead of the one
selected last. Objects on different layers and sublayers compare by the
layers' order, and a member selected with its group counts as in front
of it. An id given to layer.locate still locates that object.
2026-11-17 11:01:15 -08:00
dotCooCoo f9e6399195 Layers: with Show Layers Only on, Locate Object becomes Locate Layer
With Panel Options > Show Layers Only on, the panel lists no object
rows, so Locate Object highlighted a row that was not there. The panel
menu, the bottom bar's button and a row's menu now read Locate Layer in
that mode and send layer.locate with layersOnly: true, which highlights
the innermost layer or sublayer holding the object (a layer locates
itself) and returns {id, objectId, ancestry}. The panel opens the layers
around it and scrolls to it. With the option off nothing changes.

Help page: https://helpx.adobe.com/illustrator/desktop/manage-layers/create-and-organize-layers/locate-objects-in-the-layers-panel.html

Adds Locate Layer rows to the 28 catalogs that translate Locate Object.
2026-11-17 09:58:54 -08:00
datatimp ea69ba0b97 Layers: a c opy never goes inside a top-level layer it copies; roadmap row (#8237) 2026-11-16 17:52:20 -05:00
datatimp 79906094b6 Layers panel: an Alt-drag copies a row above or below itself (#8237) 2026-11-16 16:44:20 -05:00
dotCooCoo 9d722b8342 Layers: a Shift-click in the selection column adds or removes a layer's art in one pass
layer.selectAll {id, add: true} checked each of the row's K objects with
a scan of the S selected objects, then removed or added them one id at a
time, each removal rebuilding the selection and each addition scanning
it again, so a Shift-click on a large layer took O(K*S + K^2). It now checks
the row's art against a set of the selected objects and calls
Selection::remove_all or Selection::add_all once. The resulting
selection, its order, the reply and the highlighted rows are the same
as before.

crates/engine/examples/layer_select_bench.rs times the old loop against
the new command in one process. On a layer of 50,000 objects the whole
command took a median of 733 ms before and 6.9 ms after with all of the
layer's art selected, and 369 ms before and 24 ms after with every other
object selected (7 runs, wall clock on Linux while other builds were
running).
2026-11-16 00:06:39 -08:00
dotCooCoo d79f5ccb75 Layers: a layer or gap color with an alpha part is refused instead of losing its alpha
layer.setProps, layer.new, layer.newSublayer and livePaint.gapOptions read
an 8-digit hex color such as #ff000080 as #ff0000 and set it without its
alpha. They now refuse it with the error a bad color already gets, and
change nothing. #rgba was already refused. #rrggbb, #rgb, a preset index
and a preset name are read as before.
2026-11-04 18:29:17 +07:00
dotCooCoo 16d679fde7 Layers: Cmd/Ctrl+Alt-click places a new layer below the current one and a new sublayer at the bottom
The reference app places a new layer below the selected layer with
Ctrl+Alt-click (Command+Option-click) on the New Layer button, and a
new sublayer at the bottom of the layer list with the same click on
the New Sublayer button. In VectorCraft that click opened Layer
Options, and New Layer and New Sublayer always added the layer above
the current layer and the sublayer on top of the layer's contents.

layer.new takes below, which adds the layer directly below the current
layer at its level, and layer.newSublayer takes bottom, which adds the
sublayer under the parent's contents. In a clipping layer the new
sublayer goes above the clipping path. Each is one undo step, and
below is refused together with top. A Cmd/Ctrl+Alt-click on the
Layers panel's New Layer and New Sublayer buttons runs them. A plain
click, an Alt-click and a Cmd/Ctrl-click work as before.

Docs: docs/mcp.md, docs/target-app-parity.md.
2026-10-29 10:10:59 +07:00
dotCooCoo 4519346cfb Layers: the Layers panel's commands refuse a boolean given as text
layer.new, layer.selectAll, layer.target, layer.move, layer.template,
layer.pasteRemembersLayers and layer.releaseToLayers read their on/off
params with bool_or or as_bool, which falls back to a default for a
value that is not true or false. layer.new {"top": "true"} added the
layer above the current one instead of on top, layer.template
{"on": "false"} and layer.pasteRemembersLayers {"on": "false"} turned
the option on when it was off, layer.move {"copy": "true"} moved the
rows instead of copying them, layer.selectAll and layer.target with
"add": "true" replaced the selection, and layer.releaseToLayers
{"build": "true"} released the objects without building up copies.

These commands now fail with "`<key>` must be true or false" for a
value that is not true, false or null, as the artboard and Object menu
commands do, and leave the document, the selection, the highlighted
rows and the undo history as they were. layer.newSublayer, which takes
layer.new's options, refuses such a top too. A null is read as a key
left out.

docs/mcp.md also lists showCenterMark, showCrossHairs and
showVideoSafeAreas among the keys artboard.new and artboard.setProps
refuse in this way, as they already did.

Docs: docs/mcp.md, docs/target-app-parity.md.
2026-10-29 09:57:33 +07:00
aiongg 83eec43b18 refactor(engine): move tests_*.rs to tests/<topic>.rs 2026-10-26 18:26:56 +00:00