Commit Graph
29 Commits
Author SHA1 Message Date
dotCooCoo 9ef93eb563 Swatches: a library pattern keeps a global color whose name the document uses
When Add to Swatches brought a library pattern whose art links to a global
or spot color, and the document had that name for another color, the
pattern was relinked to the document's color. Adding the library's color
then made a numbered copy that the pattern did not use. The color now comes
in under a numbered name and the pattern links to it, as an added color
does, and the check for a pattern already in the document compares it the
same way.
2026-11-17 06:20:11 -08:00
dotCooCoo 485a1e5ae8 Swatches: a color a pattern brings in is not added again in the same call
When one Add to Swatches call added a pattern swatch and then a global or
spot color its art links to, the pattern brought the color in and the color
was added a second time as a numbered copy. The color the pattern brought
now takes the library swatch's place and color group instead.
2026-11-16 22:30:20 -08:00
dotCooCoo 49184fc486 Swatches: a library pattern painted with another pattern is matched by both
Adding a library pattern swatch reused a document pattern with the same
tile options and art even when that art paints with a pattern of the same
name and a different definition, so the library's inner pattern never came
in. A pattern whose art uses other resources is now matched by importing it
into a copy of the document, which compares those resources too.
2026-11-16 21:51:12 -08:00
dotCooCoo dec5025147 Fix #8034: review fixes for pattern swatches from another document
- swatch.library.add lists a library pattern swatch that stands for a
  swatch added earlier in the same call under existing, not twice
  under added.
- An empty library file (.gpl, .ase, .vcswatches) loads as an empty
  library again; only a document with no swatches is refused. A
  PostScript file whose swatches are only the default ones is refused
  like a .ai or .eps.
- The Swatch Libraries filter of Other Library… also lists .ait and
  .epsf files.
- The library panel finds a loaded library's pattern swatch by looking
  only at libraries that have pattern swatches.
- The Czech message for Copy to User Defined names pattern swatches.
- Color spelling in the new params text and comments; docs/mcp.md
  rewrapped.
2026-11-16 01:12:03 -08:00
dotCooCoo 98f5086c20 Fix #8034: Other Library… brings a .ai library's pattern swatches with their patterns
Swatches › Open Swatch Library › Other Library… read a document's
swatches without its pattern swatches, so a pattern from a .ai swatch
library came in only as the colors it uses.

- swatch.library.load keeps a document's pattern swatches, and keeps
  the document for a library that has them. swatch.library.add brings
  the pattern with its tile and art, as a pattern swatch with the
  library swatch's name, placement and color group.
- The library panel draws those pattern swatches from their pattern.
- The Swatch Libraries filter of Other Library… lists .ai and .eps
  files.
- A file with no swatches, and a .ai or .eps whose swatches are only
  the default ones, are refused with "`<file>` has no swatches of its
  own". Copy to User Defined refuses a loaded library with pattern
  swatches, since a .vcswatches file can't hold them.

Docs: docs/mcp.md, docs/target-app-parity.md.
2026-11-16 00:30:07 -08:00
dotCooCoo be9be8c1bd Swatches: a replacement gradient or pattern is stored as a new swatch stores it
swatch.edit stored a replacement gradient without its placement, so a
radial gradient with an aspect, Alt-dropped on a gradient swatch or
given as `paint`, lost that aspect, while swatch.new keeps it and
applies the swatch with it. A gradient given an aspect without `start`
and `end` lost the aspect in both commands. A replacement pattern kept
the tile transform of the swatch it came from, while swatch.new stores
a pattern untransformed, and `paint: {pattern: name}`, which an Alt-drop
of a pattern fill sends, was refused.

swatch.edit and swatch.new now store a gradient or pattern through one
helper: a gradient keeps its aspect, with or without a vector, and holds
no swatch link, and a pattern is untransformed. swatch.edit takes a
pattern by name, as swatch.new does.
2026-11-14 04:45:04 -08:00
dotCooCoo ba2531bc3f Tests: engine tests remove the temp folders they make
vectorcraft_testkit::temp_dir returns a bare path, so every engine test
that wrote into one left the folder in the system temporary folder.

- testkit: TempDir, a test's own folder made through temp_dir (same
  private creation and ownership checks) under a tag no other TempDir in
  the process uses, removed with its contents when dropped, also when
  the test panics.
- Engine unit and integration tests hold a TempDir for the whole test
  instead of calling temp_dir: graph, fileio, compare, journal, library,
  shortcut set, spelling, store, web export, cancel, containers, build,
  color settings, command sweep, font folder, removed font, model-based
  and the font search fuzz.
- The DCS and swatch library tests' own helpers and the PDF editing
  tests' shared vc-pdfedit-<pid> folder use a TempDir per test too.
- The font and link file search, store, color settings and font folder
  helpers no longer delete the private folder temp_dir checked and make
  it again with default permissions.
2026-11-13 09:33:36 -08:00
dotCooCoo 0576806e1a Merge main into feat/patterns-optical-effects 2026-11-12 05:55:42 -08:00
dotCooCoo 2bb8cd0b92 Swatch libraries: Patterns › Optical Effects adds wave, moiré and op-art patterns
Window › Swatch Libraries › Patterns and the Swatches panel's library
menu gain Optical Effects (`optical-effects`), a built-in pattern library
of eight black tiles drawn in code: Sine Bands, Ripple Lines,
Interference Rings, Offset Rings, Warped Checks, Pinched Stripes,
Chevron Pulse and Radiating Lenses. The names and designs are
VectorCraft's own. Each tile is 32 to 48 pt, one period of its design,
with fixed sample counts (at most 600 paths and 20,000 segments), so a
band that leaves one edge comes back at the same place on the opposite
edge, and rings and lenses that cross an edge are kept whole for the
tiling to draw on the next tile. Clicking a swatch adds its pattern and
swatch once and applies it, as with Geometric Patterns
(`swatch.library.add`).

The menu label has a row in every catalog; docs/mcp.md, the parity doc
and ROADMAP name the library.
2026-11-12 00:48:41 -08:00
dotCooCoo f4384486ca Merge main into feat/gradients-holographic 2026-11-12 00:41:03 -08:00
dotCooCoo fc8a7e46c6 Swatch libraries: Gradients › Holographic adds iridescent foil and glow gradients
Window › Swatch Libraries › Gradients gains Holographic, after Organic
Fades: seven foils (opaque linear gradients of six narrow pastel and
pearl bands with off-center midpoints) and seven glows (radial
gradients from a bright center out to a clear edge), all mixed with the
Perceptual method. They also list in the Swatches panel's library menu,
swatch.library.list/get/add and the Gradient panel's Presets.

The names, colors and stops are VectorCraft's own. A saved preset that
already uses one of the new names is renamed with the first free number
when the preferences load.

Docs: docs/target-app-parity.md Swatches line, ROADMAP.
2026-11-11 23:19:16 -08:00
dotCooCoo 1c28809333 Merge main into feat/patterns-grit-textures 2026-11-11 22:45:36 -08:00
dotCooCoo 9fc4e3c5cf Swatch libraries: Patterns › Grit Textures adds seamless grain, speckle and stipple patterns
Window › Swatch Libraries › Patterns and the Swatches panel's library
menu gain a second built-in pattern library, Grit Textures, with eight
black textures on square grid tiles of 18 to 36 pt: Fine Grain, Coarse
Grit, Sand, Speckle, Stipple, Scratches, Sparse Flecks and Dense Flecks.
Each is drawn in code from a fixed seed, so it is the same every time.
Marks that reach past a tile edge are drawn on the next tile by the
tiling, so the tiles join without a seam.

Docs: docs/mcp.md, docs/target-app-parity.md, ROADMAP.
2026-11-11 21:30:00 -08:00
dotCooCoo 1e70274189 Swatch libraries: Gradients › Organic Fades adds soft multi-stop fades that thin out to transparent
Window › Swatch Libraries › Gradients gains Organic Fades, a gradient
library of fifteen fades (ten linear, five radial). Each runs through
three to five unevenly spaced stops with off-center midpoints, mixes
with the Perceptual method, and thins out to transparent at the end of
a linear fade or at the edge of a radial one. The colors are computed
from VectorCraft's own OKLCH anchors.

The library also lists in the Swatches panel's library menu, in
swatch.library.list (category "gradients") and in the Gradient panel's
Presets. swatch.library.add keeps each fade's stops, opacities,
midpoints and method in RGB and CMYK documents.

The other built-in libraries are unchanged: their gradients still mix
with Classic and keep centered midpoints, and a test checks it.

- Gradient previews in the Swatch Libraries panel, the Gradient
  panel's Presets menu, swatch tiles and the toolbar drew every stop
  opaque. Each chip vertex now takes the sampled opacity as its alpha
  (freeform points too), and a chip with any translucent vertex draws
  a white and gray checkerboard under the gradient. Opaque gradients
  draw as before.
- When the preferences are applied, a saved gradient preset whose name
  matches a built-in preset, or an earlier saved preset, in any case,
  is renamed to the first free "<name> N" (N from 2), so a saved
  preset named like a new built-in fade stays listed and can be
  applied and deleted.
2026-11-11 21:26:11 -08:00
Cursor AgentandAdithya Shankaran 4e11389bf0 Don't write over a library file that changed since it was saved
The name remembered for a user library file stays only while the file still
holds the bytes that were written. A file a device name could make, which can
no longer be read, is kept too, and the save goes to a new file.

Co-authored-by: Adithya Shankaran <adikshan11@users.noreply.github.com>
2026-11-07 00:17:12 +07:00
Adithya Shankaran 850fd620f9 Don't replace an .ase file whose owner isn't known
After a restart an .ase file called COM¹- could have been saved as COM¹ or as
COM¹-, and the same goes for its numbered files. Such a file is kept until it is
saved here, so a library named like that gets a new file, once per run. Other
names go on replacing their own file.
2026-11-06 23:05:29 +07:00
Adithya Shankaran a17efec894 Remember the name a library file was saved under
An .ase file can't say whose it is, so without this COM¹ saved after COM¹- wrote
over it. The app now remembers while it runs. After a restart COM¹ gets a new
file, which costs a copy and loses nothing.
2026-11-06 23:05:29 +07:00
Adithya Shankaran 857ba3972b Don't copy a library on every save when its format keeps no title
An .ase file reads its name from the file name, so COM¹ saved again looked like
another library and got a new numbered file each time.
2026-11-06 23:05:29 +07:00
Adithya Shankaran 0864db9494 Keep the other library when two names share a file name
A library called COM¹ is saved as COM¹-, which can be the file of a library
really called COM¹-, and the numbered file one of them then gets can be asked
for by a third name. Saving one replaced the other. Each now gets a free file
name, and saving it again goes back to that file.
2026-11-06 16:52:05 +07:00
Adithya Shankaran a455e72bf8 Automation roots: refuse COM¹ to LPT³ as Windows device names 2026-11-06 14:34:58 +07:00
dotCooCoo 5e3a0090a2 Swatch libraries: test that a pattern library adds only the picked pattern
Reading a pattern library adds no pattern or swatch to the document. A
pattern added from it undoes and redoes with its swatch, and both are
kept after a save and reopen.
2026-11-02 12:04:03 +07:00
dotCooCoo 284b5b45b6 Swatch libraries: only a built-in pattern library's own swatches draw its pattern tiles 2026-11-02 12:04:03 +07:00
dotCooCoo 6b7513c0a0 Swatch libraries: a pattern swatch is found without copying the document
swatch.library.add looks for the library's pattern among the document's
patterns of that name or a numbered copy of it, instead of importing it
into a copy of the document. Only a swatch that paints with the pattern
unmoved counts as the pattern's swatch, so a swatch whose pattern was
moved in its space is not reused and applied in its place.
2026-11-02 12:04:02 +07:00
dotCooCoo cb7df83217 Swatch libraries: Patterns › Geometric Patterns adds a pattern with its swatch
Window › Swatch Libraries and the Swatches panel's library menu get a
Patterns submenu with Geometric Patterns, a built-in library of eleven
black pattern swatches drawn in code (dots, stripes, a checkerboard, a
grid, diamonds, triangles, crosses and a zigzag).

- Clicking a pattern in its library panel adds the pattern and its
  swatch to the document and applies it to the active fill or stroke
  (Alt: the other one), as one undo step. A second click reuses the
  swatch; a different pattern under the same name keeps its name and
  the library's pattern comes in numbered.
- swatch.library.list lists the pattern libraries after the gradient
  libraries (category "patterns"), and swatch.library.add brings a
  pattern swatch's pattern as pasting art painted with it does.
- The library panel draws each pattern tile from the library's pattern.
- "Geometric Patterns" is translated in every catalog.
2026-11-02 12:04:02 +07:00
marshiyar feb12cf312 Swatch libraries: a device name with an extension gets the - before its first dot (#3602)
CON.txt became CON.txt-.json, whose first part is still CON. It is now CON-.txt.json.
2026-10-31 19:43:17 +07:00
marshiyar 64ffab00a9 Swatch libraries: a library titled with a Windows device name is saved under another name (#3602)
library_file_name kept CON, NUL, COM1 and the like, which Windows treats as
devices, not files. It now adds a - after such a name (CON-.json).

Part of #3602
2026-10-31 19:43:16 +07:00
dotCooCoo ae0ce1888d Libraries: library loads check name before reading the file
swatch.library.load, graphicStyle.loadLibrary, symbol.loadLibrary and
brush.loadLibrary read the whole file or decoded data before checking
`name`, so a call with a `name` that is not a string read the file
first, and with a missing file reported the file error instead of the
parameter error. The shared loader now checks every parameter before it
reads anything.
2026-10-30 23:44:05 +07:00
dotCooCoo 567060393e Recolor Artwork and swatch libraries: parameters of the wrong form are errors
Squashed from #4492 onto main.
2026-10-30 00:15:56 +07:00
aiongg 83eec43b18 refactor(engine): move tests_*.rs to tests/<topic>.rs 2026-10-26 18:26:56 +00:00