diff --git a/.github/actions/install-agility-sdk/action.yml b/.github/actions/install-agility-sdk/action.yml index ba05465ec..2d12e1b5e 100644 --- a/.github/actions/install-agility-sdk/action.yml +++ b/.github/actions/install-agility-sdk/action.yml @@ -4,7 +4,12 @@ runs: using: "composite" steps: - shell: bash - run: | + # NOTE: We ignore the `github-env` lint because we trust: + # + # - Our `install-agility-sdk` task's output + # - Otherwise, `WGPU_DX12_AGILITY_SDK_REQUIRE` is a fixed environment variable that is easy + # to audit. + run: | # zizmor: ignore[github-env] set -e cargo xtask install-agility-sdk >> "$GITHUB_ENV" diff --git a/.github/actions/install-dxc/action.yml b/.github/actions/install-dxc/action.yml index 4e6b285bb..12f6b32f7 100644 --- a/.github/actions/install-dxc/action.yml +++ b/.github/actions/install-dxc/action.yml @@ -4,7 +4,11 @@ runs: using: "composite" steps: - shell: bash - run: | + # NOTE: We ignore the `github-env` lint because we trust: + # + # - The `cygpath` tool + # - The contents of the DXC release we use. + run: | # zizmor: ignore[github-env] set -e export DXC_RELEASE="v1.9.2602.24" diff --git a/.github/actions/install-mesa/action.yml b/.github/actions/install-mesa/action.yml index f0db58a8c..cd25b0ea7 100644 --- a/.github/actions/install-mesa/action.yml +++ b/.github/actions/install-mesa/action.yml @@ -20,7 +20,12 @@ runs: env: MESA_VERSION: ${{ inputs.version }} CI_BINARY_BUILD: ${{ inputs.ci-binary-build }} - run: | + # NOTE: We ignore `github-env` because we trust: + # + # - The `cygpath` tool + # - The `$PWD` variable + # - The contents of the Mesa archive we download here, which we control. + run: | # zizmor: ignore[github-env] set -e curl -L --retry 5 https://github.com/gfx-rs/ci-build/releases/download/$CI_BINARY_BUILD/mesa-$MESA_VERSION-linux-x86_64.tar.xz -o mesa.tar.xz @@ -51,7 +56,12 @@ runs: env: MESA_VERSION: ${{ inputs.version }} CI_BINARY_BUILD: ${{ inputs.ci-binary-build }} - run: | + # NOTE: We ignore `github-env` because we trust: + # + # - The `cygpath` tool + # - The `$PWD` variable + # - The contents of the Mesa archive we download here. + run: | # zizmor: ignore[github-env] set -e curl.exe -L --retry 5 https://github.com/pal1000/mesa-dist-win/releases/download/$MESA_VERSION/mesa3d-$MESA_VERSION-release-msvc.7z -o mesa.7z diff --git a/.github/actions/install-vulkan-sdk/action.yml b/.github/actions/install-vulkan-sdk/action.yml index 3c726902f..ed957be89 100644 --- a/.github/actions/install-vulkan-sdk/action.yml +++ b/.github/actions/install-vulkan-sdk/action.yml @@ -15,7 +15,10 @@ runs: env: VULKAN_SDK_VERSION: ${{ inputs.version }} VULKAN_FULL_SDK_VERSION: ${{ inputs.full-version }} - run: | + # NOTE: We ignore the `github-env` lint because we trust: + # + # - The contents of the Vulkan SDK we are downloading. + run: | # zizmor: ignore[github-env] set -e curl -L --retry 5 https://sdk.lunarg.com/sdk/download/${{ env.VULKAN_FULL_SDK_VERSION }}/linux/vulkansdk-linux-x86_64-${{ env.VULKAN_FULL_SDK_VERSION }}.tar.xz -o vulkan-sdk.tar.xz @@ -34,7 +37,10 @@ runs: env: VULKAN_SDK_VERSION: ${{ inputs.version }} VULKAN_FULL_SDK_VERSION: ${{ inputs.full-version }} - run: | + # NOTE: We ignore the `github-env` lint because we trust: + # + # - The contents of the Vulkan SDK we are downloading. + run: | # zizmor: ignore[github-env] set -e curl.exe -L --retry 5 https://sdk.lunarg.com/sdk/download/${{ env.VULKAN_FULL_SDK_VERSION }}/windows/vulkansdk-windows-X64-${{ env.VULKAN_FULL_SDK_VERSION }}.exe -o vulkan-sdk-installer.exe @@ -49,7 +55,10 @@ runs: env: VULKAN_SDK_VERSION: ${{ inputs.version }} VULKAN_FULL_SDK_VERSION: ${{ inputs.full-version }} - run: | + # NOTE: We ignore the `github-env` lint because we trust: + # + # - The contents of the Vulkan SDK we are downloading. + run: | # zizmor: ignore[github-env] set -e curl -L --retry 5 https://sdk.lunarg.com/sdk/download/${{ env.VULKAN_FULL_SDK_VERSION }}/mac/vulkansdk-macos-${{ env.VULKAN_FULL_SDK_VERSION }}.zip -o vulkan-sdk.zip